]>
source.dussan.org Git - poi.git/log
Andreas Beeker [Mon, 13 Jun 2016 21:18:50 +0000 (21:18 +0000)]
reverted changes of r1747942 and deprecated instead
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748313 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 18:14:26 +0000 (18:14 +0000)]
back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748294 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 18:12:29 +0000 (18:12 +0000)]
back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748293 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 10:55:49 +0000 (10:55 +0000)]
Sonar: 'static modifier out of order with the JLS suggestions.remove No need to check for null before an instanceof; the instanceof keyword returns false when given a null argument.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748175 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 10:53:03 +0000 (10:53 +0000)]
add HSSFCell.setCachedErrorResult(FormulaError)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748174 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 10:29:38 +0000 (10:29 +0000)]
type check error code when setting cell error value on HSSFCell
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748172 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 10:14:44 +0000 (10:14 +0000)]
add useless unit test for o.a.p.ss.util.RegionUtil
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748170 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 09:51:01 +0000 (09:51 +0000)]
add periods for complete sentences
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748166 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Mon, 13 Jun 2016 09:39:36 +0000 (09:39 +0000)]
Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748158 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Mon, 13 Jun 2016 09:38:12 +0000 (09:38 +0000)]
Javadoc fixes - @see and @link can't be combined together, at least not in Java 6
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748157 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 08:58:55 +0000 (08:58 +0000)]
improve unit test coverage on CellReference.
Add note that _sheetName can be null or empty string, depending on the entry-point.
Throw an exception when parsing a string if sheet name is not quoted and contains a space.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748144 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 08:55:41 +0000 (08:55 +0000)]
fix accidental infinite recursion
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748143 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 07:44:29 +0000 (07:44 +0000)]
bug 58787: add an advertisement to BorderPropertyTemplate.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748110 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 07:40:20 +0000 (07:40 +0000)]
bug 58787 follow-on: update javadocs; remove unused Workbook parameter from set(Top|Bottom|Left|Right)Border and BorderColor methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748107 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 07:27:18 +0000 (07:27 +0000)]
whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748105 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 07:15:47 +0000 (07:15 +0000)]
add description to gump and jenkins build targets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748100 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 07:02:33 +0000 (07:02 +0000)]
findbugs URF_UNREAD_FIELD: note that unread fields were commented out in r1748084 due to a Findbugs warnings (so the disabled code is less likely to be deleted in the future
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748098 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 06:38:53 +0000 (06:38 +0000)]
findbugs: fix SF_SWITCH_NO_DEFAULT warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748090 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 06:12:35 +0000 (06:12 +0000)]
findbugs: fix SF_SWITCH_FALLTHROUGH warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748088 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 05:41:32 +0000 (05:41 +0000)]
findbugs depends on the poi, poi-scratchpad, and poi-ooxml jars being copied to build/maven
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748087 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 05:34:02 +0000 (05:34 +0000)]
findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD and UUF_UNUSED_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748086 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 05:06:47 +0000 (05:06 +0000)]
findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748085 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 04:42:59 +0000 (04:42 +0000)]
findbugs: fix URF_UNREAD_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748084 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 04:34:37 +0000 (04:34 +0000)]
whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748083 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 04:09:41 +0000 (04:09 +0000)]
consolidate findbugs filters using Or logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748081 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 03:48:30 +0000 (03:48 +0000)]
fix findbugs issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748080 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 01:25:50 +0000 (01:25 +0000)]
bug 58787: reintegrate changes from ss_border_property_template branch at r1748074. The BorderPropertyTemplate allows changes to border formatting to be staged in a template and applied to a sheet at a later time. This reduces the number of intermediate styles created, reduces interactions with cell objects (CellUtil.get/setCellProperties), and makes it easier to make the same formatting changes to multiple sheets. This utility can currently apply border line style and border color. This utility also adds the ability to add a border around a cell range rather than a single cell. Contributed by Mark Murphy.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748075 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 01:00:51 +0000 (01:00 +0000)]
rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748074 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 00:50:52 +0000 (00:50 +0000)]
test copy constructor: make changes to same range: this is a better test for deepcopy
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748073 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 00:43:34 +0000 (00:43 +0000)]
add copy constructor
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748072 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 13 Jun 2016 00:40:46 +0000 (00:40 +0000)]
move colors in TestBorderPropertyTemplate to testclass constants
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748071 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 12 Jun 2016 23:43:16 +0000 (23:43 +0000)]
rewrite switch statements to not re-check the switch'd variable
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748070 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 12 Jun 2016 23:03:23 +0000 (23:03 +0000)]
rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior?
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748068 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 12 Jun 2016 22:59:47 +0000 (22:59 +0000)]
rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior?
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748067 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 12 Jun 2016 22:57:37 +0000 (22:57 +0000)]
move check if border line style is blank before setting the border color to a helper function for readability
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748066 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 12 Jun 2016 22:33:24 +0000 (22:33 +0000)]
remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key.
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748065 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 12 Jun 2016 22:02:38 +0000 (22:02 +0000)]
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748063 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 12 Jun 2016 22:01:30 +0000 (22:01 +0000)]
use CellAddress in unit tests where possible to improve readability
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748062 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 12 Jun 2016 22:00:45 +0000 (22:00 +0000)]
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748061 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 12 Jun 2016 21:35:56 +0000 (21:35 +0000)]
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1748055 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sun, 12 Jun 2016 21:28:13 +0000 (21:28 +0000)]
fixing javadocs errors (in JDK8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748054 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sun, 12 Jun 2016 20:19:59 +0000 (20:19 +0000)]
fixing javadocs errors (in JDK8)
removing Rainers author tags as those cause a lot of errors and should be omitted anyways (see https://poi.apache.org/guidelines.html)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748046 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sun, 12 Jun 2016 19:54:35 +0000 (19:54 +0000)]
javadocs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748042 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sun, 12 Jun 2016 16:57:15 +0000 (16:57 +0000)]
sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748028 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sun, 12 Jun 2016 01:18:12 +0000 (01:18 +0000)]
ignore invalid performance issues - e.g. see #57840
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747947 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sun, 12 Jun 2016 00:54:01 +0000 (00:54 +0000)]
revert back to changes of bug 57840
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747945 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sun, 12 Jun 2016 00:20:52 +0000 (00:20 +0000)]
Common-SS: changed UDFFinder from interface to abstract class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747943 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sun, 12 Jun 2016 00:12:22 +0000 (00:12 +0000)]
findbugs fixes
changed UDFFinder to abstract class and moved DEFAULT constant to factory method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747942 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sat, 11 Jun 2016 21:23:01 +0000 (21:23 +0000)]
use newer findbugs version, if we run with java 7+
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747936 13f79535 -47bb-0310-9956-
ffa450edef68
Dominik Stadler [Sat, 11 Jun 2016 17:03:59 +0000 (17:03 +0000)]
Add some pre-checks to fail the test with better assertion if the locale is not set correctly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747916 13f79535 -47bb-0310-9956-
ffa450edef68
Dominik Stadler [Sat, 11 Jun 2016 17:03:53 +0000 (17:03 +0000)]
Downgrade version of download-plugin as the newer one is not found by Maven
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747915 13f79535 -47bb-0310-9956-
ffa450edef68
Dominik Stadler [Sat, 11 Jun 2016 17:03:46 +0000 (17:03 +0000)]
Set the correct locale for tests in the Sonar-Maven files to not fail on CI machines that have a different locale set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747914 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 12:18:04 +0000 (12:18 +0000)]
make CellRangeAddresses easier to cross-reference the example with the written out workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747888 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 12:09:23 +0000 (12:09 +0000)]
make these classes more discoverable/searchable using more specific names
rename PropertyTemplate to BorderPropertyTemplate
rename Extent to BorderExtent
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747884 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 11:40:30 +0000 (11:40 +0000)]
bug 57840: lazily compute hashCode; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747881 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 11:35:18 +0000 (11:35 +0000)]
whitespace (tabs to spaces, 3-space to 4-space)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747879 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 11:28:55 +0000 (11:28 +0000)]
bug 57840: add disabled unit test with large number of structured reference formulas
patch and spreadsheet contributed by Mark Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747878 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 11:12:04 +0000 (11:12 +0000)]
javadoc update and boolean addLeft|Right|Top|Bottom line wrap update
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747877 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 11:01:48 +0000 (11:01 +0000)]
fix spelling in javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747876 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 10:09:05 +0000 (10:09 +0000)]
fix javadocs: remove unnecessary @links, remove references to CellStyle
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747873 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 09:58:12 +0000 (09:58 +0000)]
move loop-invariants outside the loop for readability and execution speed
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747871 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 09:15:57 +0000 (09:15 +0000)]
replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.*
update PropertyTemplate functions to require enum instead of short borderType
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747868 13f79535 -47bb-0310-9956-
ffa450edef68
Dominik Stadler [Sat, 11 Jun 2016 08:45:41 +0000 (08:45 +0000)]
Improve output on invalid HTTP Status Code and ignore another failure to contact the TSP server
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747863 13f79535 -47bb-0310-9956-
ffa450edef68
Dominik Stadler [Sat, 11 Jun 2016 08:45:33 +0000 (08:45 +0000)]
Remove invalid removal of findbugs-zip
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747862 13f79535 -47bb-0310-9956-
ffa450edef68
Dominik Stadler [Sat, 11 Jun 2016 08:45:28 +0000 (08:45 +0000)]
Update to latest versions of Maven plugins for Sonar-build and use properties for some third party libs and some Maven plugins
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747861 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 08:15:50 +0000 (08:15 +0000)]
continue simplifying using helper functions
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747859 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 08:08:04 +0000 (08:08 +0000)]
continue simplifying using helper functions
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747858 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 07:48:32 +0000 (07:48 +0000)]
add helper functions for verifying template properties were set correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747855 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 07:40:46 +0000 (07:40 +0000)]
whitespace (unwrap lines)
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747854 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 07:10:21 +0000 (07:10 +0000)]
shorten PropertyTemplate.Extent to Extent
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747853 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 07:00:40 +0000 (07:00 +0000)]
+props svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747852 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 06:47:25 +0000 (06:47 +0000)]
bug 58787: add PropertyTemplate, unit test, and example from Mark Murphy
Attachment 33684 plus changes to TestPropertyTemplate#applyBorders: replaced assertEquals(CellStyle.BORDER_*, cs.getBorder*()) with assertEquals(BorderStyle.*, cs.getBorder*())
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747851 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 05:39:42 +0000 (05:39 +0000)]
create branch for bug 58787 Border utility to set cell styles around a range of cells
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@
1747847 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 04:27:21 +0000 (04:27 +0000)]
+props svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747846 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 03:05:31 +0000 (03:05 +0000)]
methods that return lists should return unmodifiable lists; use foreach sheet iterator when sheet index is not needed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747843 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 02:28:21 +0000 (02:28 +0000)]
bug 57840: re-use XSSFEvaluationWorkbook when expanding a shared formula; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747840 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 02:12:43 +0000 (02:12 +0000)]
whitespace (tabs to spaces); +props svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747839 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 02:10:32 +0000 (02:10 +0000)]
bug 57840: cache XSSFEvaluationCell and XSSFEvaluationSheet instances (30% evaluation speedup due to caching and faster cell lookup); patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747838 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 01:48:37 +0000 (01:48 +0000)]
bug 57840: avoid auto-boxing ints for row/column TreeTable lookups (4% evaluation speedup at the cost of additional Integer objects); patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747837 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 01:41:54 +0000 (01:41 +0000)]
add warnings that AnalysisToolPak inconsistently handles case-sensitivity of function names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747835 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 01:38:27 +0000 (01:38 +0000)]
add crude unit tests for UDFFinder classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747834 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 00:51:12 +0000 (00:51 +0000)]
remove deprecated o.a.p.xssf.model.IndexedUDFFinder, which was moved to o.a.p.ss.formula.udf 3 years ago and was @Internal before that
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747828 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 00:45:12 +0000 (00:45 +0000)]
+props svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747826 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 00:42:57 +0000 (00:42 +0000)]
add @Override annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747825 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 00:42:33 +0000 (00:42 +0000)]
fix typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747824 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 00:38:42 +0000 (00:38 +0000)]
bug 57840: initialize the column header cache with 50% empty space
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747823 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 00:34:22 +0000 (00:34 +0000)]
whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747822 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 00:16:14 +0000 (00:16 +0000)]
whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747821 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 00:15:00 +0000 (00:15 +0000)]
whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747820 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 11 Jun 2016 00:11:41 +0000 (00:11 +0000)]
bug 57840: add test using a Data Table not anchored at A1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747819 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 10 Jun 2016 23:55:27 +0000 (23:55 +0000)]
bug 57840: add data table not anchored at A1 for testing XSSFTable.getStartColIndex()/getEndColIndex()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747817 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Fri, 10 Jun 2016 21:29:47 +0000 (21:29 +0000)]
fix text height test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747803 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 10 Jun 2016 18:45:14 +0000 (18:45 +0000)]
bug 57840: add unit tests for XSSFTable methods; rename XSSFTable.getNumerOfMappedColumns() to getNumberOfMappedColumn()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747771 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 10 Jun 2016 18:10:52 +0000 (18:10 +0000)]
bug 57840: add unit test for XSSFTable.findColumnIndex
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747762 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 10 Jun 2016 17:13:45 +0000 (17:13 +0000)]
bug 57840: fix to reuse XSSFEvaluationWorkbook inside itself; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747754 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 10 Jun 2016 17:12:28 +0000 (17:12 +0000)]
+props svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747752 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 10 Jun 2016 16:36:59 +0000 (16:36 +0000)]
bug 57721: add unit test for evaluating all formulas in a workbook containing structured reference formulas; patch from gruber.chri@gmx.at
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747740 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 10 Jun 2016 11:52:44 +0000 (11:52 +0000)]
bug 59684: correctly parse CellReference(HOMEst163); Also deprecate misspelled methods isRowWithinRange/isColumnWithinRange
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747687 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 10 Jun 2016 11:16:16 +0000 (11:16 +0000)]
findbugs: SBSC_USE_STRINGBUFFER_CONCATENATION FormulaParser.parseAsColumnQuantifier() concatenates strings using + in a loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747685 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Fri, 10 Jun 2016 09:42:09 +0000 (09:42 +0000)]
Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1747674 13f79535 -47bb-0310-9956-
ffa450edef68