Reduce the getAppPath and autoloader calls

The getAppPath will always return the same data for the same appId. It
is actually already cached. However we do some cleanup of the appId
(again). Same for the autoloading it is actually already checked.

This just removes the unneeded calls. Which can add up if you have a lot
of incomming shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #23923 from nextcloud/bugfix/oci/fix-greatest-order-for-oracle

Fix greatest/least order for oracle

Merge pull request #23956 from nextcloud/dependabot/npm_and_yarn/node-sass-5.0.0

Bump node-sass from 4.14.1 to 5.0.0

Update parameters

Signed-off-by: Joas Schilling <coding@schilljs.com>

Bump node-sass from 4.14.1 to 5.0.0

Bumps [node-sass](https://github.com/sass/node-sass) from 4.14.1 to 5.0.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.14.1...v5.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #23961 from nextcloud/dependabot/npm_and_yarn/css-vars-ponyfill-2.4.1

Merge pull request #23957 from nextcloud/dependabot/npm_and_yarn/vue-loader-15.9.5

Bump vue-loader from 15.9.4 to 15.9.5

Merge pull request #23960 from nextcloud/dependabot/npm_and_yarn/bootstrap-4.5.3

Bump bootstrap from 4.5.2 to 4.5.3

Merge pull request #23962 from nextcloud/dependabot/npm_and_yarn/vue-router-3.4.9

Bump vue-router from 3.4.8 to 3.4.9

Merge pull request #23964 from nextcloud/dependabot/npm_and_yarn/marked-1.2.3

Bump marked from 1.2.0 to 1.2.3

Merge pull request #23936 from nextcloud/bugfix/noid/trashbin-ocdb

Use query builder instead of OC_DB in trashbin

Bump css-vars-ponyfill from 2.3.2 to 2.4.1

Bumps [css-vars-ponyfill](https://github.com/jhildenbiddle/css-vars-ponyfill) from 2.3.2 to 2.4.1.
- [Release notes](https://github.com/jhildenbiddle/css-vars-ponyfill/releases)
- [Changelog](https://github.com/jhildenbiddle/css-vars-ponyfill/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jhildenbiddle/css-vars-ponyfill/compare/v2.3.2...v2.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Bump vue-loader from 15.9.4 to 15.9.5

Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.9.4 to 15.9.5.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.9.4...v15.9.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #23965 from nextcloud/dependabot/npm_and_yarn/webpack-cli-4.2.0

Merge pull request #23934 from nextcloud/enh/avoid_scss_compile

Fix tests to return config default values

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Bump vue-router from 3.4.8 to 3.4.9

Bumps [vue-router](https://github.com/vuejs/vue-router) from 3.4.8 to 3.4.9.
- [Release notes](https://github.com/vuejs/vue-router/releases)
- [Changelog](https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-router/compare/v3.4.8...v3.4.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #23966 from nextcloud/dependabot/npm_and_yarn/vue-material-design-icons-4.10.0

Merge pull request #23963 from nextcloud/dependabot/npm_and_yarn/sinon-9.2.1

Merge pull request #23968 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Bump sinon from 9.2.0 to 9.2.1

Bumps [sinon](https://github.com/sinonjs/sinon) from 9.2.0 to 9.2.1.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #23959 from nextcloud/dependabot/npm_and_yarn/sass-loader-10.0.5

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Bump vue-material-design-icons from 4.9.0 to 4.10.0

Bumps [vue-material-design-icons](https://github.com/robcresswell/vue-material-design-icons) from 4.9.0 to 4.10.0.
- [Release notes](https://github.com/robcresswell/vue-material-design-icons/releases)
- [Changelog](https://github.com/robcresswell/vue-material-design-icons/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/robcresswell/vue-material-design-icons/compare/4.9.0...4.10.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump webpack-cli from 4.1.0 to 4.2.0

Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@4.1.0...webpack-cli@4.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump marked from 1.2.0 to 1.2.3

Bumps [marked](https://github.com/markedjs/marked) from 1.2.0 to 1.2.3.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js)
- [Commits](https://github.com/markedjs/marked/compare/v1.2.0...v1.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump bootstrap from 4.5.2 to 4.5.3

Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.5.2 to 4.5.3.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](https://github.com/twbs/bootstrap/compare/v4.5.2...v4.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump sass-loader from 10.0.4 to 10.0.5

Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 10.0.4 to 10.0.5.
- [Release notes](https://github.com/webpack-contrib/sass-loader/releases)
- [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/sass-loader/compare/v10.0.4...v10.0.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

[tx-robot] updated from transifex

Merge pull request #23821 from nextcloud/td/enh/no_fs_setup_by_default

Do not setup the default FS on normal routes

Merge pull request #23942 from nextcloud/techdebt/cookie-lax-php7.3

Remove the cookie paths for php<7.3

Merge pull request #23938 from nextcloud/bugfix/oci/sharing-ocdb

Replace some usages of OC_DB in OC\Share\* with query builder

Merge pull request #23851 from nextcloud/enh/read_env_only_once

Read the env variables only once

Use query builder instead of OC_DB in trashbin

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #23943 from nextcloud/bugfix/oci/fix-ilike-on-oracle

Fix iLike() falsely turning escaped % and _ into wildcards

Merge pull request #23922 from nextcloud/bugfix/noid/fix-query-type-detection

Improve query type detection

Merge pull request #23928 from nextcloud/bugfix/oci/dont-leave-stray-cursors-on-mimetype-update

Fix repair mimetype step to not leave stray cursors

Merge pull request #23940 from nextcloud/enh/skip_already_loaded_apps

Skip already loaded apps in loadApps

Merge pull request #23919 from nextcloud/dependabot/npm_and_yarn/css-loader-5.0.1

Merge pull request #23929 from nextcloud/techdebt/noid/deprecate-prepare-and-execute-audited-as-they-leak-cursors

Deprecate OC_DB::prepare and OC_DB::executeAudited as they leak cursors

Fix iLike() falsely turning escaped % and _ into wildcards

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #23932 from nextcloud/enh/s3/do_not_check_bucket_exists_on_every_request

Allow config to specify the bucket exists

Remove the cookie paths for php<7.3

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Skip already loaded apps in loadApps

Otherwise you might end up calling a lot of functions unneeded.
And while the individual calls are cheap if you multiply them by 20k
they still get somewhat expensive.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Replace some usages of OC_DB in OC\Share\* with query builder

Signed-off-by: Joas Schilling <coding@schilljs.com>

Make sure Oracle always casts everything in the best way

Signed-off-by: Joas Schilling <coding@schilljs.com>

Use Query builder function

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix order of GREATEST for Oracle

As per https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm
Oracle uses the first value to cast the rest or the values.
So when the first value is a plain int, instead of doing the math,
it will cast the expression to int and continue with a potential 0.

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #23921 from nextcloud/techdebt/oci/fix-casting-to-integer

Fix casting to integer on Oracle

Avoid SCSS compilation if not needed

Now we do on each template load a compile with the SCSS variables to see
if they changed or not. However there is no real reason for this if the
variables didn't change.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Allow config to specify the bucket exists

In the 99% case the bucket is just always there. And if it is not the
read/write will fail hard anyways. Esp on big instances the Objectstore
is not always fast and this can save a few hundered ms of each request
that acess the objectstore.

In short it is adding

'verify_bucket_exists' => false

To the S3 config part

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Deprecate OC_DB::prepare and OC_DB::executeAudited as they leak cursors

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix repair mimetype step to not leave stray cursors

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #23920 from nextcloud/fix/match_bearer_front

Bearer must be in the start of the auth header

Merge pull request #23918 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Fix getstorage call

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Do not setup the default FS on normal routes

This should help with load times hopefully. Only initialize the FS if we
actually ned it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Bump css-loader from 3.6.0 to 5.0.1

Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.6.0 to 5.0.1.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.6.0...v5.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Improve query type detection

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix casting to integer on Oracle

Signed-off-by: Joas Schilling <coding@schilljs.com>

Bearer must be in the start of the auth header

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #23347 from st3iny/enhancement/19526/new-share-pending-confirm-button

Merge pull request #23916 from nextcloud/dependabot/npm_and_yarn/mocha-8.2.1

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Merge pull request #23857 from nextcloud/dependabot/composer/vimeo/psalm-4.1.1

Bump vimeo/psalm from 4.0.1 to 4.1.1

Bump vimeo/psalm from 4.0.1 to 4.1.1

Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 4.0.1 to 4.1.1.
- [Release notes](https://github.com/vimeo/psalm/releases)
- [Commits](https://github.com/vimeo/psalm/compare/4.0.1...4.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #23906 from nextcloud/techdebt/noid/simplify-can-change-user-pasword

Simplify the check if admin can change password based on encryption status

Merge pull request #23887 from ecsecta/fix_23797

Do not emit UserCreatedEvent twice

Simplify the check if admin can change password based on encryption status

Found by Psalm:
```
/home/runner/work/server/server/apps/settings/lib/Controller/UsersController.php:324:8:error - RedundantCondition: Type true for $isEncryptionModuleLoaded is never falsy
```

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #23004 from nextcloud/files-scan-background

only run the background scanner for users that have unscanned files

Bump mocha from 7.2.0 to 8.2.1

Bumps [mocha](https://github.com/mochajs/mocha) from 7.2.0 to 8.2.1.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mochajs/mocha/compare/v7.2.0...v8.2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #23910 from nextcloud/bugfix/23908/fix-share-link-avatar

Fix link share avatar icon

Make link share avatar icon blue again

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix link share avatar icon

Use "icon-class" instead of "class" as this is how to tell the component
that we don't want initials displayed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #23907 from nextcloud/fix/noid/update-baseline-due-to-phpdoc

Check in InvalidArgument psalm error into baseline

Add confirm button in new link share pending expire/password menu

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

Check InvalidArgument psalm error into baseline - PHPDoc needs to be improved

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #23904 from nextcloud/fix/php-lint

Fix php lint action

Merge pull request #23868 from nextcloud/techdebt/webpack-hide-modules

Remove old hide modules option for webpack

Remove old hide modules option for webpack

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #23901 from nextcloud/techdebt/noid/deprecate-old-usermanager-events

Deprecate old user manager events for user creation

Fix php lint action

fix: also remove use statement of UserCreatedEvent

Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>

[tx-robot] updated from transifex

Merge pull request #23819 from nextcloud/td/routing/move_things_around

Cleanup routing

Merge pull request #23820 from nextcloud/td/remove/OCPAPI_check

Remove the matching on ancient /ocs routes

Merge pull request #23792 from nextcloud/techdebt/noid/group-unread-comment-count-query

Add a function to get the unread count for multiple objects in one go

Deprecate old user manager events for user creation

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #23888 from nextcloud/fix/noid/only-fetch-jsconfig-when-used

Only build JSConfig in TemplateLayout when it is actually used

Have the CommentsPropertiesPlugin use the new fancy method

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #23897 from nextcloud/bugfix/23236

Move help to separate stylesheet

Merge pull request #23898 from nextcloud/bugfix/noid/list-style-scope

Make user status styles scoped

Make user status styles scoped

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Move help to separate stylesheet

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #23890 from nextcloud/techdebt/noid/refactor-theming-getImage

Cleanup ImageManager::getImage()

Merge pull request #23869 from nextcloud/rakekniven-patch-1

Add a function to get the unread count for multiple objects in one go

Signed-off-by: Joas Schilling <coding@schilljs.com>

Document the behaviour inline

Signed-off-by: Morris Jobke <hey@morrisjobke.de>