]> source.dussan.org Git - poi.git/log
poi.git
7 years agoRemove use of deprecated methods
PJ Fanning [Sun, 22 Oct 2017 12:07:14 +0000 (12:07 +0000)]
Remove use of deprecated methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812901 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd getter/setter for ReadingOrder to XSSF, closes issue #73
Dominik Stadler [Wed, 18 Oct 2017 18:26:41 +0000 (18:26 +0000)]
Add getter/setter for ReadingOrder to XSSF, closes issue #73

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812558 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBump up the Eclipse JVM version to 8 to match Ant
Nick Burch [Wed, 18 Oct 2017 18:21:29 +0000 (18:21 +0000)]
Bump up the Eclipse JVM version to 8 to match Ant

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812557 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBump up the Eclipse JVM version
Nick Burch [Wed, 18 Oct 2017 18:16:48 +0000 (18:16 +0000)]
Bump up the Eclipse JVM version

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812556 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 61630: performance improvements in XSSFExportToXml. Thanks to Daniel for the...
Javen O'Neal [Wed, 18 Oct 2017 16:04:06 +0000 (16:04 +0000)]
bug 61630: performance improvements in XSSFExportToXml. Thanks to Daniel for the patch.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812546 13f79535-47bb-0310-9956-ffa450edef68

7 years agocleanup for r1812470: avoid NPEs from string.isEmpty()
Javen O'Neal [Wed, 18 Oct 2017 14:40:56 +0000 (14:40 +0000)]
cleanup for r1812470: avoid NPEs from string.isEmpty()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812532 13f79535-47bb-0310-9956-ffa450edef68

7 years agofix compile error
Javen O'Neal [Wed, 18 Oct 2017 14:40:05 +0000 (14:40 +0000)]
fix compile error

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812531 13f79535-47bb-0310-9956-ffa450edef68

7 years agocleanup for r1812475: avoid NPEs from string.isEmpty()
Javen O'Neal [Wed, 18 Oct 2017 14:29:56 +0000 (14:29 +0000)]
cleanup for r1812475: avoid NPEs from string.isEmpty()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812520 13f79535-47bb-0310-9956-ffa450edef68

7 years agocleanup for r1812476: avoid NPEs from string.isEmpty()
Javen O'Neal [Wed, 18 Oct 2017 14:08:43 +0000 (14:08 +0000)]
cleanup for r1812476: avoid NPEs from string.isEmpty()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812516 13f79535-47bb-0310-9956-ffa450edef68

7 years agoreplace "".equals(string) with string.isEmpty() to avoid null strings silently evalua...
Javen O'Neal [Wed, 18 Oct 2017 08:41:42 +0000 (08:41 +0000)]
replace "".equals(string) with string.isEmpty() to avoid null strings silently evaluating to false; most code should probably check string for null  if it is not already

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812476 13f79535-47bb-0310-9956-ffa450edef68

7 years agoprefer literal.equals(variable) over variable.equals(literal)
Javen O'Neal [Wed, 18 Oct 2017 08:41:25 +0000 (08:41 +0000)]
prefer literal.equals(variable) over variable.equals(literal)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812475 13f79535-47bb-0310-9956-ffa450edef68

7 years agoconvert "".equals(string) to string.isEmpty()
Javen O'Neal [Wed, 18 Oct 2017 08:22:51 +0000 (08:22 +0000)]
convert "".equals(string) to string.isEmpty()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812470 13f79535-47bb-0310-9956-ffa450edef68

7 years agosimplfy PackagingURIHelper#combine boolean logic using xor and replacing +FORWARD_SLA...
Javen O'Neal [Wed, 18 Oct 2017 08:10:36 +0000 (08:10 +0000)]
simplfy PackagingURIHelper#combine boolean logic using xor and replacing +FORWARD_SLASH_CHAR with FORWARD_SLASH_STRING

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812468 13f79535-47bb-0310-9956-ffa450edef68

7 years agofix typo
Javen O'Neal [Wed, 18 Oct 2017 07:47:25 +0000 (07:47 +0000)]
fix typo

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812464 13f79535-47bb-0310-9956-ffa450edef68

7 years agostring.equals("") -> string.isEmpty() or "".equals(string)
Javen O'Neal [Wed, 18 Oct 2017 07:45:53 +0000 (07:45 +0000)]
string.equals("") -> string.isEmpty() or "".equals(string)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812463 13f79535-47bb-0310-9956-ffa450edef68

7 years agofor -> foreach
Javen O'Neal [Wed, 18 Oct 2017 07:33:07 +0000 (07:33 +0000)]
for -> foreach
string.equals() -> string.isEmpty() or .equals(string)
ArrayList -> List

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812461 13f79535-47bb-0310-9956-ffa450edef68

7 years agoIntelliJ: simplify boolean logic
Javen O'Neal [Tue, 17 Oct 2017 07:43:41 +0000 (07:43 +0000)]
IntelliJ: simplify boolean logic

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812363 13f79535-47bb-0310-9956-ffa450edef68

7 years agoremove deprecated XSSFRowShifter.shiftMerged(int,int,int) method; replaced with RowSh...
Javen O'Neal [Tue, 17 Oct 2017 07:10:25 +0000 (07:10 +0000)]
remove deprecated XSSFRowShifter.shiftMerged(int,int,int) method; replaced with RowShifter.shiftMergedRegions(int,int,int) in POI 3.15 beta 2

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812354 13f79535-47bb-0310-9956-ffa450edef68

7 years agoignore gradle/, gradlew, and gradlew.bat
Javen O'Neal [Tue, 17 Oct 2017 06:13:09 +0000 (06:13 +0000)]
ignore gradle/, gradlew, and gradlew.bat

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812351 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 61584: Fix XDGFPage variable typo causing crash
Dustin Spicuzza [Mon, 16 Oct 2017 01:35:31 +0000 (01:35 +0000)]
Bug 61584: Fix XDGFPage variable typo causing crash

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812240 13f79535-47bb-0310-9956-ffa450edef68

7 years agogithub-79: add String.toString() to forbidden API's
Javen O'Neal [Mon, 16 Oct 2017 01:34:13 +0000 (01:34 +0000)]
github-79: add String.toString() to forbidden API's

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812239 13f79535-47bb-0310-9956-ffa450edef68

7 years agoMake public static members final [thanks to Kui Liu]. This close #78.
PJ Fanning [Sun, 15 Oct 2017 20:50:58 +0000 (20:50 +0000)]
Make public static members final [thanks to Kui Liu]. This close #78.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812234 13f79535-47bb-0310-9956-ffa450edef68

7 years agoRemove unnecessary toString calls [thanks to Kui Liu]. This close #79.
PJ Fanning [Sun, 15 Oct 2017 20:34:10 +0000 (20:34 +0000)]
Remove unnecessary toString calls [thanks to Kui Liu]. This close #79.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812233 13f79535-47bb-0310-9956-ffa450edef68

7 years agoRemove unnecessary StringBuilder [thanks to Kui Liu]. This close #80.
PJ Fanning [Sun, 15 Oct 2017 20:25:33 +0000 (20:25 +0000)]
Remove unnecessary StringBuilder [thanks to Kui Liu]. This close #80.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812232 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix some findbugs-issues and apply some code-cleanup and apply some smaller pull...
Dominik Stadler [Fri, 13 Oct 2017 09:40:22 +0000 (09:40 +0000)]
Fix some findbugs-issues and apply some code-cleanup and apply some smaller pull requests.
This closes #74, This closes #75, This closes #76

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812097 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix aparent copy/paste error in XSSFBorderFormatting
Dominik Stadler [Wed, 11 Oct 2017 18:32:13 +0000 (18:32 +0000)]
Fix aparent copy/paste error in XSSFBorderFormatting

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811867 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 58068: Add a method to pass the actual Color to StylesTable.findFont().
Dominik Stadler [Wed, 11 Oct 2017 18:32:01 +0000 (18:32 +0000)]
Bug 58068: Add a method to pass the actual Color to StylesTable.findFont().

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811866 13f79535-47bb-0310-9956-ffa450edef68

7 years agoadjust tests, javadoc, ...
Dominik Stadler [Wed, 11 Oct 2017 18:31:34 +0000 (18:31 +0000)]
adjust tests, javadoc, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811865 13f79535-47bb-0310-9956-ffa450edef68

7 years agoRemove "filling" in IntList as this has no effect whatsoever as far as I could see
Dominik Stadler [Wed, 11 Oct 2017 05:32:05 +0000 (05:32 +0000)]
Remove "filling" in IntList as this has no effect whatsoever as far as I could see
Fix some IntelliJ warnings, missing JavaDoc, typos, Findbugs issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811793 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd more output to the pre-check to help in analysis some strange build-failures...
Dominik Stadler [Mon, 9 Oct 2017 19:35:43 +0000 (19:35 +0000)]
Add more output to the pre-check to help in analysis some strange build-failures in CI, e.g. INFRA-15244

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811597 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix target compile-ooxml-ss, it needs the crypt-code now
Dominik Stadler [Mon, 9 Oct 2017 19:35:39 +0000 (19:35 +0000)]
Fix target compile-ooxml-ss, it needs the crypt-code now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811596 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd test which shows that bug 51262 is fixed now
Dominik Stadler [Mon, 9 Oct 2017 19:35:32 +0000 (19:35 +0000)]
Add test which shows that bug 51262 is fixed now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811595 13f79535-47bb-0310-9956-ffa450edef68

7 years agoApply patch from bug 61096: Add support for modules in VBAMacroReader
Dominik Stadler [Sat, 7 Oct 2017 06:11:12 +0000 (06:11 +0000)]
Apply patch from bug 61096: Add support for modules in VBAMacroReader

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811383 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 61586: Add test which shows that it works as expected
Dominik Stadler [Fri, 6 Oct 2017 17:41:20 +0000 (17:41 +0000)]
Bug 61586: Add test which shows that it works as expected

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811355 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 61564: Try to get rid of the Java 9 illegal access warning now that we run Java 8
Dominik Stadler [Wed, 4 Oct 2017 19:54:41 +0000 (19:54 +0000)]
Bug 61564: Try to get rid of the Java 9 illegal access warning now that we run Java 8

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811145 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd some more code from the separate integration test project to be able to publish...
Dominik Stadler [Wed, 4 Oct 2017 19:54:21 +0000 (19:54 +0000)]
Add some more code from the separate integration test project to be able to publish the femaining functionality as separate project at some point

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811144 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 61064: Support behavior of function CEILING in newer versions of Microsoft Excel
Dominik Stadler [Thu, 28 Sep 2017 14:36:53 +0000 (14:36 +0000)]
Bug 61064: Support behavior of function CEILING in newer versions of Microsoft Excel

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1810007 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 61082: Adjust JavaDoc for getFirst/LastRow/Cell to explain that there might be...
Dominik Stadler [Thu, 28 Sep 2017 13:12:32 +0000 (13:12 +0000)]
Bug 61082: Adjust JavaDoc for getFirst/LastRow/Cell to explain that there might be empty rows/cells included in the counts

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809988 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix bug 61516: when copying cells with formulas we should properly check for referenc...
Dominik Stadler [Thu, 28 Sep 2017 09:56:45 +0000 (09:56 +0000)]
Fix bug 61516: when copying cells with formulas we should properly check for references that are invalid afterwards.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809967 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdjust some unit-tests, use try-with-resource, enable test which works now, ...
Dominik Stadler [Tue, 26 Sep 2017 12:40:38 +0000 (12:40 +0000)]
Adjust some unit-tests, use try-with-resource, enable test which works now, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809739 13f79535-47bb-0310-9956-ffa450edef68

7 years agoReplace "getEntry() plus catch" by "hasEntry()" in HSSFWorkbook
Dominik Stadler [Tue, 26 Sep 2017 12:33:08 +0000 (12:33 +0000)]
Replace "getEntry() plus catch" by "hasEntry()" in HSSFWorkbook

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809738 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFixup change for CellReference to keep the behavior the same as before
Dominik Stadler [Tue, 26 Sep 2017 12:31:51 +0000 (12:31 +0000)]
Fixup change for CellReference to keep the behavior the same as before

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809737 13f79535-47bb-0310-9956-ffa450edef68

7 years agoRemove empty directories beneath "scratchpad"
Dominik Stadler [Tue, 26 Sep 2017 12:22:53 +0000 (12:22 +0000)]
Remove empty directories beneath "scratchpad"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809735 13f79535-47bb-0310-9956-ffa450edef68

7 years agoReplace deprecated CellReference class and some other warnings fixed
Dominik Stadler [Tue, 26 Sep 2017 08:26:05 +0000 (08:26 +0000)]
Replace deprecated CellReference class and some other warnings fixed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809714 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix some Sonar issues
Dominik Stadler [Mon, 25 Sep 2017 15:10:40 +0000 (15:10 +0000)]
Fix some Sonar issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809636 13f79535-47bb-0310-9956-ffa450edef68

7 years agoReplace the incompatible new interface method endSheet() with a Java 8 default method...
Dominik Stadler [Mon, 25 Sep 2017 14:45:14 +0000 (14:45 +0000)]
Replace the incompatible new interface method endSheet() with a Java 8 default method so existing implementations do not need to be adjusted. Also use this for headerFooter() and remove the empty implementations that are now obsolete.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809635 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 61349 -- bump limits on classes that caused regressions in Dominik's regression...
Tim Allison [Mon, 25 Sep 2017 12:53:10 +0000 (12:53 +0000)]
Bug 61349 -- bump limits on classes that caused regressions in Dominik's regression corpus.  Many thanks to Dominik Stadler for running the regression tests!!!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809623 13f79535-47bb-0310-9956-ffa450edef68

7 years agoRemove more deprecated classes and methods
PJ Fanning [Sat, 23 Sep 2017 14:03:25 +0000 (14:03 +0000)]
Remove more deprecated classes and methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809428 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix compiling Examples after adding new interface-method, fix compiler warnings and...
Dominik Stadler [Sat, 23 Sep 2017 10:26:27 +0000 (10:26 +0000)]
Fix compiling Examples after adding new interface-method, fix compiler warnings and adjust some broken Javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809388 13f79535-47bb-0310-9956-ffa450edef68

7 years agoTried to enable this test, but it is broken since a long time and I am not sure how...
Dominik Stadler [Sat, 23 Sep 2017 07:44:09 +0000 (07:44 +0000)]
Tried to enable this test, but it is broken since a long time and I am not sure how this is expected to behave...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809372 13f79535-47bb-0310-9956-ffa450edef68

7 years agoApply patch to add endSheet() to the XSSFEventBasedExcelExtractor, fixes bug 60737...
Dominik Stadler [Sat, 23 Sep 2017 07:41:27 +0000 (07:41 +0000)]
Apply patch to add endSheet() to the XSSFEventBasedExcelExtractor, fixes bug 60737, thanks to user zakim for the patch

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809371 13f79535-47bb-0310-9956-ffa450edef68

7 years agoMore IntelliJ warnings fixes
Dominik Stadler [Sat, 23 Sep 2017 07:38:01 +0000 (07:38 +0000)]
More IntelliJ warnings fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809370 13f79535-47bb-0310-9956-ffa450edef68

7 years agoThe Gradle-based Sonarqube job does not actually, it completes with success, but...
Dominik Stadler [Fri, 22 Sep 2017 21:30:40 +0000 (21:30 +0000)]
The Gradle-based Sonarqube job does not actually, it completes with success, but the data never appears on Sonarqube itself, we need to investigate this some more later, for now I enabled the Maven based job again.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809359 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 59747: Adjust order of first two entries in the resulting Zip to try to enable...
Dominik Stadler [Fri, 22 Sep 2017 21:19:39 +0000 (21:19 +0000)]
Bug 59747: Adjust order of first two entries in the resulting Zip to try to enable some external tools to auto-detect the file-type

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809357 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdjust many examples for Java 8: try-with-resource, multi-catch and other code cleanup.
Dominik Stadler [Fri, 22 Sep 2017 21:16:09 +0000 (21:16 +0000)]
Adjust many examples for Java 8: try-with-resource, multi-catch and other code cleanup.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809354 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix some IntelliJ warnings
Dominik Stadler [Fri, 22 Sep 2017 20:07:56 +0000 (20:07 +0000)]
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809349 13f79535-47bb-0310-9956-ffa450edef68

7 years agoRemove Jobs for JDK 1.6/1.7, this should also make the findbugs-hacks obsolete here
Dominik Stadler [Fri, 22 Sep 2017 20:06:31 +0000 (20:06 +0000)]
Remove Jobs for JDK 1.6/1.7, this should also make the findbugs-hacks obsolete here
The jobs still need to manually removed in Jenkins, though!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809348 13f79535-47bb-0310-9956-ffa450edef68

7 years agoJavadoc fix
Nick Burch [Thu, 21 Sep 2017 15:09:50 +0000 (15:09 +0000)]
Javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809171 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 61349 -- add more sanity checks when allocating byte[]
Tim Allison [Thu, 21 Sep 2017 14:52:59 +0000 (14:52 +0000)]
Bug 61349 -- add more sanity checks when allocating byte[]

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809169 13f79535-47bb-0310-9956-ffa450edef68

7 years agoApply patch from bug 61033 to add a XSSFWorkbook.setCellFormulaValidation(false)...
Dominik Stadler [Wed, 20 Sep 2017 19:08:57 +0000 (19:08 +0000)]
Apply patch from bug 61033 to add a XSSFWorkbook.setCellFormulaValidation(false) to speed up some operations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809071 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 61528 - Pivot Table enhancements, new example [Thanks to R Kietel]. This closes #71
PJ Fanning [Tue, 19 Sep 2017 21:21:37 +0000 (21:21 +0000)]
Bug 61528 - Pivot Table enhancements, new example [Thanks to R Kietel]. This closes #71

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808946 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 61528 - Pivot Table enhancements, new example [Thanks to R Kietel]. This closes #71
PJ Fanning [Tue, 19 Sep 2017 21:18:09 +0000 (21:18 +0000)]
Bug 61528 - Pivot Table enhancements, new example [Thanks to R Kietel]. This closes #71

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808945 13f79535-47bb-0310-9956-ffa450edef68

7 years agotidy up some test code
PJ Fanning [Tue, 19 Sep 2017 21:04:30 +0000 (21:04 +0000)]
tidy up some test code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808944 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd test to verify that bug 61532 is fixed as far as I see via the changes for bug...
Dominik Stadler [Tue, 19 Sep 2017 19:19:30 +0000 (19:19 +0000)]
Add test to verify that bug 61532 is fixed as far as I see via the changes for bug 61148.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808932 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdjust to make forbidden-api-check succeed again
Dominik Stadler [Tue, 19 Sep 2017 19:02:31 +0000 (19:02 +0000)]
Adjust to make forbidden-api-check succeed again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808930 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 61148: Fix calculating formula value, unfortunately we currently need to set...
Dominik Stadler [Tue, 19 Sep 2017 19:02:22 +0000 (19:02 +0000)]
Bug 61148: Fix calculating formula value, unfortunately we currently need to set the value twice
Also rework related tests to run more of the tests for HSSF, XSSF and SXSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808929 13f79535-47bb-0310-9956-ffa450edef68

7 years agoIntelliJ warnings, deprecation
Dominik Stadler [Tue, 19 Sep 2017 19:02:06 +0000 (19:02 +0000)]
IntelliJ warnings, deprecation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808928 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix some IntelliJ warnings
Dominik Stadler [Tue, 19 Sep 2017 16:23:37 +0000 (16:23 +0000)]
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808908 13f79535-47bb-0310-9956-ffa450edef68

7 years ago60805 (partial) -- remove/suppress println in tests
Tim Allison [Tue, 19 Sep 2017 15:52:21 +0000 (15:52 +0000)]
60805 (partial) -- remove/suppress println in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808903 13f79535-47bb-0310-9956-ffa450edef68

7 years agoWhile working on bug 61148 I found that getCellType() and setCellErrorValue() in...
Dominik Stadler [Tue, 19 Sep 2017 12:47:13 +0000 (12:47 +0000)]
While working on bug 61148 I found that getCellType() and setCellErrorValue() in SXSSFCell are doing different things than the ones in XSSFCell, tried to fix this by mimicking functionality of XSSF in SXSSF as well.
Reformating some small things as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808874 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 61454: add column width to example Spreadsheet ToHtml; thanks to Christian Froehler
Javen O'Neal [Tue, 19 Sep 2017 03:27:40 +0000 (03:27 +0000)]
bug 61454: add column width to example Spreadsheet ToHtml; thanks to Christian Froehler

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808817 13f79535-47bb-0310-9956-ffa450edef68

7 years agobug 61454: add column width to example Spreadsheet ToHtml; thanks to Christian Froehler
Javen O'Neal [Tue, 19 Sep 2017 03:26:20 +0000 (03:26 +0000)]
bug 61454: add column width to example Spreadsheet ToHtml; thanks to Christian Froehler

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808816 13f79535-47bb-0310-9956-ffa450edef68

7 years agoBug 61520: Add JavaDoc about name-references in Excel
Dominik Stadler [Mon, 18 Sep 2017 18:55:07 +0000 (18:55 +0000)]
Bug 61520: Add JavaDoc about name-references in Excel

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808763 13f79535-47bb-0310-9956-ffa450edef68

7 years agoAdd missing test.jar to test-hssf target
Dominik Stadler [Mon, 18 Sep 2017 18:54:47 +0000 (18:54 +0000)]
Add missing test.jar to test-hssf target

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808762 13f79535-47bb-0310-9956-ffa450edef68

7 years agouse non-deprecated versions of getCellType
PJ Fanning [Mon, 18 Sep 2017 16:31:55 +0000 (16:31 +0000)]
use non-deprecated versions of getCellType

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808741 13f79535-47bb-0310-9956-ffa450edef68

7 years agochange CellFormat.ultimateType to return CellType
PJ Fanning [Mon, 18 Sep 2017 16:06:54 +0000 (16:06 +0000)]
change CellFormat.ultimateType to return CellType

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808739 13f79535-47bb-0310-9956-ffa450edef68

7 years agochange HyperLink getType to return HyperlinkType
PJ Fanning [Mon, 18 Sep 2017 15:55:48 +0000 (15:55 +0000)]
change HyperLink getType to return HyperlinkType

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808737 13f79535-47bb-0310-9956-ffa450edef68

7 years agofix compiler warnings
PJ Fanning [Mon, 18 Sep 2017 14:15:15 +0000 (14:15 +0000)]
fix compiler warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808722 13f79535-47bb-0310-9956-ffa450edef68

7 years agoupdate getCellType to return CellType enum instead of int
PJ Fanning [Mon, 18 Sep 2017 13:58:55 +0000 (13:58 +0000)]
update getCellType to return CellType enum instead of int

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808718 13f79535-47bb-0310-9956-ffa450edef68

7 years agoupdate getCellType to return CellType enum instead of int
PJ Fanning [Mon, 18 Sep 2017 13:38:07 +0000 (13:38 +0000)]
update getCellType to return CellType enum instead of int

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808703 13f79535-47bb-0310-9956-ffa450edef68

7 years agoupdate getCellType to return CellType enum instead of int
PJ Fanning [Mon, 18 Sep 2017 13:26:16 +0000 (13:26 +0000)]
update getCellType to return CellType enum instead of int

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808700 13f79535-47bb-0310-9956-ffa450edef68

7 years agoremove some deprecated code slated for removal in 3.18
PJ Fanning [Mon, 18 Sep 2017 12:27:36 +0000 (12:27 +0000)]
remove some deprecated code slated for removal in 3.18

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808687 13f79535-47bb-0310-9956-ffa450edef68

7 years agoChange getCachedFormulaResultType to return CellType
PJ Fanning [Mon, 18 Sep 2017 10:50:50 +0000 (10:50 +0000)]
Change getCachedFormulaResultType to return CellType

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808678 13f79535-47bb-0310-9956-ffa450edef68

7 years ago#60499 - Deleting a picture that is used twice on a slide corrupt the slide
Andreas Beeker [Sun, 17 Sep 2017 22:45:03 +0000 (22:45 +0000)]
#60499 - Deleting a picture that is used twice on a slide corrupt the slide

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808661 13f79535-47bb-0310-9956-ffa450edef68

7 years agoRemove deprecated methods from NPOIFSFileSystem/OPOIFSFileSystem
Dominik Stadler [Sun, 17 Sep 2017 11:08:45 +0000 (11:08 +0000)]
Remove deprecated methods from NPOIFSFileSystem/OPOIFSFileSystem
IntelliJ warnings/suggestions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808622 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix some warnings in OOXMLLite and move copyFile to IOUtils
Dominik Stadler [Sun, 17 Sep 2017 11:08:31 +0000 (11:08 +0000)]
Fix some warnings in OOXMLLite and move copyFile to IOUtils

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808621 13f79535-47bb-0310-9956-ffa450edef68

7 years agoVarious code cleanups, "final" for static methods is useless, for-loops, simplify...
Dominik Stadler [Sun, 17 Sep 2017 11:08:23 +0000 (11:08 +0000)]
Various code cleanups, "final" for static methods is useless, for-loops, simplify boolean conditions, try-with-resource, javadoc, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808620 13f79535-47bb-0310-9956-ffa450edef68

7 years agoSome more code cleanup
Dominik Stadler [Sun, 17 Sep 2017 11:07:48 +0000 (11:07 +0000)]
Some more code cleanup

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808619 13f79535-47bb-0310-9956-ffa450edef68

7 years agoChange version to 4.0.0-SNAPSHOT as discussed on the mailing-list
Dominik Stadler [Sun, 17 Sep 2017 11:07:37 +0000 (11:07 +0000)]
Change version to 4.0.0-SNAPSHOT as discussed on the mailing-list

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808618 13f79535-47bb-0310-9956-ffa450edef68

7 years agoMaxPermSize is not used any more in Java 8, so remove it everywhere
Dominik Stadler [Sun, 17 Sep 2017 11:07:28 +0000 (11:07 +0000)]
MaxPermSize is not used any more in Java 8, so remove it everywhere

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808617 13f79535-47bb-0310-9956-ffa450edef68

7 years agoDisable Maven-Sonar run to check if the Gradle-Sonar job is working, some more comments
Dominik Stadler [Sun, 17 Sep 2017 11:07:21 +0000 (11:07 +0000)]
Disable Maven-Sonar run to check if the Gradle-Sonar job is working, some more comments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808616 13f79535-47bb-0310-9956-ffa450edef68

7 years agowrong release-notes link
Andreas Beeker [Sat, 16 Sep 2017 21:38:43 +0000 (21:38 +0000)]
wrong release-notes link

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808594 13f79535-47bb-0310-9956-ffa450edef68

7 years agoSonar-Maven: Switch to UTF-8 for source files to silence some warnings in the build.
Dominik Stadler [Sat, 16 Sep 2017 13:39:29 +0000 (13:39 +0000)]
Sonar-Maven: Switch to UTF-8 for source files to silence some warnings in the build.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808540 13f79535-47bb-0310-9956-ffa450edef68

7 years agoJenkins DSL: Remove timeout from Jenkins Jobs for now, it seems this plugin is curren...
Dominik Stadler [Sat, 16 Sep 2017 13:39:25 +0000 (13:39 +0000)]
Jenkins DSL: Remove timeout from Jenkins Jobs for now, it seems this plugin is currently missing in the Apache Jenkins instance
Adjust nodes for OpenJDK build after requiring OpenJDK 8 instead of 6

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808539 13f79535-47bb-0310-9956-ffa450edef68

7 years agoJenkins DSL: Use JDK 1.8 for more projects, fix listing of slaves in Test-Environment job
Dominik Stadler [Sat, 16 Sep 2017 13:06:59 +0000 (13:06 +0000)]
Jenkins DSL: Use JDK 1.8 for more projects, fix listing of slaves in Test-Environment job

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808537 13f79535-47bb-0310-9956-ffa450edef68

7 years agoremove some deprecated code slated for removal in 3.18
PJ Fanning [Sat, 16 Sep 2017 12:16:29 +0000 (12:16 +0000)]
remove some deprecated code slated for removal in 3.18

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808535 13f79535-47bb-0310-9956-ffa450edef68

7 years agoJenkins DSL:
Dominik Stadler [Sat, 16 Sep 2017 09:08:45 +0000 (09:08 +0000)]
Jenkins DSL:
* Enable SCM-retry to see if that helps against the frequent SVN update failures
* Add a POI-DSL-Test-Environment to have this Job also defined via DSL

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808525 13f79535-47bb-0310-9956-ffa450edef68

7 years agoJenkins DSL: Use OpenJDK 8 and latest JDK 1.9
Dominik Stadler [Sat, 16 Sep 2017 08:29:33 +0000 (08:29 +0000)]
Jenkins DSL: Use OpenJDK 8 and latest JDK 1.9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808524 13f79535-47bb-0310-9956-ffa450edef68

7 years agoFix some compiler warnings
Dominik Stadler [Sat, 16 Sep 2017 08:29:28 +0000 (08:29 +0000)]
Fix some compiler warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808523 13f79535-47bb-0310-9956-ffa450edef68

7 years agoUse Integer.compare() where possible
Dominik Stadler [Sat, 16 Sep 2017 08:29:20 +0000 (08:29 +0000)]
Use Integer.compare() where possible

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808522 13f79535-47bb-0310-9956-ffa450edef68