Artur Signell [Mon, 11 Nov 2013 13:56:06 +0000 (15:56 +0200)]
Merge changes from origin/7.1
51a46a0 Recovering scroll position after regression problems. (#12727) c464dcf Convert push test to TB3 so it has a chance to pass 2c6d010 Fixes test issues preventing it from passing 049b9d9 Remove out of order flush() (#12283)
Mika Murtojarvi [Thu, 7 Nov 2013 11:28:53 +0000 (13:28 +0200)]
A fix for handling nested parentheses in sass (#12833)
Selectors such as *:not(:lang(fr)) are now allowed. Nested
parentheses were identified as the cause of the problem. Now
skipping is done to the matching right parenthesis instead of the
first right parenthesis.
Mika Murtojarvi [Tue, 5 Nov 2013 09:20:21 +0000 (11:20 +0200)]
Sass, the handling of selectors containing multiple #-symbols (#12832)
After the first commit, a test case has been downloaded and added to
w3ctests. The indentation of a production was also changed in an
attempt to more clearly express its meaning.
joheriks [Tue, 22 Oct 2013 14:30:31 +0000 (17:30 +0300)]
Import W3C CSS tests to validate CSS parsing (#12735)
Downloaded W3C conformance tests for CSS 2.1 and CSS 3 (selectors),
extracted all CSS (style tags, inline styles, and linked stylesheets),
Since each CSS is valid SCSS, the parser should accept them. Since these
are browser tests, some include CSS fragments which are intentionally
malformed. These are excluded via explicit exclusion lists.
Jarno Rantala [Mon, 28 Oct 2013 12:53:54 +0000 (14:53 +0200)]
Forces small delay before showing accessible tooltip on focus (#12849)
Screen reader (JAWS 14) seems to get confused about the focused item if
the tooltip is shown on focus. This commit forces small delay before
showing the tooltip. More info, see
http://www.w3.org/TR/2011/CR-wai-aria-20110118/roles#tooltip
Artur Signell [Fri, 18 Oct 2013 11:08:50 +0000 (14:08 +0300)]
Remove out of order flush() (#12283)
Writer.flush() is specified as:
"Flushes the stream. If the stream has saved any characters from the various
write() methods in a buffer, write them immediately to their intended
destination. Then, if that destination is another character or byte stream,
flush it. Thus one flush() invocation will flush all the buffers in a chain
of Writers and OutputStreams."
Recovering scroll position after regression problems. (#12727)
The fix for "Panels get unnecessary scroll bars in WebKit when content is 100% wide (#12727)" introduced side effects to #6731. This fix solves the problem.
Fabian Lange [Tue, 22 Oct 2013 22:06:24 +0000 (00:06 +0200)]
removed obsolete field "width" from VNativeButton. (#12825)
The field width of VNativeButton was written when setWidth() was invoked,
but it was never read anywhere. Removing it saves cpu time and memory.
This field was not marked as internal and it was protected, if anybody needs
it, they can easily add it to their classes.
Leif Åstrand [Tue, 22 Oct 2013 06:12:59 +0000 (09:12 +0300)]
Merge changes from origin/7.1
c7ae45c Validate that the connector is enabled before triggering actions for it (#12743) ce89a75 Created constants for tested browser versions (#12786) f9ea9b3 Allow running tests locally by overriding runLocally() (#12786) e70ba25 Added liferay module for building liferay.zip #12748 7c12694 Add sub directory support to sass test scanner (#12790) 39fdf66 Handle numbers in the same way if they do not have a unit (#12732) 6155d61 Disable fallback in a way compatible with Atmosphere JS 2.0.3 (#12241) f401595 Test for pushing large chunks of data (#12567) d41967d Skip compilation of TB2 tests if tests.tb2.skip is set 6c1ba81 Reverted button click() logic check (#12743) 779c8a0 Disable automated testing on Opera until issues are resolved (#12487, #12367, #12800) 962c1c3 Fix compilation error 7ee11a7 Remove unused test super class (#12786) a4211dc Resolve concurrency issue in running TB3 tests 20c28aa Fixed javadoc 0d36896 Add more hax to make test work with new Atmosphere JS (#12241) ed50200 Fix serialization issue (#12703) dd51b7f Added more exception handling to PushHandler (#12578, #11882) 6f76840 Sass variables can now start with underscore (#12716) ab5b20c Ticket #12727 - Panels get unnecessary scroll bars in WebKit when content is 100% wide. 361ad17 Fixed focus issue in TableMoveFocusWithSelectionTest (#12540) ee809e5 Revert broken fix and test (#12446)
The timeoutInterval variable needs to be part of per-UI state for the
code to work correctly. Storing it in a servlet-global MetadataWriter
instance is both semantically wrong and a race condition.
Also, the test currently throws NPE if assertions are enabled.
Henrik Paul [Fri, 18 Oct 2013 12:09:43 +0000 (15:09 +0300)]
Merge changes from origin/7.1
377d49e Allow configuring deployment port for TB3 tests 6779857 Updatet servlet tests to follow the same *Test naming convention e1c38bf Avoid obsolete calendar panel renderings to avoid various NPEs. (#12504,#12667) 63f10ec Fixed compilation error in TB3 test 3e593b0 Focus selected row in Table #12540 3c842b7 added small pause to make test pass 1b7e40d Only fetch rows if there are some (#11189) f595d05 Make the various Writers member fields instead of local variables (#12446) 4cb304d Converted broken test to TB3 2aa2fdc Handle ClientMethodInvocation serialization with JSONArray as parameter (#12532) 1449425 Also hide shim iframe of VOverlay on setVisible(false) (#12731) 25fc2f2 Fix whitespace after including a mixin (#12715) c29ca5e Update to atmosphere javascript 2.0.3-vaadin1 (#12241, #12127) f75164f Disable unit cache to avoid compilation issues when switching between branches 6a99730 Allow skipping TB2/TB3 tests using tests.tb2/tb3.skip
Artur Signell [Thu, 17 Oct 2013 12:21:09 +0000 (15:21 +0300)]
Resolve concurrency issue in running TB3 tests
Ensure nobody can update the static collections of browsers to run on
but that sub classes can restrict which browsers to run on using
super.getBrowersToTest().remove(something)
Artur Signell [Wed, 16 Oct 2013 12:31:15 +0000 (15:31 +0300)]
Reverted button click() logic check (#12743)
The isConnectorEnabled() method should only to be used to check if the
client side is allowed to interact with the button, not on the server side
(isConnectorEnabled() is false if the component is not attached to a UI)
Jarno Rantala [Thu, 10 Oct 2013 10:08:09 +0000 (13:08 +0300)]
Added ItemSetAddEvent and ItemSetRemoveEvent (#2794)
The events inherits the ItemSetChangedEvent and they contain more information about the added/removed items. These events are fired
from AbstractInMemoryContainer.
Pekka Hyvönen [Fri, 11 Oct 2013 12:55:50 +0000 (15:55 +0300)]
Converted test to use screenshots due to IE8 issues with TB dnd commands
(#12714)
Basically the screenshot for IE8 after the drag + drop commands shows
that the column header drag element is not removed from DOM for some
reason. In real life, column header drag and drop works for IE8.
Leif Åstrand [Thu, 10 Oct 2013 09:50:13 +0000 (12:50 +0300)]
Merge changes from origin/7.1
503e575 Fix NullPointerException in logger when message is null (#12588) d9f6dad Fixed Table range selection IE regression #12407 6453055 Run tests on Tomcat 8 (#12326) 10bcbdc Actually open integration test. 3cba6bf Rebuild OptionGroup on HtmlContentAllowed/Multiselect changes (#10451) 4f3cc4c Converted push test to TB3 (#12226, #12522) 281fc43 Fixed incorrect logging (#12241) 63e16e6 Mark as deprecated to discourage usage for new tests f488825 Update TB3+ convention to use a separate *Test file 5fb877b Makes test stable and adds helper comparison methods daf06e9 Use class name and not enclosing class for screenshot name
Leif Åstrand [Thu, 10 Oct 2013 09:49:52 +0000 (12:49 +0300)]
Merge changes from origin/7.1
ffb33be Update slider client-side state object on value change (#12676) b8828e7 Only publish files actually produced by this test/browser 5966f01 reduce reflow and calculation in VOverlay (#12566) 600f5f3 Do not try to focus invisible components which not present in UIDL #12654 d0e604f Only print testbench failure TeamCity messages when running in TC 0e9ff32 Ported regression fixes in 6.8 for #12407 to 7.1 branch 267a4ca Fix OptionGroup elements losing focus on value change (#10451) 07ca622 Fixes #12564 (HorizontalLayout breaks w/ alignment & error indicator)
Matti Tahvonen [Fri, 4 Oct 2013 12:41:06 +0000 (15:41 +0300)]
Only fetch rows if there are some (#11189)
IE hacks cause calls to onScroll in situations where the cache row fetch
logic is not working correctly (causes JS exception). This change has an
optimization to pass this logic if there are no rows available and this
way fixes the JS exception as well.
Artur Signell [Mon, 7 Oct 2013 16:56:43 +0000 (19:56 +0300)]
Makes test stable and adds helper comparison methods
* Takes into account that the timer can be triggered multiple times before the initial request is done (especially if the server is slow)
* Adds assertLessThan, assertLessThanOrEqual, assertGreaterThan, assertGreaterThanOrEqual to ease test creation
Artur Signell [Mon, 7 Oct 2013 15:12:06 +0000 (18:12 +0300)]
Update TB3+ convention to use a separate *Test file
For any issue there should be a UI class, e.g. LabelSomething and a
Test class which has the name of the UI + Test, e.g. LabelSomethingTest.
The LabelSomethingTest contains ALL tests which depend on LabelSomething
and are named accordingly to what they test.
For special and legacy cases also LegacyApplication and UIProvider are
supported in addition to UI classes
John Ahlroos [Mon, 7 Oct 2013 09:37:50 +0000 (12:37 +0300)]
Fixed Table range selection IE regression #12407
After fixes for #12407 the range selection did not work in the case
where the selection start had previously been removed. This caused
MultiSelectWithRemovedRow test to fail on IE.
Artur Signell [Thu, 12 Sep 2013 17:57:01 +0000 (20:57 +0300)]
Prepare for Atmosphere Javascript 2.0 (#12241)
* Atmosphere 2.0 has changed enableProtocol to default to true.
* Reopening a connection in Atmosphere 2.0 is signalled through an onReopen event (not present at all in Atmosphere 1.0.x)
Fix was backported from master
Change-Id: I6ed258087a0b3a06440ab9d19b621560fa4f998f
Merge: no
Removed some obsolete (hopefully!?) code doing some odd things with caption height calculation and some refactoring to make that part of code slightly more readable.
Leif Åstrand [Fri, 4 Oct 2013 09:00:00 +0000 (12:00 +0300)]
Merge changes from origin/7.1
8ce6565 Fixes normal drag and drop events (regression since 7.1) and html5 style D&D in IE10 (#12339) 5fb1da2 Publish error artifacts immediatly in TeamCity 649735f Added user agent for IE 11 (#12631) a5795f3 Prefixes GET parameters in Liferay with portlet namespace #12602 b235d9c Refactor how TB3 tests are written (#12572)
Artem Godin [Wed, 2 Oct 2013 14:07:14 +0000 (17:07 +0300)]
Fix OptionGroup elements losing focus on value change (#10451)
The misbehavior was caused by VOptionGroup.buildOptions recreating
associated panel on every change by removing and adding new elements.
With this fix applied it tries to update existing elements,
distinguishing them by assigned keys. It will recreate panel though if
elements are reordered or new elements were added/removed.
Artur Signell [Fri, 27 Sep 2013 10:14:36 +0000 (13:14 +0300)]
Refactor how TB3 tests are written (#12572)
* openTestUrl() must be called in the beginning of each test. Before that setPush and setDebug can be used to determine whether /run-push or ?debug should be used in the URL
Artur Signell [Thu, 26 Sep 2013 06:28:50 +0000 (09:28 +0300)]
Merge changes from origin/7.1
7f7dc31 Base files for TB3 tests (#12572) 6b17abe Make it possible to override web driver in tests (#12572) a682e3b Refactored build scripts to support TB2, TB3 + integration tests (#12572) e556642 Converted servlet integration tests to TB3 (#12573) 21af0c3 Updated TB3 tests to use Firefox 24 (#12604) a7583c6 TB3 test for browsers (#12572) 37b8543 Do not add empty package javadoc for new classes 0248b8f Fixes browser detection for IE11 (#12638) 1df28c3 Run TB3 tests also on IE11 (#12631) a2daf65 Converted TB2 push tests to TB3 (#12580) d3261d7 Fixes issue with Table not scrolling completely to the end #12651 bd0ae05 Limit the number of tests run concurrently (#12572)