]>
source.dussan.org Git - vaadin-framework.git/log
Pekka Hyvönen [Wed, 22 Nov 2017 10:36:07 +0000 (12:36 +0200)]
Fix missing v-disabled for RadioButtonGroup and CheckBoxGroup options (#10332)
* Fix missing v-disabled for RadioButtonGroup
* Fix missing v-disabled for CheckBoxGroup
Resolves #9258
Ansku [Wed, 22 Nov 2017 08:29:42 +0000 (10:29 +0200)]
Test for MenuBar's WAI-ARIA attributes (#3922) (#10349)
Ahmed Ashour [Wed, 22 Nov 2017 07:31:56 +0000 (08:31 +0100)]
Disabled ComboBox should not open popup on pasting (Fixes #7898) (#10240)
schaerl [Wed, 22 Nov 2017 05:26:57 +0000 (06:26 +0100)]
Fix nested bean property name (#10271)
* Changed retrieval of names of nested properties (#10159)
The getName() function in NestedBeanPropertyDefinition will return only the top level name, which causes problems when adding a nested property that has the same name as a non-nested (e.g "value" & "sub.value")
This change should fix this behaviour by changing the return value of "getName()" of NestedBeanPropertyDefinition and introducing a function "getTopLevelName()" that only returns the last part of the full name for where it's needed
Teemu Suo-Anttila [Tue, 21 Nov 2017 15:05:05 +0000 (17:05 +0200)]
Improve Binder JavaDocs and APIs (#10347)
This patch also adds ValueChangeEvent as a parameter to field value change method in Binder.
Aleksi Hietanen [Tue, 21 Nov 2017 15:03:25 +0000 (17:03 +0200)]
Create DescriptionGenerator in package com.vaadin.ui (#10346)
Deprecate com.vaadin.ui.components.grid.DescriptionGenerator
and subclass it from the new DescriptionGenerator.
Aleksi Hietanen [Tue, 21 Nov 2017 12:25:42 +0000 (14:25 +0200)]
Fix issues from API review for 8.2 (#10342)
* Rename HierarchicalDataCommunicator#getMapper to getHierarchyMapper
* Make rpc field in Notification private
* Change DropIndexCalculator.ALWAYS_DROP_TO_END to a generic static method
* Move EditorImpl#editRow documentation to the interface level
* Correct GridDragEndEvent, GridDragStartEvent constructor javadocs
* Revert SharedState.registeredEventListeners to a Set
* Rename GridDropTarget dropAllowedOnSortedGridRows
* Rename ColumnState.contentMode to tooltipContentMode
Aleksi Hietanen [Tue, 21 Nov 2017 12:24:10 +0000 (14:24 +0200)]
Extract AbstractBeanPropertyDefinition and PropertyFilterDefinition (#10344)
This commit extracts the private nested class AbstractBeanPropertyDefinition from BeanPropertySet to a public class of package com.vaadin.data.
Additionally, the nested protected class PropertyFilterDefinition is extracted from NestedBeanPropertyDefinition to a public class in package com.vaadin.data.
Ansku [Tue, 21 Nov 2017 12:19:52 +0000 (14:19 +0200)]
Issue3922disableditem (#10259)
* Accessibility for MenuBar (#3922)
* TabIndex handling fix and an indexing tweak
* Make disabled MenuItems selectable for accessibility (#3922)
- It should be possible to navigate to a disabled MenuItem, even if
triggering the related command is disabled
* Refactor primary style name and aria attribute handling to own method
Ahmed Ashour [Tue, 21 Nov 2017 11:36:26 +0000 (12:36 +0100)]
FileResource to use bufferSize, and StreamResource to use getCacheTime() (#10247)
Ahmed Ashour [Tue, 21 Nov 2017 08:57:39 +0000 (09:57 +0100)]
Remove unused imports (#10330)
Guille [Mon, 20 Nov 2017 08:19:40 +0000 (10:19 +0200)]
Update testbench version (#10336)
Teemu Suo-Anttila [Fri, 17 Nov 2017 09:19:39 +0000 (11:19 +0200)]
Add known PushStateNavigation issue to release notes (#10334)
Pekka Hyvönen [Fri, 17 Nov 2017 08:46:14 +0000 (10:46 +0200)]
Rename GridDragger to GridRowDragger (#10333)
The old name GridDragger gave an impression that you're dragging the whole grid instead of rows.
Pekka Hyvönen [Thu, 16 Nov 2017 12:05:12 +0000 (14:05 +0200)]
Add documentation on GridDragger (#10328)
This pathc also switches GridDragger to by default not allow drops on rows when the
grid has been sorted.
Teemu Suo-Anttila [Thu, 16 Nov 2017 05:56:40 +0000 (07:56 +0200)]
Remove empty li element from release notes (#10326)
Teemu Suo-Anttila [Wed, 15 Nov 2017 14:09:39 +0000 (16:09 +0200)]
Update since tags in JavaDoc (#10325)
Teemu Suo-Anttila [Wed, 15 Nov 2017 13:54:40 +0000 (15:54 +0200)]
Fix click listener in WidgetSet test (#10324)
Pekka Hyvönen [Wed, 15 Nov 2017 12:37:33 +0000 (14:37 +0200)]
Add helper for Grid row DnD (#10255)
* Added Griddragger.
* Refactored the GridDragger to match FW style
Unit tests, Test UI and documentation to come next.
* Change DropMode to BETWEEN and add Test UIs
* Simplify GridDragger API
* Fixes and unit tests for GridDragger
Fixed issues regarding drop index calculation when sourche and target grid is the same.
When the ListDataProvider is not internally using List, always drops to the end.
Updates the old data provider instead of creating a new one to preserve filters&sorting.
Teemu Suo-Anttila [Wed, 15 Nov 2017 08:22:32 +0000 (10:22 +0200)]
Add mention of Wildfly 11 support and a test for it (#10319)
Olli Tietäväinen [Wed, 15 Nov 2017 08:21:40 +0000 (10:21 +0200)]
Update CDI tutorial wiki link (#10322)
Pekka Hyvönen [Wed, 15 Nov 2017 07:56:27 +0000 (09:56 +0200)]
Add new drop mode ON_GRID for GridDropTarget (#10296)
* Add new drop mode ON_GRID for GridDropTarget
Also adds a way to not accept drops on rows when the user has sorted the grid.
This way the bad UX can be avoided for showing the drop indicator for the wrong place when the grid has been sorted.
This has not been made default behavior to GridDropTarget since it would change behavior compared to 8.1.
Instead if is triggerable via API in GridDropTarget.
* Refactor sorted grid drop logic to server side
* Block setDropMode calls
Blocking setDropMode set values if the grid has been sorted and drop on
sorted rows is not allowed. The value is used once the grid is not sorted
anymore or the drops are allowed on sorted rows.
Jerome Meyer [Tue, 14 Nov 2017 14:26:57 +0000 (09:26 -0500)]
Fix TreeGrid to use correct super constructor (#10291)
Fixes #10195
Olli Tietäväinen [Tue, 14 Nov 2017 13:40:37 +0000 (15:40 +0200)]
Improve nested property support for Binder (#9925)
Fixes #9210
Teemu Suo-Anttila [Mon, 13 Nov 2017 12:58:31 +0000 (13:58 +0100)]
Add API to read Binding value from bean (#10316)
Leif Åstrand [Fri, 10 Nov 2017 15:11:03 +0000 (17:11 +0200)]
Set no-store headers on UIDL messages
UIDL might contain sensitive information that we should prevent from
being stored anywhere.
Olli Tietäväinen [Fri, 10 Nov 2017 15:05:44 +0000 (17:05 +0200)]
set default ContentMode PREFORMATTED in parameterless TooltipInfo constructor, fixes undefined enum value access in VTooltip.setTooltipText
Ansku [Fri, 10 Nov 2017 14:50:27 +0000 (16:50 +0200)]
Fix setting custom tab index for TabSheet or Accordion (#9574) (#10278)
Teemu Suo-Anttila [Fri, 10 Nov 2017 14:46:57 +0000 (15:46 +0100)]
Add ContentMode for row and cell descriptions in Grid (#10282)
Olli Tietäväinen [Fri, 10 Nov 2017 13:59:13 +0000 (15:59 +0200)]
Update README.md (#10302)
Ilia Motornyi [Fri, 10 Nov 2017 09:42:23 +0000 (11:42 +0200)]
Relax mapper access in HierarchicalDataCommunicator
Fixes #10292
Ahmed Ashour [Tue, 7 Nov 2017 11:47:09 +0000 (12:47 +0100)]
Remove deprecated usage of ApplicationConnection.hasEventListeners() (#10248)
From VDateField and VWindow
Leif Åstrand [Tue, 7 Nov 2017 11:21:06 +0000 (13:21 +0200)]
Skip scheduled flush if clear() is called (#10289)
Based on vaadin/flow#2834
Péter Török [Tue, 7 Nov 2017 09:39:11 +0000 (11:39 +0200)]
Make focus circulate in modal dialog to improve accessibility (#10260)
Make focus circulate in modal dialog to improve accessibility
Pekka Hyvönen [Mon, 6 Nov 2017 18:20:58 +0000 (20:20 +0200)]
HasItems.setItems(T... items) should allow edits (#10290)
* HasItems.setItems(T... items) should allow edits
Arrays.asList() creates a immutable Arrays.ArrayList, preventing users from doing dataProvider.getItems() and updating the returned collection. This makes it impossible to keep the same data provider, update it and keep the filters & sorting, and then just call dataProvider.refreshAll() to get changes visible. We should not require users to create a new data provider in this case.
This is the same for DataProvider.ofItems(T... items)
* fix missing whitespace from test error message
Ilia Motornyi [Mon, 6 Nov 2017 14:46:59 +0000 (16:46 +0200)]
Relax TreeGrid and Tree members access modifiers. (#10293)
* Relax TreeGrid and Tree members access modifiers.
Fixes #10292
* Fixes after review
Ahmed Ashour [Mon, 6 Nov 2017 14:17:04 +0000 (15:17 +0100)]
Use Logger instead of VConsole (#10249)
Because VConsole is deprecated and it recommends using Logger instead
Ahmed Ashour [Mon, 6 Nov 2017 13:27:22 +0000 (14:27 +0100)]
Fix javadoc ending (#10274)
Henri Muurimaa [Mon, 6 Nov 2017 13:23:47 +0000 (15:23 +0200)]
Fix link format (#10269)
Mikko Inkinen [Mon, 6 Nov 2017 13:15:55 +0000 (15:15 +0200)]
Fix typo (#10295)
Ahmed Ashour [Wed, 1 Nov 2017 09:36:47 +0000 (10:36 +0100)]
Use lambda expressions. (#10268)
Ahmed Ashour [Tue, 31 Oct 2017 17:51:22 +0000 (18:51 +0100)]
Use local variable for getWidget(). (#10253)
In some places, getWidget() is called many times, and I believe this can
have a litte performance improvement, since in some cases
super.getWidget() is called more than once.
Ahmed Ashour [Tue, 31 Oct 2017 16:41:14 +0000 (17:41 +0100)]
Fix end of line comments, which were made by automatic formatter (#10234)
Ahmed Ashour [Tue, 31 Oct 2017 10:23:36 +0000 (11:23 +0100)]
Remove redundant interface already implemented by super class. (#10258)
Adam Wagner [Mon, 30 Oct 2017 11:31:27 +0000 (13:31 +0200)]
Fix combo box suggestion popup height (#10256)
Fixes #10214
Knoobie [Mon, 30 Oct 2017 08:00:21 +0000 (09:00 +0100)]
add Grid.Column#get/setAssistiveCaption (#10219)
* add Grid#Column#get/setAssistiveCaption
* fix test and update doc
* move testGridAssistiveCaption to GridTest
* delete test file
* delete test file
* Delete GridAssistiveCaptionTest.java
* Create GridAssistiveCaptionTest
* Create GridAssistiveCaption
* Rename GridAssistiveCaption to GridAssistiveCaption.java
* Rename GridAssistiveCaptionTest to GridAssistiveCaptionTest.java
* Reformat using eclipse
Ahmed Ashour [Fri, 27 Oct 2017 15:44:19 +0000 (17:44 +0200)]
Use lambda with Handlers (#10229)
Also improve naming by replacing one-letter variable names.
Ahmed Ashour [Thu, 26 Oct 2017 19:19:41 +0000 (21:19 +0200)]
Use lambda with Listeners (#10222)
Also use "event" as the name for events
Ahmed Ashour [Thu, 26 Oct 2017 11:26:20 +0000 (13:26 +0200)]
Improve naming of fields and variables (#10242)
* Variable names to conform to naming convention.
* Use static constants where it makes sense
Ahmed Ashour [Thu, 26 Oct 2017 10:07:51 +0000 (12:07 +0200)]
Remove trailing spaces (#10224)
Teemu Suo-Anttila [Mon, 23 Oct 2017 12:34:42 +0000 (15:34 +0300)]
Add contribution guideline (#10083)
* Add contribution guideline
* Make suggested improvements to CONTRIBUTING.md
* Add link to good first issues and project setup
* Small update to CONTRIBUTING.md
Knoobie [Mon, 23 Oct 2017 12:33:55 +0000 (14:33 +0200)]
adds simple fix for missing label text in grid select checkboxes (#10223)
* adds simple fix for missing label text in grid select checkboxes
* updated comment and wording
Pekka Hyvönen [Mon, 23 Oct 2017 12:31:02 +0000 (13:31 +0100)]
Fix bad grammar in declarative documentation (#10236)
* Fix bad grammar in declarative documentation
* Fix typos
Ilia Motornyi [Mon, 23 Oct 2017 11:34:20 +0000 (14:34 +0300)]
Unlock panel caption div hacking (#10120)
* Unlock panel caption div hacking
Fixes #10119
* Javadoc formatting fix
Ahmed Ashour [Mon, 23 Oct 2017 07:05:44 +0000 (09:05 +0200)]
Grid column to be sortable when implemented/supported (Fixes #8792). (#10190)
* Grid column to be sortable when implemented/supported
* Fix GridDeclarativeTest
* Parameterize to Grid<Person>
* Revert Parameterize to Grid<Person>, JDK with generics.
* Assertions for other columns
* Fix test
Fixes #8792
Ahmed Ashour [Fri, 20 Oct 2017 12:17:32 +0000 (14:17 +0200)]
Grid.removeColumn() not to fail silently (Fixes #8056) (#10215)
* Grid.removeColumn() not to fail silently (Fixes #8056)
* Compilation with JDK
* Fix removeColumnByColumn_alreadyRemoved test
* Use ExpectedException
Oskar Bilén [Fri, 20 Oct 2017 08:55:11 +0000 (10:55 +0200)]
Typo in code (#10218)
Remove "java" from code example
Ahmed Ashour [Fri, 20 Oct 2017 08:54:25 +0000 (10:54 +0200)]
AbstractDateField.formatDate() to be abstract (#10186)
* AbstractDateField.formatDate to be abstract
Remove invalidDateString paramter, as it can be deduced
* Fix test
* Remove AbstractDateField.getResolutionVariable
VAbstractTextualDate: rename updateDateVariables() to updateBufferedResolutions()
* Revert to use fixed value of MONDAY.
* release notes
* updateAndSendBufferedValues()
* Missed call to updateAndSendBufferedValues();
* release note
Stephan Knitelius [Fri, 20 Oct 2017 08:53:45 +0000 (10:53 +0200)]
Added utility method Binder#asRequired() (#9873)
* Added the possiblity of defining a Field as Required without
setting an error message.
* Added @since to asRequired()
* Add droped paragraphs and see tag for asRequired(String)
Ahmed Ashour [Fri, 20 Oct 2017 08:15:43 +0000 (10:15 +0200)]
Fix typos (#10213)
* Fix typos
* Fix
Adam Wagner [Fri, 20 Oct 2017 08:14:33 +0000 (10:14 +0200)]
Check class name type on Grid cell mouse over (#10194)
* Check whether className is of type string
* Move string type checker method to widget util
* Fix formatting of WidgetUtil
* Break svg into lines
Knoobie [Fri, 20 Oct 2017 08:11:10 +0000 (10:11 +0200)]
Improve role usage in grid (#10206)
* add role="row" and role="gridcell"
* optimize code and add additional rows for the header
* add simple test
* improve code and add rowgroup
* add debug log
* add more log to test
* remove debug test info and add role before appending to tr
* wording - change contains to contain
* create enum for magic strings, change comments and method signature
* rename enum to be singular and rename param roleName to role
* update javadoc, rename and make enum public
Ahmed Ashour [Fri, 20 Oct 2017 08:10:02 +0000 (10:10 +0200)]
Use .toLowerCase and .toUpperCase(Locale.ROOT) (#10182)
* Use .toLowerCase and .toUpperCase(Locale.ROOT)
* Spaces
* add spaces after if(
Teemu Suo-Anttila [Fri, 20 Oct 2017 08:01:43 +0000 (11:01 +0300)]
Use GWT 2.8.2 (#10217)
Ahmed Ashour [Fri, 20 Oct 2017 07:12:44 +0000 (09:12 +0200)]
Fix HTML tags inside code in javadoc (#10160)
* Fix HTML tags inside code in javadoc
* only modify <table> and <tr>
* Fix javadoc
Ahmed Ashour [Fri, 20 Oct 2017 07:01:39 +0000 (09:01 +0200)]
Scheduler.ScheduledCommand and RepeatingCommand to be lambda (#10203)
* Scheduler.ScheduledCommand and RepeatingCommand to be lambda
* Restore <table> in javadoc
* Fix docs
Ahmed Ashour [Fri, 20 Oct 2017 07:00:01 +0000 (09:00 +0200)]
Add spaces after 'if' and 'for' in JavaScript (#10199)
* Add spaces after 'if' and 'for' in JavaScript
* Revert to old format
* Remove whitespaces
Ahmed Ashour [Fri, 20 Oct 2017 06:59:17 +0000 (08:59 +0200)]
Simplify lambda expressions (#10198)
* Simplify lambda expressions
And remove unneeded 'return' keyword.
* Format
Ahmed Ashour [Fri, 20 Oct 2017 06:54:49 +0000 (08:54 +0200)]
AbstractDateField: set value after being invalid (#10187)
Fixes #9763
Fixes #9978
Ahmed Ashour [Mon, 16 Oct 2017 15:21:23 +0000 (17:21 +0200)]
Fix AbstractDateField to correctly show week day names (#10188)
Fixes #9200
Ahmed Ashour [Mon, 16 Oct 2017 14:56:17 +0000 (16:56 +0200)]
Add *.properties to .gitattributes (#10180)
Teemu Suo-Anttila [Mon, 16 Oct 2017 10:31:15 +0000 (13:31 +0300)]
Fix IDE usage of Elemental in vaadin-shared (#10178)
Ahmed Ashour [Fri, 13 Oct 2017 13:11:49 +0000 (15:11 +0200)]
Fix some checkstyle warnings (#10179)
Ahmed Ashour [Fri, 13 Oct 2017 13:10:20 +0000 (15:10 +0200)]
Simplify waitUntil() in tests (#10181)
Ahmed Ashour [Fri, 13 Oct 2017 06:53:17 +0000 (08:53 +0200)]
Convert AbstractDateField not to be a LegacyComponent (#10148)
Teemu Suo-Anttila [Fri, 13 Oct 2017 06:44:32 +0000 (09:44 +0300)]
Add Navigator testing to Spring Boot test (#10174)
Ahmed Ashour [Thu, 12 Oct 2017 08:46:06 +0000 (10:46 +0200)]
Use Collection.isEmpty() (#10172)
Ahmed Ashour [Thu, 12 Oct 2017 06:00:02 +0000 (08:00 +0200)]
Remove redundant null checks before an instanceof (#10173)
Teemu Suo-Anttila [Wed, 11 Oct 2017 13:04:58 +0000 (16:04 +0300)]
Add ErrorLevel to Validators and results (#10099)
Fixes #9792
Teemu Suo-Anttila [Wed, 11 Oct 2017 12:15:46 +0000 (15:15 +0300)]
Fix Binder bean writing to only validate and write given bindings (#10162)
Pekka Hyvönen [Wed, 11 Oct 2017 11:40:51 +0000 (14:40 +0300)]
Fix wrong method name in Grid docs (#10171)
Knoobie [Wed, 11 Oct 2017 10:15:26 +0000 (12:15 +0200)]
Add aria-rowcount to grid (#10167)
This is based on discussion from vaadin/vaadin-grid#1023 .
Piotr Wilkin [Wed, 11 Oct 2017 07:23:22 +0000 (09:23 +0200)]
Fix for Grid client-side exception. (#10166)
Do not try to update the select all checkbox if it is not visible.
Fixes #10164
Pekka Hyvönen [Wed, 11 Oct 2017 05:34:13 +0000 (08:34 +0300)]
Add mention of Flow to issue template (#10168)
Ansku [Tue, 10 Oct 2017 15:45:44 +0000 (18:45 +0300)]
Prevent Grid refreshAll from getting stuck due mismatched state (#10161)
Fixes #10038
Ahmed Ashour [Tue, 10 Oct 2017 11:14:59 +0000 (13:14 +0200)]
Fix typos (#10158)
Ahmed Ashour [Tue, 10 Oct 2017 10:06:27 +0000 (12:06 +0200)]
Remove unneeded .toString() (#10141)
Piotr Wilkin [Tue, 10 Oct 2017 10:02:47 +0000 (12:02 +0200)]
Edit grid row by index - server side (#10040)
Opening grid editor from server side.
Fixes #8477.
Addressing #8820 will be the user's responsibility as fetching index of item might be slow.
Teemu Suo-Anttila [Tue, 10 Oct 2017 09:59:28 +0000 (12:59 +0300)]
Move microprofile tests to profile, add Wildfly Swarm (#10156)
Teemu Suo-Anttila [Mon, 9 Oct 2017 12:51:34 +0000 (15:51 +0300)]
Add maven based tests for several application servers (#10143)
Add tests for Glassfish based servers, Jetty 8, Tomcat 7 and Liberty (three runtimes).
Ahmed Ashour [Mon, 9 Oct 2017 10:49:10 +0000 (12:49 +0200)]
Use StringBuilder instead of StringBuffer (#10154)
Ahmed Ashour [Mon, 9 Oct 2017 06:41:21 +0000 (08:41 +0200)]
Remove checkstyle "FinalClass" (#10145)
Ahmed Ashour [Fri, 6 Oct 2017 07:15:48 +0000 (09:15 +0200)]
Add empty line at the end of files (#10142)
Teemu Suo-Anttila [Thu, 5 Oct 2017 07:09:22 +0000 (10:09 +0300)]
Add maven based server tests for Wildfly and Jetty (#10116)
This patch refactors the generic integration test war into
two jar dependencies and individual modules for different servers.
There is now a common approach for making configurations for the
remaining server tests still executed through an Ant build script.
Ahmed Ashour [Wed, 4 Oct 2017 10:48:21 +0000 (12:48 +0200)]
Don't use synthetic methods for listener classes. (#10135)
Fixes #9504
Olli Tietäväinen [Wed, 4 Oct 2017 10:18:38 +0000 (13:18 +0300)]
Support null intermediate properties in NestedMethodProperty (#10134)
Ignore null intermediate properties in setValue().
Forward port of #10085 in 7.7 to the compatibility package.
Ahmed Ashour [Wed, 4 Oct 2017 08:29:34 +0000 (10:29 +0200)]
Fix typos (#10124)
Ahmed Ashour [Wed, 4 Oct 2017 07:35:19 +0000 (09:35 +0200)]
Registration to remove state.registeredEventListeners (fixes #9634) (#10130)
This changes SharedState.registeredEventListeners to be a Map that keeps track of how many listeners of each type have been added, and handles unregistering of such listeners correctly.
Knoobie [Wed, 4 Oct 2017 05:51:31 +0000 (07:51 +0200)]
Add role="grid" and aria-multiselectable to grid (#10009)
Also adds aria-selected for grid rows.
Ahmed Ashour [Tue, 3 Oct 2017 10:56:48 +0000 (12:56 +0200)]
Break iteration when method is found (#10128)