Merge pull request #32482 from nextcloud/enh/noid/share-attributes

Add share attributes + prevent download permission

Multiple fixes

- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #33225 from nextcloud/fix/handle-one-time-passwords

Handle one time password better

Enforcing permission during resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Inherit hide download from share attributes

When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Block download when needed on direct download endpoint

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix view-only code after code review comments

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix adding to empty attributes and duplicate request

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Add share attrs + download permission support in frontend

Added download permission checkbox in frontend
Added share attributes parsing and setting in frontend.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Add nc:share-attributes Webdav property

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Don't reset share attributes when not specified

When not specified in the OCS call, don't reset the share attributes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Attempt to fix sqlite json issue

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix share attribute related tests + code style

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix share controller to accept share attributes alone

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Add share attributes + prevent download permission

Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #33394 from nextcloud/fix/fix-370-Label_not_connected_to_form-element_in_file_listing

Connect ```input``` checkbox with corresponding file name via ```aria-describedby```

Handle one time password better

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Connect ```input``` checkbox with corresponding file name via ```aria-describedby```

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

Merge pull request #33385 from nextcloud/fix/transfer-aria-label-from-nav-settings-to-settings-icon

Transfer `aria-label` from nav settings menu to settings menu icon-button

Merge pull request #33081 from nextcloud/techdebt/noid/ocp-security-bruteforce-ithrottler

Add a public interface for the bruteforce throttler and register for …

Merge pull request #33280 from nextcloud/externalStorageWithoutVersioning

handle AccessDenied error when checking if external s3 support versions

Transfer `aria-label` from nav settings menu to settings menu icon-button

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

handle AccessDenied error when checking if external s3 support versions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #33299 from nextcloud/fix/files-dark-color-theme

[files app]: Fix dark color mode detection for filelist

Add a public interface for the bruteforce throttler and register for injection

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #33380 from luzpaz/fix/lib-private-typos

Fix typos in lib/private subdirectory

Merge pull request #32244 from nextcloud/dependabot/npm_and_yarn/core-js-3.22.3

Bump core-js from 3.22.0 to 3.22.3

Bumps [core-js](https://github.com/zloirock/core-js) from 3.22.0 to 3.22.3.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.22.0...v3.22.3)

---
updated-dependencies:
- dependency-name: core-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #33386 from nextcloud/fix/noid/delete-user-value

Merge pull request #33379 from nextcloud/techdebt/noid/goodbye-legacy-ids

Remove more legacy ids

Merge pull request #32956 from nextcloud/fix/upload-folder-wrong-content

Handle file contained inside the uploads folder

fix mistake in db query to delete a user config value

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>

Merge pull request #33378 from nextcloud/s3-no-null-bundle

don't set `null` as a bundle path

Fix typos in lib/private subdirectory

Found via `codespell -q 3 -S l10n -L jus ./lib/private`

Signed-off-by: luz paz <luzpaz@github.com>

Merge pull request #33316 from nextcloud/bugfix/noid/aria-label-share-link-buttons

Accessible names for share panel buttons

Remove more legacy ids

Remove more unused legacy ids from early ownCloud times.

This reduces the number of duplicate ids in the DOM.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #33373 from nextcloud/techdebt/noid/remove-legacy-dir

Remove legacy #dir element in files list

Merge pull request #33368 from luzpaz/fix/apps-dav-typos

Fix typos in apps/dav subdirectory

don't set `null` as a bundle path

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #33265 from nextcloud/fix/carl/login-boxes

Redesign guest pages for better accessibility

Merge pull request #33300 from nextcloud/fix/dashboard-dark-color-theme

dashboard: Fix dark theme detection

Fix login flow

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Fix caldav invitation related public pages

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Redesign guest pages for better accessibility

- Use white box and put content on it
- Improve focus indicator

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Remove legacy #dir element in files list

Removed legacy "#dir" input element in the DOM.

Apps should use OCA.Files.App.currentFileList or
OCA.Sharing.PublicApp.fileList and call getCurrentDirectory() to
retrieve the current directory and changeDirectory() to change it.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #33307 from nextcloud/bump/nextcloud-dialogs-3.1.2-to-3.1.4

Bump nextcloud-dialogs from 3.1.2 to 3.1.4

Merge pull request #33271 from nextcloud/enh/a11y-new-file-menu

Use explicit name for new file/folder menu

Fix typos in apps/dav subdirectory

Found via `codespell -q 3 -S l10n -L jus ./apps/dav`

Signed-off-by: luz paz <luzpaz@github.com>

Bump nextcloud-dialogs from 3.1.2 to 3.1.4

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #30030 from nextcloud/fexists

Fix disabled `php_uname`

Merge pull request #30510 from nextcloud/user-cleanup-storage-before-cache

delete files before cleaning cache when cleaning user files

Accessible names for share panel buttons

Added aria-label for the buttons on the share panel.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #33361 from nextcloud/techdebt/noid/further-cleanup

Further markup cleanup

Merge pull request #33251 from cneukom/feature/birthday-calendar-reminder-settings

Birthday Calendar Reminder Setting

Merge pull request #33360 from nextcloud/adjust-acceptance-tests-to-changes-in-sharing-tab

Merge pull request #33341 from nextcloud/fix/29617/no-purge-when-birthday-calendar-doesnt-exist

Don't try to purge objects from the birthday calendar when it doesn't exist

Merge pull request #32733 from nextcloud/dependabot/npm_and_yarn/underscore-1.13.4

Bump underscore from 1.12.0 to 1.13.4

Merge pull request #33358 from nextcloud/techdebt/noid/remove-old-notification-container

Remove obsolete notification container

Merge pull request #31728 from nextcloud/bugfix/30791/update-subshare-owner-on-move

Update owner of subdir on move into/out of share

Add missing closing spans and avoid empty href

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Remove obsolete notification container

The future is TOAST 🍞

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Fix core tests by stubbing debounce

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Removed id=modified in files app

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Adjust acceptance tests to changes in sharing tab

The name of the user shared with is now marked with a "span" rather than
with "h5".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Bump underscore from 1.12.0 to 1.13.4

Bumps [underscore](https://github.com/jashkenas/underscore) from 1.12.0 to 1.13.4.
- [Release notes](https://github.com/jashkenas/underscore/releases)
- [Commits](https://github.com/jashkenas/underscore/compare/1.12.0...1.13.4)

---
updated-dependencies:
- dependency-name: underscore
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Add argument to getSharesInFolder enable deep share lookup

Signed-off-by: Louis Chemineau <louis@chmn.me>

Skip testMovedIntoShareChangeOwner

Signed-off-by: Louis Chemineau <louis@chmn.me>

Recursively fetch subshares

Signed-off-by: Louis Chemineau <louis@chmn.me>

Int test for share owner change on move

Added tests to verify share owner change when moving the parent of a
subshare in and out of a received share.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Change share owner when moving share out of share

Signed-off-by: Louis Chemineau <louis@chmn.me>

Prevent column name conflict between tables

Signed-off-by: Louis Chemineau <louis@chmn.me>

Update owner of subdir on move into/out of share

When moving a directory into or out of a received share, make sure to
also update the share owner column for shares that exist insie the
directory.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Test moving share in and out of another share

Signed-off-by: Louis Chemineau <louis@chmn.me>

dashboard: Fix dark theme detection

When system default color theme is selected for theming,
the enabledThemes array is empty or just contains one entry 'default',
in this case the color theme has to be retrieved from the browser.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #33320 from nextcloud/bugfix/noid/remove-files-duplicate-dom-ids

Replace files app ids to classes

files: Fix colormode detection for filelist

When system default color theme is selected for theming, the `enabledThemes` array
is empty or just contains on entry `'default'`, in this case the color theme has
to be retrieved from the browser to ensure text like the modified date is readable.

This fixes #33298

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>

Merge pull request #33031 from nextcloud/fix/improve-local-ip-detection

Improve local IP detection

Merge pull request #33166 from Lukasdoe/master

Add button disable on submit for login grant

Replace files app ids to classes

Replaced ids to classes for the following:

- #filestable -> .files-filestable
- #fileList -> .files-fileList
- #controls -> .files-controls
- #emptycontent -> .emptyfilelist.emptycontent

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #33315 from nextcloud/bugfix/33314/allow-reseting-status-only-with-message-id

Reset user status based on message ID only

Merge pull request #33206 from nextcloud/enh/27869/consolidate

Consolidate account property getters

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #33334 from nextcloud/bugfix/appmenu-text

Don't try to purge objects from the birthday calendar when it doesn't exist

Doesn't matter much as it's been recreated afterwards with (ensureCalendarExists).

Closes #29617

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Merge pull request #33129 from nextcloud/fix-reading-blob-as-resources

Fix reading blob data as resource

Merge pull request #33342 from nextcloud/bugfix/delete-comments-that-have-expired-now

Delete comments that expired now

Delete comments that expired now

Signed-off-by: Vitor Mattos <vitor@php.rio>

Add button disable on submit for login grant

Signed-off-by: Lukas Döllerer <info@lukas-doellerer.de>

Merge pull request #33338 from nextcloud/fix/contrast-search-icon

Fix contrast of the search icon

Fix contrast of the search icon

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #33321 from nextcloud/bugfix/noid/fix-sharing-lighthouse-issues

Fix sharing panel lighthouse warnings

Fix reading blob data as resource

PostgreSQL returns data as resource when using IQueryBuilder::PARAM_LOB
(which is used for QBMapper).

Previously we just converted this resource using settype, which produced
things like "Resource id #14" instead of the actual resource data.

Now we read the stream correctly if the returned data is a resource

See context at #22472

Fixes #22439

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Make sure app menu text opacity matches the icons

Signed-off-by: Julius Härtl <jus@bitgrid.net>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #33324 from nextcloud/fix/noid/controller_tests

fix Controller tests

Merge pull request #32869 from nextcloud/dav-no-deleted-user-activities

Avoid calendar & addressbook activities being created on user being deleted

Merge pull request #33308 from nextcloud/fs-setup-builtin-wrappers

always triger setup of builtin storage wrappers

fix Controller tests

- added pageTitle in code was missing in expectations
- fixed warnings of superflouos parameter
- fixed wrong type of mock

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>