Merge pull request #39501 from nextcloud/release/25.0.9

25.0.9

Merge pull request #39493 from nextcloud/backport/39490/stable25

[stable25] fix(apps): Fix loading info.xml file

25.0.9

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix(apps): Fix loading info.xml file

Ref: https://bugs.php.net/bug.php?id=62577

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #39426 from nextcloud/release/25.0.9_rc2

25.0.9 RC2

Merge pull request #39419 from nextcloud/backport/39416/stable25

[stable25] fix(core): Add password confirmation requirement for getapppassword

25.0.9 RC2

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix(core): Add password confirmation requirement for getapppassword

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #39394 from nextcloud/backport/39380/stable25

[stable25] fix(db): no hardcoded table prefix is expected

fix(db): no hardcoded table prefix is expected

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #39353 from nextcloud/tests/noid/psalm-baseline

[stable25] test(psalm): ignore known reports

Merge pull request #39279 from nextcloud/release/25.0.9_rc1

25.0.9 RC1

Merge pull request #39356 from nextcloud/backport/39323/39323-stable25

[stable25] getStorage before remove

getStorage before remove

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Merge pull request #36601 from nextcloud/backport/35743/stable25

[stable25] Include more information in iMIP email and show diff information on updating an event

Merge pull request #39346 from nextcloud/ci/sign-drone-stable25

[stable25] chore(CI): Sign .drone.yml file

test(psalm): ignore known reports

- this is code we also have in master, but raises flags here due to "race
  conditions" in merging and backporting competing with enabling psalm
  reacting on those types.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #39220 from nextcloud/automated/noid/stable25-update-psalm-baseline

[stable25] Update psalm-baseline.xml

chore(CI): Sign .drone.yml file

Signed-off-by: Joas Schilling <coding@schilljs.com>

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #39259 from nextcloud/backports/39146/stable25

[stable25] fix(files_sharing): hide download permission for circle shares

style(php): satisfy style checker

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #39061 from nextcloud/backport/31790/stable25

[stable25] Fix creating events with old (< unix time) lastoccurence

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #39294 from nextcloud/backport/39248/stable25

[stable25] preload custom properties when propfinding folders

Merge pull request #39101 from nextcloud/backport/39093/stable25

[stable25] Silent `imagecreatefromstring()` errors

Merge pull request #38982 from nextcloud/automated/noid/stable25-fix-npm-audit

[stable25] Fix npm audit

chore(deps): fix npm audit

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #39233 from nextcloud/backport/39202/stable25

[stable25] use more efficient tag retrieval on DAV report request

Use recurrence instance to build iMip email

instead of the main VEVENT of a repeating event

Fixes part of https://github.com/nextcloud/calendar/issues/3919

Signed-off-by: Anna Larch <anna@nextcloud.com>

Merge pull request #38973 from nextcloud/backport/38747/stable25

[stable25] perf: skip request without write permission

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

preload custom properties when propfinding folders

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #39253 from nextcloud/backport/38046/stable25

[stable25] fix(dav): Abort requests with 429 instead of waiting

chore(psalm): Make psalm aware of sabre/uri

Signed-off-by: Julius Härtl <jus@bitgrid.net>

perf: skip request without write permission

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #39032 from nextcloud/backport/38917/stable25

[stable25] fix(l10n): Fix plural issue with different locale and language

Merge pull request #39144 from nextcloud/fix/password-confirmation-25

[stable25] Fix password confirmation

Merge pull request #37744 from nextcloud/backport/36690/stable25

[stable25] fix: Make sure that rollback hook is triggered on all version backends

25.0.9 RC1

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

chore: fix codestyle for \OC\Files\Node\Folder

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

fix: use handleLoginFailed for invalid email address

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #39081 from nextcloud/backport/39025/stable25

fix: PHP 7.4 compatibility

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix(files_sharing): hide download permission for circle shares

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

fix(dav): Abort requests with 429 instead of waiting

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

style: satisfy code style checker

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

properly register test mount for user

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix: Check return type on rollback

Signed-off-by: Julius Härtl <jus@bitgrid.net>

don't re-get fileinfo for versioned file if it's not shared

Signed-off-by: Robin Appelman <robin@icewind.nl>

tests(files_versions): Tear down fs to clear mount cache before testing

Signed-off-by: Julius Härtl <jus@bitgrid.net>

fix: Make sure that rollback hook is triggered on all version backends

Signed-off-by: Julius Härtl <jus@bitgrid.net>

refactor: adjust to unexposed searchBySystemTag

- in this backport we have to drop the breaking addition in
  \OCP\Files\Folder
- this requires adjustments in check for the existance of the method but
  also in testing
- another change in \OCP\SystemTag\ISystemTagManager can be applied as
  this interface is not implemented elsewhere

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: cannot apply limit+offset on multi-tag-search

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

refactor: save unnecessary method_exists

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: use array_unitersect against objects

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: obey offset and limit for results from favs and circles

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: cominbation of small fixes

- possible null return
- parameter name mismatch in implementation
- incomplete unit test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: include invisible tags for admins

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: search with more than one search tags

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: no search when LazyFolder was provided

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

chore: cleanup unused code

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: ensure searchBySystemTag() is available

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: favorites view and universal search against tags

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: change if with conditionless else to switch; and a parameter value

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

use efficient tag retrieval on DAV report request

- uses DAV search approach against valid files joined by systemtag selector
- reduced table join for tag/systemtag search
- supports pagination
- no changes to the output formats or similar

Example request body:

<?xml version="1.0"?>
<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns">
  <d:prop>
    <d:getcontentlength/>
    <d:getcontenttype/>
    <d:getetag/>
    <d:getlastmodified/>
    <d:resourcetype/>
    <nc:face-detections/>
    <nc:file-metadata-size/>
    <nc:has-preview/>
    <nc:realpath/>
    <oc:favorite/>
    <oc:fileid/>
    <oc:permissions/>
    <nc:nbItems/>
  </d:prop>
  <oc:filter-rules>
    <oc:systemtag>32</oc:systemtag>
  </oc:filter-rules>
  <d:limit>
    <d:nresults>50</d:nresults>
    <nc:firstresult>0</nc:firstresult>
  </d:limit>
</oc:filter-files>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #39153 from nextcloud/backport/39115/stable25

[stable25] fix(sse): don't update uncached files

Merge pull request #39195 from nextcloud/fix/stable25/tag-search-short-circuit-master

[stable25] fix(TagSearchProvider): Short circuit if no tag matches the query

Fix psalm error

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(TagSearchProvider): Short circuit if no tag matches the query

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Merge pull request #39154 from nextcloud/backport/38625/stable25

[stable25] fix: expect interface, not a specific implementation

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38959 from nextcloud/fix/oc-image-bmp-no-color

[stable25] fix: BMP image without color info causes array access on `false`

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix: adjust to PHP level and codebase

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

ci: adjust return annotation to older psalm version

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

docs: adjust @since version to backport

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

ci: pro forma check of existence of internal method

createNode() is protected and used by Folder, but being an internal-only
method it shall not be exposed in the Folder or IRootFolder interface.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

refactor: declare getMount() and getMountsIn() at IRootFolder

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

chore: ugly type juggling

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: add typehine for IRootFolder

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: expect interface, not a specific implementation

- fixes a regression when deleting folders while music app was enabled,
  for a LazyRoot was passed to this method.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix(sse): don't update uncached files

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

Fix(OC/password-confirmation): Hide the correct button

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Silent imagecreatefromstring() errors

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>