]> source.dussan.org Git - sonarqube.git/log
sonarqube.git
5 years agoSONAR-11027 Fix the documentation of api/qualityprofiles/inheritance
Duarte Meneses [Thu, 6 Jun 2019 21:20:22 +0000 (16:20 -0500)]
SONAR-11027 Fix the documentation of api/qualityprofiles/inheritance

5 years agoSONAR-10259 Deprecate SonarQubeVersion
Duarte Meneses [Thu, 6 Jun 2019 20:34:29 +0000 (15:34 -0500)]
SONAR-10259 Deprecate SonarQubeVersion

5 years agoSONAR-12141 Database needs migration : misleading instruction message
Duarte Meneses [Thu, 6 Jun 2019 19:25:34 +0000 (14:25 -0500)]
SONAR-12141 Database needs migration : misleading instruction message

5 years agoSONAR-12117 Database requires downgrade : incorrect error message
Duarte Meneses [Thu, 6 Jun 2019 18:42:08 +0000 (13:42 -0500)]
SONAR-12117 Database requires downgrade : incorrect error message

5 years agoSONAR-12143 Make it clear that api/project_analyses/search only accepts Long-Living...
Duarte Meneses [Thu, 6 Jun 2019 18:34:11 +0000 (13:34 -0500)]
SONAR-12143 Make it clear that api/project_analyses/search only accepts Long-Living-Branches

5 years agoSONAR-11251 add http.nonProxyHosts to sonar.properties
Sébastien Lesaint [Tue, 4 Jun 2019 08:03:17 +0000 (10:03 +0200)]
SONAR-11251 add http.nonProxyHosts to sonar.properties

5 years agoDOC drop 'prev versions' page
G. Ann Campbell [Tue, 11 Jun 2019 12:19:19 +0000 (14:19 +0200)]
DOC drop 'prev versions' page

5 years agoClarify: SonarCloud targets cloud ALMs (#1691)
Fabrice Bellingard [Tue, 11 Jun 2019 11:04:38 +0000 (13:04 +0200)]
Clarify: SonarCloud targets cloud ALMs (#1691)

* Clarify: SonarCloud targets cloud ALMs
* Clarify GitHub.com
* Clarify Azure DevOps Services

5 years agoDOC add missing links in deploy-to-mktplce
G. Ann Campbell [Tue, 11 Jun 2019 10:53:47 +0000 (12:53 +0200)]
DOC add missing links in deploy-to-mktplce

5 years agoDOC correct ES lock threshold
G. Ann Campbell [Tue, 11 Jun 2019 10:35:09 +0000 (12:35 +0200)]
DOC correct ES lock threshold

ES docs + community threads indicate 15% is the real number

5 years agoClarify requirement for AutoScan
Fabrice Bellingard [Tue, 11 Jun 2019 10:11:40 +0000 (12:11 +0200)]
Clarify requirement for AutoScan

The project must be bound.

5 years agoDOC add ES free disk space req.
G. Ann Campbell [Tue, 11 Jun 2019 09:58:11 +0000 (11:58 +0200)]
DOC add ES free disk space req.

5 years agoOutput of ":server:sonar-docs:yarn_run" should not depend on build number
Evgeny Mandrikov [Tue, 11 Jun 2019 08:01:07 +0000 (10:01 +0200)]
Output of ":server:sonar-docs:yarn_run" should not depend on build number

5 years agoAdd support for Windows in ./scripts/start.sh
philippe-perrin-sonarsource [Wed, 5 Jun 2019 14:02:05 +0000 (16:02 +0200)]
Add support for Windows in ./scripts/start.sh

5 years agoSONAR-12181 Improve the error message when using sonar.branch.name on Community Edition
Duarte Meneses [Mon, 10 Jun 2019 18:34:48 +0000 (13:34 -0500)]
SONAR-12181 Improve the error message when using sonar.branch.name on Community Edition

5 years agoSONAR-11871 upgrade elasticsearch to 6.8.0
Sébastien Lesaint [Wed, 15 May 2019 09:59:31 +0000 (11:59 +0200)]
SONAR-11871 upgrade elasticsearch to 6.8.0

5 years agoDOC add (re-instate) SCAN docs
G. Ann Campbell [Fri, 7 Jun 2019 07:39:03 +0000 (09:39 +0200)]
DOC add (re-instate) SCAN docs

5 years agoBuild task ":server:sonar-web:yarn_run" should produce same result outside of CI
Evgeny Mandrikov [Fri, 7 Jun 2019 05:37:54 +0000 (07:37 +0200)]
Build task ":server:sonar-web:yarn_run" should produce same result outside of CI

While this adds quite some overhead, benefit is that
remote Gradle cache entry can be used locally.

5 years agoFix 008c177ae1, that introduced broken documentation in SonarCloud
Grégoire Aubert [Thu, 6 Jun 2019 14:44:26 +0000 (16:44 +0200)]
Fix 008c177ae1, that introduced broken documentation in SonarCloud

5 years agoSONAR-12055 Fix ALM integration (#1708)
Siegfried Ehret [Thu, 6 Jun 2019 07:03:02 +0000 (09:03 +0200)]
SONAR-12055 Fix ALM integration (#1708)

5 years agoDOC Add minimum ALM versions
G. Ann Campbell [Tue, 4 Jun 2019 15:26:29 +0000 (17:26 +0200)]
DOC Add minimum ALM versions

5 years agoDo not disable recording of code coverage in builds outside of CI
Evgeny Mandrikov [Fri, 31 May 2019 13:55:56 +0000 (15:55 +0200)]
Do not disable recording of code coverage in builds outside of CI

While this adds little overhead, benefit is that
remote Gradle cache entry can be used locally.

5 years agoSONAR-12172 CI auto-configuration conflict with Jenkins
Simon Brandhof [Tue, 4 Jun 2019 09:18:03 +0000 (11:18 +0200)]
SONAR-12172 CI auto-configuration conflict with Jenkins

5 years agoSONAR-12121 Show a warning if QG conditions are ignored
Wouter Admiraal [Wed, 29 May 2019 07:52:13 +0000 (09:52 +0200)]
SONAR-12121 Show a warning if QG conditions are ignored

5 years agoFix failing UI test snapshot
Grégoire Aubert [Tue, 4 Jun 2019 07:54:57 +0000 (09:54 +0200)]
Fix failing UI test snapshot

5 years agoSONAR-12042 Apply feedback regarding logging
Duarte Meneses [Fri, 31 May 2019 20:11:14 +0000 (15:11 -0500)]
SONAR-12042 Apply feedback regarding logging

5 years agoSONAR-12041 Display warning at startup if list of hosts is not consistent across...
Duarte Meneses [Thu, 30 May 2019 19:27:43 +0000 (14:27 -0500)]
SONAR-12041 Display warning at startup if list of hosts is not consistent across all cluster nodes

5 years agoSONAR-12042 Apply feedback regarding logging
Duarte Meneses [Tue, 28 May 2019 22:06:04 +0000 (17:06 -0500)]
SONAR-12042 Apply feedback regarding logging

5 years agoSONAR-12066 Update Docs for Scalability
MikeBirnstiehl [Fri, 17 May 2019 16:35:18 +0000 (11:35 -0500)]
SONAR-12066 Update Docs for Scalability

5 years agoSONAR-12043 Hard stop if stop takes too long
Duarte Meneses [Tue, 14 May 2019 16:23:16 +0000 (11:23 -0500)]
SONAR-12043 Hard stop if stop takes too long

5 years agoSONAR-12041 Display warning at startup if list of hosts is not consistent across...
Duarte Meneses [Wed, 8 May 2019 17:57:47 +0000 (12:57 -0500)]
SONAR-12041 Display warning at startup if list of hosts is not consistent across all cluster nodes

5 years agoSONAR-12042 add force-stop option to MacOS's sonar.sh
Sébastien Lesaint [Mon, 13 May 2019 09:53:14 +0000 (11:53 +0200)]
SONAR-12042 add force-stop option to MacOS's sonar.sh

5 years agoSONAR-12042 add force-stop option to Linux's sonar.sh
Sébastien Lesaint [Thu, 9 May 2019 07:33:29 +0000 (09:33 +0200)]
SONAR-12042 add force-stop option to Linux's sonar.sh

5 years agoSONAR-12043 Refactor ProcessEntryPoint
Duarte Meneses [Fri, 10 May 2019 13:24:25 +0000 (08:24 -0500)]
SONAR-12043 Refactor ProcessEntryPoint

Simplifies a bit Stop and HardStop operations

5 years agoSONAR-12043 stopper threads should be daemon
Duarte Meneses [Fri, 10 May 2019 18:43:21 +0000 (13:43 -0500)]
SONAR-12043 stopper threads should be daemon

5 years agoSONAR-12043 Refactor CeServer
Duarte Meneses [Fri, 10 May 2019 18:48:20 +0000 (13:48 -0500)]
SONAR-12043 Refactor CeServer

* Improves waiting operations: no pooling, no additional threads
* Any number of threads can wait for stop (actually required if both stop and hard stop threads end up waiting)
* Prevents potentially multiple invocations of 'stopProcessing' by 'stop()' and the 'CeMainThread' after a hard stop

5 years agoSONAR-12043 Refactor ProcessEntryPoint
Duarte Meneses [Thu, 9 May 2019 18:21:16 +0000 (13:21 -0500)]
SONAR-12043 Refactor ProcessEntryPoint

* Remove unused methods
* Extract method 'waitForStatus'

5 years agoSONAR-12043 Minor refactor
Duarte Meneses [Thu, 9 May 2019 16:17:15 +0000 (11:17 -0500)]
SONAR-12043 Minor refactor

5 years agoSONAR-12043 graceful shutdown timeout configurable for ITs
Sébastien Lesaint [Tue, 7 May 2019 12:54:51 +0000 (14:54 +0200)]
SONAR-12043 graceful shutdown timeout configurable for ITs

5 years agoSONAR-12043 make Lifecycle threadsafe
Sébastien Lesaint [Tue, 7 May 2019 09:25:35 +0000 (11:25 +0200)]
SONAR-12043 make Lifecycle threadsafe

and make ProcessEntryPointTest#launch_then_request_graceful_stop stable
and add trace log when some code tests the current state of Lifecyle (#getState() replaced by isCurrentState(State))

5 years agoSONAR-12042 app always watches for hard stop, on demand for stop
Sébastien Lesaint [Mon, 6 May 2019 15:04:53 +0000 (17:04 +0200)]
SONAR-12042 app always watches for hard stop, on demand for stop

5 years agoSONAR-12043 CE gracefully stops
Sébastien Lesaint [Mon, 6 May 2019 13:53:53 +0000 (15:53 +0200)]
SONAR-12043 CE gracefully stops

5 years agoSONAR-12043 main process supports graceful and hard stop
Sébastien Lesaint [Mon, 6 May 2019 07:30:40 +0000 (09:30 +0200)]
SONAR-12043 main process supports graceful and hard stop

5 years agoSONAR-12043 SchedulerImpl correctly handle Thread interrupt
Sébastien Lesaint [Fri, 3 May 2019 15:36:18 +0000 (17:36 +0200)]
SONAR-12043 SchedulerImpl correctly handle Thread interrupt

5 years agoSONAR-12043 use only NodeLifecycle to store SQ node state
Sébastien Lesaint [Fri, 3 May 2019 13:30:52 +0000 (15:30 +0200)]
SONAR-12043 use only NodeLifecycle to store SQ node state

in SchedulerImpl

5 years agoSONAR-12043 some clarification class renaming in sonar-main module
Sébastien Lesaint [Fri, 3 May 2019 11:59:10 +0000 (13:59 +0200)]
SONAR-12043 some clarification class renaming in sonar-main module

5 years agoSONAR-12043 change restartDisabled to restarting for easier understanding
Sébastien Lesaint [Fri, 3 May 2019 11:43:12 +0000 (13:43 +0200)]
SONAR-12043 change restartDisabled to restarting for easier understanding

this internal flag of class SchedulerImpl is easier to understand with this name

5 years agoSONAR-12043 move hard stop timeout out of SQProcess#hardstop arguments
Sébastien Lesaint [Fri, 3 May 2019 09:21:24 +0000 (11:21 +0200)]
SONAR-12043 move hard stop timeout out of SQProcess#hardstop arguments

timeout is instead configured as state of SQProcess instance
this will allow calling hardStop with the right timeout from another method of SQProcess (the incoming stop() method)

5 years agoSONAR-12043 move closing shared memory to ProcessEntryPoint
Sébastien Lesaint [Thu, 2 May 2019 14:41:30 +0000 (16:41 +0200)]
SONAR-12043 move closing shared memory to ProcessEntryPoint

and out of HardStopperThread & HardStopWatcher
this simplifies responsibilities and duplicate (ineffective) closing of the shared memory

5 years agoSONAR-12043 delete dead code in sonar-process tests
Sébastien Lesaint [Thu, 2 May 2019 13:27:24 +0000 (15:27 +0200)]
SONAR-12043 delete dead code in sonar-process tests

5 years agoSONAR-12043 add (graceful) stop flag to shared memory
Sébastien Lesaint [Thu, 2 May 2019 10:50:32 +0000 (12:50 +0200)]
SONAR-12043 add (graceful) stop flag to shared memory

5 years agoSONAR-12043 rename current shutdown code from stop to hardStop
Sébastien Lesaint [Thu, 2 May 2019 10:26:06 +0000 (12:26 +0200)]
SONAR-12043 rename current shutdown code from stop to hardStop

5 years agoSONAR-12043 ProcessCommands doesn't need to be AutoCloseable
Sébastien Lesaint [Thu, 2 May 2019 10:09:21 +0000 (12:09 +0200)]
SONAR-12043 ProcessCommands doesn't need to be AutoCloseable

the only implement was actually throwing UnsupportedOperationException

5 years agoSONAR-12043 process lifecycle: can hard stop when stopping
Sébastien Lesaint [Thu, 2 May 2019 10:02:53 +0000 (12:02 +0200)]
SONAR-12043 process lifecycle: can hard stop when stopping

5 years agoSONAR-12043 increase default timeout to 6 hours
Sébastien Lesaint [Thu, 2 May 2019 08:51:11 +0000 (10:51 +0200)]
SONAR-12043 increase default timeout to 6 hours

5 years agoSONAR-12043 disable Java Service Wrapper shutdown timeout features
Sébastien Lesaint [Thu, 2 May 2019 07:12:14 +0000 (09:12 +0200)]
SONAR-12043 disable Java Service Wrapper shutdown timeout features

they are getting in the way of implementing gracefull shutdown in SQ which can last for a looooog time (35min+ by default)

5 years agoSONAR-12043 minor renaming of 2 methods of CeConfiguration
Sébastien Lesaint [Tue, 30 Apr 2019 15:16:00 +0000 (17:16 +0200)]
SONAR-12043 minor renaming of 2 methods of CeConfiguration

5 years agoSONAR-12055 Display administration navbar notification when restarting the server
Grégoire Aubert [Thu, 9 May 2019 12:36:39 +0000 (14:36 +0200)]
SONAR-12055 Display administration navbar notification when restarting the server

5 years agoSONAR-12040 Display pending time on system background task page
Grégoire Aubert [Thu, 9 May 2019 06:42:22 +0000 (08:42 +0200)]
SONAR-12040 Display pending time on system background task page

5 years agoSONAR-12040 Drop duplicated css classes
Grégoire Aubert [Wed, 8 May 2019 14:48:36 +0000 (16:48 +0200)]
SONAR-12040 Drop duplicated css classes

5 years agoSONAR-12038 Add pendingTime to api/ce/activity_status and ComputeEngineTasks JMX...
Duarte Meneses [Thu, 9 May 2019 15:48:58 +0000 (10:48 -0500)]
SONAR-12038 Add pendingTime to api/ce/activity_status and ComputeEngineTasks JMX metrics

5 years agoSONAR-12037 Run cluster ITs on Cirrus
Duarte Meneses [Fri, 3 May 2019 15:52:06 +0000 (10:52 -0500)]
SONAR-12037 Run cluster ITs on Cirrus

5 years agoMinor fixes to main app
Duarte Meneses [Wed, 1 May 2019 15:06:59 +0000 (10:06 -0500)]
Minor fixes to main app

5 years agoSONAR-12039 Make WS api/ce/activity_status public
Duarte Meneses [Tue, 30 Apr 2019 18:04:04 +0000 (13:04 -0500)]
SONAR-12039 Make WS api/ce/activity_status public

5 years agoSONAR-12168 Define embedded documentation for languages (#1592)
Elena Vilchik [Mon, 3 Jun 2019 11:52:05 +0000 (13:52 +0200)]
SONAR-12168 Define embedded documentation for languages (#1592)

5 years agoFix typos (GCC, Clang)
Siegfried Ehret [Mon, 3 Jun 2019 06:43:26 +0000 (08:43 +0200)]
Fix typos (GCC, Clang)

5 years agoSONAR-11443 add DB in JDBC URL Case Sensitive
MikeBirnstiehl [Fri, 31 May 2019 15:06:07 +0000 (10:06 -0500)]
SONAR-11443 add DB in JDBC URL Case Sensitive

5 years agoSONAR-11857 link to dashboard for branches/PRs in webhook payload
Sébastien Lesaint [Tue, 28 May 2019 10:12:54 +0000 (12:12 +0200)]
SONAR-11857 link to dashboard for branches/PRs in webhook payload

5 years agoRevert "DOC add Oracle changes to Upgrade notes"
Duarte Meneses [Fri, 31 May 2019 13:34:56 +0000 (08:34 -0500)]
Revert "DOC add Oracle changes to Upgrade notes"

This reverts commit 9764d3c4e2f57d0834fd9158631096ded82c6a05.

5 years agoRevert "SONAR-11942 Drop support of Oracle 11g and 12.1"
Duarte Meneses [Fri, 31 May 2019 13:34:43 +0000 (08:34 -0500)]
Revert "SONAR-11942 Drop support of Oracle 11g and 12.1"

This reverts commit 51d491b2525e850b049c1bc97b77a616e1f174a0.

5 years agoTreat using unset variables as error in Travis script
Janos Gyerik [Fri, 31 May 2019 13:33:40 +0000 (15:33 +0200)]
Treat using unset variables as error in Travis script

5 years agoDOC add Oracle changes to Upgrade notes
G. Ann Campbell [Fri, 31 May 2019 11:29:53 +0000 (07:29 -0400)]
DOC add Oracle changes to Upgrade notes

5 years agoSONAR-11942 Drop support of Oracle 11g and 12.1
Duarte Meneses [Fri, 31 May 2019 13:01:05 +0000 (08:01 -0500)]
SONAR-11942 Drop support of Oracle 11g and 12.1

5 years agoSONAR-11941 Support Oracle 19c
Duarte Meneses [Thu, 30 May 2019 21:12:02 +0000 (16:12 -0500)]
SONAR-11941 Support Oracle 19c

5 years agoFix Travis build on external pull requests
Simon Brandhof [Fri, 31 May 2019 08:14:16 +0000 (10:14 +0200)]
Fix Travis build on external pull requests

5 years agoSONAR-11675 delete scan contexts and CE activities on project purge
Sébastien Lesaint [Mon, 27 May 2019 08:53:05 +0000 (10:53 +0200)]
SONAR-11675 delete scan contexts and CE activities on project purge

5 years agoFix build task ":sonar-application:zip" and remove ":server:sonar-web:copyBranding"
Evgeny Mandrikov [Wed, 29 May 2019 10:48:02 +0000 (12:48 +0200)]
Fix build task ":sonar-application:zip" and remove ":server:sonar-web:copyBranding"

5 years agoSONAR-12112 Fix issue actions
Jeremy Davis [Wed, 29 May 2019 12:53:23 +0000 (14:53 +0200)]
SONAR-12112 Fix issue actions

5 years agoRemove useless declarations of resource filters from build
Evgeny Mandrikov [Wed, 29 May 2019 15:25:53 +0000 (17:25 +0200)]
Remove useless declarations of resource filters from build

5 years agoSONAR-11676 Fix Bulk Apply Permission Template
Jeremy Davis [Mon, 27 May 2019 09:33:34 +0000 (11:33 +0200)]
SONAR-11676 Fix Bulk Apply Permission Template

5 years agoSONAR-12114 Add Links in codeviewer header
Jeremy Davis [Mon, 27 May 2019 08:41:30 +0000 (10:41 +0200)]
SONAR-12114 Add Links in codeviewer header

5 years agoSONAR-12025 Allow spaces to be typed in project name
Jeremy Davis [Thu, 23 May 2019 15:55:22 +0000 (17:55 +0200)]
SONAR-12025 Allow spaces to be typed in project name

5 years agoSONAR-9898 Deprecate org.sonar.api.i18n.I18n
Julien Lancelot [Mon, 27 May 2019 15:16:40 +0000 (17:16 +0200)]
SONAR-9898 Deprecate org.sonar.api.i18n.I18n

5 years agoSet target and source compatibility for Java 8 for IDEs to load correct language...
Duarte Meneses [Wed, 29 May 2019 13:54:04 +0000 (08:54 -0500)]
Set target and source compatibility for Java 8 for IDEs to load correct language level

5 years agoImprove test coverage
Wouter Admiraal [Thu, 4 Apr 2019 13:16:46 +0000 (15:16 +0200)]
Improve test coverage

5 years agoSONAR-11875 Connect WorkspaceComponentViewer to the branch redux store, and refresh...
Wouter Admiraal [Tue, 2 Apr 2019 09:06:47 +0000 (11:06 +0200)]
SONAR-11875 Connect WorkspaceComponentViewer to the branch redux store, and refresh branch status when updating an issue

5 years agoSONAR-11875 Connect Measures to the branch redux store, and refresh branch status...
Wouter Admiraal [Tue, 2 Apr 2019 08:22:14 +0000 (10:22 +0200)]
SONAR-11875 Connect Measures to the branch redux store, and refresh branch status when updating an issue

5 years agoSONAR-11875 Connect Code to the branch redux store, and refresh branch status when...
Wouter Admiraal [Tue, 2 Apr 2019 08:12:43 +0000 (10:12 +0200)]
SONAR-11875 Connect Code to the branch redux store, and refresh branch status when updating an issue

5 years agoSONAR-11875 Connect Issues to the redux store, and refresh branch status when updatin...
Wouter Admiraal [Tue, 2 Apr 2019 07:21:08 +0000 (09:21 +0200)]
SONAR-11875 Connect Issues to the redux store, and refresh branch status when updating an issue

5 years agoSONAR-11875 Move QG conditions to the branch redux store
Wouter Admiraal [Tue, 2 Apr 2019 09:22:00 +0000 (11:22 +0200)]
SONAR-11875 Move QG conditions to the branch redux store

5 years agoUpdate failing tests due to new lodash mock
Wouter Admiraal [Wed, 29 May 2019 06:33:43 +0000 (08:33 +0200)]
Update failing tests due to new lodash mock

5 years agoSONAR-11875 Provide new action for refreshing a branch status
Wouter Admiraal [Tue, 2 Apr 2019 09:22:33 +0000 (11:22 +0200)]
SONAR-11875 Provide new action for refreshing a branch status

5 years agoRemove redundant entries from .gitignore files
Evgeny Mandrikov [Tue, 28 May 2019 14:34:11 +0000 (16:34 +0200)]
Remove redundant entries from .gitignore files

All removed entries already defined in .gitignore file at the root of
the repository.

5 years agoFix sonar-docs readme (#1671)
Evgeny Mandrikov [Tue, 28 May 2019 13:08:05 +0000 (15:08 +0200)]
Fix sonar-docs readme (#1671)

5 years agoSONAR-12120 Fix users duplicated values on EXTERNAL_LOGIN and EXTERNAL_ID
Julien Lancelot [Tue, 28 May 2019 08:28:23 +0000 (10:28 +0200)]
SONAR-12120 Fix users duplicated values on EXTERNAL_LOGIN and EXTERNAL_ID

5 years agoSONAR-10034 HealthStateRefresher must implement Startable
Sébastien Lesaint [Tue, 28 May 2019 08:01:54 +0000 (10:01 +0200)]
SONAR-10034 HealthStateRefresher must implement Startable

5 years agoGradle cache key for "test" tasks should not depend on build number
Evgeny Mandrikov [Mon, 27 May 2019 14:08:47 +0000 (16:08 +0200)]
Gradle cache key for "test" tasks should not depend on build number

Since Gradle 5.0 JaCoCo plugin works with the build cache and parallel
test execution, so this change allows to enable build cache for "test"
tasks in Cirrus CI.

5 years agoReformat sonar-docs readme using Prettier
Grégoire Aubert [Mon, 27 May 2019 14:38:33 +0000 (16:38 +0200)]
Reformat sonar-docs readme using Prettier

5 years agoSONARCLOUD-669 Fix favorite star behavior
Siegfried Ehret [Mon, 27 May 2019 08:40:59 +0000 (10:40 +0200)]
SONARCLOUD-669 Fix favorite star behavior

5 years agoFix formatting issue
Wouter Admiraal [Wed, 22 May 2019 07:35:11 +0000 (09:35 +0200)]
Fix formatting issue