]> source.dussan.org Git - jquery-ui.git/log
jquery-ui.git
8 years agoDroppable: Use `$.ui.intersect()`
Evelyn Masso [Sat, 1 Oct 2016 22:47:36 +0000 (15:47 -0700)]
Droppable: Use `$.ui.intersect()`

Fixes #14963

8 years agoTabs: Remove presentation role
milk54 [Sun, 18 Sep 2016 10:11:41 +0000 (19:11 +0900)]
Tabs: Remove presentation role

Fixes #10122
Closes gh-1748

8 years agoResizable: Fix aspectRatio cannot be changed after initialization.
Sergei Ratnikov [Fri, 23 Sep 2016 15:42:21 +0000 (18:42 +0300)]
Resizable: Fix aspectRatio cannot be changed after initialization.

Fixes #4186
Closes gh-1750

8 years agoBuild: Fix list of source files 1-12-stable
Scott González [Mon, 26 Sep 2016 13:20:29 +0000 (09:20 -0400)]
Build: Fix list of source files

Fixes #15052
Closes gh-1751

8 years agoAutocomplete: Escape HTML tags in callback name to avoid XSS in demo
Scott González [Thu, 22 Sep 2016 11:53:22 +0000 (07:53 -0400)]
Autocomplete: Escape HTML tags in callback name to avoid XSS in demo

Fixes #15048

8 years agoBuild: Updating the master version to 1.12.2-pre.
Scott González [Wed, 14 Sep 2016 16:34:40 +0000 (12:34 -0400)]
Build: Updating the master version to 1.12.2-pre.

8 years agoBuild: Update authors list
Scott González [Wed, 14 Sep 2016 16:29:20 +0000 (12:29 -0400)]
Build: Update authors list

8 years agoSortable: Use an event object for simulated `mouseup` in `cancel()`
Scott González [Wed, 14 Sep 2016 13:42:46 +0000 (09:42 -0400)]
Sortable: Use an event object for simulated `mouseup` in `cancel()`

Regression caused by a1d69208bad175a27c7b50c27fdc10001563cd4d

Fixes #15042
Closes gh-1746

8 years agoTheme: Fix icon default color when not within a button
Alexander Schmitz [Tue, 13 Sep 2016 19:42:13 +0000 (15:42 -0400)]
Theme: Fix icon default color when not within a button

Fixes jquery/jqueryui.com#159
Closes gh-1745

8 years agoWidget: Untrack classes elements when they are removed from the DOM
Alexander Schmitz [Mon, 12 Sep 2016 14:26:24 +0000 (10:26 -0400)]
Widget: Untrack classes elements when they are removed from the DOM

Fixes #15043
Closes gh-1744

8 years agoRelease: Remove externals directory from CDN zip
Scott González [Wed, 7 Sep 2016 17:38:45 +0000 (13:38 -0400)]
Release: Remove externals directory from CDN zip

Closes gh-1741

8 years agoDraggable: Fix spurious blur in dialogs on mousedown
Ryan Oriecuia [Tue, 16 Aug 2016 23:52:15 +0000 (16:52 -0700)]
Draggable: Fix spurious blur in dialogs on mousedown

I was running into a problem with a popup menu control in a dialog; clicks
weren't working (but keyboard was working fine). It turned out that the menu
was getting destroyed before the click event could fire.

Tracked down the issue to the way draggable blurs focused controls; it was
doing the blur before it ran through the logic to figure out if the drag was
actually on the handle. I've moved the blur below these checks, so it'll only
blur things if it actually needs to handle the drag. Otherwise, it asserts no
opinion on what should and shouldn't be focused, which seems like the way
things ought to be.

Also, added a unit test to check for the expected behavior.

Fixes #15046
Closes gh-1730

8 years agoSlider: Add demo for custom handle
Scott González [Fri, 2 Sep 2016 14:21:25 +0000 (10:21 -0400)]
Slider: Add demo for custom handle

Fixes #15023
Closes gh-1740

8 years agoBuild: Update authors list
Scott González [Wed, 7 Sep 2016 14:11:36 +0000 (10:11 -0400)]
Build: Update authors list

8 years agoAutocomplete: Remove unreachable code in remote demo
Scott González [Thu, 1 Sep 2016 19:56:29 +0000 (15:56 -0400)]
Autocomplete: Remove unreachable code in remote demo

8 years agoAutocomplete: Change JSONP demo to use local data source
Scott González [Thu, 1 Sep 2016 19:55:25 +0000 (15:55 -0400)]
Autocomplete: Change JSONP demo to use local data source

Fixes #14974

8 years agoPosition: Remove fractional pixel detection
Scott González [Wed, 31 Aug 2016 16:28:36 +0000 (12:28 -0400)]
Position: Remove fractional pixel detection

Hooray for newer browsers.

Closes gh-1739

8 years agoControlgroup: Don't use `String.prototype.trim()`
Scott González [Wed, 31 Aug 2016 20:29:54 +0000 (16:29 -0400)]
Controlgroup: Don't use `String.prototype.trim()`

We still support IE 8, which doesn't have this method.

8 years agoDialog: Fix code style
Scott González [Wed, 31 Aug 2016 15:22:54 +0000 (11:22 -0400)]
Dialog: Fix code style

8 years agoDialog: Allow for subpixel calculation errors in tests
Scott González [Tue, 30 Aug 2016 18:58:39 +0000 (14:58 -0400)]
Dialog: Allow for subpixel calculation errors in tests

Tests were failing in IE 10-11 with values that were off by 0.01 pixels.

Closes gh-1737

8 years agoTabs: Strip hash from remote content URLs
Scott González [Tue, 30 Aug 2016 18:37:04 +0000 (14:37 -0400)]
Tabs: Strip hash from remote content URLs

As of jQuery 3.0.0, hashes are no longer stripped for Ajax requests. This
causes issues in IE <11, so we need to strip this before making the request.

Ref jquery/jquery#1732
Closes gh-1736

8 years agoEffects: Adjust animation duration in tests
Scott González [Tue, 30 Aug 2016 20:26:18 +0000 (16:26 -0400)]
Effects: Adjust animation duration in tests

With jQuery 3 using `requestAnimationFrame()`, the `setTimeout()` timing
for short animations wasn't working consistently. This resulted in infrequent
failures everywhere (but infrequent enough that it's hard to even notice), but
consistent failures in IE and Edge. Bumping up the duration and running the
assertions in the middle seems to give consistent results.

Eventually, we should refactor this to use `requestAnimationFrame()` in the
tests themselves to avoid problems like this.

Closes gh-1738

8 years agoDemos: Optimize *.png with zopflipng
Ville Skyttä [Wed, 27 Jul 2016 13:21:20 +0000 (16:21 +0300)]
Demos: Optimize *.png with zopflipng

zopflipng -m, version 1.0.1.

Closes gh-1726

8 years agoMenu: Support number pad keyboard input
Felix Nagel [Wed, 17 Aug 2016 22:15:29 +0000 (00:15 +0200)]
Menu: Support number pad keyboard input

Fixes #15031
Closes gh-1732

8 years agoCONTRIBUTING: Replace grunt commands with npm
Scott González [Fri, 19 Aug 2016 13:14:35 +0000 (09:14 -0400)]
CONTRIBUTING: Replace grunt commands with npm

Closes gh-1733

8 years agoBuild: Update bower.json with license information
Johannes Schäfer [Wed, 17 Aug 2016 07:57:48 +0000 (09:57 +0200)]
Build: Update bower.json with license information

Closes gh-1731

8 years agoWidget: `instance()` should return `undefined` for empty sets
Scott González [Thu, 4 Aug 2016 13:04:16 +0000 (09:04 -0400)]
Widget: `instance()` should return `undefined` for empty sets

Fixes #15019

8 years agoCheckboxradio: Adjust rule order to avoid specificty issues with other icons
Alexander Schmitz [Tue, 26 Jul 2016 19:32:04 +0000 (15:32 -0400)]
Checkboxradio: Adjust rule order to avoid specificty issues with other icons

Fixes #15003
Closes gh-1725

8 years agoDialog: Support deprecated button options
Scott González [Mon, 25 Jul 2016 12:16:13 +0000 (08:16 -0400)]
Dialog: Support deprecated button options

Fixes #15016
Closes gh-1723

8 years agoControlgroup: Handle child elements that don't have options defined
Scott González [Mon, 11 Jul 2016 15:32:39 +0000 (11:32 -0400)]
Controlgroup: Handle child elements that don't have options defined

Closes gh-1719

8 years agoCheckboxradio: Fix label handling with jQuery 3.x
Scott González [Mon, 11 Jul 2016 16:11:59 +0000 (12:11 -0400)]
Checkboxradio: Fix label handling with jQuery 3.x

Fixes #15006
Closes gh-1720

8 years agoBuild: Updating the master version to 1.12.1-pre.
Jörn Zaefferer [Fri, 8 Jul 2016 17:14:59 +0000 (19:14 +0200)]
Build: Updating the master version to 1.12.1-pre.

8 years agoBuild: Add jQuery 3.1.0
Scott González [Fri, 8 Jul 2016 17:02:10 +0000 (13:02 -0400)]
Build: Add jQuery 3.1.0

8 years agoTests: Only test latest patch versions for jQuery Core in TestSwarm
Scott González [Fri, 8 Jul 2016 16:51:44 +0000 (12:51 -0400)]
Tests: Only test latest patch versions for jQuery Core in TestSwarm

Adds some missing tests to TestSwarm and `all.html`.

8 years agoResizable: Avoid `Array#map()` in tests for IE8
Scott González [Thu, 7 Jul 2016 14:18:18 +0000 (10:18 -0400)]
Resizable: Avoid `Array#map()` in tests for IE8

8 years agoTooltip: Allow tracking tooltips to be off by a fraciton of a pixel
Scott González [Wed, 6 Jul 2016 20:39:05 +0000 (16:39 -0400)]
Tooltip: Allow tracking tooltips to be off by a fraciton of a pixel

Closes gh-1718

8 years agoTests: Add jQuery 3.0.0 to missing systems
Scott González [Thu, 7 Jul 2016 13:07:54 +0000 (09:07 -0400)]
Tests: Add jQuery 3.0.0 to missing systems

8 years agoEffects: Fix timing of `.animateClass()` assertion
Scott González [Wed, 6 Jul 2016 20:29:43 +0000 (16:29 -0400)]
Effects: Fix timing of `.animateClass()` assertion

8 years agoTabs: Remove test for Ajax URLs containing hashes
Scott González [Wed, 6 Jul 2016 17:09:15 +0000 (13:09 -0400)]
Tabs: Remove test for Ajax URLs containing hashes

This hasn't been a problem for a long time and jQuery no longer removes
the hash in 3.0.0, so the test started to fail even though the actual
code is working just fine.

Ref #3627
Ref jquery/jquery#1732

8 years agoBuild: Add jQuery 3.0 for testing
Alexander Schmitz [Wed, 6 Jul 2016 13:45:29 +0000 (09:45 -0400)]
Build: Add jQuery 3.0 for testing

8 years agoControlgroup: Correctly handle non-empty child class key
Gabriel Schulhof [Tue, 14 Jun 2016 14:47:09 +0000 (17:47 +0300)]
Controlgroup: Correctly handle non-empty child class key

Fixes #14984
Closes gh-1713

8 years agoBuild: Adjust author info for Dan Strohl
Scott González [Thu, 30 Jun 2016 14:02:33 +0000 (10:02 -0400)]
Build: Adjust author info for Dan Strohl

8 years agoControlgroup: Add "only" position to class generator functions
Alexander Schmitz [Wed, 18 May 2016 15:48:47 +0000 (11:48 -0400)]
Controlgroup: Add "only" position to class generator functions

Fixes #14972
Closes gh-1711

8 years agoAll: Replace non-breaking spaces with regular spaces
Scott González [Wed, 8 Jun 2016 17:03:42 +0000 (13:03 -0400)]
All: Replace non-breaking spaces with regular spaces

8 years agoCheckboxradio: Use new `ui-state-checked` class in checkboxradio
Alexander Schmitz [Wed, 1 Jun 2016 15:31:41 +0000 (11:31 -0400)]
Checkboxradio: Use new `ui-state-checked` class in checkboxradio

Using `ui-state-highlight` caused a conflict with dialog

Fixes #14955
Closes gh-1712
Closes gh-1704

8 years agoAll: Optimize png images losslessly using zopflipng
Peter Dave Hello [Mon, 30 May 2016 18:13:08 +0000 (02:13 +0800)]
All: Optimize png images losslessly using zopflipng

Closes gh-1710

8 years agoTests: Removed links to tests that no longer exist
Peter Kehl [Sun, 29 May 2016 22:49:16 +0000 (08:49 +1000)]
Tests: Removed links to tests that no longer exist

Closes gh-1709

8 years agoControlgroup: Fix rendering of labels
Alexander Schmitz [Wed, 11 May 2016 16:14:14 +0000 (12:14 -0400)]
Controlgroup: Fix rendering of labels

Fixes #14967
Closes gh-1703

8 years agoControlgroup: Fix issues with compatibility with spinner
Alexander Schmitz [Wed, 11 May 2016 15:49:37 +0000 (11:49 -0400)]
Controlgroup: Fix issues with compatibility with spinner

Fixes #14966

8 years agoControlgroup: Don't remove existing classes classes
Alexander Schmitz [Tue, 10 May 2016 17:32:21 +0000 (13:32 -0400)]
Controlgroup: Don't remove existing classes classes

unless its a corner class

Fixes #14960

8 years agoTests: Stop testing against core 2.0.2 on testswarm
Michał Gołębiowski [Thu, 26 May 2016 09:41:34 +0000 (11:41 +0200)]
Tests: Stop testing against core 2.0.2 on testswarm

jQuery 2.0.3 fixed very few things from 2.0.2, the list is here:
​http://blog.jquery.com/2013/07/03/jquery-1-10-2-and-2-0-3-released/

One of the fixes was ​http://bugs.jquery.com/ticket/13980, though which was
about cross-domain iframe issues. The problem is TestSwarm loads a cross-domain
iframe: the main page is swarm.jquery.org, the frame is on
builds.jenkins.jquery.com so it might be causing issues. You can see jQuery UI
tests are timing out in all IE versions in jQuery 2.0.2:
​http://swarm.jquery.org/job/2918

The problem is that it doesn't just fail, it starves the available IE pool,
making it sometimes harder for other projects to get their tests run on IE.

That's why tests with jQuery 2.0.2 on TestSwarm need to be removed as it's been
done with 1.10.1.

Refs #12745
Refs c2224bf5dc418c84c185844611786b9ccfb869a7
Refs gh-1706
Closes gh-1707

8 years agoBuild: Don't run tests on IE 8 with jQuery Core 2 and newer
Michał Gołębiowski [Wed, 25 May 2016 20:29:04 +0000 (22:29 +0200)]
Build: Don't run tests on IE 8 with jQuery Core 2 and newer

Closes gh-1706

8 years agoBuild: Add grunt-cli to devDependencies, don't install it globally
Michał Gołębiowski [Wed, 25 May 2016 12:59:28 +0000 (14:59 +0200)]
Build: Add grunt-cli to devDependencies, don't install it globally

This makes it possible to use Grunt without installing grunt-cli globally
which makes the whole process more resilient.

Ref gh-1706

8 years agoBuild: Add bower_components to .gitignore
Michał Gołębiowski [Wed, 25 May 2016 12:58:21 +0000 (14:58 +0200)]
Build: Add bower_components to .gitignore

Ref gh-1706

8 years agoBuild: Add jQuery 1.12/2.2 to the test configuration
Michał Gołębiowski [Wed, 25 May 2016 12:58:08 +0000 (14:58 +0200)]
Build: Add jQuery 1.12/2.2 to the test configuration

Ref gh-1706

8 years agoFocusable: Detect disabled fieldsets
Scott González [Wed, 25 May 2016 12:37:28 +0000 (08:37 -0400)]
Focusable: Detect disabled fieldsets

Fixes #14970
Closes gh-1705

8 years agoTabs: Fix test
Scott González [Wed, 25 May 2016 12:41:08 +0000 (08:41 -0400)]
Tabs: Fix test

8 years agoTabs: Fix default `classes` option
Scott González [Wed, 25 May 2016 11:45:23 +0000 (07:45 -0400)]
Tabs: Fix default `classes` option

Fixes #14973

8 years agoDroppable: Re-expose `$.ui.intersect()`
Scott González [Wed, 4 May 2016 22:48:41 +0000 (18:48 -0400)]
Droppable: Re-expose `$.ui.intersect()`

Fixes #14963
Ref #10534

8 years agoTooltip: Fix re-enabling of delegated tooltips
Scott González [Wed, 20 Apr 2016 17:07:53 +0000 (13:07 -0400)]
Tooltip: Fix re-enabling of delegated tooltips

Fixes #14950
Closes gh-1699

8 years ago Build: Update authors list
Jörn Zaefferer [Thu, 21 Apr 2016 14:16:37 +0000 (16:16 +0200)]
 Build: Update authors list

8 years agoSelectable: Proper handling of inner scrolling
Alexey Balchunas [Wed, 1 Jul 2015 18:45:54 +0000 (21:45 +0300)]
Selectable: Proper handling of inner scrolling

Fixes #13359
Closes gh-1570

8 years agoTests: Remove all qunit global excludes from jshint config 1577/head
Amanpreet Singh [Wed, 13 Apr 2016 18:42:43 +0000 (00:12 +0530)]
Tests: Remove all qunit global excludes from jshint config

8 years agoTests: Update common lib to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 15:59:16 +0000 (21:29 +0530)]
Tests: Update common lib to use no globals

8 years agoWidget: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 14:06:47 +0000 (19:36 +0530)]
Widget: Shift to use no globals

8 years agoTooltip: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 13:59:12 +0000 (19:29 +0530)]
Tooltip: Shift to use no globals

8 years agoTabs: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 13:48:50 +0000 (19:18 +0530)]
Tabs: Shift to use no globals

8 years agoSpinner: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 13:26:05 +0000 (18:56 +0530)]
Spinner: Shift to use no globals

8 years agoSortable: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 13:22:59 +0000 (18:52 +0530)]
Sortable: Shift to use no globals

8 years agoSlider: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 13:18:13 +0000 (18:48 +0530)]
Slider: Shift to use no globals

8 years agoSelectmenu: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 13:16:23 +0000 (18:46 +0530)]
Selectmenu: Shift to use no globals

8 years agoSelectable: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 13:13:06 +0000 (18:43 +0530)]
Selectable: Shift to use no globals

8 years agoResizeable: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 13:11:09 +0000 (18:41 +0530)]
Resizeable: Shift to use no globals

8 years agoProgressbar: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 13:08:28 +0000 (18:38 +0530)]
Progressbar: Shift to use no globals

8 years agoPosition: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 13:05:47 +0000 (18:35 +0530)]
Position: Shift to use no globals

8 years agoMenu: Shift to use no globals
Amanpreet Singh [Wed, 6 Apr 2016 13:02:55 +0000 (18:32 +0530)]
Menu: Shift to use no globals

8 years agoForm: Shift form-reset-mixin to use no globals
Amanpreet Singh [Sun, 3 Apr 2016 16:47:12 +0000 (22:17 +0530)]
Form: Shift form-reset-mixin to use no globals

8 years agoEffects: Shift to use no globals
Amanpreet Singh [Sun, 3 Apr 2016 16:45:40 +0000 (22:15 +0530)]
Effects: Shift to use no globals

8 years agoDroppable: Shift to use no globals
Amanpreet Singh [Sun, 3 Apr 2016 16:32:14 +0000 (22:02 +0530)]
Droppable: Shift to use no globals

8 years agoDraggable: Shift to use no globals
Amanpreet Singh [Sun, 3 Apr 2016 16:21:57 +0000 (21:51 +0530)]
Draggable: Shift to use no globals

8 years agoDialog: Shift to use no globals
Amanpreet Singh [Sun, 3 Apr 2016 16:10:09 +0000 (21:40 +0530)]
Dialog: Shift to use no globals

8 years agoDatepicker: Shift to use no globals
Amanpreet Singh [Sun, 3 Apr 2016 15:11:33 +0000 (20:41 +0530)]
Datepicker: Shift to use no globals

8 years agoCore: Shift to no globals
Amanpreet Singh [Sun, 3 Apr 2016 15:02:08 +0000 (20:32 +0530)]
Core: Shift to no globals

8 years agoControlgroup: Shift to use no globals
Amanpreet Singh [Sun, 3 Apr 2016 14:56:10 +0000 (20:26 +0530)]
Controlgroup: Shift to use no globals

8 years agoCheckboxradio: Shift to use no globals
Amanpreet Singh [Sun, 3 Apr 2016 14:53:34 +0000 (20:23 +0530)]
Checkboxradio: Shift to use no globals

8 years agoAutocomplete: Shift to use no globals
Amanpreet Singh [Sun, 3 Apr 2016 14:51:14 +0000 (20:21 +0530)]
Autocomplete: Shift to use no globals

8 years agoButton: Shift to no globals
Amanpreet Singh [Sun, 3 Apr 2016 14:43:27 +0000 (20:13 +0530)]
Button: Shift to no globals

8 years agoAccordion: Shift to use no globals
Amanpreet Singh [Sun, 3 Apr 2016 14:37:27 +0000 (20:07 +0530)]
Accordion: Shift to use no globals

8 years agoMenu: Remove extraneous blank lines
Scott González [Wed, 13 Apr 2016 15:36:41 +0000 (11:36 -0400)]
Menu: Remove extraneous blank lines

8 years agoBuild: Remove maxLineLength execption in .jscsrc
Alexander Schmitz [Thu, 31 Mar 2016 13:16:31 +0000 (09:16 -0400)]
Build: Remove maxLineLength execption in .jscsrc

Also seperates tests into a seperate task because they still have many errors

Closes gh-1690

8 years agoEffect: Disable maxLineLength for description meta
Alexander Schmitz [Thu, 31 Mar 2016 13:16:13 +0000 (09:16 -0400)]
Effect: Disable maxLineLength for description meta

Ref gh-1690

8 years agoEffects: Disable maxLineLength for description meta explode
Alexander Schmitz [Thu, 31 Mar 2016 13:15:46 +0000 (09:15 -0400)]
Effects: Disable maxLineLength for description meta explode

Ref gh-1690

8 years agoAccordion: Disable maxLineLength for description meta
Alexander Schmitz [Thu, 31 Mar 2016 13:13:28 +0000 (09:13 -0400)]
Accordion: Disable maxLineLength for description meta

Ref gh-1690

8 years agoDatepicker: Disable maxLineLength for jscs
Alexander Schmitz [Thu, 31 Mar 2016 13:12:37 +0000 (09:12 -0400)]
Datepicker: Disable maxLineLength for jscs

There are too many errors and re-write is essentially done

Ref gh-1690

8 years agoProgressbar: Disable maxLineLength for description meta
Alexander Schmitz [Thu, 31 Mar 2016 13:12:21 +0000 (09:12 -0400)]
Progressbar: Disable maxLineLength for description meta

Ref gh-1690

8 years agoSelectmenu: Disable maxLineLength for description meta
Alexander Schmitz [Thu, 31 Mar 2016 13:11:31 +0000 (09:11 -0400)]
Selectmenu: Disable maxLineLength for description meta

Ref gh-1690

8 years agoEffect: Fix line length issues
Alexander Schmitz [Thu, 31 Mar 2016 04:31:28 +0000 (00:31 -0400)]
Effect: Fix line length issues

Ref gh-1690

8 years agoPlugin: Fix line length issues
Alexander Schmitz [Thu, 31 Mar 2016 04:31:10 +0000 (00:31 -0400)]
Plugin: Fix line length issues

Ref gh-1690

8 years agoBuild: Fix line length issues
Alexander Schmitz [Thu, 31 Mar 2016 04:30:43 +0000 (00:30 -0400)]
Build: Fix line length issues

Ref gh-1690

8 years agoEffects: Fix line length issues
Alexander Schmitz [Thu, 31 Mar 2016 04:30:21 +0000 (00:30 -0400)]
Effects: Fix line length issues

Ref gh-1690