]> source.dussan.org Git - vaadin-framework.git/log
vaadin-framework.git
11 years agoSend window position data back to server after drag (#12885)
Thomas [Tue, 5 Nov 2013 13:21:06 +0000 (15:21 +0200)]
Send window position data back to server after drag (#12885)

Change-Id: I9ca766b0e06390c7ab90f9cbd4996b83032789db

11 years agoImprove error message in createWidget() (#12901)
Leif Åstrand [Tue, 5 Nov 2013 13:41:45 +0000 (15:41 +0200)]
Improve error message in createWidget() (#12901)

Change-Id: If456a2be242754bcd1e0a8c5be00062a4355af35

11 years agoAllow @font-face and general @-directives inside @if-blocks (#11649)
joheriks [Mon, 28 Oct 2013 15:06:23 +0000 (17:06 +0200)]
Allow @font-face and general @-directives inside @if-blocks (#11649)

Change-Id: Ifa844e7bf8add886792b39c016cc2c9aa3d94b0c

11 years agoUpdated to Atmosphere 1.0.18.vaadin1 (#12891)
Artur Signell [Tue, 5 Nov 2013 06:36:37 +0000 (08:36 +0200)]
Updated to Atmosphere 1.0.18.vaadin1 (#12891)

Change-Id: I5387c9f5eca1eb7941fbd4565d4b6f3cb95a5a0f

11 years agoEnsure testing Jetty does not run out of heap space
Artur Signell [Mon, 4 Nov 2013 19:50:49 +0000 (21:50 +0200)]
Ensure testing Jetty does not run out of heap space

Change-Id: If4549c7bcb0a6518756aa42827340415c44a030c

11 years agoMake Panel scroll the correct div (#12736)
Artur Signell [Mon, 4 Nov 2013 18:23:27 +0000 (20:23 +0200)]
Make Panel scroll the correct div (#12736)

Redefined util method to take the scrollable instead of its parent to make
it useful also for cases where the first child is not scrollable

Change-Id: I301d260d26373b38fdee525f169347bb7b4c499e

11 years agoMake test more reliable by updating description which does not update the DOM
Artur Signell [Mon, 4 Nov 2013 20:24:49 +0000 (22:24 +0200)]
Make test more reliable by updating description which does not update the DOM

Many browsers (IE) choke quite easily when there is a 1MB string inside a div

Change-Id: Ied9b27c17c5374b7cac36820be9cbe38e84448ee

11 years agoFix NPE in fix (#12504)
Artur Signell [Mon, 4 Nov 2013 17:59:50 +0000 (19:59 +0200)]
Fix NPE in fix (#12504)

Change-Id: I65960bcfae850955ea40584445125c0affa26848

11 years agoRemove possibility to use static inner classes for tests
Artur Signell [Fri, 1 Nov 2013 10:58:33 +0000 (12:58 +0200)]
Remove possibility to use static inner classes for tests

Change-Id: I461568918bc09bd7a09abbf9c4a34f1a5f3b997f

11 years agoExtracted test to separate class
Artur Signell [Fri, 1 Nov 2013 10:54:05 +0000 (12:54 +0200)]
Extracted test to separate class

Change-Id: Ibfad0180e93e7f74b91427761b40c86938044c50

11 years agoFix NPE caused by setting ApplicationConnection too late (#12736)
Artur Signell [Mon, 4 Nov 2013 09:25:50 +0000 (11:25 +0200)]
Fix NPE caused by setting ApplicationConnection too late (#12736)

Change-Id: Ib5b3bc7123ffd2f212fb6e242ee07175ff743b0f

11 years agoReverted change in how hack works (#12727, #12736)
Artur Signell [Mon, 4 Nov 2013 09:26:54 +0000 (11:26 +0200)]
Reverted change in how hack works (#12727, #12736)

The fix for Window slightly altered how the hack was done, breaking #12736

Change-Id: I2d33b45421c40ce011d2e728a573f7572e326c47

11 years agofix regression related to #12504
Matti Tahvonen [Wed, 23 Oct 2013 14:28:55 +0000 (17:28 +0300)]
fix regression related to #12504

Cloning date instances passed from state to cal panel as they appear to be mutating

Change-Id: I3775b8445ddc0a779b894b4e044bde93f4c5936c

11 years agoMade test more stable and added Firefox reconnect test (#12492)
Artur Signell [Thu, 31 Oct 2013 19:35:25 +0000 (21:35 +0200)]
Made test more stable and added Firefox reconnect test (#12492)

Waits longer for push message as at least Firefox has some kind of built in back off for websocket reconnects

Change-Id: Iaab2e09e8364f0b6247b3b39c19be439a4995800

11 years agoPrepare for Safari 7 testing (#5288)
Artur Signell [Thu, 31 Oct 2013 17:27:40 +0000 (19:27 +0200)]
Prepare for Safari 7 testing (#5288)

Change-Id: I8868d9bd5e6dcc2b6ece404460700f00e6f2004e

11 years agoFix duplicate id issue in test and test more corner cases
Artur Signell [Thu, 31 Oct 2013 17:22:44 +0000 (19:22 +0200)]
Fix duplicate id issue in test and test more corner cases

Change-Id: I4bacfe7353968df7b0f1a8786ae4e488dffa3565

11 years agoUpdate to Atmosphere js 2.0.3.vaadin2 (#12868, #12852)
Artur Signell [Thu, 31 Oct 2013 17:34:00 +0000 (19:34 +0200)]
Update to Atmosphere js 2.0.3.vaadin2 (#12868, #12852)

Change-Id: I1a75b7dbc024e4222466d7cd0900660991a3c8f2

11 years agoNo longer require specifying Atmosphere js version in two places
Artur Signell [Thu, 31 Oct 2013 17:00:21 +0000 (19:00 +0200)]
No longer require specifying Atmosphere js version in two places

Change-Id: I84faea7fe0cd3447d7d66503e5231f26367dcd57

11 years agoForce connection to closed state on reconnect (#12853)
Artur Signell [Thu, 31 Oct 2013 16:42:22 +0000 (18:42 +0200)]
Force connection to closed state on reconnect (#12853)

IE10+ does not call onabort when the streaming connection is aborted.
As a result, onclose is never called and the client side does not
change the connection state away from "connected". This results in
user actions not being queued on the client side, instead the client
tries to send them immediately, leading to an eternal spinner.

If this can be fixed in Atmosphere somehow, it should. This is a
workaround until then.

Change-Id: Icd1a86ac9775d1a7d9c0bc1dee0fd399e2bf2266

11 years agoTests for validating reconnect works for streaming and websockets (#12868,#12853...
Artur Signell [Thu, 31 Oct 2013 10:39:12 +0000 (12:39 +0200)]
Tests for validating reconnect works for streaming and websockets (#12868,#12853,#12852)

Change-Id: I0e1e51291e9275a78737ad0e70e63b75ef993a63

11 years agoFix compilation error in test
Artur Signell [Thu, 31 Oct 2013 12:30:16 +0000 (14:30 +0200)]
Fix compilation error in test

Change-Id: I1ad693fdc55becd4b4e620b8549d824b4496b908

11 years agoConverted LayoutTesterApplication test to TB3
Artur Signell [Mon, 28 Oct 2013 14:55:45 +0000 (16:55 +0200)]
Converted LayoutTesterApplication test to TB3

Change-Id: I2cee37ae8297c74b4a37fc59e3cf835c9291ed43

11 years agoAdd StringToLongConverter for automatic handling of long values (#12225)
Artur Signell [Fri, 9 Aug 2013 17:35:54 +0000 (20:35 +0300)]
Add StringToLongConverter for automatic handling of long values (#12225)

Backported from master

Change-Id: Ibb91d28aab3731486c84d09547c7af641f39610a
Merge: no

11 years agoFixed Tab error tooltips (#12802)
Juho Nurminen [Wed, 30 Oct 2013 12:25:30 +0000 (14:25 +0200)]
Fixed Tab error tooltips (#12802)

Change-Id: I5ad33f38be5fac64805950d143ad2712e671ff83

11 years agoFixes the handling of the scroll position of a Window (#12736)
Mika Murtojarvi [Tue, 29 Oct 2013 13:22:45 +0000 (15:22 +0200)]
Fixes the handling of the scroll position of a Window (#12736)

After the first commit the same fix has been applied also for panels, in
addition to other suggested changes.

The scroll position of a Window is now memorized before applying
the fix for bug #11994. The position is restored after the fix.

Because the scrolling issue is known to appear also in other components,
the fix for the scrolling has been moved to the Util class.

Change-Id: I5251011b5bede77a7fb18972e1d90016c0eccc23

11 years agoAdded dummy checkstyle and test targets to liferay module
John Ahlroos [Mon, 28 Oct 2013 12:55:22 +0000 (14:55 +0200)]
Added dummy checkstyle and test targets to liferay module

The main build is currently assuming that every submodule has
a checkstyle and a test target. Added a dummy implementation for both of
them so the build passes.

Change-Id: Iea29b25840c26a4a384ba1ce8293d9ea6f37981e

11 years agoStop polling if Communication Error #12362
John Ahlroos [Mon, 28 Oct 2013 14:41:24 +0000 (16:41 +0200)]
Stop polling if Communication Error #12362

This change adds a new ApplicationStopped event which is triggered
whenever the ApplicationConnection marks the application as stopped.
This event is listened by the UIConnector and will terminate any polling
that might be currently done.

Change-Id: I5e698fba7a94f530f69a9f6f554eea896c370824

11 years agoRevert "Publish error artifacts immediatly in TeamCity"
Artur Signell [Wed, 30 Oct 2013 07:04:17 +0000 (07:04 +0000)]
Revert "Publish error artifacts immediatly in TeamCity"

This reverts commit 5fb1da2da04ccca2305af31a9105b848e42b1ed6.

Change-Id: I9d84b75e5e189378eacd2559bb42399b77957010

11 years agoRevert "Only print testbench failure TeamCity messages when running in TC"
Artur Signell [Wed, 30 Oct 2013 07:03:51 +0000 (07:03 +0000)]
Revert "Only print testbench failure TeamCity messages when running in TC"

This reverts commit d0e604f6b509767c46ffe0fd6765cf23535f593e.

Change-Id: I14509a9cb1365761d02a3a8a18d3febc4a7ba918

11 years agoEnsure error screenshots are named according to the browser and not reference
Artur Signell [Tue, 29 Oct 2013 12:18:24 +0000 (14:18 +0200)]
Ensure error screenshots are named according to the browser and not reference

Change-Id: I3fe0a3f5e2906bde79d6d9fc3e84dab8102ffd60

11 years agoParser stripped minus of negative numbers with unknown units (#12811)
joheriks [Mon, 28 Oct 2013 12:28:57 +0000 (14:28 +0200)]
Parser stripped minus of negative numbers with unknown units (#12811)

Change-Id: I8964b1732f867cb3c5aa5859d12e94a5978adece

11 years agoRemove out of order flush() (#12283)
Artur Signell [Fri, 18 Oct 2013 11:08:50 +0000 (14:08 +0300)]
Remove out of order flush() (#12283)

Writer.flush() is specified as:
"Flushes the stream. If the stream has saved any characters from the various
write() methods in a buffer, write them immediately to their intended
destination. Then, if that destination is another character or byte stream,
flush it. Thus one flush() invocation will flush all the buffers in a chain
of Writers and OutputStreams."

Change-Id: Iecafdbb13a7a26a48300d2967c25c705f5bf1e38

11 years agoFixes test issues preventing it from passing
Artur Signell [Tue, 22 Oct 2013 20:24:44 +0000 (23:24 +0300)]
Fixes test issues preventing it from passing

Ensure push is enabled correctly without a fallback and made test more stable

Change-Id: I6c653a96375e05c6ad18e1f5b697c6a584c6c53f

11 years agoConvert push test to TB3 so it has a chance to pass
Artur Signell [Tue, 22 Oct 2013 21:51:44 +0000 (00:51 +0300)]
Convert push test to TB3 so it has a chance to pass

Change-Id: I6381ea4bd61b3df19599f2f9d3a303a50c810460

11 years agoRecovering scroll position after regression problems. (#12727)
Felype Santiago Ferreira [Wed, 23 Oct 2013 08:23:02 +0000 (11:23 +0300)]
Recovering scroll position after regression problems. (#12727)

The fix for "Panels get unnecessary scroll bars in WebKit when content is 100% wide (#12727)" introduced side effects to #6731. This fix solves the problem.

Change-Id: I15ca926c0ee4cad49e9eea0c578c9cc73c850588

11 years agoRevert broken fix and test (#12446)
Johannes Dahlström [Mon, 21 Oct 2013 13:16:37 +0000 (16:16 +0300)]
Revert broken fix and test (#12446)

The timeoutInterval variable needs to be part of per-UI state for the
code to work correctly. Storing it in a servlet-global MetadataWriter
instance is both semantically wrong and a race condition.

Also, the test currently throws NPE if assertions are enabled.

This reverts commit f595d057951523baf35a797692376dfa5de0bc8d.

Change-Id: Ia6d1383b2c112b86ce60c75a3ebb9f10da545d4a

11 years agoFixed focus issue in TableMoveFocusWithSelectionTest (#12540)
John Ahlroos [Mon, 21 Oct 2013 13:12:09 +0000 (16:12 +0300)]
Fixed focus issue in TableMoveFocusWithSelectionTest (#12540)

Change-Id: I40dbc81b6aa4eaf0a235ae2cc7f04025011445c9

11 years agoTicket #12727 - Panels get unnecessary scroll bars in WebKit when content is 100...
Felype Santiago Ferreira [Fri, 18 Oct 2013 07:44:35 +0000 (10:44 +0300)]
Ticket #12727 - Panels get unnecessary scroll bars in WebKit when content is 100% wide.

Change-Id: Ia34e7c3ce755556460d237fb3489501274ced39f

11 years agoSass variables can now start with underscore (#12716)
joheriks [Thu, 17 Oct 2013 08:16:45 +0000 (11:16 +0300)]
Sass variables can now start with underscore (#12716)

Change-Id: I1c6cb12113f2462f96e8fcfc0749d3f62fd1998c

11 years agoAdded more exception handling to PushHandler (#12578, #11882)
Marc Englund [Wed, 9 Oct 2013 12:31:06 +0000 (15:31 +0300)]
Added more exception handling to PushHandler (#12578, #11882)

PushHandler now catches Exception and calls ErrorHandler more.

Change-Id: I7032c00f717b1dae34f4352abc035b1b398c7cfc

11 years agoFix serialization issue (#12703)
Artur Signell [Fri, 18 Oct 2013 10:00:31 +0000 (13:00 +0300)]
Fix serialization issue (#12703)

Change-Id: Ibdced8cdc3200ccfef2750e32fc8bf8dc544f1ae

11 years agoAdd more hax to make test work with new Atmosphere JS (#12241)
Artur Signell [Thu, 17 Oct 2013 12:46:40 +0000 (15:46 +0300)]
Add more hax to make test work with new Atmosphere JS (#12241)

Change-Id: Id75cabd402e243ed4bec7da61771554f2df4fbf6

11 years agoFixed javadoc
Artur Signell [Thu, 17 Oct 2013 08:25:50 +0000 (11:25 +0300)]
Fixed javadoc

Change-Id: I0c54a5d033d53efd2c82a1dc03f9b6fda423e8ce

11 years agoResolve concurrency issue in running TB3 tests
Artur Signell [Thu, 17 Oct 2013 12:21:09 +0000 (15:21 +0300)]
Resolve concurrency issue in running TB3 tests

Ensure nobody can update the static collections of browsers to run on
but that sub classes can restrict which browsers to run on using
super.getBrowersToTest().remove(something)

Change-Id: Iad520840801fbeb719bae51050714c0e47148804

11 years agoRemove unused test super class (#12786)
Artur Signell [Thu, 17 Oct 2013 08:19:06 +0000 (11:19 +0300)]
Remove unused test super class (#12786)

Change-Id: I7a56c9da10557485d5562eaf8d9197bfff4bc849

11 years agoFix compilation error
Artur Signell [Wed, 16 Oct 2013 14:02:42 +0000 (17:02 +0300)]
Fix compilation error

Change-Id: I0068b68ef29c2b3f669869cb4bf427567f71c8b2

11 years agoDisable automated testing on Opera until issues are resolved (#12487, #12367, #12800)
Artur Signell [Wed, 16 Oct 2013 13:33:54 +0000 (16:33 +0300)]
Disable automated testing on Opera until issues are resolved (#12487, #12367, #12800)

Change-Id: Id90abf6b2241aeb4f4e83551647169512a93401b

11 years agoReverted button click() logic check (#12743)
Artur Signell [Wed, 16 Oct 2013 12:31:15 +0000 (15:31 +0300)]
Reverted button click() logic check (#12743)

The isConnectorEnabled() method should only to be used to check if the
client side is allowed to interact with the button, not on the server side
(isConnectorEnabled() is false if the component is not attached to a UI)

Change-Id: I56cd93a1041432199337148f5c4a1449a825c5bc

11 years agoSkip compilation of TB2 tests if tests.tb2.skip is set
Artur Signell [Wed, 16 Oct 2013 11:48:57 +0000 (14:48 +0300)]
Skip compilation of TB2 tests if tests.tb2.skip is set

Change-Id: I647fb48059372b497c77580d252c9622d259d3eb

11 years agoTest for pushing large chunks of data (#12567)
Artur Signell [Fri, 13 Sep 2013 06:18:47 +0000 (09:18 +0300)]
Test for pushing large chunks of data (#12567)

Change-Id: I846b8417f69a0dca7cda2c3851148896d22cabcc

11 years agoDisable fallback in a way compatible with Atmosphere JS 2.0.3 (#12241)
Artur Signell [Wed, 16 Oct 2013 11:09:45 +0000 (14:09 +0300)]
Disable fallback in a way compatible with Atmosphere JS 2.0.3 (#12241)

Change-Id: I4023b50038288e39559cb8542ed59be807274d40

11 years agoHandle numbers in the same way if they do not have a unit (#12732)
Artur Signell [Tue, 15 Oct 2013 19:50:47 +0000 (22:50 +0300)]
Handle numbers in the same way if they do not have a unit (#12732)

Change-Id: Ic9dba337ffb209bf73ab427fa3a39e542e645c08

11 years agoAdd sub directory support to sass test scanner (#12790)
Artur Signell [Tue, 15 Oct 2013 18:49:25 +0000 (21:49 +0300)]
Add sub directory support to sass test scanner (#12790)

Exclude partial scss files (starting with _)
Add new lines to normalized css for easier comparison

Change-Id: I2bfb796b293cb0b578c3c5c56aacffe7c1514b02

11 years agoAdded liferay module for building liferay.zip #12748
John Ahlroos [Fri, 11 Oct 2013 12:41:49 +0000 (15:41 +0300)]
Added liferay module for building liferay.zip #12748

Change-Id: I16c7ba25387b3e1ad9a56e800c49755306b44890

11 years agoAllow running tests locally by overriding runLocally() (#12786)
Artur Signell [Mon, 14 Oct 2013 19:05:40 +0000 (22:05 +0300)]
Allow running tests locally by overriding runLocally() (#12786)

Uses Firefox either from path or from the location given using firefox.path in /work/run-eclipse-run-selected-test.properties

Change-Id: I29faa94cac4c978792a8fab9db338048553d166a

11 years agoCreated constants for tested browser versions (#12786)
Artur Signell [Tue, 15 Oct 2013 14:01:32 +0000 (17:01 +0300)]
Created constants for tested browser versions (#12786)

Change-Id: I8f349bb3c338bb7e9073944891436edac5ee1bb1

11 years agoValidate that the connector is enabled before triggering actions for it (#12743)
Artur Signell [Tue, 15 Oct 2013 06:33:43 +0000 (09:33 +0300)]
Validate that the connector is enabled before triggering actions for it (#12743)

Automated test enabled only for IE9-IE11 because of #12785

Change-Id: I265e5d1ead3fa56469861c5a98dcc9d0106d1051

11 years agoFixed swallower access. Now error handler logs exceptions. (#12703)
Felype Santiago Ferreira [Tue, 8 Oct 2013 13:04:32 +0000 (16:04 +0300)]
Fixed swallower access. Now error handler logs exceptions. (#12703)

Change-Id: If8fe00e10c7ec56cbd8753ff88d4816613a340f2

11 years agoAllow skipping TB2/TB3 tests using tests.tb2/tb3.skip
Artur Signell [Fri, 11 Oct 2013 17:31:48 +0000 (20:31 +0300)]
Allow skipping TB2/TB3 tests using tests.tb2/tb3.skip

Change-Id: If9f16657731fa5ea06e61bf9702abe385e4fc7a1

11 years agoDisable unit cache to avoid compilation issues when switching between branches
Artur Signell [Mon, 14 Oct 2013 18:57:08 +0000 (21:57 +0300)]
Disable unit cache to avoid compilation issues when switching between branches

Change-Id: Iac8a3cdc4b17c031108c08cf3e8cd8769bc14961

11 years agoUpdate to atmosphere javascript 2.0.3-vaadin1 (#12241, #12127)
Artur Signell [Fri, 11 Oct 2013 13:28:32 +0000 (16:28 +0300)]
Update to atmosphere javascript 2.0.3-vaadin1 (#12241, #12127)

Build vaadinPush.js from the released version instead of having a separate
javascript version in the project

Change-Id: I37aac284216c8ec6efd03c242e639e88854f11fd

11 years agoFix whitespace after including a mixin (#12715)
Mika Murtojarvi [Mon, 14 Oct 2013 12:16:40 +0000 (15:16 +0300)]
Fix whitespace after including a mixin (#12715)

Change-Id: I9b25968cc140a9443820a26eadb6b5a1507ad7ec

11 years agoAlso hide shim iframe of VOverlay on setVisible(false) (#12731)
Henri Sara [Wed, 9 Oct 2013 09:31:00 +0000 (12:31 +0300)]
Also hide shim iframe of VOverlay on setVisible(false) (#12731)

Change-Id: I48258a24bb14bbe79c1e11c9bda4a18b120b2a42

11 years agoHandle ClientMethodInvocation serialization with JSONArray as parameter
Pekka Hyvönen [Fri, 11 Oct 2013 09:38:53 +0000 (12:38 +0300)]
Handle ClientMethodInvocation serialization with JSONArray as parameter
(#12532)

Change-Id: I67306d2b9d151614f72455063b0d01423aeed4c1

11 years agoConverted broken test to TB3
Artur Signell [Fri, 27 Sep 2013 10:16:45 +0000 (13:16 +0300)]
Converted broken test to TB3

Change-Id: Ic30db7584a65c944eb45c576e12b7671399d1965

11 years agoMake the various Writers member fields instead of local variables (#12446)
Johannes Dahlström [Thu, 12 Sep 2013 13:07:59 +0000 (16:07 +0300)]
Make the various Writers member fields instead of local variables (#12446)

Change-Id: I9ca101edf6df41702b27635da9f749bdac5bf5f4

11 years agoOnly fetch rows if there are some (#11189)
Matti Tahvonen [Fri, 4 Oct 2013 12:41:06 +0000 (15:41 +0300)]
Only fetch rows if there are some (#11189)

IE hacks cause calls to onScroll in situations where the cache row fetch
logic is not working correctly (causes JS exception). This change has an
optimization to pass this logic if there are no rows available and this
way fixes the JS exception as well.

Change-Id: I3425f3d75cad8b65e605638343b167abf7b48067

11 years agoadded small pause to make test pass
Matti Tahvonen [Wed, 9 Oct 2013 11:37:57 +0000 (14:37 +0300)]
added small pause to make test pass

Change-Id: I2e58a7444e5a2740f81409e6f248e0acedcead54

11 years agoFocus selected row in Table #12540
John Ahlroos [Tue, 1 Oct 2013 13:55:39 +0000 (16:55 +0300)]
Focus selected row in Table #12540

Change-Id: Ic920f9cb11840a456a7c49746317eaccde1e1406

11 years agoFixed compilation error in TB3 test
John Ahlroos [Wed, 9 Oct 2013 06:59:03 +0000 (09:59 +0300)]
Fixed compilation error in TB3 test

Change-Id: I62e246995879733393af3275778e9201cd970adb

11 years agoAvoid obsolete calendar panel renderings to avoid various NPEs.
Matti Tahvonen [Fri, 27 Sep 2013 12:07:48 +0000 (15:07 +0300)]
Avoid obsolete calendar panel renderings to avoid various NPEs.
(#12504,#12667)

Change-Id: Ie0a9a8d9913116520b766062ebabdb771a76d1b6

11 years agoUpdatet servlet tests to follow the same *Test naming convention
Artur Signell [Mon, 7 Oct 2013 17:34:23 +0000 (20:34 +0300)]
Updatet servlet tests to follow the same *Test naming convention

Change-Id: I3c718232364f5ca7cce7131fa7685e4a2b833120

11 years agoAllow configuring deployment port for TB3 tests
John Ahlroos [Tue, 8 Oct 2013 12:54:55 +0000 (15:54 +0300)]
Allow configuring deployment port for TB3 tests

Change-Id: Iee0827d1e65dcbc1fc6c71701b80f355285b6902

11 years agoRecreate transient pendingAccessQueue in readObject() (#12456)
Johannes Dahlström [Tue, 24 Sep 2013 13:08:08 +0000 (16:08 +0300)]
Recreate transient pendingAccessQueue in readObject() (#12456)

This prevents a race condition in getPendingAccessQueue().

Change-Id: I1b8d013119e5963ed6083b7dd17afccd3a915e42

11 years agoUse class name and not enclosing class for screenshot name
Artur Signell [Mon, 7 Oct 2013 17:17:40 +0000 (20:17 +0300)]
Use class name and not enclosing class for screenshot name

Change-Id: I8e9e0487f4354ee0523b5d3c0c016a002c395107

11 years agoMakes test stable and adds helper comparison methods
Artur Signell [Mon, 7 Oct 2013 16:56:43 +0000 (19:56 +0300)]
Makes test stable and adds helper comparison methods

* Takes into account that the timer can be triggered multiple times before the initial request is done (especially if the server is slow)
* Adds assertLessThan, assertLessThanOrEqual, assertGreaterThan, assertGreaterThanOrEqual to ease test creation

Change-Id: I5ce1681e35d9c1de02a83b38528f17ee705331d7

11 years agoUpdate TB3+ convention to use a separate *Test file
Artur Signell [Mon, 7 Oct 2013 15:12:06 +0000 (18:12 +0300)]
Update TB3+ convention to use a separate *Test file

For any issue there should be a UI class, e.g. LabelSomething and a
Test class which has the name of the UI + Test, e.g. LabelSomethingTest.
The LabelSomethingTest contains ALL tests which depend on LabelSomething
and are named accordingly to what they test.

For special and legacy cases also LegacyApplication and UIProvider are
supported in addition to UI classes

Change-Id: Ifc0180b377284bbd029202494ad194d324f8213b

11 years agoMark as deprecated to discourage usage for new tests
Artur Signell [Mon, 7 Oct 2013 14:56:31 +0000 (17:56 +0300)]
Mark as deprecated to discourage usage for new tests

Change-Id: I87d417da5b6b8cf9753604944dff74f8f39c321a

11 years agoFixed incorrect logging (#12241)
Artur Signell [Mon, 7 Oct 2013 15:53:53 +0000 (18:53 +0300)]
Fixed incorrect logging (#12241)

Change-Id: Icfe32a26f9069b7c5ed8160dba93b806754acf58

11 years agoConverted push test to TB3 (#12226, #12522)
Artur Signell [Fri, 27 Sep 2013 10:44:00 +0000 (13:44 +0300)]
Converted push test to TB3 (#12226, #12522)

Change-Id: Ia12b35ef6beed0bf2f534f2c9505b22ce7b3c7c3

11 years agoRebuild OptionGroup on HtmlContentAllowed/Multiselect changes (#10451)
Artem Godin [Mon, 7 Oct 2013 14:19:57 +0000 (17:19 +0300)]
Rebuild OptionGroup on HtmlContentAllowed/Multiselect changes (#10451)

Fixes regression with HtmlContent in Safari 5 and changing of
Multiselect properties on the fly.

Change-Id: I4a3820eba8d1c06460777340ea36b1df31b38983

11 years agoActually open integration test.
Artur Signell [Mon, 7 Oct 2013 17:16:15 +0000 (20:16 +0300)]
Actually open integration test.

Regression since the change in test behavior (no longer automatically
opens test URL)

Change-Id: I1c4efc9b5b5c8a28818afa6f91af1a8b159354b4

11 years agoRun tests on Tomcat 8 (#12326)
Artur Signell [Mon, 7 Oct 2013 17:49:18 +0000 (20:49 +0300)]
Run tests on Tomcat 8 (#12326)

Change-Id: I99d91f16c5ad2dce6fb93f2862913b23518410d7

11 years agoFixed Table range selection IE regression #12407
John Ahlroos [Mon, 7 Oct 2013 09:37:50 +0000 (12:37 +0300)]
Fixed Table range selection IE regression #12407

After fixes for #12407 the range selection did not work in the case
where the selection start had previously been removed. This caused
MultiSelectWithRemovedRow test to fail on IE.

Change-Id: Iaa91cc6a3a310aedc80c4c2475fa8e94a30a5563

11 years agoFix NullPointerException in logger when message is null (#12588)
Artem Godin [Thu, 3 Oct 2013 12:47:08 +0000 (15:47 +0300)]
Fix NullPointerException in logger when message is null (#12588)

LogSection.publish and VConsole.log/VConsole.error methods now replace
null message with an empty string ("")

Change-Id: I735b51bce971ababe2557f1b6c317c01066bc03c

11 years agoPrepare for Atmosphere Javascript 2.0 (#12241)
Artur Signell [Thu, 12 Sep 2013 17:57:01 +0000 (20:57 +0300)]
Prepare for Atmosphere Javascript 2.0 (#12241)

* Atmosphere 2.0 has changed enableProtocol to default to true.
* Reopening a connection in Atmosphere 2.0 is signalled through an onReopen event (not present at all in Atmosphere 1.0.x)

Fix was backported from master

Change-Id: I6ed258087a0b3a06440ab9d19b621560fa4f998f
Merge: no

11 years agoFixes #12564 (HorizontalLayout breaks w/ alignment & error indicator)
Matti Tahvonen [Fri, 27 Sep 2013 16:00:53 +0000 (19:00 +0300)]
Fixes #12564 (HorizontalLayout breaks w/ alignment & error indicator)

Removed some obsolete (hopefully!?) code doing some odd things with caption height calculation  and some refactoring to make that part of code slightly more readable.

Change-Id: I960e4a9eba0388281868f18a182c8788cedf08f9

11 years agoFix OptionGroup elements losing focus on value change (#10451)
Artem Godin [Wed, 2 Oct 2013 14:07:14 +0000 (17:07 +0300)]
Fix OptionGroup elements losing focus on value change (#10451)

The misbehavior was caused by VOptionGroup.buildOptions recreating
associated panel on every change by removing and adding new elements.
With this fix applied it tries to update existing elements,
distinguishing them by assigned keys. It will recreate panel though if
elements are reordered or new elements were added/removed.

Change-Id: I1245b2ff30ce1932614c1eac37bd0131cbd29dd7

11 years agoPorted regression fixes in 6.8 for #12407 to 7.1 branch
John Ahlroos [Wed, 2 Oct 2013 13:33:41 +0000 (16:33 +0300)]
Ported regression fixes in 6.8 for #12407 to 7.1 branch

Change-Id: Ie46ab97fc1ff89dd241eec9182ed0f92164b754d

11 years agoOnly print testbench failure TeamCity messages when running in TC
John Ahlroos [Mon, 30 Sep 2013 11:45:43 +0000 (14:45 +0300)]
Only print testbench failure TeamCity messages when running in TC

Change-Id: Ifa04ce512743bc8ccddea0bdca7b82cceaff150e

11 years agoDo not try to focus invisible components which not present in UIDL #12654
Yuriy Artamonov [Thu, 26 Sep 2013 07:37:42 +0000 (11:37 +0400)]
Do not try to focus invisible components which not present in UIDL #12654

Change-Id: I365940e72d97426eceb408878bc8b24d7655de7c

11 years agoreduce reflow and calculation in VOverlay (#12566)
Fabian Lange [Thu, 12 Sep 2013 14:20:17 +0000 (16:20 +0200)]
reduce reflow and calculation in VOverlay (#12566)

the actual position of VOverlay is only required when a shim or shadow is used.
Otherwise the calculation of its position causes unnecessary reflows.

Change-Id: Id3915fe55c6b477f5d3ff01ee3a505014303d6d6

11 years agoOnly publish files actually produced by this test/browser
Artur Signell [Wed, 2 Oct 2013 06:39:34 +0000 (09:39 +0300)]
Only publish files actually produced by this test/browser

Change-Id: If4f66157791d642801c0100bb4bc0f293efe76cc

11 years agoUpdate slider client-side state object on value change (#12676)
Juho Nurminen [Tue, 1 Oct 2013 12:14:28 +0000 (15:14 +0300)]
Update slider client-side state object on value change (#12676)

Change-Id: Ief93d845e5498388072e05a0faff7ef2d29f1c77

11 years agoCheck modifiers when handling TabSheet hot keys. Fixes #12178
Juho Nurminen [Mon, 23 Sep 2013 10:17:41 +0000 (13:17 +0300)]
Check modifiers when handling TabSheet hot keys. Fixes #12178

Change-Id: I685dbf2c22e3b160632b811652bf3ab52d3ef6dc

11 years agoRefactor how TB3 tests are written (#12572)
Artur Signell [Fri, 27 Sep 2013 10:14:36 +0000 (13:14 +0300)]
Refactor how TB3 tests are written (#12572)

* openTestUrl() must be called in the beginning of each test. Before that setPush and setDebug can be used to determine whether /run-push or ?debug should be used in the URL

Change-Id: Ie70996fcbdb2769fcd4ec56cb878e20198e02bf6

11 years agoPrefixes GET parameters in Liferay with portlet namespace #12602
John Ahlroos [Mon, 23 Sep 2013 13:51:42 +0000 (16:51 +0300)]
Prefixes GET parameters in Liferay with portlet namespace #12602

Change-Id: I9939a7af83482e136ed0d146accdeec0cd9f10ea

11 years agoAdded user agent for IE 11 (#12631)
Artur Signell [Fri, 27 Sep 2013 10:12:35 +0000 (13:12 +0300)]
Added user agent for IE 11 (#12631)

Change-Id: I1ba1791c04a3d1685e1bc482d2b04a748e19f012

11 years agoPublish error artifacts immediatly in TeamCity
John Ahlroos [Wed, 25 Sep 2013 10:51:23 +0000 (13:51 +0300)]
Publish error artifacts immediatly in TeamCity

Change-Id: I69cb2208b7f6b3263ddb25fa26eebebcc6f9a7c3

11 years agoFixes normal drag and drop events (regression since 7.1) and html5 style
Matti Tahvonen [Thu, 26 Sep 2013 12:59:55 +0000 (15:59 +0300)]
Fixes normal drag and drop events (regression since 7.1) and html5 style
D&D in IE10 (#12339)

Change-Id: Ied4504406ebbeab6ff464fb239f7b3f5987fbbd9