]> source.dussan.org Git - vaadin-framework.git/log
vaadin-framework.git
6 years agoUpdate release notes for maintenance release 8.2 10644/head pr10644/r1 8.2.1
Teemu Suo-Anttila [Wed, 10 Jan 2018 13:38:50 +0000 (15:38 +0200)]
Update release notes for maintenance release

6 years agoFix tests for Chrome 63 and focus issues in IE11 (#10495)
Teemu Suo-Anttila [Wed, 10 Jan 2018 10:47:21 +0000 (12:47 +0200)]
Fix tests for Chrome 63 and focus issues in IE11 (#10495)

6 years agoFix space key on selection checkbox to select grid row (#10388)
Marco Collovati [Tue, 9 Jan 2018 13:42:49 +0000 (14:42 +0100)]
Fix space key on selection checkbox to select grid row (#10388)

Fixes #10221

6 years agoMake profiler work again (#10462)
Artur [Tue, 2 Jan 2018 08:53:43 +0000 (10:53 +0200)]
Make profiler work again (#10462)

6 years agoFix javadoc for Notification TYPE_TRAY_NOTIFICATION (#10479)
Marco Collovati [Fri, 29 Dec 2017 07:16:18 +0000 (08:16 +0100)]
Fix javadoc for Notification TYPE_TRAY_NOTIFICATION (#10479)

Fixes #10434

6 years agoDo not create DOM elements for initially hidden columns (#10465)
Artur [Thu, 28 Dec 2017 07:58:19 +0000 (09:58 +0200)]
Do not create DOM elements for initially hidden columns (#10465)

6 years agoChange the order of inheritance to preserve user.agent property (#10470)
Adam Wagner [Wed, 27 Dec 2017 11:29:28 +0000 (13:29 +0200)]
Change the order of inheritance to preserve user.agent property (#10470)

6 years agoUpdate Grid.addColumn JavaDoc to tell about nested properties (#10431)
Olli Tietäväinen [Wed, 27 Dec 2017 09:58:23 +0000 (11:58 +0200)]
Update Grid.addColumn JavaDoc to tell about nested properties (#10431)

6 years agoBackport fix for removing Notifications on close (#10504)
Teemu Suo-Anttila [Wed, 10 Jan 2018 08:30:57 +0000 (10:30 +0200)]
Backport fix for removing Notifications on close (#10504)

6 years agoUpdated release notes for 8.2 final (#10459) 8.2.0
Pekka Hyvönen [Fri, 22 Dec 2017 08:17:09 +0000 (10:17 +0200)]
Updated release notes for 8.2 final (#10459)

Added mention of GridRowDragger, moved PushState navigation to top on features list.
Commented unnecessary mention about alpha version.

6 years agoUse new validation screenshots (#10455)
Teemu Suo-Anttila [Wed, 20 Dec 2017 11:41:18 +0000 (13:41 +0200)]
Use new validation screenshots (#10455)

6 years agoForce correct Selenium version for Spring Boot test (#10421)
Teemu Suo-Anttila [Thu, 7 Dec 2017 14:49:13 +0000 (16:49 +0200)]
Force correct Selenium version for Spring Boot test (#10421)

6 years agoUpdate release notes for release candidate (#10362) 8.2.0.rc1
Teemu Suo-Anttila [Thu, 7 Dec 2017 10:27:47 +0000 (12:27 +0200)]
Update release notes for release candidate (#10362)

6 years agoClarify ContentMode javadocs (#10395)
Leif Åstrand [Fri, 1 Dec 2017 07:30:43 +0000 (09:30 +0200)]
Clarify ContentMode javadocs (#10395)

* Don't refer to Label
* Explicitly mention XSS risk with HTML

6 years agoUpdate to TestBench 5.1.1 (#10391)
Guille [Wed, 29 Nov 2017 11:37:37 +0000 (13:37 +0200)]
Update to TestBench 5.1.1 (#10391)

6 years agoFix selection column size calculation without data (#10384)
Teemu Suo-Anttila [Wed, 29 Nov 2017 09:21:14 +0000 (11:21 +0200)]
Fix selection column size calculation without data (#10384)

6 years agoFix alpine docker image error (#10382)
jtomass [Wed, 29 Nov 2017 08:59:23 +0000 (10:59 +0200)]
Fix alpine docker image error (#10382)

6 years agoFix styling of Window control buttons to show focus (#10285)
Anna Koskinen [Tue, 28 Nov 2017 11:34:00 +0000 (13:34 +0200)]
Fix styling of Window control buttons to show focus (#10285)

Fixes #8918

6 years agoPrevent killing UI if heartbeats are pending (#10371)
Teemu Suo-Anttila [Mon, 27 Nov 2017 11:15:56 +0000 (13:15 +0200)]
Prevent killing UI if heartbeats are pending (#10371)

Fixes #9663

6 years agoAdd missing JavaDocs and since tags (#10372)
Teemu Suo-Anttila [Fri, 24 Nov 2017 10:51:22 +0000 (12:51 +0200)]
Add missing JavaDocs and since tags (#10372)

7 years agoFix RadioButtonGroupTest imports (#10354)
Teemu Suo-Anttila [Wed, 22 Nov 2017 13:57:10 +0000 (15:57 +0200)]
Fix RadioButtonGroupTest imports (#10354)

7 years agoFix missing v-disabled for RadioButtonGroup and CheckBoxGroup options (#10332)
Pekka Hyvönen [Wed, 22 Nov 2017 10:36:07 +0000 (12:36 +0200)]
Fix missing v-disabled for RadioButtonGroup and CheckBoxGroup options (#10332)

* Fix missing v-disabled for RadioButtonGroup
* Fix missing v-disabled for CheckBoxGroup

Resolves #9258

7 years agoFix issues from TestBench version upgrade (#10360)
Teemu Suo-Anttila [Thu, 23 Nov 2017 09:38:13 +0000 (11:38 +0200)]
Fix issues from TestBench version upgrade (#10360)

7 years agoFix AbstractIntegrationTest to use new TestBench API (#10358)
Anna Koskinen [Thu, 23 Nov 2017 05:51:20 +0000 (07:51 +0200)]
Fix AbstractIntegrationTest to use new TestBench API (#10358)

7 years agoTest for MenuBar's WAI-ARIA attributes (#3922) (#10349)
Ansku [Wed, 22 Nov 2017 08:29:42 +0000 (10:29 +0200)]
Test for MenuBar's WAI-ARIA attributes (#3922) (#10349)

7 years agoImprove Binder JavaDocs and APIs (#10347) 8.2.0.beta1
Teemu Suo-Anttila [Tue, 21 Nov 2017 15:05:05 +0000 (17:05 +0200)]
Improve Binder JavaDocs and APIs (#10347)

This patch also adds ValueChangeEvent as a parameter to field value change method in Binder.

7 years agoCreate DescriptionGenerator in package com.vaadin.ui (#10346)
Aleksi Hietanen [Tue, 21 Nov 2017 15:03:25 +0000 (17:03 +0200)]
Create DescriptionGenerator in package com.vaadin.ui (#10346)

Deprecate com.vaadin.ui.components.grid.DescriptionGenerator
and subclass it from the new DescriptionGenerator.

7 years agoFix issues from API review for 8.2 (#10342)
Aleksi Hietanen [Tue, 21 Nov 2017 12:25:42 +0000 (14:25 +0200)]
Fix issues from API review for 8.2 (#10342)

* Rename HierarchicalDataCommunicator#getMapper to getHierarchyMapper

* Make rpc field in Notification private

* Change DropIndexCalculator.ALWAYS_DROP_TO_END to a generic static method

* Move EditorImpl#editRow documentation to the interface level

* Correct GridDragEndEvent, GridDragStartEvent constructor javadocs

* Revert SharedState.registeredEventListeners to a Set

* Rename GridDropTarget dropAllowedOnSortedGridRows

* Rename ColumnState.contentMode to tooltipContentMode

7 years agoExtract AbstractBeanPropertyDefinition and PropertyFilterDefinition (#10344)
Aleksi Hietanen [Tue, 21 Nov 2017 12:24:10 +0000 (14:24 +0200)]
Extract AbstractBeanPropertyDefinition and PropertyFilterDefinition (#10344)

This commit extracts the private nested class AbstractBeanPropertyDefinition from BeanPropertySet to a public class of package com.vaadin.data.

Additionally, the nested protected class PropertyFilterDefinition is extracted from NestedBeanPropertyDefinition to a public class in package com.vaadin.data.

7 years agoIssue3922disableditem (#10259)
Ansku [Tue, 21 Nov 2017 12:19:52 +0000 (14:19 +0200)]
Issue3922disableditem (#10259)

* Accessibility for MenuBar (#3922)
* TabIndex handling fix and an indexing tweak
* Make disabled MenuItems selectable for accessibility (#3922)

- It should be possible to navigate to a disabled MenuItem, even if
triggering the related command is disabled

* Refactor primary style name and aria attribute handling to own method

7 years agoFileResource to use bufferSize, and StreamResource to use getCacheTime() (#10247)
Ahmed Ashour [Tue, 21 Nov 2017 11:36:26 +0000 (12:36 +0100)]
FileResource to use bufferSize, and StreamResource to use getCacheTime() (#10247)

7 years agoRemove unused imports (#10330)
Ahmed Ashour [Tue, 21 Nov 2017 08:57:39 +0000 (09:57 +0100)]
Remove unused imports (#10330)

7 years agoUpdate testbench version (#10336)
Guille [Mon, 20 Nov 2017 08:19:40 +0000 (10:19 +0200)]
Update testbench version (#10336)

7 years agoAdd known PushStateNavigation issue to release notes (#10334)
Teemu Suo-Anttila [Fri, 17 Nov 2017 09:19:39 +0000 (11:19 +0200)]
Add known PushStateNavigation issue to release notes (#10334)

7 years agoRename GridDragger to GridRowDragger (#10333)
Pekka Hyvönen [Fri, 17 Nov 2017 08:46:14 +0000 (10:46 +0200)]
Rename GridDragger to GridRowDragger (#10333)

The old name GridDragger gave an impression that you're dragging the whole grid instead of rows.

7 years agoAdd documentation on GridDragger (#10328)
Pekka Hyvönen [Thu, 16 Nov 2017 12:05:12 +0000 (14:05 +0200)]
Add documentation on GridDragger (#10328)

This pathc also switches GridDragger to by default not allow drops on rows when the
grid has been sorted.

7 years agoRemove empty li element from release notes (#10326)
Teemu Suo-Anttila [Thu, 16 Nov 2017 05:56:40 +0000 (07:56 +0200)]
Remove empty li element from release notes (#10326)

7 years agoUpdate since tags in JavaDoc (#10325) 8.2.0.alpha3
Teemu Suo-Anttila [Wed, 15 Nov 2017 14:09:39 +0000 (16:09 +0200)]
Update since tags in JavaDoc (#10325)

7 years agoFix click listener in WidgetSet test (#10324)
Teemu Suo-Anttila [Wed, 15 Nov 2017 13:54:40 +0000 (15:54 +0200)]
Fix click listener in WidgetSet test (#10324)

7 years agoAdd helper for Grid row DnD (#10255)
Pekka Hyvönen [Wed, 15 Nov 2017 12:37:33 +0000 (14:37 +0200)]
Add helper for Grid row DnD (#10255)

* Added Griddragger.

* Refactored the GridDragger to match FW style

Unit tests, Test UI and documentation to come next.

* Change DropMode to BETWEEN and add Test UIs

* Simplify GridDragger API

* Fixes and unit tests for GridDragger

Fixed issues regarding drop index calculation when sourche and target grid is the same.
When the ListDataProvider is not internally using List, always drops to the end.
Updates the old data provider instead of creating a new one to preserve filters&sorting.

7 years agoAdd mention of Wildfly 11 support and a test for it (#10319)
Teemu Suo-Anttila [Wed, 15 Nov 2017 08:22:32 +0000 (10:22 +0200)]
Add mention of Wildfly 11 support and a test for it (#10319)

7 years agoUpdate CDI tutorial wiki link (#10322)
Olli Tietäväinen [Wed, 15 Nov 2017 08:21:40 +0000 (10:21 +0200)]
Update CDI tutorial wiki link (#10322)

7 years agoAdd new drop mode ON_GRID for GridDropTarget (#10296)
Pekka Hyvönen [Wed, 15 Nov 2017 07:56:27 +0000 (09:56 +0200)]
Add new drop mode ON_GRID for GridDropTarget (#10296)

* Add new drop mode ON_GRID for GridDropTarget

Also adds a way to not accept drops on rows when the user has sorted the grid.
This way the bad UX can be avoided for showing the drop indicator for the wrong place when the grid has been sorted.
This has not been made default behavior to GridDropTarget since it would change behavior compared to 8.1.
Instead if is triggerable via API in GridDropTarget.

* Refactor sorted grid drop logic to server side

* Block setDropMode calls

Blocking setDropMode set values if the grid has been sorted and drop on
sorted rows is not allowed. The value is used once the grid is not sorted
anymore or the drops are allowed on sorted rows.

7 years agoFix TreeGrid to use correct super constructor (#10291)
Jerome Meyer [Tue, 14 Nov 2017 14:26:57 +0000 (09:26 -0500)]
Fix TreeGrid to use correct super constructor (#10291)

Fixes #10195

7 years agoImprove nested property support for Binder (#9925)
Olli Tietäväinen [Tue, 14 Nov 2017 13:40:37 +0000 (15:40 +0200)]
Improve nested property support for Binder (#9925)

Fixes #9210

7 years ago Add API to read Binding value from bean (#10316)
Teemu Suo-Anttila [Mon, 13 Nov 2017 12:58:31 +0000 (13:58 +0100)]
 Add API to read Binding value from bean (#10316)

7 years agoSet no-store headers on UIDL messages
Leif Åstrand [Fri, 10 Nov 2017 15:11:03 +0000 (17:11 +0200)]
Set no-store headers on UIDL messages

UIDL might contain sensitive information that we should prevent from
being stored anywhere.

7 years agoset default ContentMode PREFORMATTED in parameterless TooltipInfo constructor, fixes...
Olli Tietäväinen [Fri, 10 Nov 2017 15:05:44 +0000 (17:05 +0200)]
set default ContentMode PREFORMATTED in parameterless TooltipInfo constructor, fixes undefined enum value access in VTooltip.setTooltipText

7 years agoFix setting custom tab index for TabSheet or Accordion (#9574) (#10278)
Ansku [Fri, 10 Nov 2017 14:50:27 +0000 (16:50 +0200)]
Fix setting custom tab index for TabSheet or Accordion (#9574) (#10278)

7 years agoAdd ContentMode for row and cell descriptions in Grid (#10282)
Teemu Suo-Anttila [Fri, 10 Nov 2017 14:46:57 +0000 (15:46 +0100)]
Add ContentMode for row and cell descriptions in Grid (#10282)

7 years agoUpdate README.md (#10302)
Olli Tietäväinen [Fri, 10 Nov 2017 13:59:13 +0000 (15:59 +0200)]
Update README.md (#10302)

7 years agoRelax mapper access in HierarchicalDataCommunicator
Ilia Motornyi [Fri, 10 Nov 2017 09:42:23 +0000 (11:42 +0200)]
Relax mapper access in HierarchicalDataCommunicator

Fixes #10292

7 years agoRemove deprecated usage of ApplicationConnection.hasEventListeners() (#10248)
Ahmed Ashour [Tue, 7 Nov 2017 11:47:09 +0000 (12:47 +0100)]
Remove deprecated usage of ApplicationConnection.hasEventListeners() (#10248)

From VDateField and VWindow

7 years agoSkip scheduled flush if clear() is called (#10289)
Leif Åstrand [Tue, 7 Nov 2017 11:21:06 +0000 (13:21 +0200)]
Skip scheduled flush if clear() is called (#10289)

Based on vaadin/flow#2834

7 years agoMake focus circulate in modal dialog to improve accessibility (#10260)
Péter Török [Tue, 7 Nov 2017 09:39:11 +0000 (11:39 +0200)]
Make focus circulate in modal dialog to improve accessibility (#10260)

Make focus circulate in modal dialog to improve accessibility

7 years agoHasItems.setItems(T... items) should allow edits (#10290)
Pekka Hyvönen [Mon, 6 Nov 2017 18:20:58 +0000 (20:20 +0200)]
HasItems.setItems(T... items) should allow edits (#10290)

* HasItems.setItems(T... items) should allow edits

Arrays.asList() creates a immutable Arrays.ArrayList, preventing users from doing dataProvider.getItems() and updating the returned collection. This makes it impossible to keep the same data provider, update it and keep the filters & sorting, and then just call dataProvider.refreshAll() to get changes visible. We should not require users to create a new data provider in this case.
This is the same for DataProvider.ofItems(T... items)

* fix missing whitespace from test error message

7 years agoRelax TreeGrid and Tree members access modifiers. (#10293)
Ilia Motornyi [Mon, 6 Nov 2017 14:46:59 +0000 (16:46 +0200)]
Relax TreeGrid and Tree members access modifiers. (#10293)

* Relax TreeGrid and Tree members access modifiers.

Fixes #10292

* Fixes after review

7 years agoUse Logger instead of VConsole (#10249)
Ahmed Ashour [Mon, 6 Nov 2017 14:17:04 +0000 (15:17 +0100)]
Use Logger instead of VConsole (#10249)

Because VConsole is deprecated and it recommends using Logger instead

7 years agoFix javadoc ending (#10274)
Ahmed Ashour [Mon, 6 Nov 2017 13:27:22 +0000 (14:27 +0100)]
Fix javadoc ending (#10274)

7 years agoFix link format (#10269)
Henri Muurimaa [Mon, 6 Nov 2017 13:23:47 +0000 (15:23 +0200)]
Fix link format (#10269)

7 years agoFix typo (#10295)
Mikko Inkinen [Mon, 6 Nov 2017 13:15:55 +0000 (15:15 +0200)]
Fix typo (#10295)

7 years agoUse lambda expressions. (#10268)
Ahmed Ashour [Wed, 1 Nov 2017 09:36:47 +0000 (10:36 +0100)]
Use lambda expressions. (#10268)

7 years agoUse local variable for getWidget(). (#10253)
Ahmed Ashour [Tue, 31 Oct 2017 17:51:22 +0000 (18:51 +0100)]
Use local variable for getWidget(). (#10253)

In some places, getWidget() is called many times, and I believe this can
have a litte performance improvement, since in some cases
super.getWidget() is called more than once.

7 years agoFix end of line comments, which were made by automatic formatter (#10234)
Ahmed Ashour [Tue, 31 Oct 2017 16:41:14 +0000 (17:41 +0100)]
Fix end of line comments, which were made by automatic formatter (#10234)

7 years agoRemove redundant interface already implemented by super class. (#10258)
Ahmed Ashour [Tue, 31 Oct 2017 10:23:36 +0000 (11:23 +0100)]
Remove redundant interface already implemented by super class. (#10258)

7 years agoFix combo box suggestion popup height (#10256)
Adam Wagner [Mon, 30 Oct 2017 11:31:27 +0000 (13:31 +0200)]
Fix combo box suggestion popup height (#10256)

Fixes #10214

7 years agoadd Grid.Column#get/setAssistiveCaption (#10219)
Knoobie [Mon, 30 Oct 2017 08:00:21 +0000 (09:00 +0100)]
add Grid.Column#get/setAssistiveCaption (#10219)

* add Grid#Column#get/setAssistiveCaption

* fix test and update doc

* move testGridAssistiveCaption to GridTest

* delete test file

* delete test file

* Delete GridAssistiveCaptionTest.java

* Create GridAssistiveCaptionTest

* Create GridAssistiveCaption

* Rename GridAssistiveCaption to GridAssistiveCaption.java

* Rename GridAssistiveCaptionTest to GridAssistiveCaptionTest.java

* Reformat using eclipse

7 years agoUse lambda with Handlers (#10229)
Ahmed Ashour [Fri, 27 Oct 2017 15:44:19 +0000 (17:44 +0200)]
Use lambda with Handlers (#10229)

Also improve naming by replacing one-letter variable names.

7 years ago Use lambda with Listeners (#10222)
Ahmed Ashour [Thu, 26 Oct 2017 19:19:41 +0000 (21:19 +0200)]
 Use lambda with Listeners (#10222)

Also use "event" as the name for events

7 years agoImprove naming of fields and variables (#10242)
Ahmed Ashour [Thu, 26 Oct 2017 11:26:20 +0000 (13:26 +0200)]
Improve naming of fields and variables (#10242)

* Variable names to conform to naming convention.

* Use static constants where it makes sense

7 years agoRemove trailing spaces (#10224)
Ahmed Ashour [Thu, 26 Oct 2017 10:07:51 +0000 (12:07 +0200)]
Remove trailing spaces (#10224)

7 years agoAdd contribution guideline (#10083)
Teemu Suo-Anttila [Mon, 23 Oct 2017 12:34:42 +0000 (15:34 +0300)]
Add contribution guideline (#10083)

* Add contribution guideline

* Make suggested improvements to CONTRIBUTING.md

* Add link to good first issues and project setup

* Small update to CONTRIBUTING.md

7 years agoadds simple fix for missing label text in grid select checkboxes (#10223)
Knoobie [Mon, 23 Oct 2017 12:33:55 +0000 (14:33 +0200)]
adds simple fix for missing label text in grid select checkboxes (#10223)

* adds simple fix for missing label text in grid select checkboxes

* updated comment and wording

7 years agoFix bad grammar in declarative documentation (#10236)
Pekka Hyvönen [Mon, 23 Oct 2017 12:31:02 +0000 (13:31 +0100)]
Fix bad grammar in declarative documentation (#10236)

* Fix bad grammar in declarative documentation

* Fix typos

7 years agoUnlock panel caption div hacking (#10120)
Ilia Motornyi [Mon, 23 Oct 2017 11:34:20 +0000 (14:34 +0300)]
Unlock panel caption div hacking (#10120)

* Unlock panel caption div hacking

Fixes #10119

* Javadoc formatting fix

7 years agoGrid column to be sortable when implemented/supported (Fixes #8792). (#10190)
Ahmed Ashour [Mon, 23 Oct 2017 07:05:44 +0000 (09:05 +0200)]
Grid column to be sortable when implemented/supported (Fixes #8792). (#10190)

* Grid column to be sortable when implemented/supported
* Fix GridDeclarativeTest
* Parameterize to Grid<Person>
* Revert Parameterize to Grid<Person>, JDK with generics.
* Assertions for other columns
* Fix test

Fixes #8792

7 years agoGrid.removeColumn() not to fail silently (Fixes #8056) (#10215)
Ahmed Ashour [Fri, 20 Oct 2017 12:17:32 +0000 (14:17 +0200)]
Grid.removeColumn() not to fail silently (Fixes #8056) (#10215)

* Grid.removeColumn() not to fail silently (Fixes #8056)

* Compilation with JDK

* Fix removeColumnByColumn_alreadyRemoved test

* Use ExpectedException

7 years agoTypo in code (#10218)
Oskar Bilén [Fri, 20 Oct 2017 08:55:11 +0000 (10:55 +0200)]
Typo in code (#10218)

Remove "java" from code example

7 years agoAbstractDateField.formatDate() to be abstract (#10186)
Ahmed Ashour [Fri, 20 Oct 2017 08:54:25 +0000 (10:54 +0200)]
AbstractDateField.formatDate() to be abstract (#10186)

* AbstractDateField.formatDate to be abstract

Remove invalidDateString paramter, as it can be deduced

* Fix test

* Remove AbstractDateField.getResolutionVariable

VAbstractTextualDate: rename updateDateVariables() to updateBufferedResolutions()

* Revert to use fixed value of MONDAY.

* release notes

* updateAndSendBufferedValues()

* Missed call to updateAndSendBufferedValues();

* release note

7 years agoAdded utility method Binder#asRequired() (#9873)
Stephan Knitelius [Fri, 20 Oct 2017 08:53:45 +0000 (10:53 +0200)]
Added utility method Binder#asRequired()  (#9873)

* Added the possiblity of defining a Field as Required without
setting an error message.

* Added @since to asRequired()

* Add droped paragraphs and see tag for asRequired(String)

7 years agoFix typos (#10213)
Ahmed Ashour [Fri, 20 Oct 2017 08:15:43 +0000 (10:15 +0200)]
Fix typos (#10213)

* Fix typos

* Fix

7 years agoCheck class name type on Grid cell mouse over (#10194)
Adam Wagner [Fri, 20 Oct 2017 08:14:33 +0000 (10:14 +0200)]
Check class name type on Grid cell mouse over (#10194)

* Check whether className is of type string

* Move string type checker method to widget util

* Fix formatting of WidgetUtil

* Break svg into lines

7 years agoImprove role usage in grid (#10206)
Knoobie [Fri, 20 Oct 2017 08:11:10 +0000 (10:11 +0200)]
Improve role usage in grid (#10206)

* add role="row" and role="gridcell"

* optimize code and add additional rows for the header

* add simple test

* improve code and add rowgroup

* add debug log

* add more log to test

* remove debug test info and add role before appending to tr

* wording - change contains to contain

* create enum for magic strings, change comments and method signature

* rename enum to be singular and rename param roleName to role

* update javadoc, rename and make enum public

7 years agoUse .toLowerCase and .toUpperCase(Locale.ROOT) (#10182)
Ahmed Ashour [Fri, 20 Oct 2017 08:10:02 +0000 (10:10 +0200)]
Use .toLowerCase and .toUpperCase(Locale.ROOT) (#10182)

* Use .toLowerCase and .toUpperCase(Locale.ROOT)

* Spaces

* add spaces after if(

7 years agoUse GWT 2.8.2 (#10217)
Teemu Suo-Anttila [Fri, 20 Oct 2017 08:01:43 +0000 (11:01 +0300)]
Use GWT 2.8.2 (#10217)

7 years agoFix HTML tags inside code in javadoc (#10160)
Ahmed Ashour [Fri, 20 Oct 2017 07:12:44 +0000 (09:12 +0200)]
Fix HTML tags inside code in javadoc (#10160)

* Fix HTML tags inside code in javadoc

* only modify <table> and <tr>

* Fix javadoc

7 years agoScheduler.ScheduledCommand and RepeatingCommand to be lambda (#10203)
Ahmed Ashour [Fri, 20 Oct 2017 07:01:39 +0000 (09:01 +0200)]
Scheduler.ScheduledCommand and RepeatingCommand to be lambda (#10203)

* Scheduler.ScheduledCommand and RepeatingCommand to be lambda

* Restore <table> in javadoc

* Fix docs

7 years agoAdd spaces after 'if' and 'for' in JavaScript (#10199)
Ahmed Ashour [Fri, 20 Oct 2017 07:00:01 +0000 (09:00 +0200)]
Add spaces after 'if' and 'for' in JavaScript (#10199)

* Add spaces after 'if' and 'for' in JavaScript

* Revert to old format

* Remove whitespaces

7 years agoSimplify lambda expressions (#10198)
Ahmed Ashour [Fri, 20 Oct 2017 06:59:17 +0000 (08:59 +0200)]
Simplify lambda expressions (#10198)

* Simplify lambda expressions

And remove unneeded 'return' keyword.

* Format

7 years agoAbstractDateField: set value after being invalid (#10187)
Ahmed Ashour [Fri, 20 Oct 2017 06:54:49 +0000 (08:54 +0200)]
AbstractDateField: set value after being invalid (#10187)

Fixes #9763
Fixes #9978

7 years agoFix AbstractDateField to correctly show week day names (#10188)
Ahmed Ashour [Mon, 16 Oct 2017 15:21:23 +0000 (17:21 +0200)]
Fix AbstractDateField to correctly show week day names (#10188)

Fixes #9200

7 years agoAdd *.properties to .gitattributes (#10180)
Ahmed Ashour [Mon, 16 Oct 2017 14:56:17 +0000 (16:56 +0200)]
Add *.properties to .gitattributes (#10180)

7 years agoFix IDE usage of Elemental in vaadin-shared (#10178)
Teemu Suo-Anttila [Mon, 16 Oct 2017 10:31:15 +0000 (13:31 +0300)]
Fix IDE usage of Elemental in vaadin-shared (#10178)

7 years agoFix some checkstyle warnings (#10179)
Ahmed Ashour [Fri, 13 Oct 2017 13:11:49 +0000 (15:11 +0200)]
Fix some checkstyle warnings (#10179)

7 years agoSimplify waitUntil() in tests (#10181)
Ahmed Ashour [Fri, 13 Oct 2017 13:10:20 +0000 (15:10 +0200)]
Simplify waitUntil() in tests (#10181)

7 years agoConvert AbstractDateField not to be a LegacyComponent (#10148)
Ahmed Ashour [Fri, 13 Oct 2017 06:53:17 +0000 (08:53 +0200)]
Convert AbstractDateField not to be a LegacyComponent (#10148)

7 years agoAdd Navigator testing to Spring Boot test (#10174)
Teemu Suo-Anttila [Fri, 13 Oct 2017 06:44:32 +0000 (09:44 +0300)]
Add Navigator testing to Spring Boot test (#10174)

7 years agoUse Collection.isEmpty() (#10172)
Ahmed Ashour [Thu, 12 Oct 2017 08:46:06 +0000 (10:46 +0200)]
Use Collection.isEmpty() (#10172)

7 years agoRemove redundant null checks before an instanceof (#10173)
Ahmed Ashour [Thu, 12 Oct 2017 06:00:02 +0000 (08:00 +0200)]
Remove redundant null checks before an instanceof (#10173)

7 years agoAdd ErrorLevel to Validators and results (#10099)
Teemu Suo-Anttila [Wed, 11 Oct 2017 13:04:58 +0000 (16:04 +0300)]
Add ErrorLevel to Validators and results (#10099)

Fixes #9792