Apply missing v-readonly style to CheckBoxGroup, when component is readOnly (#11370)
Setting read-only state to CheckBoxGroup should disable adding clicking effect. Missing v-readonly style is added to every CheckBox in the component, if it's set to read-only.
Fixes: https://github.com/vaadin/framework/issues/11113
* Add file missed from initial commit
* Verifying that option is enabled
Some of the options might be disabled on there own. Verify that option is not disabled, before removing disabled styles.
Matti Tahvonen [Tue, 18 Dec 2018 07:12:37 +0000 (09:12 +0200)]
Update portal-osgi.asciidoc (#11384)
Updated versions to latest ones as people often just copy past things. Added comment to urge people to use the versions they need. Removed version from archetype to use the latest by default.
mlindfors [Wed, 5 Dec 2018 14:39:09 +0000 (16:39 +0200)]
Fix Grid's frozen columns not being set (#10653) (#11346)
In certain cases setting the frozen columns didn't produce the expected result in the client side widget state. This happened if the frozen columns value was set to be the same it was before removeAllColumns was called.
This fix removes the frozen column value from the diff state so that the value gets properly set in the client side.
```buildTime()``` function re-initializes ListBoxes for hours,minutes and seconds values. We need to set correct values in those ListBoxes, before assigning value to the labels displayed instead of those ListBoxes in ReadOnly state, as , otherwise, the selectedItemIndex returns 0.
Display the caption of the Empty selection in NativeSelect (#11191)
* Fixes #10937
- Previously if selected value is null, then index is set to -1; in current implementation if value is null and emptySelection is allowed then set the index to 0. (The position for the empty selection)
- Also, if changing the allowEmptySelection on the fly, ensure, that either index is to-reset to -1 by setting the selected value to null on the client-side (the value before was null) or preserve the value(value was different than empty).
* Change the test case
Since in this pr the behaviour of the NS is changed, therefore old test need to be adjusted.
Change: setting null as value will select empty selection. Before that nothing would be selected and value will be cleared.
Behaviour change in PR: Allow selecting null as value
Add test case to address the issue with removing gird with components;
Current situation: the grid cannot be removed and client-side throw an error.
fixes: Revert the corresponding change, as it didn't address any issue which was fixed.
Anna Koskinen [Wed, 10 Oct 2018 10:26:13 +0000 (13:26 +0300)]
Updates to scrolled TabSheet resize logic and Valo right-alignment. (#11133)
- When a TabSheet is scrolled to an end and then resized bigger, more
tabs should appear to the left.
- When a TabSheet is right-aligned in Valo and scrolled to the end, last
tab shouldn't be partially hidden behind the scroller buttons.
- Shouldn't allow attempts to scroll into directions where there is
nothing left to scroll to, even if the current tab isn't fully visible.
Sun Zhe [Wed, 10 Oct 2018 07:50:44 +0000 (10:50 +0300)]
Fixes to displaying Grid in a detail row. (#11147) (#11228)
- Multiple headers shouldn't stack behind each other.
- Body rows shouldn't get stuck to default row height.
- Compatibility version's hidable row selector shouldn't try to
calculate row heights based on rows that haven't been added to DOM yet.
Kari Söderholm [Mon, 1 Oct 2018 12:14:19 +0000 (15:14 +0300)]
Fix link in "Vaadin Spring Tips" article (#11214)
Link to `3.0` branch of `vaadin/spring` which is the latest version for Vaadin 8 and latest version branch to contain this mentioned file with this path/name.
Mehdi Javan [Mon, 17 Sep 2018 13:17:28 +0000 (16:17 +0300)]
Fixing RadioButtonGroup exception in Window (#11181)
* discardStaleCacheEntries is moved to a proper place before updating indexToRowMap and keyToIndexMap maps. In its previous place, it cleared the data that was just put in the maps.
Fixes #11143
* Adding test
* Removing extra annotations
* Updating chrome version to 69 in tests (#11182)
* Updating Chrome version to 69
* Updating screenshots taken in Chrome 69
* Fixing screenshots
* Fixing screenshots
* Adding some wait commands to tests
* Fixing screenshots
* Revert: Fixing screenshots
* More screenshots
* - Adding wait commands to make sure the transitions end before screenshot
- Fixing a screenshot
* Correcting a mistake of using wait instead of sleep
* Fixing more screenshots
* Increasing the height of ContextMenu (Because of limitation of new Chrome 69 in terms of minimum window height, ContextMenu size can't be tested with a small height.)
Mehdi Javan [Mon, 17 Sep 2018 08:23:23 +0000 (11:23 +0300)]
Updating chrome version to 69 in tests (#11182)
* Updating Chrome version to 69
* Updating screenshots taken in Chrome 69
* Fixing screenshots
* Fixing screenshots
* Adding some wait commands to tests
* Fixing screenshots
* Revert: Fixing screenshots
* More screenshots
* - Adding wait commands to make sure the transitions end before screenshot
- Fixing a screenshot
* Correcting a mistake of using wait instead of sleep
* Fixing more screenshots
* Increasing the height of ContextMenu (Because of limitation of new Chrome 69 in terms of minimum window height, ContextMenu size can't be tested with a small height.)
projects / vaadin-framework.git / log