fix: lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix(user_database): Add IDBConnection as a constructor dependency

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Merge pull request #48028 from nextcloud/fix/fix-ldap-setupcheck-crash

fix(user_ldap): Use %n in plural translation to avoid a crash in L10N

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48049 from nextcloud/refactor/void-tests

refactor: Add void return type to PHPUnit test methods

Merge pull request #48043 from nextcloud/fix/imip-test-expects-integer

test(dav): imip service test expects integers for last occurence

Merge pull request #48046 from nextcloud/refactor/self-class-reference

refactor: Replace __CLASS__ with ::class references

Merge pull request #47973 from melroy89/patch-1

Add missing Nextcloud v30 to issue template

Merge pull request #48045 from nextcloud/fix/add-function-type-for-mimetype-sanitizer

chore: Update git blame ignore

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

refactor: Add void return type to PHPUnit test methods

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

test(dav): imip service test expects integers for last occurence

Signed-off-by: Anna Larch <anna@nextcloud.com>

Merge pull request #48010 from nextcloud/feat/switch-from-settype-to-casts

feat(db): switch from settype to casts

docs: Add missing Nextcloud v30

Signed-off-by: Melroy van den Berg <melroy@melroy.org>

refactor: Replace __CLASS__ with ::class references

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

fix(dav): set string type for sanitizeMtime

Signed-off-by: Anna Larch <anna@nextcloud.com>

Merge pull request #48041 from nextcloud/refactor/dirname-to-dir

refactor: migrate dirname to __DIR__ constants

refactor: migrate dirname to __DIR__ constants

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #47916 from nextcloud/feat/add-subscription-via-occ

feat(caldav): create subscriptions via occ

Merge pull request #48037 from nextcloud/chore/noid/correctTrademarkLink

fix: correct link to trademark

fix: correct link to trademark

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

feat(db): switch from settype to casts

Signed-off-by: Anna Larch <anna@nextcloud.com>

Merge pull request #48016 from nextcloud/fix/s3configtrait/proxy-false

Merge pull request #48013 from nextcloud/fix/baseresponse/xml-element-value-string-cast

feat(caldav): create subscriptions via occ

Signed-off-by: Anna Larch <anna@nextcloud.com>

fix(user_ldap): Use %n in plural translation to avoid a crash in L10N

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #48014 from nextcloud/fix/tags/boolean-user-has-tags

Merge pull request #48017 from nextcloud/fix/comment/children-count-integer

Merge pull request #48015 from nextcloud/fix/storage-local/get-source-path-spl-file-info

fix(Comment): Initialize childrenCount as integer

Signed-off-by: provokateurin <kate@provokateurin.de>

fix(S3ConfigTrait): Allow proxy field to take false

Signed-off-by: provokateurin <kate@provokateurin.de>

fix(Storage\Local): Do not call getSourcePath() on SplFileInfo

Signed-off-by: provokateurin <kate@provokateurin.de>

fix(BaseResponse): Cast XML element values to string

Signed-off-by: provokateurin <kate@provokateurin.de>

fix(Tags): Return boolean for userHasTags()

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48003 from nextcloud/artonge/fix/missing_dot

fix: Restore missing dot in FilesListVirtual.vue

Merge pull request #47999 from nextcloud/fix/noid/try-latest-buildjet-cache

chore: update BuildJet/cache to v4

Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>

fix: Restore missing dot in FilesListVirtual.vue

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix(ci): Use latest buildjet version

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>

Merge pull request #47990 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

chore(tests): Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #47920 from nextcloud/artonge/feat/reset_route_when_sidebar_and_viewer_are_close

feat: Reset route if neither the Viewer of the Sidebar is open

feat: Reset route if neither the Viewer of the Sidebar is open

When the viewer or the sidebar is opened, we add the fileid to the route.
When both of them are closed, we do not remove the fileid from the route.
This means that, upon reload, the sidebar will be opened even though it was closed previously.

This PR ensure that the fileid is removed from the route when both the Sidebar and the Viewer are closed.

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #47928 from nextcloud/bugfix/noid/update-opendyslexic

Merge pull request #47971 from nextcloud/fix/do-not-try-to-change-response-code-too-late

fix: Do not try to set HTTP response code on already closed connection

Merge pull request #47293 from nextcloud/feat/logger-allow-psr-loglevel

feat(PsrLoggerAdapter): Allow to use `Psr\Log\LogLevel` for `log` method

Merge pull request #47968 from nextcloud/fixKeyExFileExt

feat(PsrLoggerAdapter): Allow to use `Psr\Log\LogLevel` for `log` method

There is the `Psr\Log\LogLevel` class defining loglevel constants,
to be fully compatible we should at least support those logging levels.
Moreover this is the last part that was still required from `ILogger` interface,
as we did not have alternatives for the loglevel constants.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix: Do not try to set HTTP response code on already closed connection

This avoids a PHP warning in the logs about trying to set the response
 code while the output already started. It’s useless to try to print an
 error page anyway in this situation because the connection was closed
 already.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix(files_external): Check key exists before accessing it

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Merge pull request #47965 from nextcloud/dependabot/npm_and_yarn/express-4.21.0

build(deps-dev): bump express from 4.19.2 to 4.21.0

Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #47960 from nextcloud/dependabot/composer/vendor-bin/psalm/vimeo/psalm-5.26.1

Merge pull request #47961 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

chore(tests): Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

build(deps): bump vimeo/psalm from 5.25.0 to 5.26.1 in /vendor-bin/psalm

Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 5.25.0 to 5.26.1.
- [Release notes](https://github.com/vimeo/psalm/releases)
- [Commits](https://github.com/vimeo/psalm/compare/5.25.0...5.26.1)

---
updated-dependencies:
- dependency-name: vimeo/psalm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #47954 from nextcloud/fix/files/cache-search-query-parameter-name

fix(files): Adjust Cache::searchQuery() parameter name to match interface

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #47927 from nextcloud/fix/migrate-away-from-oc_app

Migrate away from OC_App to IAppManager

Merge pull request #47945 from nextcloud/fix/external-storage-creds

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files_external): broken credentials dialog

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Merge pull request #47865 from nextcloud/admin_audit/enh/move-to-event-listeners-v2

Move admin_audit to proper event listeners v2

fix: Fix phpdoc wording

Co-authored-by: Anna <anna@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>

Merge pull request #47883 from nextcloud/fix/setup-checks

fix(setup-checks): Ensure URL with webroot works

Merge pull request #47933 from nextcloud/bugfix/noid/throw-precondition-failure-when-not-matching

fix(config): Throw PreconditionException always when it didn't match

refactor(settings): `CheckServerResponseTrait` always expect absolute path

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(setup-checks): Ensure URL with webroot works

We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #47932 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

Merge pull request #47854 from nextcloud/validAppsFromAppStore

fix(appstore): Ensure returned apps from AppStore are valid

chore(tests): Fix Router test by mocking AppManager methods correctly

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix: Replace OC_App::getAllApps with a method in AppManager

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

chore: Migrate cleanAppId and getAppPath calls to IAppManager from OC_App

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix: check if key is set

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix(config): Throw PreconditionException always when it didn't match

Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.

Signed-off-by: Joas Schilling <coding@schilljs.com>

chore(tests): Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(tests): Test OTF font file

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #47930 from nextcloud/chore/noid/bump-db-version

build: bump version to run sha265 for background job arguments migration

chore: bump 3rdparty

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

build: bump version to run sha265 for background job arguments migration

Follow-up for https://github.com/nextcloud/server/pull/47769

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

fix(a11y): Update OpenDyslexic from 0.920 to 2.001

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #47526 from nextcloud/jtr/fix-ftp-custom-port-ui

fix(files_external): Handling in FTP UI for custom ports

Merge pull request #47527 from nextcloud/fix-sftp-custom-port-ui

fix(files_external): Handling in SFTP UI for custom ports

Merge pull request #47685 from nextcloud/fix/move-apihelper-to-oc-namespace

fix: Move OC_API into \OC\ApiHelper in standard namespace

Merge pull request #47914 from nextcloud/fix/noid/ldap-range-index-check

fix(LDAP): check index before accessing it

fix(LDAP): check index before accessing it

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #47913 from nextcloud/fix/whiteboard-app-bundles

fix: Add whiteboard to education and public sector bundle

fix: Add whiteboard to education and public sector bundle

Signed-off-by: Julius Knorr <jus@bitgrid.net>

Merge pull request #47906 from nextcloud/chore/trashbin-retention-config-cleanup

chore: Update trashbin retention documentation with exceeded quota details

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

chore: Update trashbin retention documentation with exceeded quota details

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #47586 from nextcloud/fix/color

fix(theming): Add migration to restore primary color after separating primary and background

Merge pull request #47891 from nextcloud/fix/make-watcher-null-safe

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>