fix: Adjust preview for view-only shares

Previously there was a different behavior for public shares (link-shares) and internal shares,
if the user disabled the view permission.
The legacy UI for public shares simply "disabled" the context menu and hided all download actions.
With Nextcloud 31 all share types use the consistent permissions attributes,
which simplifies code, but caused a regression: Images can no longer been viewed.

Because on 30 and before the attribute was not set, previews for view-only files
were still allowed. Now with 31 we need a new way to allow "viewing" shares.

So this is allowing previews for those files, but only for internal usage.
This is done by settin a special header, which only works with custom requests,
and not by opening the URL directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #48921 from nextcloud/ci/psalm/imagick-extension

ci(psalm): Add missing imagick extension

Merge pull request #48943 from nextcloud/feat/photo-cache-webp

feat: Allow WebP content type in PhotoCache

Merge pull request #48871 from nextcloud/fix/app-store-reactivity

fix(app-store): Update update count in navigation

feat: Allow WebP content type in PhotoCache

Signed-off-by: Miguel Sánchez de León Peque <peque@ieco.io>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

Merge pull request #48915 from nextcloud/fix/encrypt-decrypt-password

Merge pull request #48918 from nextcloud/fix/files_sharing/cleanup-error-messages

fix: crypto made inline for constructor and decrypt error handled in exception

Signed-off-by: yemkareems <yemkareems@gmail.com>

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix: crypto made inline for constructor and decrypt error handled in exception

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix(app-store): Update update count in navigation

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #48919 from nextcloud/fix/settings/userid-dependency-injection

Merge pull request #48912 from nextcloud/bugfix/exception-appscreenshot-notstring

fix(apps-store): Fix exception on generating preview url for installed app screenshot

fix: use Icrypto in place of Cypto

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: crypto type made not nullable and tests run using ICrypto

Signed-off-by: yemkareems <yemkareems@gmail.com>

Merge pull request #48614 from nextcloud/refactor/storage/constructors

Merge pull request #48917 from nextcloud/fix/dav/view-only-check

ci(psalm): Add missing imagick extension

Signed-off-by: provokateurin <kate@provokateurin.de>

fix(files_sharing): Cleanup error messages

Signed-off-by: provokateurin <kate@provokateurin.de>

fix(appinfo): Make sure screenshot, author and category are always arrays

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix(appsmanagement): Fix exception on generating preview url for screenshots

Some installed apps meant for older server versions might unexpectedly
offer up screenshot values in a non-string format (e.g. health). Avoid
an exception by checking first if the first app screenshot is indeed a
string and otherwise we take the value of the parameter

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

fix(settings): Fix  dependency injection

Signed-off-by: provokateurin <kate@provokateurin.de>

fix(dav): Cleanup view-only check

Signed-off-by: provokateurin <kate@provokateurin.de>

fix: encrypt and store password, decrypt and retrieve the same

Signed-off-by: yemkareems <yemkareems@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48898 from nextcloud/fix/files--list-header-button-title

fix(files): add title for files list table header button

chore(assets): Recompile assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(files): add title for files list table header button

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Merge pull request #48895 from nextcloud/jtr/chore-bug-report-logs

chore: Clarify log entry requirements in bug report form

chore: Clarify log entry requirements in bug report form

Signed-off-by: Josh <josh.t.richards@gmail.com>

Merge pull request #48892 from nextcloud/update-stale-bot-configuration

chore: don't remove needs info label when commenting on a stale issue

Merge pull request #48884 from nextcloud/bugfix/noid/allow-to-force-db-throttler

feat(bruteforce): Allow forcing the database throttler

Merge pull request #48625 from nextcloud/fix/files--handle-empty-view-with-error

fix(files): handle empty view with error

chore: don't remove needs info label when commenting on a stale issue

1) Removing the "needs info" label when someone comments on a stale issue seems incorrect.
2) By default, the stale action removes the "stale" label upon commenting. However, the labels-to-remove-when-unstale option triggers an additional API request to remove the "stale" label, which was already removed in the previous API call.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

chore(assets): Recompile assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

refactor(files): migrate to @nextcloud/sharing

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(files): handle empty view with error

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(files): migrate davUtils to TS

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48882 from nextcloud/safety-net-null-check

refactor(ShareApiController): Check for null and empty strings with e…

feat(bruteforce): Allow forcing the database throttler

Using the database is most likely worse for performance, but makes investigating
issues a lot easier as it's possible to look directly at the table to see all
logged remote addresses and actions.

Signed-off-by: Joas Schilling <coding@schilljs.com>

refactor(ShareApiController): Check for null and empty strings with empty()

Proactive measure to avoid warnings in higher php versions as well possible type errors

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Merge pull request #48381 from nextcloud/fix/48012/fix-share-email-send-mail-share

fix(ShareAPI): Send mails for mail shares by default

fix(ShareAPI): Send mails for mail shares by default

It looks like, the frontend it needs to provide the `sendMail` param
for the backend to decide wether mails would be sent.

Our UI does not have that at the moment so it should default to sending
emails always for mail shares.

Not exactly sure how this was handled earlier but this is a good starting point.

Resolves : https://github.com/nextcloud/server/issues/48012

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Merge pull request #48874 from nextcloud/jtr/setup-checks-heading

fix(settings): Change "setup warnings" -> "setup checks" in Overview

Merge pull request #48863 from nextcloud/fix/noid/textprocessing-list-types

[TextProcessing] Fix: Also list types that are available in task processing

feat(textprocessing): factorize taskProcessingCompatibleTaskTypes

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

fix(textprocessing): also list types that are available in task processing

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(settings): Change "setup warnings" -> "setup checks" in Overview

Signed-off-by: Josh <josh.t.richards@gmail.com>

Merge pull request #48864 from nextcloud/fix/invalid-app-config

fix(settings): Do not use `null` on `string` parameter for sharing disclaimer

chore: Compile assets

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(settings): Do not use `null` on `string` parameter for sharing disclaimer

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #48852 from nextcloud/fix/app-store-markdown

fix(app-store): Correctly render Markdown in app description

Merge pull request #48867 from nextcloud/fix/apps/wrong-missing-casts

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #48854 from nextcloud/fix/proxy-app-screenshot

fix(app-store): Correctly render Markdown in app description

This seems to be broken by an update because the renderer now passes an object instead of multiple arguments to the render functions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(apps): Fix wrong or missing casts

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48853 from nextcloud/fix/app-store-groups

fix(app-store): Ensure the `groups` property is always an array

Merge pull request #48850 from nextcloud/fix/unified-search-ctrl-f

fix(unified-search): Close on second ctrl+f

Merge pull request #48851 from nextcloud/artonge/fix/uid_type

Fix $uid type in Encryption stream

Merge pull request #48837 from nextcloud/followup/47329/add-all-types-to-handling

fix(entity): Fix mapping of old/sub-types to actually supported datab…

Merge pull request #48839 from nextcloud/build/translation-checker-print-rtl-limited-characters

build: Print RTL limited characters in translation-checker

fix(app-store): Also proxy images of locally installed apps

Before this only app store apps got their screenshots proxied,
but this will cause locally installed apps to not be correctly shown on the app-store.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(app-store): Ensure the `groups` property is always an array

If the value was a string, like a single group, then `json_decode` will also yield only a string.
So in this case we ensure the property is always an array with that value.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

chore: Compile assets

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

refactor(Storage): Align all Storage constructors

Signed-off-by: provokateurin <kate@provokateurin.de>

fix(unified-search): Close on second ctrl+f

Also only add the event listener if short-cuts are not disabled for accessibility reasons.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix: $uid type in Encryption stream

As explained by the comment.

Signed-off-by: Louis <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>

build: Show the actual string

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix(entity): Fix mapping of old/sub-types to actually supported database types

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

build: Print RTL limited characters in translation-checker

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48790 from nextcloud/refactor/apps/constructor-property-promotion

Merge pull request #48756 from nextcloud/build/autoloader/remove-noisy-changes

Merge pull request #48799 from nextcloud/fix/people-translation

fix(files_sharing): Add correct context to translation

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48728 from nextcloud/fix/nav-quota-new-design

fix(files): Adjust NavigationQuota for Nextcloud 30 design

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files): Adjust NavigationQuota for Nextcloud 30 design

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #48583 from nextcloud/fix/overide-itip-broker

fix: override iTip Broker to fix several issues

fix: override iTip Broker to fix several issues

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

Merge pull request #48758 from nextcloud/feat/files/chunked-upload-config-capabilities

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files_sharing): Add correct context to translation

This string is extracted in the `files_sharing` app so it needs to be accessed there and not on `files`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(psalm): Fix some newly detected issues

Signed-off-by: provokateurin <kate@provokateurin.de>

refactor(apps): Use constructor property promotion when possible

Signed-off-by: provokateurin <kate@provokateurin.de>

feat(files): Expose chunked upload config via capabilities

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48809 from nextcloud/rakekniven-patch-1

chore(i18n): Improved grammar

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #48812 from nextcloud/bugfix/noid/fix-download-activity-parameters

fix(activity): Fix download activity parameters

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(activity): Fix download activity parameters

Signed-off-by: Joas Schilling <coding@schilljs.com>

chore(i18n): Improved grammar

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>