]>
source.dussan.org Git - nextcloud-server.git/log
Ferdinand Thiessen [Mon, 7 Oct 2024 15:31:39 +0000 (17:31 +0200)]
refactor(files_sharing): Handle access to shares using the direct download endpoint
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Ferdinand Thiessen [Mon, 7 Oct 2024 15:29:57 +0000 (17:29 +0200)]
feat: Allow to pass `Node` to `BeforeDirectFileDownloadEvent`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Ferdinand Thiessen [Mon, 7 Oct 2024 15:18:11 +0000 (17:18 +0200)]
refactor(files_sharing): Move share access handling from controller to event listener
This ensures we catch all share access attempts and not only the controller ones (e.g. when using the zip folder plugin).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Ferdinand Thiessen [Mon, 7 Oct 2024 15:16:34 +0000 (17:16 +0200)]
feat(files_sharing): Add step constants to `ShareLinkAccessedEvent`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
F. E Noel Nfebe [Mon, 7 Oct 2024 14:19:36 +0000 (16:19 +0200)]
Merge pull request #46691 from nextcloud/fix-show-original-owner
feat(sidebar): Show node owner in metadata subline
nextcloud-command [Mon, 7 Oct 2024 13:22:35 +0000 (13:22 +0000)]
chore(assets): Recompile assets
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
fenn-cs [Mon, 22 Jul 2024 16:54:39 +0000 (17:54 +0100)]
feat(sidebar): Show node owner in metadata subline
Resolves: https://github.com/nextcloud/server/issues/46178
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Kate [Mon, 7 Oct 2024 12:37:25 +0000 (14:37 +0200)]
Merge pull request #48487 from nextcloud/refactor/stream-encryption/typings
provokateurin [Tue, 1 Oct 2024 13:55:36 +0000 (15:55 +0200)]
refactor(Wrapper\Encryption): Migrate to strong types
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin [Tue, 1 Oct 2024 13:07:36 +0000 (15:07 +0200)]
refactor(Stream\Encryption): Migrate to strong types
Signed-off-by: provokateurin <kate@provokateurin.de>
Ferdinand Thiessen [Mon, 7 Oct 2024 11:14:23 +0000 (13:14 +0200)]
Merge pull request #48584 from nextcloud/bugfix/noid/increase-exclude-list
fix(config): Mark more app configs sensitive
Joas Schilling [Mon, 7 Oct 2024 11:08:42 +0000 (13:08 +0200)]
Merge pull request #48539 from nextcloud/dependabot/composer/symfony-6.4
build: Bump symfony/* to 6.4
Joas Schilling [Fri, 4 Oct 2024 14:24:22 +0000 (16:24 +0200)]
test(settings): Correctly only return bool for Symfony Input::hasParameterOption calls
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Fri, 4 Oct 2024 14:13:28 +0000 (16:13 +0200)]
fix(message): Fix logic of Mail test
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 2 Oct 2024 22:28:22 +0000 (00:28 +0200)]
fix: Ensure we only pass string to writeln()
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 2 Oct 2024 22:28:07 +0000 (00:28 +0200)]
test: Fix wrongly mocked method
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 2 Oct 2024 22:27:52 +0000 (00:27 +0200)]
test: Fix mock creation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 2 Oct 2024 21:58:31 +0000 (23:58 +0200)]
ci: Fix psalm by typing the QuestionHelper
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 2 Oct 2024 21:58:01 +0000 (23:58 +0200)]
ci: Update psalm-baseline
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 2 Oct 2024 21:41:44 +0000 (23:41 +0200)]
fix(command): Make method compatible with upstream class (requires 3rdparty bump)
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 2 Oct 2024 21:38:05 +0000 (23:38 +0200)]
fix(command): Make method compatible with upstream class (backportable)
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 2 Oct 2024 21:18:52 +0000 (23:18 +0200)]
build: Bump symfony/* to 6.4
Signed-off-by: Joas Schilling <coding@schilljs.com>
Ferdinand Thiessen [Mon, 7 Oct 2024 09:58:34 +0000 (11:58 +0200)]
Merge pull request #48438 from nextcloud/fix/bring-back-zip-event
fix(dav): Emit `BeforeZipCreatedEvent` when creating folder zip archive
Ferdinand Thiessen [Mon, 7 Oct 2024 09:33:07 +0000 (11:33 +0200)]
Merge pull request #47896 from nextcloud/fix/resiliant-user-removal
fix: Make user removal more resilient
Joas Schilling [Mon, 7 Oct 2024 08:58:03 +0000 (10:58 +0200)]
fix(config): Mark more app configs sensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
Nextcloud bot [Mon, 7 Oct 2024 00:19:56 +0000 (00:19 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 6 Oct 2024 00:21:20 +0000 (00:21 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
dependabot[bot] [Sat, 5 Oct 2024 06:21:23 +0000 (06:21 +0000)]
Merge pull request #48574 from nextcloud/dependabot/npm_and_yarn/dompurify-3.1.7
nextcloud-command [Sat, 5 Oct 2024 06:11:26 +0000 (06:11 +0000)]
chore(assets): Recompile assets
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
dependabot[bot] [Sat, 5 Oct 2024 02:29:46 +0000 (02:29 +0000)]
Merge pull request #48576 from nextcloud/dependabot/npm_and_yarn/babel/plugin-transform-private-methods-7.25.7
dependabot[bot] [Sat, 5 Oct 2024 02:16:21 +0000 (02:16 +0000)]
chore(deps-dev): Bump @babel/plugin-transform-private-methods
Bumps [@babel/plugin-transform-private-methods](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-private-methods) from 7.25.4 to 7.25.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.7/packages/babel-plugin-transform-private-methods)
---
updated-dependencies:
- dependency-name: "@babel/plugin-transform-private-methods"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
dependabot[bot] [Sat, 5 Oct 2024 02:14:50 +0000 (02:14 +0000)]
Merge pull request #48573 from nextcloud/dependabot/npm_and_yarn/babel/node-7.25.7
dependabot[bot] [Sat, 5 Oct 2024 01:23:03 +0000 (01:23 +0000)]
chore(deps): Bump dompurify from 3.1.6 to 3.1.7
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.1.6 to 3.1.7.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/3.1.6...3.1.7)
---
updated-dependencies:
- dependency-name: dompurify
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
dependabot[bot] [Sat, 5 Oct 2024 01:22:44 +0000 (01:22 +0000)]
chore(deps-dev): Bump @babel/node from 7.25.0 to 7.25.7
Bumps [@babel/node](https://github.com/babel/babel/tree/HEAD/packages/babel-node) from 7.25.0 to 7.25.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.7/packages/babel-node)
---
updated-dependencies:
- dependency-name: "@babel/node"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Nextcloud bot [Sat, 5 Oct 2024 00:20:17 +0000 (00:20 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Arthur Schiwon [Fri, 4 Oct 2024 18:03:18 +0000 (20:03 +0200)]
Merge pull request #48532 from nextcloud/fix/48437/dont-exclude-user
fix: do not reduce count for subadmins if they are members of group
Robin Appelman [Fri, 4 Oct 2024 14:43:21 +0000 (16:43 +0200)]
Merge pull request #48421 from nextcloud/smb-systembridge
fix: use nc's binary finding logic for smb
Robin Appelman [Fri, 27 Sep 2024 13:41:26 +0000 (15:41 +0200)]
fix: use nc's binary finding logic for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
Nextcloud bot [Fri, 4 Oct 2024 00:20:04 +0000 (00:20 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Ferdinand Thiessen [Thu, 3 Oct 2024 17:04:30 +0000 (19:04 +0200)]
Merge pull request #48440 from nextcloud/refactor/background-service
refactor(theming): Reduce duplicated code in `BackgroundService`
Kate [Thu, 3 Oct 2024 13:48:10 +0000 (15:48 +0200)]
Merge pull request #48522 from nextcloud/fix/querybuilder/output-columns-aliases
Pytal [Thu, 3 Oct 2024 12:28:24 +0000 (05:28 -0700)]
Merge pull request #48543 from nextcloud/fix/themes-layout
fix(theming): Fix layout of themes
Côme Chilliet [Thu, 3 Oct 2024 12:07:55 +0000 (14:07 +0200)]
Merge pull request #48548 from nextcloud/fix/fix-admin-audit-event-listening
fix(admin_audit): Listen to the right events
Joas Schilling [Thu, 3 Oct 2024 10:28:12 +0000 (12:28 +0200)]
Merge pull request #48540 from nextcloud/bugfix/noid/remove-3rdparty-use
fix(filesexternal): Remove unneeded 3rdparty library use
Côme Chilliet [Thu, 3 Oct 2024 08:56:42 +0000 (10:56 +0200)]
fix(admin_audit): Listen to the right events
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Nextcloud bot [Thu, 3 Oct 2024 00:20:34 +0000 (00:20 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
nextcloud-command [Wed, 2 Oct 2024 23:29:56 +0000 (23:29 +0000)]
chore(assets): Recompile assets
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Christopher Ng [Wed, 2 Oct 2024 23:13:43 +0000 (16:13 -0700)]
fix(theming): Fix layout of themes
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Joas Schilling [Wed, 2 Oct 2024 21:27:44 +0000 (23:27 +0200)]
fix(filesexternal): Remove unneeded 3rdparty library use
Signed-off-by: Joas Schilling <coding@schilljs.com>
Maksim Sukharev [Wed, 2 Oct 2024 13:25:19 +0000 (15:25 +0200)]
fix: do not reduce count for subadmins if they are members of group
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Anna [Wed, 2 Oct 2024 13:12:26 +0000 (15:12 +0200)]
Merge pull request #48508 from nextcloud/fix/webcal-subscription-jobs-middleware
fix(caldav): add missing handlers
Sebastian Krupinski [Wed, 2 Oct 2024 13:04:21 +0000 (09:04 -0400)]
Merge pull request #48519 from nextcloud/bug/48518/ignore-invalid-dates
fix(dav): don't crash subscription on invalid calendar object
F. E Noel Nfebe [Wed, 2 Oct 2024 10:03:54 +0000 (12:03 +0200)]
Merge pull request #48486 from nextcloud/chore/48408/rename-twitter-to-x
chore: Move from Twitter to X
provokateurin [Wed, 2 Oct 2024 09:55:27 +0000 (11:55 +0200)]
fix(QueryBuilder): Account for aliases in output columns
Signed-off-by: provokateurin <kate@provokateurin.de>
escoand [Wed, 25 Sep 2024 10:29:12 +0000 (12:29 +0200)]
fix(dav): don't crash subscription on invalid calendar object
Signed-off-by: escoand <escoand@users.noreply.github.com>
Arthur Schiwon [Wed, 2 Oct 2024 09:25:36 +0000 (11:25 +0200)]
Merge pull request #47414 from nextcloud/debt/noid/user-changed-event
test(admin_audit): add test for user management listener
Pytal [Wed, 2 Oct 2024 09:07:50 +0000 (02:07 -0700)]
Merge pull request #48512 from nextcloud/fix/pick-folder-smart-picker
fix(files): Fix folders not being selectable in the smart picker
fenn-cs [Tue, 1 Oct 2024 12:45:07 +0000 (14:45 +0200)]
chore: Move from Twitter to X
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Anna [Wed, 2 Oct 2024 08:35:44 +0000 (10:35 +0200)]
Merge pull request #47788 from nextcloud/feat/add-addressbook-list-command
feat(carddav): add command to list address books
Marcel Klehr [Wed, 2 Oct 2024 07:56:13 +0000 (09:56 +0200)]
Merge pull request #48513 from nextcloud/fix/taskprocessing-manager/php-notice
fix(TaskProcessing\Manager): Don't provoke PHP notice in setTaskResult
Marcel Klehr [Wed, 2 Oct 2024 06:38:20 +0000 (08:38 +0200)]
fix(TaskProcessing\Manager): Don't provoke PHP notice in setTaskResult
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Nextcloud bot [Wed, 2 Oct 2024 00:19:58 +0000 (00:19 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
nextcloud-command [Tue, 1 Oct 2024 23:12:33 +0000 (23:12 +0000)]
chore(assets): Recompile assets
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Christopher Ng [Tue, 1 Oct 2024 22:55:14 +0000 (15:55 -0700)]
fix(files): Fix folders not being selectable in the smart picker
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Julien Veyssier [Tue, 1 Oct 2024 21:42:08 +0000 (23:42 +0200)]
Merge pull request #48496 from nextcloud/enh/noid/taskprocessing-commands-task-errors
[taskprocessing] Add new command to get a task from a task ID
Anna Larch [Mon, 19 Aug 2024 11:28:04 +0000 (13:28 +0200)]
fix(caldav): add missing handlers
Signed-off-by: Anna Larch <anna@nextcloud.com>
Daniel [Tue, 1 Oct 2024 18:41:42 +0000 (20:41 +0200)]
Merge pull request #48451 from nextcloud/bug/noid/federated-addressbook-sync-without-localaddressallowed
fix: make federation address book sync work with allow_local_remote_servers = false
Julien Veyssier [Tue, 1 Oct 2024 15:20:59 +0000 (17:20 +0200)]
feat(taskprocessing): new command to get a task from a task ID, include error_message in list and get commands
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Kate [Tue, 1 Oct 2024 16:19:51 +0000 (18:19 +0200)]
Merge pull request #48426 from nextcloud/jtr/fix-45671
Daniel Kesselberg [Mon, 30 Sep 2024 11:05:19 +0000 (13:05 +0200)]
chore: always execute parse_url in preventLocalAddress
This change should make it easier to spot wrong uses of the HTTP client on development setups where allow_local_remote_servers is usually true.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Daniel Kesselberg [Fri, 27 Sep 2024 17:16:59 +0000 (19:16 +0200)]
fix: make federation address book sync work with allow_local_remote_servers = false
Client.preventLocalAddress expects an absolute URL, which means the base_uri option cannot be used.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Kate [Tue, 1 Oct 2024 14:22:16 +0000 (16:22 +0200)]
Merge pull request #48454 from nextcloud/fix/storage/get-directory-content-return-type
Arthur Schiwon [Tue, 1 Oct 2024 13:47:11 +0000 (15:47 +0200)]
Merge pull request #48484 from nextcloud/fwdport/48445/master
fix(Auth): ignore missing token when trying to set password-unconfirm…
Git'Fellow [Tue, 1 Oct 2024 13:17:52 +0000 (15:17 +0200)]
Merge pull request #48480 from nextcloud/checkColExists
fix(migration): Check if column exits before adding it
Robin Appelman [Tue, 1 Oct 2024 13:11:10 +0000 (15:11 +0200)]
Merge pull request #48235 from nextcloud/readd-object-store-phpunit
test: re-add object store primary storage phpunit tests
Joas Schilling [Tue, 1 Oct 2024 10:28:39 +0000 (12:28 +0200)]
ci: Fix path name
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Tue, 1 Oct 2024 10:24:34 +0000 (12:24 +0200)]
Merge pull request #48483 from nextcloud/ci/noid/execute-psalm-security-on-push
ci: Execute psalm:security on pushes
Arthur Schiwon [Tue, 1 Oct 2024 10:20:20 +0000 (12:20 +0200)]
fix(Auth): ignore missing token when trying to set password-unconfirmable
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Joas Schilling [Tue, 1 Oct 2024 10:07:21 +0000 (12:07 +0200)]
ci: Execute psalm:security on pushes
Signed-off-by: Joas Schilling <coding@schilljs.com>
Daniel [Tue, 1 Oct 2024 08:46:38 +0000 (10:46 +0200)]
Merge pull request #48476 from nextcloud/ci/noid/improve-running-psalm-locally
ci: Don't upload output of normal psalm to GitHub Security section
Git'Fellow [Tue, 1 Oct 2024 06:12:11 +0000 (08:12 +0200)]
fix(migration): Check if column exits before adding it
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
dependabot[bot] [Tue, 1 Oct 2024 05:54:10 +0000 (05:54 +0000)]
Merge pull request #48479 from nextcloud/dependabot/github_actions/github-actions-
aa3137d618
Nextcloud bot [Tue, 1 Oct 2024 00:20:31 +0000 (00:20 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
dependabot[bot] [Mon, 30 Sep 2024 22:35:17 +0000 (22:35 +0000)]
chore(deps): Bump actions/checkout in the github-actions group
Bumps the github-actions group with 1 update: [actions/checkout](https://github.com/actions/checkout).
Updates `actions/checkout` from 4.1.7 to 4.2.0
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/
692973e3d937129bcbf40652eb9f2f61becf3332...
d632683dd7b4114ad314bca15554477dd762a938)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions
...
Signed-off-by: dependabot[bot] <support@github.com>
Joas Schilling [Mon, 30 Sep 2024 22:09:15 +0000 (00:09 +0200)]
ci: Add psalm baseline for security and make CI fail on change
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Mon, 30 Sep 2024 21:57:39 +0000 (23:57 +0200)]
ci: Don't upload output of normal psalm to GitHub Security section
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Mon, 30 Sep 2024 21:53:53 +0000 (23:53 +0200)]
ci: Improve usability of running different psalm modes locally
Signed-off-by: Joas Schilling <coding@schilljs.com>
Daniel [Mon, 30 Sep 2024 21:02:53 +0000 (23:02 +0200)]
Merge pull request #48455 from nextcloud/update-phpdoc-for-folder-get
update docs for Folder.get and call for Folder.nodeExists
Hamza [Mon, 30 Sep 2024 17:20:25 +0000 (19:20 +0200)]
Merge pull request #47846 from nextcloud/fix/provisionApi-status-codes
fix: provision api's status codes
Daniel Kesselberg [Mon, 30 Sep 2024 11:54:40 +0000 (13:54 +0200)]
fix: catch NotPermittedException in Folder.nodeExists
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Daniel Kesselberg [Mon, 30 Sep 2024 11:52:46 +0000 (13:52 +0200)]
docs: Folder.get throws a NotPermittedException exception
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Daniel [Mon, 30 Sep 2024 17:00:04 +0000 (19:00 +0200)]
Merge pull request #48466 from nextcloud/ci/noid/require-up-to-date-psalm-paseline
ci: fail psalm when baseline update required
Kate [Mon, 30 Sep 2024 16:09:24 +0000 (18:09 +0200)]
Merge pull request #48461 from nextcloud/perf/files/chunked-upload-default-100-mib
Daniel Kesselberg [Mon, 30 Sep 2024 16:05:05 +0000 (18:05 +0200)]
ci: fail psalm when baseline update required
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Joas Schilling [Mon, 30 Sep 2024 15:40:30 +0000 (17:40 +0200)]
Merge pull request #48460 from nextcloud/deps/noid/bump-3rdparty-hash
build: Bump 3rdparty hash after empty updates
Hamza Mahjoubi [Mon, 9 Sep 2024 13:08:15 +0000 (15:08 +0200)]
fix: provision api's status codes
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
provokateurin [Mon, 30 Sep 2024 10:45:44 +0000 (12:45 +0200)]
fix(Storage): Fix getDirectoryContent() return type
Signed-off-by: provokateurin <kate@provokateurin.de>
Kate [Mon, 30 Sep 2024 14:46:38 +0000 (16:46 +0200)]
Merge pull request #48453 from nextcloud/fix/psalm/update-baseline
provokateurin [Mon, 30 Sep 2024 14:29:11 +0000 (16:29 +0200)]
perf(files): Adjust default chunk size for chunked upload to 100MiB
Signed-off-by: provokateurin <kate@provokateurin.de>
Joas Schilling [Mon, 30 Sep 2024 13:11:03 +0000 (15:11 +0200)]
build: Bump 3rdparty hash after empty updates
Signed-off-by: Joas Schilling <coding@schilljs.com>