]> source.dussan.org Git - nextcloud-server.git/log
nextcloud-server.git
5 years agoProperly return an int in the getId function of the cache 16686/head
Roeland Jago Douma [Wed, 7 Aug 2019 18:38:42 +0000 (20:38 +0200)]
Properly return an int in the getId function of the cache

fixes #16684

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 7 Aug 2019 02:14:38 +0000 (02:14 +0000)]
[tx-robot] updated from transifex

5 years agoFix ie app menu loading click (#16667)
John Molakvoæ [Tue, 6 Aug 2019 17:58:40 +0000 (19:58 +0200)]
Fix ie app menu loading click (#16667)

Fix ie app menu loading click

5 years agoFix ie app menu loading click 16667/head
John Molakvoæ (skjnldsv) [Tue, 6 Aug 2019 12:37:03 +0000 (14:37 +0200)]
Fix ie app menu loading click

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
5 years agoprevent the server's app-navigation's css to overrule the scop… (#16661)
John Molakvoæ [Tue, 6 Aug 2019 13:37:55 +0000 (15:37 +0200)]
prevent the server's app-navigation's css to overrule the scop… (#16661)

prevent the server's app-navigation's css to overrule the scoped css …

5 years agoprevent the server's app-navigation's css to overrule the scoped css in vue components 16661/head
Marco Ambrosini [Tue, 6 Aug 2019 06:45:19 +0000 (08:45 +0200)]
prevent the server's app-navigation's css to overrule the scoped css in vue components

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 6 Aug 2019 02:14:36 +0000 (02:14 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #16498 from nextcloud/feature/noid/room_metadata
Morris Jobke [Mon, 5 Aug 2019 12:52:45 +0000 (14:52 +0200)]
Merge pull request #16498 from nextcloud/feature/noid/room_metadata

Allow calendar resources/rooms to provide metadata

5 years agoMerge pull request #16639 from nextcloud/feature/noid/new-types
Roeland Jago Douma [Mon, 5 Aug 2019 12:21:12 +0000 (14:21 +0200)]
Merge pull request #16639 from nextcloud/feature/noid/new-types

Adding comparaison types: +regex +wildcard (fulltextsearch)

5 years agoMerge pull request #16643 from nextcloud/enh/moreDIUsage
Morris Jobke [Mon, 5 Aug 2019 10:55:52 +0000 (12:55 +0200)]
Merge pull request #16643 from nextcloud/enh/moreDIUsage

Lets use DI where we can

5 years agoMerge pull request #16649 from nextcloud/dependabot/npm_and_yarn/nextcloud-vue-collec...
Roeland Jago Douma [Mon, 5 Aug 2019 06:48:25 +0000 (08:48 +0200)]
Merge pull request #16649 from nextcloud/dependabot/npm_and_yarn/nextcloud-vue-collections-0.5.6

Bump nextcloud-vue-collections from 0.5.4 to 0.5.6

5 years agoBump nextcloud-vue-collections from 0.5.4 to 0.5.6 16649/head
dependabot-preview[bot] [Sun, 4 Aug 2019 20:55:47 +0000 (20:55 +0000)]
Bump nextcloud-vue-collections from 0.5.4 to 0.5.6

Bumps [nextcloud-vue-collections](https://github.com/juliushaertl/nextcloud-vue-collections) from 0.5.4 to 0.5.6.
- [Release notes](https://github.com/juliushaertl/nextcloud-vue-collections/releases)
- [Commits](https://github.com/juliushaertl/nextcloud-vue-collections/compare/v0.5.4...v0.5.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 5 Aug 2019 02:14:26 +0000 (02:14 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #16651 from nextcloud/dependabot/npm_and_yarn/webpack-4.39.1
Roeland Jago Douma [Sun, 4 Aug 2019 20:48:37 +0000 (22:48 +0200)]
Merge pull request #16651 from nextcloud/dependabot/npm_and_yarn/webpack-4.39.1

Bump webpack from 4.38.0 to 4.39.1

5 years agoBump webpack from 4.38.0 to 4.39.1 16651/head
dependabot-preview[bot] [Sun, 4 Aug 2019 01:13:41 +0000 (01:13 +0000)]
Bump webpack from 4.38.0 to 4.39.1

Bumps [webpack](https://github.com/webpack/webpack) from 4.38.0 to 4.39.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.38.0...v4.39.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 4 Aug 2019 02:15:22 +0000 (02:15 +0000)]
[tx-robot] updated from transifex

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 3 Aug 2019 02:14:32 +0000 (02:14 +0000)]
[tx-robot] updated from transifex

5 years agoLets use DI where we can 16643/head
Roeland Jago Douma [Fri, 2 Aug 2019 18:43:50 +0000 (20:43 +0200)]
Lets use DI where we can

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoAdd standard metadata key for room-features 16498/head
Georg Ehrke [Fri, 2 Aug 2019 18:01:32 +0000 (20:01 +0200)]
Add standard metadata key for room-features

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
5 years agocomparaison types: +regex +wildcard 16639/head
Maxence Lange [Fri, 2 Aug 2019 13:24:32 +0000 (12:24 -0100)]
comparaison types: +regex +wildcard

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
5 years agoMerge pull request #16525 from nextcloud/bugfix/external-user-substitution
blizzz [Fri, 2 Aug 2019 12:07:39 +0000 (14:07 +0200)]
Merge pull request #16525 from nextcloud/bugfix/external-user-substitution

files_external: proper user context for sharing

5 years agofix check for null 16525/head
Arthur Schiwon [Fri, 2 Aug 2019 11:09:38 +0000 (13:09 +0200)]
fix check for null

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
5 years agoAdjust tests
Julius Härtl [Thu, 25 Jul 2019 07:58:54 +0000 (09:58 +0200)]
Adjust tests

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years agofixes terminology and allows to request an IUser instance
Arthur Schiwon [Thu, 25 Jul 2019 15:57:22 +0000 (17:57 +0200)]
fixes terminology and allows to request an IUser instance

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
5 years agoadjusts LDAP's home handler to use the correct user object
Arthur Schiwon [Thu, 25 Jul 2019 15:58:13 +0000 (17:58 +0200)]
adjusts LDAP's home handler to use the correct user object

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
5 years agodo not send null value when string is expected
Arthur Schiwon [Thu, 25 Jul 2019 16:50:28 +0000 (18:50 +0200)]
do not send null value when string is expected

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
5 years agoProvide proper user context from initMountPoints
Julius Härtl [Thu, 25 Jul 2019 07:31:39 +0000 (09:31 +0200)]
Provide proper user context from initMountPoints

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years agofiles_external: Make sure the correct user context is used in substitution of variables
Julius Härtl [Wed, 24 Jul 2019 09:53:53 +0000 (11:53 +0200)]
files_external: Make sure the correct user context is used in substitution of variables

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 2 Aug 2019 02:14:30 +0000 (02:14 +0000)]
[tx-robot] updated from transifex

5 years agoAllow to do a principal property search based on metadata keys
Georg Ehrke [Thu, 1 Aug 2019 16:37:50 +0000 (18:37 +0200)]
Allow to do a principal property search based on metadata keys

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
5 years agoProvide standard metadata keys for contact person of a resource
Georg Ehrke [Thu, 1 Aug 2019 13:26:11 +0000 (15:26 +0200)]
Provide standard metadata keys for contact person of a resource

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
5 years agoProvide standard metadata keys for location of room
Georg Ehrke [Thu, 1 Aug 2019 13:25:43 +0000 (15:25 +0200)]
Provide standard metadata keys for location of room

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
5 years agoTest resource and room principal backend to check that they provide metadata
Georg Ehrke [Thu, 1 Aug 2019 13:05:53 +0000 (15:05 +0200)]
Test resource and room principal backend to check that they provide metadata

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
5 years agoMerge pull request #16624 from nextcloud/bugfix/noid/versions-fetch-owner-only
Roeland Jago Douma [Thu, 1 Aug 2019 13:00:24 +0000 (15:00 +0200)]
Merge pull request #16624 from nextcloud/bugfix/noid/versions-fetch-owner-only

Make sure we only fetch the file by id for the actual owner

5 years agoMerge pull request #16622 from nextcloud/design/scrollbar
John Molakvoæ [Thu, 1 Aug 2019 12:57:14 +0000 (14:57 +0200)]
Merge pull request #16622 from nextcloud/design/scrollbar

Standardize scrollbar color and width across Webkit and Firefox

5 years agoTest sync of resource and room metadata
Georg Ehrke [Thu, 1 Aug 2019 12:03:34 +0000 (14:03 +0200)]
Test sync of resource and room metadata

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
5 years agoMerge pull request #16586 from nextcloud/feature/16585_adminAuditShareCirclesRemotel...
Roeland Jago Douma [Thu, 1 Aug 2019 10:35:26 +0000 (12:35 +0200)]
Merge pull request #16586 from nextcloud/feature/16585_adminAuditShareCirclesRemotel/wiswedel

log circles and remote shares in admin_audit

5 years agolog circles and remote shares in admin_audit 16586/head
Sascha Wiswedel [Sun, 28 Jul 2019 12:16:43 +0000 (14:16 +0200)]
log circles and remote shares in admin_audit

Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
5 years agoMerge pull request #16592 from nextcloud/bugfix/noid/federated-reshare
Roeland Jago Douma [Thu, 1 Aug 2019 08:55:35 +0000 (10:55 +0200)]
Merge pull request #16592 from nextcloud/bugfix/noid/federated-reshare

Fix permission check on incoming federated shares

5 years agoMake sure we only fetch the file by id for the actual owner 16624/head
Julius Härtl [Thu, 1 Aug 2019 08:10:49 +0000 (10:10 +0200)]
Make sure we only fetch the file by id for the actual owner

Otherwise this will fetch all mounts for the file id which is quite
expensive and causes long saving times in big sharing structures

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years agosync metadata of rooms / resources with cache
Georg Ehrke [Mon, 29 Jul 2019 13:39:43 +0000 (15:39 +0200)]
sync metadata of rooms / resources with cache

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
5 years agoprovide room / resource properties as principal properties
Georg Ehrke [Fri, 26 Jul 2019 12:50:16 +0000 (14:50 +0200)]
provide room / resource properties as principal properties

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
5 years agoadd oc_calendar_resources_md and oc_calendar_rooms_md tables
Georg Ehrke [Thu, 25 Jul 2019 12:09:39 +0000 (14:09 +0200)]
add oc_calendar_resources_md and oc_calendar_rooms_md tables

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
5 years agoAdd \OCP\Calendar\IMetadataProvider interface and provider for common metadata keys
Georg Ehrke [Mon, 22 Jul 2019 09:36:26 +0000 (11:36 +0200)]
Add \OCP\Calendar\IMetadataProvider interface and provider for common metadata keys

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 1 Aug 2019 02:15:27 +0000 (02:15 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #16618 from nextcloud/enh/csp/form-action
Roeland Jago Douma [Wed, 31 Jul 2019 17:41:52 +0000 (19:41 +0200)]
Merge pull request #16618 from nextcloud/enh/csp/form-action

Add form-action CSP element

5 years agoStandardize scrollbar color and width across Webkit and Firefox 16622/head
Jan-Christoph Borchardt [Tue, 30 Jul 2019 14:39:37 +0000 (16:39 +0200)]
Standardize scrollbar color and width across Webkit and Firefox

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
5 years agoUpdate CSP test cases to handle the new form-action 16618/head
Roeland Jago Douma [Wed, 31 Jul 2019 07:03:33 +0000 (09:03 +0200)]
Update CSP test cases to handle the new form-action

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoAdd form-action CSP element
Roeland Jago Douma [Tue, 30 Jul 2019 21:13:46 +0000 (23:13 +0200)]
Add form-action CSP element

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoFix permission check on incoming federated shares 16592/head
Julius Härtl [Mon, 29 Jul 2019 13:00:07 +0000 (15:00 +0200)]
Fix permission check on incoming federated shares

Since federated shares have their permissions set on the node, we do not need
to check for parent share permissions. Otherwise reshares of incoming federated
have no permission variable defined and creating them will fail

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years agoMerge pull request #16619 from nextcloud/bugfix/16446/theming-url-validate
Roeland Jago Douma [Wed, 31 Jul 2019 10:52:19 +0000 (12:52 +0200)]
Merge pull request #16619 from nextcloud/bugfix/16446/theming-url-validate

Validate urls in theming settings and properly handle error messages

5 years agoMerge pull request #16544 from nextcloud/bugfix/16540
Roeland Jago Douma [Wed, 31 Jul 2019 09:02:20 +0000 (11:02 +0200)]
Merge pull request #16544 from nextcloud/bugfix/16540

Add missing password reset page to vue

5 years agoMerge pull request #16616 from nextcloud/dep/setEvalScript
Roeland Jago Douma [Wed, 31 Jul 2019 09:01:38 +0000 (11:01 +0200)]
Merge pull request #16616 from nextcloud/dep/setEvalScript

setting unsafe-eval is deprecated

5 years agoValidate urls in theming settings and properly handle error messages 16619/head
Julius Härtl [Wed, 31 Jul 2019 08:05:46 +0000 (10:05 +0200)]
Validate urls in theming settings and properly handle error messages

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years agoMove actual password reset to vue 16544/head
Julius Härtl [Thu, 25 Jul 2019 15:04:33 +0000 (17:04 +0200)]
Move actual password reset to vue

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 31 Jul 2019 02:16:00 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

5 years agosetting unsafe-eval is deprecated 16616/head
Roeland Jago Douma [Tue, 30 Jul 2019 14:27:38 +0000 (16:27 +0200)]
setting unsafe-eval is deprecated

This will be removed in a future version of Nextcloud.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoMerge pull request #16594 from nextcloud/tech-debt/noid/remove-unused-checkPasswordPr...
Joas Schilling [Tue, 30 Jul 2019 07:58:38 +0000 (09:58 +0200)]
Merge pull request #16594 from nextcloud/tech-debt/noid/remove-unused-checkPasswordProtectedShare

Remove unused OC\Share\Share::checkPasswordProtectedShare

5 years agoMerge pull request #16599 from nextcloud/fix/xss/on-favorite-file
Roeland Jago Douma [Tue, 30 Jul 2019 07:51:45 +0000 (09:51 +0200)]
Merge pull request #16599 from nextcloud/fix/xss/on-favorite-file

Fix/xss/on favorite file

5 years agoMerge pull request #16593 from nextcloud/fix/noid/more-precise-error-message
Roeland Jago Douma [Tue, 30 Jul 2019 06:55:28 +0000 (08:55 +0200)]
Merge pull request #16593 from nextcloud/fix/noid/more-precise-error-message

More precise error message when expected filesize does not match

5 years agoMerge pull request #16579 from nextcloud/enh/PostLoginEvent
Roeland Jago Douma [Tue, 30 Jul 2019 06:54:10 +0000 (08:54 +0200)]
Merge pull request #16579 from nextcloud/enh/PostLoginEvent

Add proper PostLoginEvent

5 years agoMerge pull request #16596 from nextcloud/bugfix/noid/vtooltip-defaults
Roeland Jago Douma [Tue, 30 Jul 2019 06:43:10 +0000 (08:43 +0200)]
Merge pull request #16596 from nextcloud/bugfix/noid/vtooltip-defaults

Set proper defaults for v-tooltip usages

5 years agoMerge pull request #16595 from nextcloud/tech-debt/noid/no-need-to-document-the-obvious
Roeland Jago Douma [Tue, 30 Jul 2019 06:42:31 +0000 (08:42 +0200)]
Merge pull request #16595 from nextcloud/tech-debt/noid/no-need-to-document-the-obvious

Do not document the obvious

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 30 Jul 2019 02:14:45 +0000 (02:14 +0000)]
[tx-robot] updated from transifex

5 years agoBump bundles 16596/head
Julius Härtl [Mon, 29 Jul 2019 13:55:14 +0000 (15:55 +0200)]
Bump bundles

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years agoForce defaultHtml setting of v-tooltip to be disabled
Julius Härtl [Mon, 29 Jul 2019 13:51:08 +0000 (15:51 +0200)]
Force defaultHtml setting of v-tooltip to be disabled

Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years agoprevent potential XSS via unchecked use innerHTML 16599/head
Max Fichtelmann [Mon, 29 Jul 2019 15:48:33 +0000 (17:48 +0200)]
prevent potential XSS via unchecked use innerHTML

Signed-off-by: Max Fichtelmann <max.fichtelmann@procilon.de>
5 years agofix XSS when adding a file with a malicious name to favorites
Max Fichtelmann [Mon, 29 Jul 2019 15:44:01 +0000 (17:44 +0200)]
fix XSS when adding a file with a malicious name to favorites

Signed-off-by: Max Fichtelmann <max.fichtelmann@procilon.de>
5 years agoMerge pull request #16502 from nextcloud/bugfix/16474
Morris Jobke [Mon, 29 Jul 2019 14:59:26 +0000 (16:59 +0200)]
Merge pull request #16502 from nextcloud/bugfix/16474

Check the if we can actually access the storage cache for recent files

5 years agoMerge pull request #16591 from nextcloud/fix/noid/typo-in-comment
Morris Jobke [Mon, 29 Jul 2019 14:54:29 +0000 (16:54 +0200)]
Merge pull request #16591 from nextcloud/fix/noid/typo-in-comment

Fix typo in comment

5 years agoUpdate tests 16579/head
Roeland Jago Douma [Sun, 28 Jul 2019 18:46:01 +0000 (20:46 +0200)]
Update tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoAdd proper PostLoginEvent
Roeland Jago Douma [Sat, 27 Jul 2019 10:56:27 +0000 (12:56 +0200)]
Add proper PostLoginEvent

This can be used by othr mechanisms to listen for this event in a lazy
fashion.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoDo not document the obvious 16595/head
Morris Jobke [Mon, 29 Jul 2019 13:25:53 +0000 (15:25 +0200)]
Do not document the obvious

This removes PHPDoc that is already available as source code type hints.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
5 years agoRemove unused OC\Share\Share::checkPasswordProtectedShare 16594/head
Morris Jobke [Mon, 29 Jul 2019 13:23:21 +0000 (15:23 +0200)]
Remove unused OC\Share\Share::checkPasswordProtectedShare

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
5 years agoMore precise error message when expected filesize does not match - could be on readin... 16593/head
Morris Jobke [Mon, 29 Jul 2019 13:03:01 +0000 (15:03 +0200)]
More precise error message when expected filesize does not match - could be on reading or writing side

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
5 years agoFix typo in comment 16591/head
Morris Jobke [Mon, 29 Jul 2019 12:55:43 +0000 (14:55 +0200)]
Fix typo in comment

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
5 years agoMerge pull request #16582 from nextcloud/enh/split_up_security_middleware
Roeland Jago Douma [Mon, 29 Jul 2019 10:13:55 +0000 (12:13 +0200)]
Merge pull request #16582 from nextcloud/enh/split_up_security_middleware

Split up security middleware

5 years agoMerge pull request #16563 from nextcloud/enh/lostcontroller/better_exceptions
Morris Jobke [Mon, 29 Jul 2019 08:42:36 +0000 (10:42 +0200)]
Merge pull request #16563 from nextcloud/enh/lostcontroller/better_exceptions

Use proper exception in lostController

5 years agoMerge pull request #16581 from nextcloud/dep/strict_csps_can_go
Roeland Jago Douma [Mon, 29 Jul 2019 08:40:38 +0000 (10:40 +0200)]
Merge pull request #16581 from nextcloud/dep/strict_csps_can_go

No need to have these classes we tighten the default CSP from time to time

5 years agoMerge pull request #16570 from nextcloud/enh/supress_touch_error
Roeland Jago Douma [Mon, 29 Jul 2019 08:39:46 +0000 (10:39 +0200)]
Merge pull request #16570 from nextcloud/enh/supress_touch_error

Supress warnings touch can generate

5 years agoMerge pull request #16571 from nextcloud/enh/update_preview_controller
Morris Jobke [Mon, 29 Jul 2019 08:35:08 +0000 (10:35 +0200)]
Merge pull request #16571 from nextcloud/enh/update_preview_controller

Update PreviewController

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 29 Jul 2019 02:14:59 +0000 (02:14 +0000)]
[tx-robot] updated from transifex

5 years agoMerge pull request #16573 from nextcloud/fix-default-timeouts-in-oc-notification
Roeland Jago Douma [Sun, 28 Jul 2019 18:57:31 +0000 (20:57 +0200)]
Merge pull request #16573 from nextcloud/fix-default-timeouts-in-oc-notification

Fix default timeouts in OC.Notification

5 years agoMerge pull request #16583 from nextcloud/dependabot/npm_and_yarn/webpack-4.38.0
Roeland Jago Douma [Sun, 28 Jul 2019 08:49:02 +0000 (10:49 +0200)]
Merge pull request #16583 from nextcloud/dependabot/npm_and_yarn/webpack-4.38.0

Bump webpack from 4.36.1 to 4.38.0

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 28 Jul 2019 02:15:26 +0000 (02:15 +0000)]
[tx-robot] updated from transifex

5 years agoBump webpack from 4.36.1 to 4.38.0 16583/head
dependabot-preview[bot] [Sun, 28 Jul 2019 01:13:42 +0000 (01:13 +0000)]
Bump webpack from 4.36.1 to 4.38.0

Bumps [webpack](https://github.com/webpack/webpack) from 4.36.1 to 4.38.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.36.1...v4.38.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
5 years agoUse proper exception in lostController 16563/head
Roeland Jago Douma [Fri, 26 Jul 2019 13:21:41 +0000 (15:21 +0200)]
Use proper exception in lostController

There is no need to log the expcetion of most of the stuff here.
We should properly log them but an exception is excessive.

This moves it to a proper exception which we can catch and then log.
The other exceptions will still be fully logged.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoSplit up security middleware 16582/head
Roeland Jago Douma [Sat, 27 Jul 2019 14:04:51 +0000 (16:04 +0200)]
Split up security middleware

With upcoming work for the feature policy header. Splitting this in
smaller classes that just do 1 thing makes sense.

I rather have a few small classes that are tiny and do 1 thing right
(and we all understand what is going on) than have big ones.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoNo need to have these classes we tighten the default CSP from time to 16581/head
Roeland Jago Douma [Sat, 27 Jul 2019 12:59:48 +0000 (14:59 +0200)]
No need to have these classes we tighten the default CSP from time to
time

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoMerge pull request #16560 from nextcloud/bugfix/noid/fix_cutype_reporting
Roeland Jago Douma [Sat, 27 Jul 2019 10:23:25 +0000 (12:23 +0200)]
Merge pull request #16560 from nextcloud/bugfix/noid/fix_cutype_reporting

fix calendar-user-type reporting

5 years agoMerge pull request #16558 from nextcloud/enh/less_verbose_locked_logging
Roeland Jago Douma [Sat, 27 Jul 2019 08:39:11 +0000 (10:39 +0200)]
Merge pull request #16558 from nextcloud/enh/less_verbose_locked_logging

Do not log all locked exceptions

5 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 27 Jul 2019 02:14:37 +0000 (02:14 +0000)]
[tx-robot] updated from transifex

5 years agoAdd unit tests for "OC.Notification.hide()" 16573/head
Daniel Calviño Sánchez [Fri, 26 Jul 2019 16:29:00 +0000 (18:29 +0200)]
Add unit tests for "OC.Notification.hide()"

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
5 years agoFix default timeouts in OC.Notification
Daniel Calviño Sánchez [Fri, 26 Jul 2019 16:00:07 +0000 (18:00 +0200)]
Fix default timeouts in OC.Notification

When no timeout was given "show()" used the default timeout of
"OCP.Toast", which is 7 seconds instead of indefinitely as stated in the
documentation of "show()". "showHtml()" should also indefinitely show
the notification if no timeout is given, but due to the strict
comparison the notification was indefinitely shown only when a timeout
of 0 was explicitly given. Now both methods show the notification
indefinitely (or until it is explicitly hidden) when no timeout is
given.

The unit tests did not catch this error because "showHtml()" had no
tests (as before the move to Toastify it was called from "show()" and
thus implicitly tested), and because "show()" verified that "hide()" was
not called after some time; "hide()" is no longer called from "show()"
since "OCP.Toast" is used internally, so the test always passed even if
the notification was indeed hidden. Now the test is based on whether the
element is found or not, and explicit tests were added too for
"showHtml()".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
5 years agoFix mixed test for "show" and "showTemporary"
Daniel Calviño Sánchez [Fri, 26 Jul 2019 15:49:58 +0000 (17:49 +0200)]
Fix mixed test for "show" and "showTemporary"

"showTemporary()" when a timeout was given was being tested along with
the "show()" tests; now there are two separate tests when a timeout is
given, one for "showTemporary()" and one for "show()".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
5 years agoCheck number of elements instead of if the jQuery object is defined
Daniel Calviño Sánchez [Fri, 26 Jul 2019 15:40:44 +0000 (17:40 +0200)]
Check number of elements instead of if the jQuery object is defined

Tje jQuery object created through "$('#testArea .toastify')" will be
always defined even if no elements were found, so the check does not
really work; instead, it should be checked the number of elements found.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
5 years agoUpdate PreviewController 16571/head
Roeland Jago Douma [Fri, 26 Jul 2019 15:37:11 +0000 (17:37 +0200)]
Update PreviewController

The constructor is called with the userId. However if a user is not
logged in this is null. Which means that we get an exception instead of
this being handled gracefully in the middleware.

There are cleaner solutions. But this is the solution that is the
easiest to apply without lots of work and risk of breaking things
(handling the logged in middleware before initializing the controller
etc).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoSupress warnings touch can generate 16570/head
Roeland Jago Douma [Fri, 26 Jul 2019 15:26:59 +0000 (17:26 +0200)]
Supress warnings touch can generate

We already catch the result value. Having the warning being logged
explicitly doesn't help and polutes the log.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
5 years agoMerge pull request #16556 from nextcloud/feature/16554_adminAuditShareByMail/wiswedel
Morris Jobke [Fri, 26 Jul 2019 14:14:47 +0000 (16:14 +0200)]
Merge pull request #16556 from nextcloud/feature/16554_adminAuditShareByMail/wiswedel

log email shares in admin_audit log

5 years agoMerge pull request #16557 from nextcloud/enh/do_not_log_locked_files
Morris Jobke [Fri, 26 Jul 2019 13:44:52 +0000 (15:44 +0200)]
Merge pull request #16557 from nextcloud/enh/do_not_log_locked_files

Do not log locked files