]> source.dussan.org Git - nextcloud-server.git/log
nextcloud-server.git
4 years agoAllow for compression of the PROPFIND responses 20272/head
Roeland Jago Douma [Thu, 2 Apr 2020 13:17:04 +0000 (15:17 +0200)]
Allow for compression of the PROPFIND responses

For now it just gzip and only for propfind (the 99% case). Already saves
a bunch since the propfinds compress so nicely.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years agoMerge pull request #21253 from nextcloud/bugfix/noid/fix-psr4-namespace
Roeland Jago Douma [Sat, 6 Jun 2020 07:30:26 +0000 (09:30 +0200)]
Merge pull request #21253 from nextcloud/bugfix/noid/fix-psr4-namespace

Fix PSR-4 namespace

4 years agoMerge pull request #21254 from nextcloud/td/js/remove/_capabilities
Roeland Jago Douma [Sat, 6 Jun 2020 07:30:04 +0000 (09:30 +0200)]
Merge pull request #21254 from nextcloud/td/js/remove/_capabilities

Actually remove _capabilities

4 years agoMerge pull request #21257 from nextcloud/td/js/systemtags_linter
Roeland Jago Douma [Sat, 6 Jun 2020 07:29:42 +0000 (09:29 +0200)]
Merge pull request #21257 from nextcloud/td/js/systemtags_linter

Fix linting on systemtags and use @nextcloud/router

4 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 6 Jun 2020 02:16:00 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoFix linting on systemtags and use @nextcloud/router 21257/head
Roeland Jago Douma [Fri, 5 Jun 2020 14:26:58 +0000 (16:26 +0200)]
Fix linting on systemtags and use @nextcloud/router

Makes the linter happy. And thus me a bit happy since it now is
complaining less.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years agoActually remove _capabilities 21254/head
Roeland Jago Douma [Fri, 5 Jun 2020 13:23:00 +0000 (15:23 +0200)]
Actually remove _capabilities

Leftover from a previous PR.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years agoFix PSR-4 namespace 21253/head
Joas Schilling [Fri, 5 Jun 2020 13:11:57 +0000 (15:11 +0200)]
Fix PSR-4 namespace

Signed-off-by: Joas Schilling <coding@schilljs.com>
4 years agoMerge pull request #21240 from nextcloud/enh/theming/js_to_initial_state
Roeland Jago Douma [Fri, 5 Jun 2020 11:39:41 +0000 (13:39 +0200)]
Merge pull request #21240 from nextcloud/enh/theming/js_to_initial_state

Move theming js to initial state

4 years agoMerge pull request #21246 from nextcloud/enh/js/maintenance_no_oc_import
Roeland Jago Douma [Fri, 5 Jun 2020 11:01:17 +0000 (13:01 +0200)]
Merge pull request #21246 from nextcloud/enh/js/maintenance_no_oc_import

Do not import the full OC since we don't need it

4 years agoMerge pull request #21197 from nextcloud/bugfix/noid/app-screenshots
Roeland Jago Douma [Fri, 5 Jun 2020 11:01:02 +0000 (13:01 +0200)]
Merge pull request #21197 from nextcloud/bugfix/noid/app-screenshots

Check if screenshot is available before showing it

4 years agoMove theming js to initial state 21240/head
Roeland Jago Douma [Thu, 4 Jun 2020 14:31:36 +0000 (16:31 +0200)]
Move theming js to initial state

A bit more elegant. Plus it will allow us to also write a proper
@nextcloud/theming package. To make life easier down the line for all.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years agoCheck if screenshot is available before showing it 21197/head
Julius Härtl [Wed, 3 Jun 2020 06:42:06 +0000 (08:42 +0200)]
Check if screenshot is available before showing it

Signed-off-by: Julius Härtl <jus@bitgrid.net>
4 years agoDo not import the full OC since we don't need it 21246/head
Roeland Jago Douma [Fri, 5 Jun 2020 06:48:28 +0000 (08:48 +0200)]
Do not import the full OC since we don't need it

Import what we need. Saves off a bunch of bytes of the bundle (600
kilobytes to be exact)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years agoMerge pull request #21225 from nextcloud/techdebt/humanfilesize-getcanonicallocale...
Roeland Jago Douma [Fri, 5 Jun 2020 07:02:50 +0000 (09:02 +0200)]
Merge pull request #21225 from nextcloud/techdebt/humanfilesize-getcanonicallocale-package

Move humanFileSize and OC.getCanonicalLocale to npm packages

4 years agoMerge pull request #21229 from nextcloud/fix-empty-event-reminder-notifications
Roeland Jago Douma [Fri, 5 Jun 2020 07:02:01 +0000 (09:02 +0200)]
Merge pull request #21229 from nextcloud/fix-empty-event-reminder-notifications

Fix empty event UUID reminder notifications

4 years agoMove humanFileSize and OC.getCanonicalLocale to npm packages 21225/head
Christoph Wurst [Thu, 4 Jun 2020 08:52:03 +0000 (10:52 +0200)]
Move humanFileSize and OC.getCanonicalLocale to npm packages

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 5 Jun 2020 02:16:34 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoMerge pull request #20914 from nextcloud/enh/deprecated_event_log_usage
Roeland Jago Douma [Thu, 4 Jun 2020 17:19:02 +0000 (19:19 +0200)]
Merge pull request #20914 from nextcloud/enh/deprecated_event_log_usage

Log usage of a deprecated event instead of emitting

4 years agoMerge pull request #21232 from nextcloud/bug/20427/use-OC-CLI-instead-of-PHP-SAPI
Roeland Jago Douma [Thu, 4 Jun 2020 17:03:54 +0000 (19:03 +0200)]
Merge pull request #21232 from nextcloud/bug/20427/use-OC-CLI-instead-of-PHP-SAPI

Use \OC::$CLI instead of PHP_SAPI

4 years agoMerge pull request #21165 from nextcloud/dependabot/npm_and_yarn/babel/plugin-proposa...
Roeland Jago Douma [Thu, 4 Jun 2020 17:03:30 +0000 (19:03 +0200)]
Merge pull request #21165 from nextcloud/dependabot/npm_and_yarn/babel/plugin-proposal-class-properties-7.10.1

Bump @babel/plugin-proposal-class-properties from 7.8.3 to 7.10.1

4 years agoMerge pull request #21191 from nextcloud/td/js/use_router
Roeland Jago Douma [Thu, 4 Jun 2020 17:01:19 +0000 (19:01 +0200)]
Merge pull request #21191 from nextcloud/td/js/use_router

OC.routing is just a @nextcloud/routing proxy

4 years agoUse \OC::$CLI instead of PHP_SAPI 21232/head
Thomas Citharel [Thu, 4 Jun 2020 09:31:09 +0000 (11:31 +0200)]
Use \OC::$CLI instead of PHP_SAPI

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
4 years agoFix empty event UUID reminder notifications 21229/head
Thomas Citharel [Thu, 4 Jun 2020 09:08:20 +0000 (11:08 +0200)]
Fix empty event UUID reminder notifications

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
4 years agoOC.routing is just a @nextcloud/routing proxy 21191/head
Roeland Jago Douma [Tue, 2 Jun 2020 12:09:27 +0000 (14:09 +0200)]
OC.routing is just a @nextcloud/routing proxy

So lets kill the duplicate code!

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years agoMerge pull request #21199 from nextcloud/bugfix/noid/prevent-harder-sharing-your...
Joas Schilling [Thu, 4 Jun 2020 08:59:22 +0000 (10:59 +0200)]
Merge pull request #21199 from nextcloud/bugfix/noid/prevent-harder-sharing-your-root

Prevent harder to share your root

4 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 4 Jun 2020 02:16:24 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoMerge pull request #20938 from nextcloud/fix/share-talk-verification
Christoph Wurst [Wed, 3 Jun 2020 13:47:54 +0000 (15:47 +0200)]
Merge pull request #20938 from nextcloud/fix/share-talk-verification

Fix the Talk verification

4 years agoBump @babel/plugin-proposal-class-properties from 7.8.3 to 7.10.1 21165/head
dependabot-preview[bot] [Wed, 3 Jun 2020 13:31:38 +0000 (13:31 +0000)]
Bump @babel/plugin-proposal-class-properties from 7.8.3 to 7.10.1

Bumps [@babel/plugin-proposal-class-properties](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-proposal-class-properties) from 7.8.3 to 7.10.1.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.10.1/packages/babel-plugin-proposal-class-properties)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
4 years agoMerge pull request #21168 from nextcloud/dependabot/npm_and_yarn/babel/preset-env...
Roeland Jago Douma [Wed, 3 Jun 2020 13:29:20 +0000 (15:29 +0200)]
Merge pull request #21168 from nextcloud/dependabot/npm_and_yarn/babel/preset-env-7.10.2

Bump @babel/preset-env from 7.9.6 to 7.10.2

4 years agoPrevent harder to share your root 21199/head
Joas Schilling [Wed, 3 Jun 2020 07:29:19 +0000 (09:29 +0200)]
Prevent harder to share your root

Signed-off-by: Joas Schilling <coding@schilljs.com>
4 years agoBump @babel/preset-env from 7.9.6 to 7.10.2 21168/head
dependabot-preview[bot] [Wed, 3 Jun 2020 11:13:11 +0000 (11:13 +0000)]
Bump @babel/preset-env from 7.9.6 to 7.10.2

Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.9.6 to 7.10.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.10.2/packages/babel-preset-env)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
4 years agoMerge pull request #21166 from nextcloud/dependabot/npm_and_yarn/babel/core-7.10.2
Roeland Jago Douma [Wed, 3 Jun 2020 11:10:51 +0000 (13:10 +0200)]
Merge pull request #21166 from nextcloud/dependabot/npm_and_yarn/babel/core-7.10.2

Bump @babel/core from 7.9.6 to 7.10.2

4 years agoMerge pull request #21167 from nextcloud/dependabot/npm_and_yarn/vue-router-3.3.2
Roeland Jago Douma [Wed, 3 Jun 2020 11:10:10 +0000 (13:10 +0200)]
Merge pull request #21167 from nextcloud/dependabot/npm_and_yarn/vue-router-3.3.2

Bump vue-router from 3.2.0 to 3.3.2

4 years agoMerge pull request #21091 from nextcloud/sftp-normalize-path
Joas Schilling [Wed, 3 Jun 2020 10:17:38 +0000 (12:17 +0200)]
Merge pull request #21091 from nextcloud/sftp-normalize-path

normalize sftp path in read and write stream

4 years agoMerge pull request #21181 from nextcloud/fix/remote-share-remove-error-handling
Christoph Wurst [Wed, 3 Jun 2020 09:11:47 +0000 (11:11 +0200)]
Merge pull request #21181 from nextcloud/fix/remote-share-remove-error-handling

Do not only catch Exceptions but any Throwable during rmt share delete

4 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 3 Jun 2020 02:16:18 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoMerge pull request #21190 from nextcloud/td/js/linter
Roeland Jago Douma [Tue, 2 Jun 2020 14:02:07 +0000 (16:02 +0200)]
Merge pull request #21190 from nextcloud/td/js/linter

Fix some linter warning

4 years agoFix some linter warning 21190/head
Roeland Jago Douma [Tue, 2 Jun 2020 12:00:55 +0000 (14:00 +0200)]
Fix some linter warning

Part of my ongoing battle against deprecation messages.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
4 years agoBump vue-router from 3.2.0 to 3.3.2 21167/head
dependabot-preview[bot] [Tue, 2 Jun 2020 11:37:46 +0000 (11:37 +0000)]
Bump vue-router from 3.2.0 to 3.3.2

Bumps [vue-router](https://github.com/vuejs/vue-router) from 3.2.0 to 3.3.2.
- [Release notes](https://github.com/vuejs/vue-router/releases)
- [Changelog](https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-router/compare/v3.2.0...v3.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
4 years agoMerge pull request #21164 from nextcloud/dependabot/npm_and_yarn/nextcloud/dialogs...
Roeland Jago Douma [Tue, 2 Jun 2020 11:34:48 +0000 (13:34 +0200)]
Merge pull request #21164 from nextcloud/dependabot/npm_and_yarn/nextcloud/dialogs-1.3.1

Bump @nextcloud/dialogs from 1.3.0 to 1.3.1

4 years agoDo not only catch Exceptions but any Throwable during rmt share delete 21181/head
Christoph Wurst [Tue, 2 Jun 2020 07:21:09 +0000 (09:21 +0200)]
Do not only catch Exceptions but any Throwable during rmt share delete

When a remote share is deleted, we notify the remove instance. This may
trigger various error conditions, which we want to catch in order to
avoid undeletable shares. The try-catch, however, did only capture
exceptions, so things like TypeErrors were not caught and caused the
process to fail hard.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Tue, 2 Jun 2020 02:16:02 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoRestore previous state when failing to change video verification state 20938/head
Daniel Calviño Sánchez [Mon, 1 Jun 2020 16:27:20 +0000 (18:27 +0200)]
Restore previous state when failing to change video verification state

When video verification can not be enabled or disabled the previous
state is set again in the JavaScript share object. This ensures that the
UI will not reflect a misleading state.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoFix the Talk verification
Christoph Wurst [Tue, 12 May 2020 09:57:30 +0000 (11:57 +0200)]
Fix the Talk verification

When enabling or disabling Talk verification in mail shares the server
expects also a new password to be set. As we always just update one
property at a time this means the Talk verification was impossible to
activate or deactivate. With this patch, we send the talk option AND the
new password. If there is no new password, the Talk option is disabled
(in mail shares; in link shares it is possible to enable or disable the
video verification without changing the password).

When we finally have descriptive text on ActionCheckbox'es we should
definitely add some explanatory text for the user. Right now this is as
good as it gets.

We'll have to backport to 18.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 1 Jun 2020 02:16:00 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoBump @nextcloud/dialogs from 1.3.0 to 1.3.1 21164/head
dependabot-preview[bot] [Sun, 31 May 2020 01:17:49 +0000 (01:17 +0000)]
Bump @nextcloud/dialogs from 1.3.0 to 1.3.1

Bumps [@nextcloud/dialogs](https://github.com/nextcloud/nextcloud-dialogs) from 1.3.0 to 1.3.1.
- [Release notes](https://github.com/nextcloud/nextcloud-dialogs/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-dialogs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-dialogs/compare/v1.3.0...v1.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 31 May 2020 02:16:19 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoBump @babel/core from 7.9.6 to 7.10.2 21166/head
dependabot-preview[bot] [Sun, 31 May 2020 01:19:06 +0000 (01:19 +0000)]
Bump @babel/core from 7.9.6 to 7.10.2

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.9.6 to 7.10.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.10.2/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
4 years agoMerge pull request #21155 from nextcloud/td/move_to_capabilities_package
Roeland Jago Douma [Sat, 30 May 2020 06:58:19 +0000 (08:58 +0200)]
Merge pull request #21155 from nextcloud/td/move_to_capabilities_package

Move to @nextcloud/capabilities package

4 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 30 May 2020 02:16:04 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoMerge pull request #21154 from nextcloud/fix/file_info_load_order
Morris Jobke [Fri, 29 May 2020 19:32:15 +0000 (21:32 +0200)]
Merge pull request #21154 from nextcloud/fix/file_info_load_order

Fix the loading order of the js files_info and files_client

4 years agoMerge pull request #21156 from nextcloud/do-not-clone-the-whole-talk-repository-for...
Morris Jobke [Fri, 29 May 2020 19:31:35 +0000 (21:31 +0200)]
Merge pull request #21156 from nextcloud/do-not-clone-the-whole-talk-repository-for-integration-tests

Do not clone the whole Talk repository for integration tests

4 years agoDo not clone the whole Talk repository for integration tests 21156/head
Daniel Calviño Sánchez [Fri, 29 May 2020 15:02:03 +0000 (17:02 +0200)]
Do not clone the whole Talk repository for integration tests

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoMerge pull request #21141 from nextcloud/fix/require-ext-pdo-composer
Roeland Jago Douma [Fri, 29 May 2020 14:39:59 +0000 (16:39 +0200)]
Merge pull request #21141 from nextcloud/fix/require-ext-pdo-composer

List ext-pdo as hard requirement for composer

4 years agoMove to @nextcloud/capabilities package 21155/head
Roeland Jago Douma [Fri, 29 May 2020 14:02:30 +0000 (16:02 +0200)]
Move to @nextcloud/capabilities package

And kill of oc_capabilities and _oc_capabilities globals

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years agoFix the loading order of the js files_info and files_client 21154/head
Roeland Jago Douma [Fri, 29 May 2020 13:43:45 +0000 (15:43 +0200)]
Fix the loading order of the js files_info and files_client

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years agoMerge pull request #20970 from nextcloud/td/js/escape-html-global
Roeland Jago Douma [Fri, 29 May 2020 11:36:55 +0000 (13:36 +0200)]
Merge pull request #20970 from nextcloud/td/js/escape-html-global

Remove the escape-html global

4 years agoMerge pull request #21143 from nextcloud/fix-password-changes-in-link-and-mail-shares
Roeland Jago Douma [Fri, 29 May 2020 11:36:09 +0000 (13:36 +0200)]
Merge pull request #21143 from nextcloud/fix-password-changes-in-link-and-mail-shares

Fix password changes in link and mail shares

4 years agoRemove the escape-html global 20970/head
Roeland Jago Douma [Thu, 14 May 2020 09:38:03 +0000 (11:38 +0200)]
Remove the escape-html global

Already announced for 19 that it would go. So now it realy does go.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
4 years agoMerge pull request #21118 from nextcloud/td/move_systemtags
Roeland Jago Douma [Fri, 29 May 2020 07:14:25 +0000 (09:14 +0200)]
Merge pull request #21118 from nextcloud/td/move_systemtags

Move systemtags to a proper location

4 years agoMerge pull request #21146 from nextcloud/fix-reference-to-wrong-class-name
Roeland Jago Douma [Fri, 29 May 2020 06:46:23 +0000 (08:46 +0200)]
Merge pull request #21146 from nextcloud/fix-reference-to-wrong-class-name

Fix reference to wrong class name

4 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 29 May 2020 02:16:30 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoAdd integration tests for video verification 21143/head
Daniel Calviño Sánchez [Thu, 28 May 2020 18:53:36 +0000 (20:53 +0200)]
Add integration tests for video verification

Enabling the "send password by Talk" property of shares require that
Talk is installed and enabled, so the Drone step that runs them has to
first clone the Talk repository.

When the integration tests are run on a local development instance,
however, it is not guaranteed that Talk is installed. Due to this the
"@Talk" tag was added, which ensures that any feature or scenario marked
with it will first check if Talk is installed and, if not, skip the
scenario (instead of failing).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoAdd integration tests for creating and updating a mail share
Daniel Calviño Sánchez [Thu, 28 May 2020 18:52:11 +0000 (20:52 +0200)]
Add integration tests for creating and updating a mail share

In most cases, when a mail share is created or updated an e-mail is sent
to the sharee, which is done by connecting to the SMTP server set in the
configuration. If the server can not be contacted then the creation or
update of the mail share fails.

To make possible to test mail shares without using a real SMTP server a
fake one has been added. The original script, which is MIT licensed, was
based on inetd, so it was slightly modified to run on its own.

In order to use it from the integration tests the "Given dummy mail
server is listening" step has to be called in the scenarios in which the
mail server is needed.

For now that is the only available step; things like checking the sent
mails, while possible (as the script can log the mails to certain file),
have not been added yet.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoGeneralize integration test steps to download last share
Daniel Calviño Sánchez [Thu, 28 May 2020 18:50:02 +0000 (20:50 +0200)]
Generalize integration test steps to download last share

Note that the "last link share can be downloaded" step was kept as it
tests the "url" property specific of link shares.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoRemove unused variables
Daniel Calviño Sánchez [Thu, 28 May 2020 18:46:33 +0000 (20:46 +0200)]
Remove unused variables

The step names were adjusted accordingly.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoFix disabling send password by Talk without new password in mail shares
Daniel Calviño Sánchez [Thu, 28 May 2020 18:40:33 +0000 (20:40 +0200)]
Fix disabling send password by Talk without new password in mail shares

When "send password by Talk" was disabled in a mail share it was
possible to keep the same password as before, as it does not pose any
security issue (unlike keeping it when "send password by Talk" is
enabled, as in that case the password was already disclosed by mail).

However, if a mail share is updated but the password is not set again
only the hashed password will be available. In that case it would not
make sense to send the password by mail, so now the password must be
changed when disabling "send password by Talk".

Note that, even if explicitly setting the same password again along with
the "send password by Talk" property would work, this was also prevented
for simplicity.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoFix reference to wrong class name 21146/head
Daniel Calviño Sánchez [Thu, 28 May 2020 23:41:06 +0000 (01:41 +0200)]
Fix reference to wrong class name

\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoMerge pull request #21140 from nextcloud/enhancement/oc-get-all-apps-return-type-doc
Morris Jobke [Thu, 28 May 2020 20:37:35 +0000 (22:37 +0200)]
Merge pull request #21140 from nextcloud/enhancement/oc-get-all-apps-return-type-doc

Document \OC_App::getAllApps return type

4 years agoFix enabling send password by Talk with same password in mail shares
Daniel Calviño Sánchez [Thu, 28 May 2020 18:37:18 +0000 (20:37 +0200)]
Fix enabling send password by Talk with same password in mail shares

When "send password by Talk" is enabled in a mail share a new password
must be also set. However, when the passwords of the original and the
new share were compared it was not taken into account that the original
password is now hashed, while the new one is not (unless no new password
was sent, in which case the password of the original share was set in
the new share by the controller, but that was already prevented due to
both passwords being literally the same), so it was possible to set the
same password again.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoFix enabling send password by Talk with empty password in link shares
Daniel Calviño Sánchez [Thu, 28 May 2020 18:29:28 +0000 (20:29 +0200)]
Fix enabling send password by Talk with empty password in link shares

When "send password by Talk" is enabled in a link share now a non empty
password is enforced.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoFix creating a mail share with a password
Daniel Calviño Sánchez [Thu, 28 May 2020 18:27:33 +0000 (20:27 +0200)]
Fix creating a mail share with a password

When a mail share was created with a password the given password was not
hashed, so it was not possible to open the share with that password.
Moreover, if passwords were enforced the given password was ignored and
a new one was set (although in this case it was hashed so it worked as
expected). Now the given password is properly hashed and not overriden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoExtend mail shares unit tests to check the password and mail template
Daniel Calviño Sánchez [Thu, 28 May 2020 18:26:00 +0000 (20:26 +0200)]
Extend mail shares unit tests to check the password and mail template

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
4 years agoMove the systemtags to core/src 21118/head
Roeland Jago Douma [Tue, 26 May 2020 19:56:40 +0000 (21:56 +0200)]
Move the systemtags to core/src

* Move to the handlebar loader from webpack

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
4 years agoList ext-pdo as hard requirement for composer 21141/head
Christoph Wurst [Thu, 28 May 2020 18:43:50 +0000 (20:43 +0200)]
List ext-pdo as hard requirement for composer

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years agoDocument \OC_App::getAllApps return type 21140/head
Christoph Wurst [Thu, 28 May 2020 18:37:24 +0000 (20:37 +0200)]
Document \OC_App::getAllApps return type

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years agoMerge pull request #20597 from nextcloud/enh/lazy_node_events 21179/head
Roeland Jago Douma [Thu, 28 May 2020 12:15:59 +0000 (14:15 +0200)]
Merge pull request #20597 from nextcloud/enh/lazy_node_events

Add lazy events for the Node API

4 years agoMerge pull request #21124 from nextcloud/feature/20612/add-capability-for-file-comments
Roeland Jago Douma [Thu, 28 May 2020 12:13:48 +0000 (14:13 +0200)]
Merge pull request #21124 from nextcloud/feature/20612/add-capability-for-file-comments

Add a capability when file comments are enabled

4 years agoAdd a capability when file comments are enabled 21124/head
Joas Schilling [Wed, 27 May 2020 13:14:40 +0000 (15:14 +0200)]
Add a capability when file comments are enabled

Signed-off-by: Joas Schilling <coding@schilljs.com>
4 years agoAdd lazy events for the Node API 20597/head
Roeland Jago Douma [Wed, 22 Apr 2020 13:21:15 +0000 (15:21 +0200)]
Add lazy events for the Node API

Right now if you want to get events via the Node API you have to have a
real instance of the Root. Which in turns sets up the whole FS.

We should make sure this is done lazy. Else enabling the preview
generator for example makes you setup the whole FS on each and every
authenticated call.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 28 May 2020 02:16:38 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoMerge pull request #21122 from nextcloud/enhancement/auth-token-exception-reporting
Roeland Jago Douma [Wed, 27 May 2020 17:37:22 +0000 (19:37 +0200)]
Merge pull request #21122 from nextcloud/enhancement/auth-token-exception-reporting

Improve traces of invalid token exceptions

4 years agoMerge pull request #21123 from nextcloud/fix/noid/fix-retrieval-of-groups
Roeland Jago Douma [Wed, 27 May 2020 17:36:49 +0000 (19:36 +0200)]
Merge pull request #21123 from nextcloud/fix/noid/fix-retrieval-of-groups

simplify getGroups, fixing wrong chunking logic

4 years agoMerge pull request #21112 from nextcloud/techdebt/noid/remove-db-prefix
Joas Schilling [Wed, 27 May 2020 14:19:38 +0000 (16:19 +0200)]
Merge pull request #21112 from nextcloud/techdebt/noid/remove-db-prefix

Remove db prefix option from cli install command

4 years agoMerge pull request #20976 from nextcloud/fix/make-translation-sanitization-optional
Christoph Wurst [Wed, 27 May 2020 13:47:28 +0000 (15:47 +0200)]
Merge pull request #20976 from nextcloud/fix/make-translation-sanitization-optional

Make the translation sanitization optional

4 years agoFix devices & sessions sanitization 20976/head
Christoph Wurst [Thu, 14 May 2020 13:37:50 +0000 (15:37 +0200)]
Fix devices & sessions sanitization

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years agoMake the translation sanitization optional
Christoph Wurst [Thu, 14 May 2020 13:03:45 +0000 (15:03 +0200)]
Make the translation sanitization optional

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years agosimplify getGroups, fixing wrong chunking logic 21123/head
Arthur Schiwon [Wed, 27 May 2020 12:41:10 +0000 (14:41 +0200)]
simplify getGroups, fixing wrong chunking logic

pagination is taken care of properly in the search logic in Access class

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
4 years agoMerge pull request #21079 from nextcloud/dependabot/npm_and_yarn/moment-2.26.0
Roeland Jago Douma [Wed, 27 May 2020 10:55:50 +0000 (12:55 +0200)]
Merge pull request #21079 from nextcloud/dependabot/npm_and_yarn/moment-2.26.0

Bump moment from 2.25.3 to 2.26.0

4 years agoMerge pull request #21117 from nextcloud/design/text-variables-simplify
Morris Jobke [Wed, 27 May 2020 08:50:43 +0000 (10:50 +0200)]
Merge pull request #21117 from nextcloud/design/text-variables-simplify

Simplify text variables from 4 to 2, map -lighter to -maxcontrast

4 years agoLog why a token is not valid during password check 21122/head
Christoph Wurst [Wed, 27 May 2020 07:58:44 +0000 (09:58 +0200)]
Log why a token is not valid during password check

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years agoImprove traces of invalid token exceptions
Christoph Wurst [Wed, 27 May 2020 07:21:47 +0000 (09:21 +0200)]
Improve traces of invalid token exceptions

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 27 May 2020 02:16:10 +0000 (02:16 +0000)]
[tx-robot] updated from transifex

4 years agoSimplify text variables from 4 to 2, map -lighter to -maxcontrast 21117/head
Jan-Christoph Borchardt [Thu, 7 May 2020 09:46:25 +0000 (11:46 +0200)]
Simplify text variables from 4 to 2, map -lighter to -maxcontrast

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
4 years agoBump moment from 2.25.3 to 2.26.0 21079/head
dependabot-preview[bot] [Mon, 25 May 2020 18:50:09 +0000 (18:50 +0000)]
Bump moment from 2.25.3 to 2.26.0

Bumps [moment](https://github.com/moment/moment) from 2.25.3 to 2.26.0.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.25.3...2.26.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
4 years agoMerge pull request #21106 from nextcloud/fix/10809/user-pwd-change-loginname
Roeland Jago Douma [Tue, 26 May 2020 19:18:57 +0000 (21:18 +0200)]
Merge pull request #21106 from nextcloud/fix/10809/user-pwd-change-loginname

use the loginname to verify the old password in user password changes

4 years agoRemove the prefix setting attempt from our CI 21112/head
Joas Schilling [Tue, 26 May 2020 14:56:41 +0000 (16:56 +0200)]
Remove the prefix setting attempt from our CI

Signed-off-by: Joas Schilling <coding@schilljs.com>
4 years agouse the loginname to verify the old password in user password changes 21106/head
Arthur Schiwon [Mon, 25 May 2020 21:00:00 +0000 (23:00 +0200)]
use the loginname to verify the old password in user password changes

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
4 years agoRemove db prefix option from cli install command
Joas Schilling [Tue, 26 May 2020 12:10:39 +0000 (14:10 +0200)]
Remove db prefix option from cli install command

Signed-off-by: Joas Schilling <coding@schilljs.com>