]>
source.dussan.org Git - nextcloud-server.git/log
dependabot-preview[bot] [Sat, 27 Jun 2020 01:18:16 +0000 (01:18 +0000)]
Bump exports-loader from 1.0.1 to 1.1.0
Bumps [exports-loader](https://github.com/webpack-contrib/exports-loader) from 1.0.1 to 1.1.0.
- [Release notes](https://github.com/webpack-contrib/exports-loader/releases)
- [Changelog](https://github.com/webpack-contrib/exports-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/exports-loader/compare/v1.0.1...v1.1.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Roeland Jago Douma [Thu, 25 Jun 2020 08:03:32 +0000 (10:03 +0200)]
Merge pull request #21582 from nextcloud/bugfix/noid/extend-description-on-trusted-servers
Extend descriptioon on trusted servers
Roeland Jago Douma [Thu, 25 Jun 2020 08:03:11 +0000 (10:03 +0200)]
Merge pull request #21576 from nextcloud/fix/21464/types
fix strings being passed where arrays where expected
Roeland Jago Douma [Thu, 25 Jun 2020 07:59:42 +0000 (09:59 +0200)]
Merge pull request #21412 from nextcloud/bugfix/21363/fix-robots-noindex
Fix robots noindex signals
Joas Schilling [Thu, 25 Jun 2020 07:07:14 +0000 (09:07 +0200)]
Extend descriptioon on trusted servers
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Mon, 15 Jun 2020 11:50:30 +0000 (13:50 +0200)]
Fix robots "noindex, nofollow" signals
Signed-off-by: Joas Schilling <coding@schilljs.com>
Nextcloud bot [Thu, 25 Jun 2020 02:16:42 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
Arthur Schiwon [Wed, 24 Jun 2020 21:34:37 +0000 (23:34 +0200)]
fix strings being passed where arrays where expected
also brought type hints up to internal API level
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Roeland Jago Douma [Wed, 24 Jun 2020 19:20:17 +0000 (21:20 +0200)]
Merge pull request #21379 from nextcloud/fix-share-permission-checkboxes-enabled-when-permissions-can-not-be-set
Fix share permission checkboxes enabled when permissions can not be set
Roeland Jago Douma [Wed, 24 Jun 2020 19:07:23 +0000 (21:07 +0200)]
Merge pull request #21508 from nextcloud/dependabot/npm_and_yarn/exports-loader-1.0.1
Bump exports-loader from 0.7.0 to 1.0.1
Roeland Jago Douma [Wed, 24 Jun 2020 19:05:07 +0000 (21:05 +0200)]
Merge pull request #21558 from nextcloud/part-file-rename-mask
relax permissions mask check for detecting part file rename
Roeland Jago Douma [Wed, 24 Jun 2020 19:03:52 +0000 (21:03 +0200)]
Merge pull request #21565 from nextcloud/fix/noid/fix-comment
comment was wrong, block is needed nevertheless
Joas Schilling [Wed, 24 Jun 2020 17:29:01 +0000 (19:29 +0200)]
Merge pull request #21562 from nextcloud/techdebt/noid/update-share-type-constant-usage
Update share type constant usage
blizzz [Wed, 24 Jun 2020 16:58:23 +0000 (18:58 +0200)]
Merge pull request #21564 from nextcloud/fix/noid/no-ocdialogs
fix obsolete usage of OCdialogs
Joas Schilling [Wed, 24 Jun 2020 16:11:20 +0000 (18:11 +0200)]
Fix tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
Arthur Schiwon [Wed, 24 Jun 2020 15:51:11 +0000 (17:51 +0200)]
comment was wrong, block is needed nevertheless
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Arthur Schiwon [Wed, 24 Jun 2020 15:34:00 +0000 (17:34 +0200)]
fix obsolete usage of OCdialogs
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Joas Schilling [Wed, 24 Jun 2020 15:09:01 +0000 (17:09 +0200)]
Merge pull request #21563 from nextcloud/update/create_dev_env
Update link for set up new dev env
GretaD [Wed, 24 Jun 2020 14:50:29 +0000 (16:50 +0200)]
Update link to set up new dev env
Signed-off-by: GretaD <gretadoci@gmail.com>
Joas Schilling [Wed, 24 Jun 2020 14:49:16 +0000 (16:49 +0200)]
Update share type constant usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
Christoph Wurst [Wed, 24 Jun 2020 13:38:03 +0000 (15:38 +0200)]
Merge pull request #20916 from nextcloud/feature/unified-search-api
Add unified search API
Christoph Wurst [Mon, 22 Jun 2020 10:19:34 +0000 (12:19 +0200)]
Migrate comments to unified search API
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Christoph Wurst [Mon, 22 Jun 2020 08:57:40 +0000 (10:57 +0200)]
Deprecate \OCP\ISearch
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Christoph Wurst [Wed, 17 Jun 2020 08:29:50 +0000 (10:29 +0200)]
Implement unified search for Files
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Christoph Wurst [Mon, 11 May 2020 08:35:54 +0000 (10:35 +0200)]
Add unified search API
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Joas Schilling [Wed, 24 Jun 2020 11:55:31 +0000 (13:55 +0200)]
Merge pull request #21525 from nextcloud/techdebt/noid/contacts-manager
Techdebt fix contacts manager
Roeland Jago Douma [Wed, 24 Jun 2020 11:42:52 +0000 (13:42 +0200)]
Merge pull request #21530 from nextcloud/bugfix/noid/s3-dir-mtime
Remove rescanDelay from directory mtime
Robin Appelman [Thu, 11 Jun 2020 12:22:59 +0000 (14:22 +0200)]
relax permissions mask check for detecting part file rename
with files drop uploads the original file name isn't always used for the '.ocTransferId' source path
Signed-off-by: Robin Appelman <robin@icewind.nl>
Julius Härtl [Wed, 24 Jun 2020 09:35:49 +0000 (11:35 +0200)]
Bump bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Julius Härtl [Wed, 24 Jun 2020 09:20:15 +0000 (11:20 +0200)]
Fix export for davclient.js legacy dependency
Signed-off-by: Julius Härtl <jus@bitgrid.net>
dependabot-preview[bot] [Mon, 22 Jun 2020 14:17:48 +0000 (14:17 +0000)]
Bump exports-loader from 0.7.0 to 1.0.1
Bumps [exports-loader](https://github.com/webpack-contrib/exports-loader) from 0.7.0 to 1.0.1.
- [Release notes](https://github.com/webpack-contrib/exports-loader/releases)
- [Changelog](https://github.com/webpack-contrib/exports-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/exports-loader/compare/v0.7.0...v1.0.1)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Roeland Jago Douma [Wed, 24 Jun 2020 07:02:40 +0000 (09:02 +0200)]
Merge pull request #21548 from nextcloud/bug/21519/add-appstoreurl-to-config
Add appstoreurl to config.sample.php.
Nextcloud bot [Wed, 24 Jun 2020 02:16:44 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
blizzz [Tue, 23 Jun 2020 21:27:13 +0000 (23:27 +0200)]
Merge pull request #21535 from nextcloud/bugfix/noid/backportable-wrong-language-in-share-note-email
Fix language in share notes email for users
Daniel Kesselberg [Tue, 23 Jun 2020 20:11:55 +0000 (22:11 +0200)]
Add appstoreurl to config.sample.php.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Joas Schilling [Tue, 23 Jun 2020 06:14:27 +0000 (08:14 +0200)]
Fix language in share notes email for users
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Tue, 23 Jun 2020 20:00:22 +0000 (22:00 +0200)]
Merge pull request #21545 from nextcloud/bugfix/noid/fix-dark-theme-for-guests
Fix dark mode for guests
Joas Schilling [Tue, 23 Jun 2020 18:55:38 +0000 (20:55 +0200)]
Merge pull request #21546 from nextcloud/techdebt/noid/make-annotations-case-insensitive
Make annotations case insensitive
Joas Schilling [Tue, 23 Jun 2020 18:18:38 +0000 (20:18 +0200)]
Unify settings middleware with others
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Tue, 23 Jun 2020 18:18:23 +0000 (20:18 +0200)]
Make annotations case insensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Tue, 23 Jun 2020 17:54:41 +0000 (19:54 +0200)]
Fix dark mode for guests
Signed-off-by: Joas Schilling <coding@schilljs.com>
Christoph Wurst [Tue, 23 Jun 2020 16:51:50 +0000 (18:51 +0200)]
Merge pull request #21524 from nextcloud/enhancement/files-bootstrap
Migrate Files to the new bootstrap mechanism
Joas Schilling [Tue, 23 Jun 2020 12:02:17 +0000 (14:02 +0200)]
Merge pull request #21452 from nextcloud/bugfix/21451/allow-autocomplete-by-displayname-again
Fix autocomplete for LDAP with `shareapi_only_share_with_group_members` on
Nextcloud bot [Tue, 23 Jun 2020 02:17:10 +0000 (02:17 +0000)]
[tx-robot] updated from transifex
Joas Schilling [Mon, 22 Jun 2020 13:56:11 +0000 (15:56 +0200)]
Merge pull request #21366 from nextcloud/feature/noid/respect-prefers-color-scheme
Respect "prefers-color-scheme" media selector for guests
Julius Härtl [Mon, 22 Jun 2020 12:15:42 +0000 (14:15 +0200)]
Remove rescanDelay from directory mtime
Signed-off-by: Julius Härtl <jus@bitgrid.net>
blizzz [Mon, 22 Jun 2020 11:00:12 +0000 (13:00 +0200)]
Merge pull request #21479 from nextcloud/fix/21474/allow_specifying_cookie_type
Allow to specify the cookie type for appframework responses
blizzz [Mon, 22 Jun 2020 09:18:50 +0000 (11:18 +0200)]
Merge pull request #21475 from nextcloud/enh/noid/flow-event-dispatcher
flow to not use deprecated event dispatcher methods
Joas Schilling [Mon, 22 Jun 2020 09:10:44 +0000 (11:10 +0200)]
More imports
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Mon, 22 Jun 2020 09:09:32 +0000 (11:09 +0200)]
Fix code style
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Mon, 22 Jun 2020 09:08:23 +0000 (11:08 +0200)]
Fix undefined class "IAddressbook" on docs
Signed-off-by: Joas Schilling <coding@schilljs.com>
Roeland Jago Douma [Mon, 22 Jun 2020 08:31:19 +0000 (10:31 +0200)]
Merge pull request #21510 from nextcloud/fix/unit_test/responsetest
Fix unit test of the ResponseTest
Christoph Wurst [Wed, 17 Jun 2020 08:16:53 +0000 (10:16 +0200)]
Migrate Files to the new bootstrap mechanism
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Joas Schilling [Mon, 22 Jun 2020 06:46:24 +0000 (08:46 +0200)]
Merge pull request #21478 from nextcloud/bugfix/noid/clarify-email-is-always-shared-in-the-instance
Clarify that the email is always shared within the instance
Roeland Jago Douma [Fri, 19 Jun 2020 07:31:47 +0000 (09:31 +0200)]
Allow to specify the cookie type for appframework responses
In general it is good to set them to Lax. But also to give devs more
control over them is not a bad thing.
Helps with #21474
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Roeland Jago Douma [Mon, 22 Jun 2020 06:29:50 +0000 (08:29 +0200)]
Merge pull request #21506 from nextcloud/dependabot/npm_and_yarn/moment-2.27.0
Bump moment from 2.26.0 to 2.27.0
Roeland Jago Douma [Sun, 21 Jun 2020 07:44:56 +0000 (09:44 +0200)]
Fix unit test of the ResponseTest
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
dependabot-preview[bot] [Sun, 21 Jun 2020 07:05:36 +0000 (07:05 +0000)]
Bump moment from 2.26.0 to 2.27.0
Bumps [moment](https://github.com/moment/moment) from 2.26.0 to 2.27.0.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.26.0...2.27.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Roeland Jago Douma [Sun, 21 Jun 2020 07:16:27 +0000 (09:16 +0200)]
Merge pull request #21492 from nextcloud/fix/noid/branch-for-cloning-acceptance-related-apps
acceptence tests shall specify which branch to pick when cloning apps
Roeland Jago Douma [Sun, 21 Jun 2020 07:03:03 +0000 (09:03 +0200)]
Merge pull request #21507 from nextcloud/dependabot/npm_and_yarn/babel/core-7.10.3
Bump @babel/core from 7.10.2 to 7.10.3
Roeland Jago Douma [Sun, 21 Jun 2020 07:02:39 +0000 (09:02 +0200)]
Merge pull request #21505 from nextcloud/dependabot/npm_and_yarn/babel/preset-env-7.10.3
Bump @babel/preset-env from 7.10.2 to 7.10.3
Roeland Jago Douma [Sun, 21 Jun 2020 07:02:06 +0000 (09:02 +0200)]
Merge pull request #21504 from nextcloud/dependabot/npm_and_yarn/webpack-cli-3.3.12
Bump webpack-cli from 3.3.11 to 3.3.12
Nextcloud bot [Sun, 21 Jun 2020 02:16:08 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
dependabot-preview[bot] [Sun, 21 Jun 2020 01:19:35 +0000 (01:19 +0000)]
Bump @babel/core from 7.10.2 to 7.10.3
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.10.2 to 7.10.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.10.3/packages/babel-core)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
dependabot-preview[bot] [Sun, 21 Jun 2020 01:17:20 +0000 (01:17 +0000)]
Bump @babel/preset-env from 7.10.2 to 7.10.3
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.10.2 to 7.10.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.10.3/packages/babel-preset-env)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
dependabot-preview[bot] [Sun, 21 Jun 2020 01:16:48 +0000 (01:16 +0000)]
Bump webpack-cli from 3.3.11 to 3.3.12
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.3.11 to 3.3.12.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/v3.3.12/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/v3.3.11...v3.3.12)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Roeland Jago Douma [Sat, 20 Jun 2020 14:23:01 +0000 (16:23 +0200)]
Merge pull request #21467 from nextcloud/enhancement/dav-bootstrap
Move DAV to the new bootstrap mechanism
Nextcloud bot [Sat, 20 Jun 2020 02:16:35 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
Arthur Schiwon [Thu, 18 Jun 2020 23:16:53 +0000 (01:16 +0200)]
flow to not use deprecated event dispatcher methods
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Roeland Jago Douma [Fri, 19 Jun 2020 19:28:29 +0000 (21:28 +0200)]
Merge pull request #21469 from nextcloud/bugfix/noid/event-service-listener-registration
Fix event service listener registration
Roeland Jago Douma [Fri, 19 Jun 2020 19:26:26 +0000 (21:26 +0200)]
Merge pull request #21483 from nextcloud/fix/scss/timeout
Give up after 10 seconds in SCSS timeout
Arthur Schiwon [Fri, 19 Jun 2020 18:59:34 +0000 (20:59 +0200)]
acceptence tests shall specify which branch to pick when cloning apps
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz [Fri, 19 Jun 2020 18:01:06 +0000 (20:01 +0200)]
Merge pull request #21421 from nextcloud/fix/noid/cached-missing-dn
getXbyY can still return false, e.g. when using ldap write support
Christoph Wurst [Thu, 18 Jun 2020 11:28:22 +0000 (13:28 +0200)]
Move DAV to the new bootstrap mechanism
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Joas Schilling [Fri, 19 Jun 2020 13:09:24 +0000 (15:09 +0200)]
Merge pull request #21482 from nextcloud/bugfix/noid/dont-log-keys
Don't log Keys
Roeland Jago Douma [Fri, 19 Jun 2020 12:39:31 +0000 (14:39 +0200)]
Give up after 10 seconds in SCSS timeout
Else we keep idling for ages which leads to bad UX
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Joas Schilling [Fri, 19 Jun 2020 11:44:27 +0000 (13:44 +0200)]
Don't log Keys
Signed-off-by: Joas Schilling <coding@schilljs.com>
Roeland Jago Douma [Fri, 19 Jun 2020 09:22:44 +0000 (11:22 +0200)]
Merge pull request #21457 from nextcloud/enhancement/crash-reporters-registration-boostrap
Allow crash reporters registration during app bootstrap
Christoph Wurst [Wed, 17 Jun 2020 13:17:59 +0000 (15:17 +0200)]
Allow crash reporters registration during app bootstrap
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Joas Schilling [Fri, 19 Jun 2020 07:12:23 +0000 (09:12 +0200)]
Clarify that the email is always shared within the instance
Signed-off-by: Joas Schilling <coding@schilljs.com>
Nextcloud bot [Fri, 19 Jun 2020 02:16:27 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
Joas Schilling [Thu, 18 Jun 2020 13:00:19 +0000 (15:00 +0200)]
Fix event service listener registration
Signed-off-by: Joas Schilling <coding@schilljs.com>
Christoph Wurst [Thu, 18 Jun 2020 11:33:38 +0000 (13:33 +0200)]
Merge pull request #21463 from nextcloud/fix/continue-not-return-register-exception
Continue with next app when one errors during register
Joas Schilling [Thu, 18 Jun 2020 09:33:43 +0000 (11:33 +0200)]
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
Christoph Wurst [Thu, 18 Jun 2020 07:17:00 +0000 (09:17 +0200)]
Continue with next app when one errors during register
My patch at #21461 had a little error in that it exits the method when a
query exception is encountered during the register step of an app. What
we actually want is to continue with the next app and finish the overall
registration procedure.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Roeland Jago Douma [Thu, 18 Jun 2020 06:59:45 +0000 (08:59 +0200)]
Merge pull request #21461 from nextcloud/fix/catch-app-register-boot-exceptions
Catch all exceptions when an app is registering or booting
Roeland Jago Douma [Thu, 18 Jun 2020 06:30:16 +0000 (08:30 +0200)]
Merge pull request #21442 from nextcloud/td/js/accessibilityjs_to_initialstate
Move accessibility js route to static js and initial state
Nextcloud bot [Thu, 18 Jun 2020 02:16:35 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
Christoph Wurst [Wed, 17 Jun 2020 19:07:42 +0000 (21:07 +0200)]
Catch all exceptions when an app is registering or booting
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Roeland Jago Douma [Tue, 16 Jun 2020 19:54:20 +0000 (21:54 +0200)]
Move accessibility js route to static js and initial state
Yet again another js file that doesn't have to be served via nextcloud.
But can just be done via the webbrowser.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Christoph Wurst [Wed, 17 Jun 2020 16:44:37 +0000 (18:44 +0200)]
Merge pull request #21456 from nextcloud/fix/bootstrap-appphp-order
Load the app.php before running apps' boot method
Roeland Jago Douma [Wed, 17 Jun 2020 13:40:11 +0000 (15:40 +0200)]
Merge pull request #21453 from nextcloud/bugfix/noid/dont-initialize-directly
Don't initialize Application directly
Joas Schilling [Wed, 17 Jun 2020 13:35:52 +0000 (15:35 +0200)]
Merge pull request #21417 from nextcloud/bugfix/noid/modal-support-for-vue-apps
Fix modal support for vue apps
Christoph Wurst [Wed, 17 Jun 2020 12:44:02 +0000 (14:44 +0200)]
Load the app.php before running apps' boot method
Some apps require the composer autoloader from app.php. If we run boot
before including that file, classes and functions from dependencies
won't be found.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Christoph Wurst [Wed, 17 Jun 2020 11:12:28 +0000 (13:12 +0200)]
Merge pull request #21454 from nextcloud/nickvergessen-patch-1
Delete FUNDING.yml
Joas Schilling [Wed, 17 Jun 2020 10:45:16 +0000 (12:45 +0200)]
Delete FUNDING.yml
Joas Schilling [Wed, 17 Jun 2020 10:18:15 +0000 (12:18 +0200)]
Don't initialize Application directly
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 17 Jun 2020 10:08:17 +0000 (12:08 +0200)]
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 17 Jun 2020 10:06:50 +0000 (12:06 +0200)]
Add another test for exact matching of a user in group restriction
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 17 Jun 2020 09:59:56 +0000 (11:59 +0200)]
Move back to IGroupManager::displayNamesInGroup()
The problem is that despite it's name IGroup::searchDisplayName()
only searches by userid and this is less fixable than changing back to this method here
Signed-off-by: Joas Schilling <coding@schilljs.com>