Remove some IRouter methods

This is not the end. IRouter needs to burn.
But it is a start.

🎵 we didn't start the fire 🎵

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #24102 from nextcloud/bugfix/noid/quota-upload

Check quota of subdirectories when uploading to them

Merge pull request #24098 from nextcloud/bugfix/noid/resharing-rights-on-circles

circleId too short in some request

Merge pull request #24163 from nextcloud/techdebt/noid/add-types-to-function-builder

Add types to function builder

Check for target folder available quota when uploading

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #24108 from csware/apple-unknown-year

Use correct year for generated birthdays events

Merge pull request #24168 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Fetch quota with files propfind

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Update psalm baseline

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add types to function builder

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #24069 from nextcloud/fix-default-internal-expiration-date

Fix default internal expiration date

Merge pull request #24112 from nextcloud/bugfix/24099/setup-fs-before-query-storage-in-settings

Set up FS before querying storage info in settings

Merge pull request #24146 from nextcloud/bugfix/24140/dont-throw-on-show-version-query

Don't throw on SHOW VERSION query

Add integration tests for creating shares with default expiration dates

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Reset app configs by deleting the values instead of setting the defaults

This avoids the need to keep the default values in the integration tests
in sync with the code, and also makes possible to reset values with
"dynamic" defaults (defaults that depend on other values).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add unit tests for "validateExpirationDateInternal"

They were copied and adjusted as needed from the tests for
"validateExpirationDate".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix default internal expiration date

The default expiration date for internal shares was set from the default
link expiration date instead of the internal one.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Don't throw on SHOW VERSION query

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Merge pull request #24124 from nextcloud/dependabot/npm_and_yarn/dompurify-2.2.2

Bump dompurify from 2.2.0 to 2.2.2

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.2.0 to 2.2.2.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.2.0...2.2.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #24126 from nextcloud/dependabot/npm_and_yarn/core-js-3.7.0

Bump core-js from 3.6.5 to 3.7.0

Bump core-js from 3.6.5 to 3.7.0

Bumps [core-js](https://github.com/zloirock/core-js) from 3.6.5 to 3.7.0.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.6.5...v3.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #24127 from nextcloud/dependabot/npm_and_yarn/nextcloud-vue-collections-0.9.0

Bump nextcloud-vue-collections from 0.8.1 to 0.9.0

Bumps [nextcloud-vue-collections](https://github.com/juliushaertl/nextcloud-vue-collections) from 0.8.1 to 0.9.0.
- [Release notes](https://github.com/juliushaertl/nextcloud-vue-collections/releases)
- [Commits](https://github.com/juliushaertl/nextcloud-vue-collections/compare/v0.8.1...v0.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #24122 from nextcloud/dependabot/npm_and_yarn/nextcloud/dialogs-3.1.1

Bump @nextcloud/dialogs from 3.0.0 to 3.1.1

Bumps [@nextcloud/dialogs](https://github.com/nextcloud/nextcloud-dialogs) from 3.0.0 to 3.1.1.
- [Release notes](https://github.com/nextcloud/nextcloud-dialogs/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-dialogs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-dialogs/compare/v3.0.0...v3.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #24119 from nextcloud/dependabot/npm_and_yarn/nextcloud/vue-3.2.0

Bump @nextcloud/vue from 3.1.0 to 3.2.0

Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/nextcloud/nextcloud-vue/releases)
- [Commits](https://github.com/nextcloud/nextcloud-vue/compare/v3.1.0...v3.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #24118 from nextcloud/dependabot/npm_and_yarn/babel-loader-8.2.1

Bump babel-loader from 8.1.0 to 8.2.1

Merge pull request #24123 from nextcloud/dependabot/npm_and_yarn/webpack-merge-5.4.0

Bump webpack-merge from 5.2.0 to 5.4.0

Merge pull request #24125 from nextcloud/dependabot/npm_and_yarn/eslint-plugin-standard-4.1.0

Merge pull request #24120 from nextcloud/dependabot/npm_and_yarn/sass-loader-10.1.0

Merge pull request #24130 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Bump eslint-plugin-standard from 4.0.2 to 4.1.0

Bumps [eslint-plugin-standard](https://github.com/standard/eslint-plugin-standard) from 4.0.2 to 4.1.0.
- [Release notes](https://github.com/standard/eslint-plugin-standard/releases)
- [Commits](https://github.com/standard/eslint-plugin-standard/compare/v4.0.2...v4.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump webpack-merge from 5.2.0 to 5.4.0

Bumps [webpack-merge](https://github.com/survivejs/webpack-merge) from 5.2.0 to 5.4.0.
- [Release notes](https://github.com/survivejs/webpack-merge/releases)
- [Changelog](https://github.com/survivejs/webpack-merge/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/survivejs/webpack-merge/compare/v5.2.0...v5.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

[tx-robot] updated from transifex

Bump sass-loader from 10.0.5 to 10.1.0

Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 10.0.5 to 10.1.0.
- [Release notes](https://github.com/webpack-contrib/sass-loader/releases)
- [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/sass-loader/compare/v10.0.5...v10.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump babel-loader from 8.1.0 to 8.2.1

Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.1.0 to 8.2.1.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel-loader/compare/v8.1.0...v8.2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #24096 from nextcloud/fix/contacts-interaction-card-resource-to-string

Convert the card resource to a string if necessary

Set up FS before querying storage info in settings

The personal info section of the personal settings is querying the
storage quota information. For this it requires the FS to be setup which
is not always guaranteed.

This fixes an issue where refreshing the settings page would cause it to
fail after Redis caches are full. It is likely that when Redis cache is
populated, some code path is initializing the FS, so it works so far.
But when the cache is populated, that code path is skipped so the FS is
not guaranteed to be setup...

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Use correct year for generated birthdays events

'X-APPLE-OMIT-YEAR' is not always present, at least iOS 12.4 uses the hard coded date of 1604 (the start of the gregorian calendar) when the year is unknown.

cf. https://forums.bitfire.at/topic/2050/bday-without-year-for-vcard-3-0-if-server-drops-property-x-apple-omit-year and https://gitlab.com/CardBook/CardBook/-/issues/586

Signed-off-by: Sven Strickroth <email@cs-ware.de>

Merge pull request #24085 from nextcloud/fix/register-add-missing-primary-keys

Register new command db:add-missing-primary-keys

Merge pull request #24023 from nextcloud/dependachristoph/npm_and_yarn/jquery-3.1.0

Bump jquery from 2.2.4 to 3.1.0

Merge pull request #23588 from nextcloud/enh/23558/override-dashboard-default-background

Override default dashboard background with theming one

circleId too short in some request

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Convert the card resource to a string if necessary

Apparently the fetched column can be a string or resource. Hence we have
to catch the resource type and convert it to a string.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Bump jquery from 2.2.4 to 3.1.0

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

override default dashboard background with theming one
fix getAppValue default value in theming app
fix cacheBuster value injection

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #24088 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Register new command db:add-missing-primary-keys

Introduced with: https://github.com/nextcloud/server/commit/d5df033ede1f2b19b87c365b1f808130023edf17

Signed-off-by: MichaIng <micha@dietpi.com>

Merge pull request #24066 from nextcloud/fix/sharing/expiration-date-internal

Fix default internal expiration date enforce

Merge pull request #24053 from nextcloud/bugfix/noid/fix-user-status-for-oracle

Merge pull request #24072 from nextcloud/fix-storage-credential-migration

fix migration of oc_credentials table

fix migration of oc_credentials table

Signed-off-by: Robin Appelman <robin@icewind.nl>

Add explicit time to test date for clarity

This shows in a clearer way that the expected expiration date is the
original one, but without time.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add unit test for expiration date with date and with default

This adds back what was being actually tested in the unit test fixed in
the previous commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix unit test for expiration date without date but with default

The expiration date was explicitly given, so it was not testing what it
should. Moreover, "link_defaultExpDays" needs to be mapped when testing
the default value (even if it will just fallback to the value of
"shareapi_expire_after_n_days").

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix unit test method name

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix unit test for verifying enforced valid expiration date.

The enforced expiration date was not actually enabled, as for that
"shareapi_default_expire_date" needs to be explicitly set to "yes".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix unit test for verifying enforced expire date too far in the future

The test should fail if no exception was thrown, and no exception was
thrown due to a missing configuration parameter. However, the use of
"addToAssertionCount(1)" made the test pass even if no exception was
thrown and, therefore, to silently fail.

Now the missing configuration parameter was added and the test will fail
if the expected exception is not thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add unit tests to enforce a relaxed default share expiration date

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Remove wrong and misleading comment

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Remove extra spaces

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix typo in variable name

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix typos in method names

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #24065 from nextcloud/enh/pimp_accessibilitycontroller

Pimp the accesibility controller

Fix default internal expiration date enforce

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

[tx-robot] updated from transifex

Merge pull request #24063 from nextcloud/techdebt/noid/switch-to-class-names-for-encryption-DI

Change to full class names for the encryption app DI in preparation of auto-wiring

Pimp the accesibility controller

* No usused members
* appRoot member
* less constructor args

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #24037 from nextcloud/enh/reflectionparamter_getclass_deprecatred

ReflectionParamter::getClass is deprecated

Change to full class names for the encryption app DI in preparation of auto-wiring

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

ReflectionParamter::getClass is deprecated

In php8 this starts throwing warnings. And since we use it quite often
we flood the log. This moves it to getType which does the same. Only non
deprecated now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #24060 from nextcloud/revert-24039-faster-installation

Revert "Installation goes brrrr"

Revert "Installation goes brrrr"

Merge pull request #24054 from nextcloud/bugfix/noid/calendar-repair-oracle

Manually iterate over calendardata when oracle is used

Dump autoloader

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Manually iterate over calendardata when oracle is used

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Also make direct_edit.accessed nullable

Signed-off-by: Joas Schilling <coding@schilljs.com>

Make is_user_defined nullable so we can store false on oracle

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #24039 from nextcloud/faster-installation

Installation goes brrrr

Merge pull request #23915 from st3iny/fix/noid/png-icons-in-caldav-reminder-emails

Use png icons in caldav reminder emails

Merge pull request #24038 from nextcloud/techdebt/noid/remove-unused-static-methods-files_external

Remove unused and deprecated methods from files_external MountConfig

Don't create a schema to check if the migrations table exists

Signed-off-by: Joas Schilling <coding@schilljs.com>

Reduce the number of schemas we generate when we just run all migrations anyway

Signed-off-by: Joas Schilling <coding@schilljs.com>

Only update the schema when we install anyway

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #24041 from nextcloud/techdebt/noid/remove-oc_hooks-for-group-management

Remove old OC_Hook for OC_Group events

Merge pull request #23882 from nextcloud/tests/oracle

Run unit tests against oracle

Merge pull request #24042 from nextcloud/fix-sharing-tab-state-not-matching-resharing-admin-settings

[tx-robot] updated from transifex

Add integration tests for default share permissions

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add acceptance tests for reshares by link when resharing is disabled

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add acceptance tests for reshares when resharing is disabled

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>