]>
source.dussan.org Git - nextcloud-server.git/log
John Molakvoæ (skjnldsv) [Mon, 20 Jul 2020 15:07:45 +0000 (17:07 +0200)]
Replace merge.smart
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
dependabot-preview[bot] [Sat, 18 Jul 2020 01:16:07 +0000 (01:16 +0000)]
Bump webpack-merge from 4.2.2 to 5.0.9
Bumps [webpack-merge](https://github.com/survivejs/webpack-merge) from 4.2.2 to 5.0.9.
- [Release notes](https://github.com/survivejs/webpack-merge/releases)
- [Changelog](https://github.com/survivejs/webpack-merge/blob/master/CHANGELOG.md)
- [Commits](https://github.com/survivejs/webpack-merge/compare/v4.2.2...v5.0.9)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Joas Schilling [Thu, 30 Jul 2020 08:59:31 +0000 (10:59 +0200)]
Merge pull request #21993 from nextcloud/fix/lower_route_not_found_level
Log the route not found exception on a lower level
Morris Jobke [Thu, 30 Jul 2020 07:47:49 +0000 (09:47 +0200)]
Merge pull request #22015 from nextcloud/bugfix/noid/correctly-remove-user-shares-on-removing-group-members
Correctly remove usergroup shares on removing group members
Joas Schilling [Mon, 27 Jul 2020 10:12:11 +0000 (12:12 +0200)]
Correctly remove usergroup shares on removing group members
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 29 Jul 2020 16:07:50 +0000 (18:07 +0200)]
Merge pull request #22034 from nextcloud/bugfix/noid/parse-url-returns-null
parse_url returns null in case a parameter is not found
Morris Jobke [Wed, 29 Jul 2020 13:36:38 +0000 (15:36 +0200)]
Merge pull request #21542 from nextcloud/activity-notifications
basic settings system for activity notifications
Morris Jobke [Wed, 29 Jul 2020 12:24:03 +0000 (14:24 +0200)]
Merge pull request #22017 from nextcloud/techdebt/noid/fix-psr4-namespace
Fix PSR-4 compatible namespace
Joas Schilling [Wed, 29 Jul 2020 12:20:23 +0000 (14:20 +0200)]
Merge pull request #22038 from nextcloud/bugfix/noid/dont-strict-type-uid-to-string
When no user is logged in null is used
Joas Schilling [Wed, 29 Jul 2020 07:42:54 +0000 (09:42 +0200)]
When no user is logged in null is used
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Wed, 29 Jul 2020 06:32:20 +0000 (08:32 +0200)]
parse_url returns null in case a parameter is not found
Signed-off-by: Joas Schilling <coding@schilljs.com>
Nextcloud bot [Wed, 29 Jul 2020 02:16:52 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
Joas Schilling [Tue, 28 Jul 2020 16:37:35 +0000 (18:37 +0200)]
Merge pull request #22027 from nextcloud/bugfix/noid/fix-overwrite-service-for-apps
Fix overwriteService() for apps
Joas Schilling [Tue, 28 Jul 2020 07:38:43 +0000 (09:38 +0200)]
Fix overwriteService() for apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
Nextcloud bot [Tue, 28 Jul 2020 02:16:39 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
Joas Schilling [Mon, 27 Jul 2020 11:17:04 +0000 (13:17 +0200)]
Fix PSR-4 compatible namespace
Signed-off-by: Joas Schilling <coding@schilljs.com>
Nextcloud bot [Mon, 27 Jul 2020 02:16:32 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
Nextcloud bot [Sat, 25 Jul 2020 02:16:36 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
Roeland Jago Douma [Fri, 24 Jul 2020 13:39:53 +0000 (15:39 +0200)]
Log the route not found exception on a lower level
This should be logged but it is not that critical to wanner level 3
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Morris Jobke [Fri, 24 Jul 2020 11:37:36 +0000 (13:37 +0200)]
Merge pull request #21977 from onehappycat/issue_21960
Ignore whitespace in sharing by mail
Morris Jobke [Fri, 24 Jul 2020 11:35:06 +0000 (13:35 +0200)]
Merge pull request #21988 from nextcloud/enh/theming-guest
Combine body-login rules in theming and fix twofactor and guest styling on bright colors
Morris Jobke [Fri, 24 Jul 2020 11:16:41 +0000 (13:16 +0200)]
Merge pull request #21818 from nextcloud/techdebt/noid/theming-bootstrap
Use IBootstrap for the app theming
Robin Appelman [Thu, 23 Jul 2020 14:39:27 +0000 (16:39 +0200)]
implement old settings interface
Signed-off-by: Robin Appelman <robin@icewind.nl>
Morris Jobke [Mon, 13 Jul 2020 15:04:49 +0000 (17:04 +0200)]
Use IBootstrap for the app theming
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Morris Jobke [Fri, 24 Jul 2020 10:20:27 +0000 (12:20 +0200)]
Merge pull request #21987 from nextcloud/techdebt/notfoundresponse-template
Move NotFoundResponse to a proper TemplateResponse
Julius Härtl [Fri, 24 Jul 2020 06:59:28 +0000 (08:59 +0200)]
Combine body-login rules in theming and fix twofactor and guest styling on bright colors
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Julius Härtl [Fri, 24 Jul 2020 05:53:48 +0000 (07:53 +0200)]
Move NotFoundResponse to a proper TemplateResponse
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Nextcloud bot [Fri, 24 Jul 2020 02:16:52 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
Morris Jobke [Thu, 23 Jul 2020 23:04:13 +0000 (01:04 +0200)]
Merge pull request #21940 from nextcloud/fix/14541/fix-fragile-acceptance-tests-part1
Revert "Disable fragile tests for now" partially
onehappycat [Thu, 23 Jul 2020 20:20:18 +0000 (22:20 +0200)]
Ignore whitespace in sharing by mail
Signed-off-by: onehappycat <one.happy.cat@gmx.com>
Morris Jobke [Thu, 23 Jul 2020 19:42:48 +0000 (21:42 +0200)]
Merge pull request #21814 from nextcloud/techdebt/noid/federated_share_added-into-typed-event
Move federated_share_added into a typed event
Morris Jobke [Thu, 23 Jul 2020 19:38:22 +0000 (21:38 +0200)]
Merge pull request #21972 from nextcloud/techdebt/noid/cleanup-phpunit-warnings
Fix PHPUnit deprecation warnings
Morris Jobke [Thu, 23 Jul 2020 19:35:18 +0000 (21:35 +0200)]
Merge pull request #21628 from nextcloud/external-to-s3-trashbin-fix
fix moving files from external storage to object store trashbin
Morris Jobke [Thu, 23 Jul 2020 19:22:01 +0000 (21:22 +0200)]
Merge pull request #21747 from simonspa/fix_mail_logosize
Fix header logo size in notification mails
Robin Appelman [Thu, 23 Jul 2020 18:31:35 +0000 (20:31 +0200)]
fix renameFromStorage messing with folder mimetype
Signed-off-by: Robin Appelman <robin@icewind.nl>
Simon Spannagel [Thu, 23 Jul 2020 16:06:44 +0000 (18:06 +0200)]
Adjust tests to new e-mail layout
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Simon Spannagel [Wed, 8 Jul 2020 08:26:34 +0000 (10:26 +0200)]
Fix header logo size in notification mails
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Morris Jobke [Thu, 23 Jul 2020 11:44:18 +0000 (13:44 +0200)]
Remove deprecated test of internal attributes via assertAttributeEquals in constructor tests
I removed the tests completely because they just test that the constructor assigns the values to the internal properties. Nothing that should be cared about from the outside.
See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-
428843322
It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Morris Jobke [Thu, 23 Jul 2020 11:39:13 +0000 (13:39 +0200)]
Replace deprecated assertArraySubset with logic that does the same
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Morris Jobke [Thu, 23 Jul 2020 11:38:49 +0000 (13:38 +0200)]
Use assertEqualsCanonicalizing instead of deprecated assertEquals parameter
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Morris Jobke [Thu, 23 Jul 2020 11:36:49 +0000 (13:36 +0200)]
Remove deprecated test of internal attributes via assertAttributeEquals
See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-
428843322
It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Morris Jobke [Thu, 23 Jul 2020 11:36:32 +0000 (13:36 +0200)]
Use assertStringContainsString instead of assertContains on strings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Morris Jobke [Thu, 23 Jul 2020 15:11:10 +0000 (17:11 +0200)]
Merge pull request #21973 from nextcloud/techdebt/noid/fix-risky-2fa-backup-code-test
Fix risky test in twofactor_backupcodes
Robin Appelman [Wed, 1 Jul 2020 13:37:47 +0000 (15:37 +0200)]
use exceptions for error signaling in writeStream
this remove the ambiguity when writing zero length files
Signed-off-by: Robin Appelman <robin@icewind.nl>
Robin Appelman [Tue, 30 Jun 2020 14:09:50 +0000 (16:09 +0200)]
rollback cache rename if trashbin move fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
Robin Appelman [Mon, 29 Jun 2020 16:14:47 +0000 (18:14 +0200)]
fix moving files from external storage to object store trashbin
having the "cache rename" after the "storage move" caused the target
to get the fileid from the source file, without taking care that the object
is stored under the original file id.
By doing the "cache rename" first, we trigger the "update existing file"
logic while moving the file to the object store and the object gets stored for the
correct file id
Signed-off-by: Robin Appelman <robin@icewind.nl>
Georg Ehrke [Thu, 23 Jul 2020 13:09:33 +0000 (15:09 +0200)]
Merge pull request #21970 from nextcloud/dependageorg/npm_and_yarn/nextcloud/vue-2.3.0
Bump @nextcloud/vue from 2.2.1 to 2.3.0
Morris Jobke [Thu, 23 Jul 2020 12:54:23 +0000 (14:54 +0200)]
Merge pull request #21966 from nextcloud/enh/userbackend/custom_logout
Allow user backends to specify a custom logout url
Morris Jobke [Thu, 23 Jul 2020 12:32:58 +0000 (14:32 +0200)]
Fix risky test in twofactor_backupcodes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Georg Ehrke [Thu, 23 Jul 2020 12:09:00 +0000 (14:09 +0200)]
Bump @nextcloud/vue from 2.2.1 to 2.3.0
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Roeland Jago Douma [Thu, 23 Jul 2020 08:53:36 +0000 (10:53 +0200)]
Merge pull request #21963 from nextcloud/fix/sharing/respect_default_share_permissions
Respect default share permissions
Roeland Jago Douma [Thu, 23 Jul 2020 08:42:40 +0000 (10:42 +0200)]
Allow user backends to specify a custom logout url
* Allows SSO backends to do a global logout
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Roeland Jago Douma [Thu, 23 Jul 2020 07:30:42 +0000 (09:30 +0200)]
Respect default share permissions
Else we'll always create new shares with the max permissions.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Julius Härtl [Thu, 23 Jul 2020 06:50:25 +0000 (08:50 +0200)]
Merge pull request #21957 from nextcloud/techdebt/noid/bootstrap-testing
Use IBootstrap for the testing app
Morris Jobke [Mon, 13 Jul 2020 13:43:42 +0000 (15:43 +0200)]
Move federated_share_added into a typed event
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Nextcloud bot [Thu, 23 Jul 2020 02:17:03 +0000 (02:17 +0000)]
[tx-robot] updated from transifex
Morris Jobke [Wed, 22 Jul 2020 20:28:04 +0000 (22:28 +0200)]
Use IBootstrap for the testing app
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Roeland Jago Douma [Wed, 22 Jul 2020 19:29:21 +0000 (21:29 +0200)]
Merge pull request #21946 from nextcloud/fix/webauthn/windows_hello
Do not double encode the userid in webauthn login
Roeland Jago Douma [Wed, 22 Jul 2020 19:19:14 +0000 (21:19 +0200)]
Merge pull request #21949 from nextcloud/smb-3.2.6
update icewind/smb to 3.2.6
Roeland Jago Douma [Wed, 22 Jul 2020 19:10:28 +0000 (21:10 +0200)]
Merge pull request #21950 from nextcloud/bugfix/noid/wipe-translation
Properly fetch translation for remote wipe confirmation dialog
Roeland Jago Douma [Wed, 22 Jul 2020 07:23:11 +0000 (09:23 +0200)]
Do not double encode the userid in webauthn login
* Else login fails with webauthn devices that send the userid
- Like windows hello
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot[bot] [Wed, 22 Jul 2020 18:45:33 +0000 (18:45 +0000)]
Compile assets
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Morris Jobke [Wed, 22 Jul 2020 18:38:50 +0000 (20:38 +0200)]
Merge pull request #21870 from nextcloud/fix/bootstrap-context-container-interfaces
Make the bootstrap context return ContainerInterface instances
Julius Härtl [Wed, 22 Jul 2020 14:56:17 +0000 (16:56 +0200)]
Properly fetch translation for remote wipe confirmation dialog
Signed-off-by: Julius Härtl <jus@bitgrid.net>
John Molakvoæ [Wed, 22 Jul 2020 15:47:33 +0000 (17:47 +0200)]
Merge pull request #21948 from nextcloud/bugfix/noid/accesibilityoca
Load accessibilityoca script
John Molakvoæ [Wed, 22 Jul 2020 15:47:18 +0000 (17:47 +0200)]
Merge pull request #21867 from nextcloud/dependageorg/npm_and_yarn/nextcloud/vue-2.2.1
Daniel Calviño Sánchez [Tue, 21 Jul 2020 19:25:18 +0000 (21:25 +0200)]
Hide share link menu before copying the share link in acceptance tests
The (old) Firefox version used in the acceptance tests does not properly
render the share link menu. As the menu is taller than it should
sometimes it covers the copy link button, so it is not possible to click
it without hiding the share link menu. Moreover, in those cases the
share menu button is also covered by the share menu, so the menu needs
to be closed by pressing the "Esc" key.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Georg Ehrke [Tue, 21 Jul 2020 06:44:14 +0000 (08:44 +0200)]
Recompile JS assets
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Georg Ehrke [Thu, 16 Jul 2020 12:39:26 +0000 (14:39 +0200)]
Fix breaking changes of nc/vue update
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Georg Ehrke [Thu, 16 Jul 2020 12:24:14 +0000 (14:24 +0200)]
Bump @nextcloud/vue from 1.5.0 to 2.2.1
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Robin Appelman [Wed, 22 Jul 2020 12:25:33 +0000 (14:25 +0200)]
update icewind/smb to 3.2.6
Signed-off-by: Robin Appelman <robin@icewind.nl>
Julius Härtl [Wed, 22 Jul 2020 10:04:16 +0000 (12:04 +0200)]
Load accessibilityoca script
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Roeland Jago Douma [Wed, 22 Jul 2020 07:44:08 +0000 (09:44 +0200)]
Merge pull request #21905 from nextcloud/dependabot/npm_and_yarn/babel/core-7.10.5
Bump @babel/core from 7.10.4 to 7.10.5
dependabot-preview[bot] [Wed, 22 Jul 2020 07:36:06 +0000 (07:36 +0000)]
Bump @babel/core from 7.10.4 to 7.10.5
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.10.4 to 7.10.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.10.5/packages/babel-core)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Roeland Jago Douma [Wed, 22 Jul 2020 07:31:46 +0000 (09:31 +0200)]
Merge pull request #21904 from nextcloud/dependabot/npm_and_yarn/nextcloud/axios-1.3.3
Bump @nextcloud/axios from 1.3.2 to 1.3.3
Nextcloud bot [Wed, 22 Jul 2020 02:16:38 +0000 (02:16 +0000)]
[tx-robot] updated from transifex
Morris Jobke [Tue, 21 Jul 2020 18:46:43 +0000 (20:46 +0200)]
Merge pull request #21658 from nextcloud/trashbin-configurable-size
allow admin to configure the max trashbin size
Morris Jobke [Tue, 21 Jul 2020 12:36:40 +0000 (14:36 +0200)]
Use the proper IAppContainer and IServerContainer type hints to know which code runs with which container
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Christoph Wurst [Thu, 16 Jul 2020 15:08:03 +0000 (17:08 +0200)]
Adjust apps' code to use the ContainerInterface
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Christoph Wurst [Thu, 16 Jul 2020 15:06:17 +0000 (17:06 +0200)]
Make the bootstrap context return ContainerInterface instances
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Robin Appelman [Tue, 21 Jul 2020 16:03:17 +0000 (18:03 +0200)]
build autoloader
Signed-off-by: Robin Appelman <robin@icewind.nl>
Robin Appelman [Tue, 21 Jul 2020 15:40:22 +0000 (17:40 +0200)]
improve default notification fallback
Signed-off-by: Robin Appelman <robin@icewind.nl>
kesselb [Tue, 21 Jul 2020 15:36:03 +0000 (17:36 +0200)]
Merge pull request #21941 from nextcloud/design/font-ubuntu-cantarell
Move Cantarell before Ubuntu in font stack to fix GNOME + Ubuntu setups
Robin Appelman [Mon, 15 Jun 2020 13:01:52 +0000 (15:01 +0200)]
basic settings system for activity notifications
Signed-off-by: Robin Appelman <robin@icewind.nl>
Jan C. Borchardt [Tue, 21 Jul 2020 14:20:32 +0000 (16:20 +0200)]
Move Cantarell before Ubuntu in font stack to fix GNOME + Ubuntu setups
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
Morris Jobke [Wed, 6 Mar 2019 08:56:29 +0000 (09:56 +0100)]
Revert "Disable fragile tests for now"
This reverts commit
40e04c83914e960b5aff739900d887f0e7a44d63 .
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Morris Jobke [Tue, 21 Jul 2020 13:19:28 +0000 (15:19 +0200)]
Merge pull request #21934 from nextcloud/tests/noid/disable-fragile-comments-tests
Disable fragile comments tests
Morris Jobke [Tue, 21 Jul 2020 11:42:26 +0000 (13:42 +0200)]
Merge pull request #21929 from nextcloud/bugfix/noid/encryption-transfer-user
Encryption is ready if master key is enabled
Morris Jobke [Tue, 21 Jul 2020 11:31:17 +0000 (13:31 +0200)]
Disable fragile comments tests
Those tests are actual problems in our code. See https://github.com/nextcloud/server/pull/20462#issuecomment-
613380650 for a summary by @danxuliu
Basically they are introduced by #18929 but are only revealed by #18764.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Julius Härtl [Tue, 21 Jul 2020 07:16:43 +0000 (09:16 +0200)]
Encryption is ready if master key is enabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Nextcloud bot [Tue, 21 Jul 2020 02:17:06 +0000 (02:17 +0000)]
[tx-robot] updated from transifex
Morris Jobke [Mon, 20 Jul 2020 22:17:17 +0000 (00:17 +0200)]
Merge pull request #21864 from nextcloud/techdebt/files-versions-psr-container
Migrate files versions to the PSR container
Morris Jobke [Mon, 20 Jul 2020 22:16:03 +0000 (00:16 +0200)]
Merge pull request #21865 from nextcloud/techdebt/settings-psr-container
Migrate settigns to the PSR container
dependabot-preview[bot] [Mon, 20 Jul 2020 15:16:07 +0000 (15:16 +0000)]
Bump @nextcloud/axios from 1.3.2 to 1.3.3
Bumps [@nextcloud/axios](https://github.com/nextcloud/nextcloud-axios) from 1.3.2 to 1.3.3.
- [Release notes](https://github.com/nextcloud/nextcloud-axios/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-axios/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-axios/compare/v1.3.2...v1.3.3)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Morris Jobke [Mon, 20 Jul 2020 14:45:14 +0000 (16:45 +0200)]
Merge pull request #21875 from nextcloud/techdebt/deprecate-ilogger
Deprecate ILogger in favor of the PSR-3 logger
Morris Jobke [Mon, 20 Jul 2020 14:41:35 +0000 (16:41 +0200)]
Merge pull request #21862 from nextcloud/techdebt/files-sharing-psr-container
Migrate files sharing to the PSR container
Morris Jobke [Mon, 20 Jul 2020 14:28:54 +0000 (16:28 +0200)]
Merge pull request #21866 from nextcloud/techdebt/ldap-psr-container
Migrate LDAP to the PSR container
Morris Jobke [Mon, 20 Jul 2020 13:00:45 +0000 (15:00 +0200)]
Merge pull request #21846 from nextcloud/dependabot/npm_and_yarn/p-limit-3.0.2
Bump p-limit from 2.3.0 to 3.0.2
Morris Jobke [Mon, 20 Jul 2020 12:20:03 +0000 (14:20 +0200)]
Merge pull request #21850 from nextcloud/techdebt/noid/register-alternative-logins
Allow to register AlternativeLogin on RegistrationContext
John Molakvoæ [Mon, 20 Jul 2020 12:07:20 +0000 (14:07 +0200)]
Merge pull request #21921 from nextcloud/fix/use-DOMContentLoaded
Use DOMContentLoaded and fix sharebymail loading issue