Use dispatchTyped instead of dispatch on the new event dispatcher

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #21787 from nextcloud/enh/hello-psalm

Hello psalm

Check only the baseline.xml and exclude the psalm.xml from the file check

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add patches for stubs

* https://github.com/JetBrains/phpstorm-stubs/pull/893
* https://github.com/JetBrains/phpstorm-stubs/pull/894
* https://github.com/JetBrains/phpstorm-stubs/pull/895
* https://github.com/JetBrains/phpstorm-stubs/pull/896

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add stubs for gd, intl, IntlChar, ldap, redis_cluster and xsl

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add a check for fixes in the psalm baseline

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add psalm baseline

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #22195 from nextcloud/design/accessibility-highcontrast-class

Add highcontrast class to body just like with dark theme

Suppress warning for template functions.

https://github.com/nextcloud/server/blob/6e8e34fef920a073118c22111f0f31eb3b3a91dc/lib/private/legacy/template/functions.php
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Fix variable name for referenced variable.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Supress UndefinedGlobalVariable for register_command.php

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Remove directory/file element.

It will suppress any error of that kind in the file. That was not intended.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Suppress warning for $_ and $l

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Exclude stubs from code style check

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Fix: UndefinedFunction Function x does not exist in templates

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Add psalm as composer dependency

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Add template functions

for some reason they are not loaded by default.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Add stubs for phpseclib

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Hello psalm

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Add highcontrast class to body just like with dark theme

Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>

Merge pull request #22244 from nextcloud/fix/16876/better_fetch_recent

Improve recent file fetching

Improve recent file fetching

Fixes #16876

Before we'd just fetch everything from all storages we'd have access to.
Then we'd sort. And filter in php. Now this of course is tricky if a
user shared just a file with you and then has a ton of activity.

Now we try to contruct the prefix path. So that the filtering can happen
right away in the databae.

Now this will make the DB more busy. But it should help overall as in
most cases less queries are needed then etc.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

[tx-robot] updated from transifex

Merge pull request #22273 from nextcloud/bugfix/noid/status-nonexisting-icon

Do not try to load non-existing icon

Merge pull request #22109 from nextcloud/feature/20931/followup-1

Limit custom message input to 80 chars

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Display user-status in sharing list

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Merge pull request #22271 from nextcloud/phpdoc/22063/add-interface-method-and-phpdoc

Properly add new methods to interface and document in PHPDoc for getR…

Merge pull request #22272 from nextcloud/phpdoc/21787/fix-misplaced-variable-phpdoc

Fix "misplaced variables" warning of Psalm in PHPDoc statements

Do not try to load non-existing icon

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #21861 from nextcloud/techdebt/files-psr-container

Migrate files to the PSR container

Fix "misplaced variables" warning of Psalm in PHPDoc statements

Ref #21787

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #22253 from nextcloud/debt/noid/docblocks

Fix some MissingDocblockType or InvalidDocblock warnings.

Properly add new methods to interface and document in PHPDoc for getRootMounts()

Introduced in #22063 and was just forgotten.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Fix TagService DI name

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Migrate files to the PSR container

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #22262 from nextcloud/dependabot/npm_and_yarn/sinon-9.0.3

Merge pull request #22261 from nextcloud/dependabot/npm_and_yarn/jsdom-16.4.0

Bump jsdom from 16.3.0 to 16.4.0

Merge pull request #22260 from nextcloud/dependabot/npm_and_yarn/lodash-4.17.20

Bump lodash from 4.17.19 to 4.17.20

Bump lodash from 4.17.19 to 4.17.20

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.19...4.17.20)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Bump sinon from 9.0.2 to 9.0.3

Bumps [sinon](https://github.com/sinonjs/sinon) from 9.0.2 to 9.0.3.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/compare/v9.0.2...v9.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump jsdom from 16.3.0 to 16.4.0

Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.3.0 to 16.4.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md)
- [Commits](https://github.com/jsdom/jsdom/compare/16.3.0...16.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

[tx-robot] updated from transifex

Fix more MissingDocblockType or InvalidDocblock warnings.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #22257 from nextcloud/debt/noid/add-parameter-to-set

Update documentation for QueryBuilder::set

Update documentation for QueryBuilder::set

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Expose status via Collaborators API

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Merge pull request #22221 from nextcloud/fix/19097/ldap-depracted-event

provide event class and typed event to LDAP loaded event; also fixing a logged deprecation message

Merge pull request #18969 from nextcloud/enh/apps/use-sidebar

Migrate app management settings to proper sidebar standards

Fix some MissingDocblockType or InvalidDocblock warnings.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Use appsidebar for apps

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Use appsidebar for apps

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Merge pull request #22243 from nextcloud/fix/20490/no_session_duplicate_warnings

Silence duplicate session warnings

Merge pull request #22198 from nextcloud/dependabot/npm_and_yarn/vue-router-3.4.3

Bump vue-router from 3.3.4 to 3.4.3

Bumps [vue-router](https://github.com/vuejs/vue-router) from 3.3.4 to 3.4.3.
- [Release notes](https://github.com/vuejs/vue-router/releases)
- [Changelog](https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-router/compare/v3.3.4...v3.4.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Merge pull request #22200 from cweiske/duplicated-sql-where-line

Remove duplicated SQL addWhere line

Silence duplicate session warnings

Fixes #20490

Basically restroring the old behavior.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

[tx-robot] updated from transifex

Merge pull request #22242 from nextcloud/techdebt/noid/remove-deprecated-methods

Remove deprecated and unused method calls

Merge pull request #20451 from exussum12/AllowPreviewWhenGeneratorHasBeenRemoved

Always try and show pre rendered preview

Fix existing test and add a specific one for the new case

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Always try and show pre rendered preview

Currently if the following situation happens

Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets a 404 error when preview exists
(Mime checked before preview)

This happens more often with documents, or video as the commands are not
native PHP, they require a binary on the server.

After the fix the following would happen

Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets preview which has been generated
(Mime checked after preview)

This would also allow offline generation (for example a docker image
containing the extra binaries), allowing a reduction in attack surface
of the instance serving the preview data.

Signed-off-by: Scott Dutton <scott@exussum.co.uk>

Remove getLastJob from IJobList

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Remove setCustomJs of the files_external FrontendDefinitionTrait

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #22128 from nextcloud/bugfix/noid/cleanup-chunks-on-failure

Delete chunks if the move on an upload failed

Return proper status when file didn't exist before

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #22235 from nextcloud/fix/22217/fix-naming-of-app-config-option

Fix name of app config option to properly reflect what it does

Fix name of app config option to properly reflect what it does

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #22229 from nextcloud/bugfix/noid/dashboard-outdated-bundles

Bump outdated dashboard bundles

Merge pull request #22202 from nextcloud/enh/noid/cleanup-servercontainer

Use autowiring where possible in server container

Bump outdated dashboard bundles

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #21788 from nextcloud/debt/noid/unused-method

Remove unused method uploadFile

Merge pull request #22205 from nextcloud/activity-settings-cleanup

merge file activity settings into a single 'favorite changed' item

Remove unused method uploadFile

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Add @deprecated labels for server DI containter aliases

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #21344 from nextcloud/fix/twofactor-cleanup-event

Emit an event for every disabled 2FA provider during cleanup

Use registerDeprecatedAlias for non-namespaced aliases

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Use autowiring where possible in server container

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

[tx-robot] updated from transifex

merge file activity settings into a single 'favorite changed' item

Signed-off-by: Robin Appelman <robin@icewind.nl>

move share notifcation settings to files group

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #22206 from nextcloud/enh/noid/tests-recent-contact-mapper

Add some tests for RecentContactMapper

Merge pull request #22217 from nextcloud/enh/noid/disable-admin-changed-email-appconfig

Add app config option to disable "Email was changed by admin" email

provide event class to LDAP loaded event to fix deprecation message

* and also dispatch the typed event as current approach to it

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #22199 from nextcloud/techdebt/noid/PHPUnit_Framework_MockObject_MockObject

Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to …

Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add app config option to disable "Email was changed by admin" email

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add some tests for RecentContactMapper

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #22211 from nextcloud/fix/noid/rm-useless-log

remove logging message carrying no valuable information

remove logging message carrying no valuable information

the exception caught is not an error, but due to valid configuration and
code flow is expecting this. For an admin it is confusing, and it carries
no information worth for debugging.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #22196 from nextcloud/enh/sse/do_not_concatenate_ints

SSE enhancement of file signature

Adjust chunking test for non-existing target node

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Delete chunks if the move on an upload failed

Signed-off-by: Julius Härtl <jus@bitgrid.net>

[tx-robot] updated from transifex

Merge pull request #21559 from nextcloud/fix/noid/ldap-group-shortcut-ad

shortcut in reading nested group members when IN_CHAIN is available

Merge pull request #22162 from nextcloud/enh/noid/password-generator-sharebymail

ShareByMail: Migrate to GenerateSecurePasswordEvent

Generate password by password_policy app

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Remove duplicated SQL addWhere line