Also show updates on the "enabled" page

The enabled page doesn't pass through "getAppsForCategory" thus it also needs to have that special logic applied.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Loop for newest version in appstore response

The current implementation when fetching apps from the appstore is to assume that the first element is the newest version, this is now always applicable and leads to the fact that for some apps (e.g. nextant) the newest version is not delivered. This can be easily tested by comparing the version of the downloaded Nextant version.

This change will loop over all releases delivered by the appstore and chooses the newest compatible one. While not the cleanest solution, it does its job.

Most of the code are actually unit tests. Whereas I have copied the whole original response from the appstore and also have performed the transformation. So that's why the diff looks so huge.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2303 from nextcloud/password-check-improvements

small password check improvements

show dialog again of operation failed

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

set focus on input field

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

Merge pull request #2296 from nextcloud/nitpicking-on-federation-admin-section

Fix some language issues in the federation admin panel

Merge pull request #2290 from nextcloud/placeholder-typo-public-link-activity

Fix placeholder typo in public link activity

Fix some language issues in the federation admin panel

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #2283 from nextcloud/no-padding-if-no-settings-area

Remove padding from apps navigation if there is no settings area

Fix placeholder typo in public link activity

https://www.transifex.com/nextcloud/nextcloud/translate/#152/files_sharing/101548786/

Merge pull request #2233 from nextcloud/change-link-to-11

Update link to the docs to 11

Merge pull request #2286 from nextcloud/ldap_password_pr-1

LDAP PR with tests

Add tests

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2247 from nextcloud/avatar-fallback

use ? instead of X for avatar name fallback

restore ldap_password_pr

Signed-off-by: Roger Szabo <roger.szabo@web.de>
remove notification part

Signed-off-by: Roger Szabo <roger.szabo@web.de>
blizzz comments

Signed-off-by: Roger Szabo <roger.szabo@web.de>
morris comment

Signed-off-by: Roger Szabo <roger.szabo@web.de>
improved error message for changing password

Signed-off-by: Roger Szabo <roger.szabo@web.de>
blizz comments 20161013

Signed-off-by: Roger Szabo <roger.szabo@web.de>
Signed-off-by: Roger Szabo <roger.szabo@web.de>
Adjust HintException usage

Signed-off-by: Roger Szabo <roger.szabo@web.de>
Signed-off-by: Roger Szabo <roger.szabo@web.de>

Remove padding from apps navigation if there is no settings area

* fixes #2189

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #2242 from nextcloud/fix-installation-spinner

show installation spinner correctly, fix #2129

fix unit tests

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #2281 from nextcloud/fix-translation

Fix language typo

Merge pull request #2232 from nextcloud/imagescale-fix

Workaround for PHP bug when calling imagescale

Fix language typo

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #2278 from nextcloud/filelist-share-visible

make the share icon in the filelist visible again

Merge pull request #2280 from nextcloud/do_not_escape_sharees

Do not escape sharees

improved style of shared entry

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Do not escape sharees

Fixes #2253

Do not escape special characters else it will look very strange.

Merge pull request #2240 from nextcloud/daita-encryption-init_on_master_key

init Session/privateKeys on Master Key

Merge pull request #2266 from nextcloud/avatar_image

VCARDS don't hold binary data

make the share icon in the filelist visible again

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #2275 from nextcloud/harden-cookies

Harden cookies more appropriate

Merge pull request #2262 from nextcloud/specify-parameters-on-public-download

Specify the parameters on public download

VCARDS don't hold binary data

* We need to base64 encode the avatar!
* Switched to vcard v4
* User proper data uri

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Harden cookies more appropriate

This adds the __Host- prefix to the same-site cookies. This is a small but yet nice security hardening.

See https://googlechrome.github.io/samples/cookie-prefixes/ for the implications.

Fixes https://github.com/nextcloud/server/issues/1412

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

check if session is initialized

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

Merge pull request #2263 from nextcloud/remove91_migration

Remove migration steps in app dav

Merge pull request #2267 from nextcloud/issue-2254-react-to-remote-share-activities-only

Only do stuff when its a remote-share activity

Merge pull request #2239 from nextcloud/cleanup-settings-application-again

Cleanup settings application again

Only do stuff when its a remote-share activity

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #2250 from nextcloud/check-if-data-is-defined

Check if data is defined

Remove 9.1 migration steps in app dav (#25654)

Specify the parameters on public download

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #2251 from nextcloud/remove-superfluos-mail-input-field

Remove superfluous email input field

Remove superfluous email input field

That field is already there and looking at the code this seems to have been missed on a rebase.

Fixes https://github.com/nextcloud/server/issues/2222

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2246 from nextcloud/display-name-for-files-and-tagging-activities-again

Use the display name for files activities again

Check if data is defined

Otherwise when adding a user as subadmin this would throw the following JS error:

```
users.js?v=bc2aae7…:500 Uncaught TypeError: Cannot read property 'message' of undefined(…)(anonymous function) @ users.js?v=bc2aae7…:500j @ jquery.js:3099fireWith @ jquery.js:3211x @ jquery.js:8264(anonymous function) @ jquery.js:8605
```

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2229 from nextcloud/select2-fix-bis

Select2 fix bis

use ? instead of X for avatar name fallback

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Merge pull request #2241 from nextcloud/make-it-a-beta

Make it 11.0 beta

document new variable

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Use the display name for files activities again

Signed-off-by: Joas Schilling <coding@schilljs.com>

show installation spinner correctly, fix #2129

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Make it 11.0 beta

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2238 from nextcloud/fix_systemtags

Fix undefined systemtags stuff

init Session/privateKeys on Master Key

I can't find another way to init the session ...

Clean up the Application class again

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix undefined systemtags stuff

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #2234 from nextcloud/add-subadmin-middleware-back

Add SubAdminMiddleware back

Add SubAdminMiddleware back

Removed by mistake in #1946

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Update link to the docs to 11

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #1972 from nextcloud/invalid-files-from-scanner

Make sure we don't scan files that can not be accessed

Workaround for PHP bug when calling imagescale

Signed-off-by: Julius Haertl <jus@bitgrid.net>

Merge pull request #2179 from nextcloud/update-systemtags-to-new-activity-api

Update systemtags activity to new API

Fix select2 input on retina - fixes #2226

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Fix systemtagsfilelist unwanted margin and clean aera a bit

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Remove unwanted padding

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Merge pull request #2165 from nextcloud/sharing-activities-update

Move file sharing activities to the new API

Merge pull request #2228 from nextcloud/use-appid-instead-of-app-element

Use app ID instead of object

Merge pull request #2154 from nextcloud/comments-activities-update

Move comments activities to the new API

[tx-robot] updated from transifex

Use app ID instead of object

Fixes several error messages when installing an app from the appstore, including:

```
Illegal offset type in isset or empty at /media/psf/stable9/lib/private/legacy/app.php#662
Illegal offset type at /media/psf/stable9/lib/private/legacy/app.php#663
Illegal offset type at /media/psf/stable9/lib/private/legacy/app.php#661
Object of class OC_App could not be converted to string at /media/psf/stable9/lib/private/legacy/app.php#81
trim() expects parameter 1 to be string, object given at /media/psf/stable9/lib/private/legacy/app.php#628
```

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2215 from nextcloud/add-setup-page-integration-test

Add integration test for web based installer

Merge pull request #2221 from nextcloud/from-is-featured-to-featured

Error log spam: Cast "isFeatured" to "featured"

Merge pull request #2225 from nextcloud/fix_caldav_proppatch_requests

fix PropPatch requests on calendars

fix PropPatch requests on calendars

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Merge pull request #2220 from nextcloud/app-password-default-device-name

app passwords: add default name if none given

Add integration test for web based installer

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Cast "isFeatured" to "featured"

The appstore returns a "isFeatured" in the current API revision. We need to cast this thus.

Fixes the following error log message when opening the tab "Customization":

> Undefined index: featured at /media/psf/stable9/settings/Controller/AppSettingsController.php#233

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

use date as device name if no name was given

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

Merge pull request #2216 from nextcloud/proper-return-value

Use proper return function

Merge pull request #2214 from nextcloud/remove-logging

remove old logging section

update tests

Signed-off-by: Robin Appelman <robin@icewind.nl>

Use proper return function

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2211 from nextcloud/maintenance-wsod

fix white screen of death in maintenance mode when theming is disabled

Merge pull request #2212 from nextcloud/fix_web_installer

Do not trigger appconfig queries when we are not yet installed

Merge pull request #1946 from nextcloud/federated-sharing-persona-settings

Add more personal information fields to the settings page for enhanced federated sharing

remove old logging section

Signed-off-by: Robin Appelman <robin@icewind.nl>

Do not trigger appconfig queries when we are not yet installed

Fixes #2209

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

fix white screen of death in maintenance mode when theming is disabled

Signed-off-by: Robin Appelman <robin@icewind.nl>

center checkmark to indicate that the setting was stored

don't try to verify email address if no email address is set

small fixes

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

Adjust unit tests

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Adjust integration test

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Ask for password when scope is changed

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Fix mail scope

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Highlight current entry

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Make JS aware of password verification

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Remove debug code

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Add config switch

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Remove unused variable

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Add retry job

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>