send share notification instead of erroring on duplicate share

when creating a share that already exists, instead of erroring, resend the notifications

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #26017 from nextcloud/enh/boostrap/initialstate

Move initialstate bootstrap to proper types classes

Merge pull request #25933 from nextcloud/bugfix/noid/remove-unsupported-remote-share-expiration

Hide expiration date field for remote shares

Merge pull request #25930 from nextcloud/techdept/psalm/25839/RedundantPropertyInitializationCheck

Fix RedundantPropertyInitializationCheck

Merge pull request #26004 from nextcloud/enh/publicsharecontroller/isauthenticatedoverwrite

Allow overwriting isAuthenticated

Hide expiration date field for remote shares

Remote shares currently do not support expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix RedundantPropertyInitializationCheck

For #25839

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25998 from nextcloud/techdept/psalm/personalsettings

Fix some types in the Settings Personal pages

Merge pull request #25970 from nextcloud/dependabot/npm_and_yarn/nextcloud/vue-dashboard-1.1.0

Bump @nextcloud/vue-dashboard from 1.0.1 to 1.1.0

Move initialstate bootstrap to proper types classes

For more type safety

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Allow overwriting isAuthenticated

* Some implementations might check for different things
* IT will not change how the current ones work

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #26018 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Merge pull request #26012 from nextcloud/dependabot/npm_and_yarn/elliptic-6.5.4

[Security] Bump elliptic from 6.5.3 to 6.5.4

[Security] Bump elliptic from 6.5.3 to 6.5.4

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #25839 from nextcloud/dependabot/composer/vimeo/psalm-4.6.2

Bump vimeo/psalm from 4.2.1 to 4.6.2

Merge pull request #26005 from nextcloud/techdept/psalm/fix_invalid_check

Fix invalid check after constructing DateTime

Merge pull request #26007 from nextcloud/docs/config/session_lifetime

Add hint about possible limit when setting a session_lifetime

Merge pull request #25996 from nextcloud/dependabot/composer/sabre/dav-4.1.5

Bump sabre/dav from 4.1.4 to 4.1.5

Add hint about possible limit when setting a session_lifetime

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #25960 from nextcloud/techdept/admin_audit

Pimp admin audit

Update baseline

The rest we will just fix as we go

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Bump vimeo/psalm from 4.2.1 to 4.6.2

Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 4.2.1 to 4.6.2.
- [Release notes](https://github.com/vimeo/psalm/releases)
- [Commits](https://github.com/vimeo/psalm/compare/4.2.1...4.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Fix invalid check after constructing DateTime

We construct an object. Either that works on not.But the result can't be
false.

Found by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25910 from nextcloud/enh/allow_login_block

Allow admins to hide the login form

Allow admins to disable the login form

In case they want to not allow this because they use SSO (and do not
want the users to enter their credentials there by accident).

?direct=1 still works.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25997 from nextcloud/techdept/psalm/redundantcast

Fix some redundant casts

Bump @nextcloud/vue-dashboard from 1.0.1 to 1.1.0

Bumps [@nextcloud/vue-dashboard](https://github.com/nextcloud/nextcloud-vue-dashboard) from 1.0.1 to 1.1.0.
- [Release notes](https://github.com/nextcloud/nextcloud-vue-dashboard/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-vue-dashboard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-vue-dashboard/compare/v1.0.1...v1.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Fix some types in the Settings Personal pages

* Fix types
* Typed the code

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25990 from nextcloud/do-not-try-to-add-an-existing-user-again-in-acceptance-tests

Do not try to add an existing user again in acceptance tests

Bump sabre/dav from 4.1.4 to 4.1.5

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #25925 from nextcloud/techdept/psalm/ActionProviderStore

Pimp ActionProviderStore

Add return type to functions

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25948 from nextcloud/techdebt/noid/depreate-getHTMLName

Deprecate getHTMLName on \OCP\Defaults

Merge pull request #25975 from nextcloud/add-missing-waits-and-asserts-in-acceptance-tests

Add missing waits and asserts in acceptance tests

Fix some redundant casts

Happier psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25988 from nextcloud/ci/fixup/action

Move fixup check to action

[tx-robot] updated from transifex

Move fixup check to action

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Remove unneeded steps to add already existing user

User "user1" is added when installing and configuring the server, so it
is already added in all tests.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix acceptance test for searching just added users in contacts menu

User "user1" is added when installing and configuring the server, so it
is already added in all tests. As the test verifies that just added
users can be searched in the contacts menu a new user should be actually
added.

The test did not fail because it assumed that "user1" did not exist and
just checked that it existed after "adding" it, but not whether adding
it failed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

[tx-robot] updated from transifex

Merge pull request #25966 from nextcloud/dependabot/npm_and_yarn/babel/plugin-proposal-class-properties-7.13.0

Merge pull request #25959 from nextcloud/techdept/logger/AccessibilityController

AccessibilityController to LoggerInterface

Merge pull request #25972 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #25969 from nextcloud/dependabot/npm_and_yarn/chai-4.3.3

[tx-robot] updated from transifex

Bump chai from 4.3.0 to 4.3.3

Bumps [chai](https://github.com/chaijs/chai) from 4.3.0 to 4.3.3.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](https://github.com/chaijs/chai/compare/4.3.0...4.3.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump @babel/plugin-proposal-class-properties from 7.12.13 to 7.13.0

Bumps [@babel/plugin-proposal-class-properties](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-proposal-class-properties) from 7.12.13 to 7.13.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.0/packages/babel-plugin-proposal-class-properties)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Find directly the label instead of falling back to it

The input element is always hidden, so the check always ended falling
back to the label. Moreover, the label is the element that the user
interacts with, so it must be the one used.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Assert also element visibility instead of just finding it

Although if the element could not be found an exception would be thrown
and the test aborted if an element is in the DOM but hidden it would be
found and the test would pass.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add explicit locator for "Enable all" bundle button

Instead of looking for the bundle button and then checking its value now
the expected value is included in the locator and the button is checked
similarly to other elements.

No "Disable all" locator was added as it was not currently needed
anywhere.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Find elements through the actor rather than the driver

"Actor::find" is a more robust way to look for elements, as it handles
some exceptions that may be thrown. Therefore, even if the elements are
not actually used and it is only checked whether they exist or not using
the actor is the preferred way when possible (and it also makes it
consistent with the rest of the acceptance tests).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add locator for apps list

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix identation

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix delete user acceptance test

Adding some missing asserts showed that the "delete user" acceptance
test was silently failing, as the deletion was not being confirmed in
the dialog and thus the user was not being deleted.

The dialog button contains a single quote ("user0's"), so the XPath
expression had to be adjusted (it seems that it is not possible to
escape a single quote in a string enclosed in single quotes in XPath
1.0).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Verify WaitFor::element... results with an assertion

WaitFor::element... calls only perform the waiting and return whether
the condition succeeded or not, but that result needs to be explicitly
checked to prevent further steps from being executed if the wait failed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add missing waits when finding elements in the acceptance tests

As no timeout was specified the elements were tried to be found just
once. This caused the steps to fail if the elements did not appear yet
in the page when they were tried to be found.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #25945 from nextcloud/dependabot/npm_and_yarn/core-js-3.9.1

Bump core-js from 3.8.3 to 3.9.1

Merge pull request #25735 from francoisfreitag/npm-ci

Remove Makefile rule clean-dev

Move background job to DI

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Move admin_audit to LoggerInterface

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

AccessibilityController to LoggerInterface

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25932 from nextcloud/bugfix/noid/fix-fed-share-add-to-nc

Skip empty obsolete owner when adding to own NC

Merge pull request #25870 from nextcloud/techdept/settings/move_group_activity_events

Move group activities to events

Bump core-js from 3.8.3 to 3.9.1

Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.8.3 to 3.9.1.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.9.1/packages/core-js)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25928 from nextcloud/enh/contactsmenu/entry

Type Entry and IEntry

Merge pull request #25588 from nextcloud/techdept/custom-psr-logger

Migrate custom loggers to PSR

Merge pull request #25947 from nextcloud/fix/provisioning_api/logger

Fixed error after merge in UsersController

Deprecate getHTMLName on \OCP\Defaults

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fixed error after merge in UsersController

This was moved to the LoggerInterface so the recent merge of #25589
broke master.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25731 from nextcloud/dependabot/npm_and_yarn/mocha-8.3.0

Bump mocha from 8.2.1 to 8.3.0

Merge pull request #25589 from nextcloud/provisioning-api-invalid-argument

forward invalid argument message to frontend when creating a user fails

Merge pull request #25726 from nextcloud/dependabot/npm_and_yarn/build/handlebars-4.7.7

Merge pull request #25660 from hosting-de/feature/add-backend-list-groups

Show group backends in occ group:list --info and group:info

Merge pull request #25659 from nextcloud/smb-getmetadata-catch

catch notfound and forbidden exception in smb::getmetadata

Merge pull request #25725 from lmamane/master

token login: emit preLogin event with LoginName

Merge pull request #25929 from nextcloud/techdept/psalm/25839/redundantcasts

Remove Redundantcasts

Bump mocha from 8.2.1 to 8.3.0

Bumps [mocha](https://github.com/mochajs/mocha) from 8.2.1 to 8.3.0.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mochajs/mocha/compare/v8.2.1...v8.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump handlebars from 4.7.6 to 4.7.7 in /build

Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.6 to 4.7.7.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.6...v4.7.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #25942 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Merge pull request #25941 from nextcloud/techdept/CompositeExpression

Type CompositeExpression and ICompositeExpression

Type CompositeExpression and ICompositeExpression

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

catch notfound and forbidden exception in smb::getmetadata

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #25927 from nextcloud/enh/sharebymail/set_expiration_on_creation

Sharebymail: set expiration on creation

Merge pull request #25926 from nextcloud/enh/activity/hidden_files

Activity: show if files are hidden or not

Skip empty obsolete owner when adding to own NC

The owner field is nowadays always empty when adding a federated share
using "Add to your Nextcloud", so don't check for it.

Fixes an issue where "Add to your Nextcloud" doesn't add anything.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #23665 from nextcloud/enh/querybuilder/execute_query_update

Add executeQuery and executeUpdate

Remove Redundantcasts

For #25839

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Type Entry and IEntry

* Fixed a docblock
* Typed the entries

Psalm happier, Roeland happier

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Add executeQuery and executeUpdate

Names shamelessly copied from Doctrine itself.
Internally it is still using the same flow. But I added some checks
around it.

This should make static analysis a bit more happy. Which in turn makes
me more happy.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Sharebymail: set expiration on creation

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Activity: show if files are hidden or not

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25881 from nextcloud/techdept/psalm/sharesplugin

Fix the SharesPlugin

Merge pull request #25912 from nextcloud/techdept/psalm/sharedstorage_some_types

Add some typing to SharedStorage

Pimp ActionProviderStore

* Fix paradoxale condition
* Add types
* Move away from ILogger

Makes psalm happy, and thus me happy

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>