Return explicit values instead of boolean from sabre (#26654)

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2811 from nextcloud/extended_apcu_cas

Extend APCu test with int CAS

Merge pull request #2808 from alantygel/patch-1

Translation string corrected > 1 user

[tx-robot] updated from transifex

Extend APCu test with int CAS

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Translation string corrected > 1 user

Merge pull request #2792 from nextcloud/update-drone-images

update drone images to latest version

Merge pull request #2796 from nextcloud/set-exit-code-to-1-if-test-is-failing

Set exit code to 1 if integration test is failing

Merge pull request #2758 from nextcloud/only-one-dav-backend

Register only one dav backend

Merge pull request #2724 from nextcloud/fix-23591

[downstream] Report failures for SignApp and SignCore

Merge pull request #2784 from nextcloud/2fa_command_tests

Add tests for 2FA commands

[tx-robot] updated from transifex

Set exit code to 1 if integration test is failing

Before it just checked the unit tests and ignored the integration test results. See https://drone.nextcloud.com/nextcloud/server/3374/35 for details.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

update drone images to latest version

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #2790 from nextcloud/update-integration-test-image

Update integration test image

Merge pull request #2273 from nextcloud/fix_invalid_calendar

Add DAV repair step to fix calendar data

Merge pull request #2789 from nextcloud/add-smb-tests

Add SMB tests execution and execute files_external tests

Run coverage

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Add SMB tests and execute files_external tests

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Update integration test image

Updates the composer dependencies so running the tests should now be faster again…

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2719 from nextcloud/behat-transferownership

[downstream] Behat transferownership

Merge pull request #2769 from nextcloud/improve_user_user_coverage

Improve OC\User\User coverage

Add tests for 2FA commands

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #2765 from nextcloud/kill-repairlegacystorages

[downstream] Remove obsolete RepairLegacyStorages repair step

[tx-robot] updated from transifex

Improve OC\User\User coverage

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #2774 from nextcloud/fix-2585

remove frequent, unimportant log message

remove frequent, unimportant log message

Fixes #2585

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #2764 from nextcloud/fix-groupshare-sharetimesort

[downstream] When grouping shares, sort by stime then id (#26777)

Merge pull request #2762 from nextcloud/add-js-computerFileSize

[downstream] Add js computer file size

Update autoloader files

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Remove obsolete RepairLegacyStorages repair step

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Fix finding transferred folder in integration tests

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

When grouping shares, sort by stime then id (#26777)

If share times are equal, the first share should still win instead of
having the shares swapped.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Verify input, add more unit tests

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Add test for unparseable string

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Implements all comments from @PVince81

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Adding computerFileSize in OC.Util

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2757 from nextcloud/cron-5.6

Also check in cron for old php version

Adjust integration test to Nextcloud branding

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Fix error when $view is null when being passed into some plugins

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Fix "Call to a member function getUID() on null"

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

No challenge within federated auth

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Allow registration of federated auth

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Register only one dav auth backend

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Add test for duplicate 401 headers on DAV

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2752 from nextcloud/issue-2675-dont-allow-firefox-to-store-the-space

Use a form so firefox doesn't try to save the space as a password

Add proper tests

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Also check in cron for old php version

Fixes #2756

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #2754 from nextcloud/activities-manager-publish-exception

Activities IManager throws an BadMethodCallException

Merge pull request #2689 from andreas-p/fix-remote-conflict

Fix showConflict

Activities IManager throws an BadMethodCallException

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Adjust to Nextcloud changes

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Add transfer ownership integration tests (#26543)

* Add transfer ownership integration tests

* Added more transfer ownership tests and OCC checks

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Use a form so firefox doesn't try to save the space as a password

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #2727 from nextcloud/fix-colon-issue

[downstream] Fix colon issue

Merge pull request #2721 from nextcloud/ocs-die-on-exception

[downstream] Die in OCS v1.php on exception

Merge pull request #2723 from nextcloud/integrity-exit-code

[downstream] Return 1 if integrity check is failed. Fixes #22806

Fix showConflict

use getFullFileName to show conflicting file
add original.directory to make fileExists happy

Signed-off-by: Andreas Pflug <dev@admin4.org>

Merge pull request #2726 from nextcloud/check-all-channels

[downstream] Consider all channel except blank and git to be signed

Merge pull request #2735 from nextcloud/fix-settingsmenu

Adjust shadows and fix positioning in header menus

Adjust shadows and fix positioning

Signed-off-by: Julius Haertl <jus@bitgrid.net>

Update third-party ref for new sabre/uri version

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2725 from nextcloud/memcached-connect-once

[downstream] Set options, then add servers

Merge pull request #2722 from nextcloud/failed-to-create-share-fix

[downstream] commit transaction after select query

Merge pull request #2720 from nextcloud/fix-25692

[downstream] Do not validate return code is set is successful

Add integration test for creating folder with colon

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Consider all channel except blank and git to be signed

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Set options, then add servers

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Update tests

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Check return value for file_put_contents. Add return value to the commands

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Return 1 if integrity check is failed. Fixes #22806

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

commit transaction after select query

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Die in OCS v1.php on exception

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Do not validate return code is set is successful

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2707 from nextcloud/clear_appstore_cache_on_upgrade

Clear appstore cache on version upgrade

Merge pull request #2504 from nextcloud/downstream-ldap-15

Downstream LDAP Range Support

Merge pull request #2550 from nextcloud/smb-notify-rename

Fix order of parameters when getting notified of smb renames

Merge pull request #2714 from amittel/patch-1

Changed anchor

Merge pull request #1678 from nextcloud/smb-stat-root

Fix mtimes for share root

Merge pull request #2398 from nextcloud/fix-2368

flicker-free permission change in share dialog

Merge pull request #2695 from nextcloud/remove-leading-slashes-on-share-activity

Remove leading slash from sharing activity

Merge pull request #2715 from nextcloud/fix_dav_toto_tests

Fix TodoTest

Fix TodoTest

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Changed anchor

from `avatar` to `personal-settings`

fixes #2711

Merge pull request #2625 from nextcloud/fix-todo-filter

Fix the Todos filter

Merge pull request #2681 from nextcloud/changes-to-changelog

let's add a date :D

Clear appstore cache on version upgrade

* Add version to cached json
* Compare version
* Updated calls
* Updated tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

let's add a date :D

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #2698 from nextcloud/dont-disable-apps-on-update-if-at-least-php7

Don't disable apps on update if PHP >= 7.0.0

Don't disable apps on update if PHP >= 7.0.0

When PHP in a version higher than 7.0.0 is used we catch fatal exceptions in app.php and gracefully already disable the app. There is thus no need to also disable the apps on updates.

This has been requested by Jan to fix because that is "the most annoying thing ever" :TM:. – I'd say we give it a try and if that causes problems in the future we can consider alternative approaches.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #2673 from nextcloud/shared-scanner-unmasked

use unmasked permissions in shared scanner

Remove leading slash from sharing activity

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add integration tests for uploading files to a permission limited share

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #2670 from nextcloud/issue-2646-dont-connet-to-database-before-creating-it

Do not connect to database before creating it

Merge pull request #2674 from nextcloud/lookup-server-connector-12

mark nc12 as supported for the lookup_server_connector

Merge pull request #2665 from nextcloud/remove-db-class-and-interface

Remove IDb interface which was deprecated for 3 years already

Merge pull request #2671 from nextcloud/issue-2661-reduce-log-level-on-database-user-creation

Only log as info when we can not create a new DB user

mark nc12 as supporter

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #2677 from nextcloud/fix-avatars-in-mail

Don't set Content-Disposition header if one already exists