Add integration tests for user_status API

Signed-off-by: Jonas Meurer <jonas@freesources.org>

Respect user enumeration settings in user status lists

So far, the functions to find user statuses listed didn't respect user
enumeration settings (`shareapi_allow_share_dialog_user_enumeration`
and `shareapi_restrict_user_enumeration_to_group` core app settings).

Fix this privacy issue by returning an empty list in case
`shareapi_allow_share_dialog_user_enumeration` is unset or
`shareapi_restrict_user_enumeration_to_group` is set.

In the long run, we might want to return users from common groups if
`shareapi_restrict_user_enumeration_to_group` is set. It's complicated
to implement this in a way that scales, though. See the discussion at
https://github.com/nextcloud/server/pull/27879#pullrequestreview-753655308
for details.

Also, don't register the user_status dashboard widget at all if
`shareapi_allow_share_dialog_user_enumeration` is unset or
`shareapi_restrict_user_enumeration_to_group` is set.

Fixes: #27122
Signed-off-by: Jonas Meurer <jonas@freesources.org>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29409 from nextcloud/dependabot/npm_and_yarn/stable22/babel-loader-8.2.3

Bump babel-loader from 8.2.2 to 8.2.3

Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.2.2 to 8.2.3.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel-loader/compare/v8.2.2...v8.2.3)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #29393 from nextcloud/backport/26725/stable22

[stable22] Fix federated scope not shown when public addressbook upload is disabled

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29419 from nextcloud/backport/29400/stable22

[stable22] fixes an undefined index when getAccessList returns an empty array

Split capability

The "federated" and "published" scopes are independent one from each
other, so the capability that encompassed both needs to be split.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Hide "federated" scope when Federation app is disabled

If the Federation app is disabled it is not possible to synchronize the
users from a different server.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix "Federated" scope not shown when the lookup server is disabled

When the lookup server is disabled the address books can still be
exchanged between trusted servers. Therefore the user should be able to
set the "Federated" scope in that case.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add missing scope to test

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #29391 from nextcloud/backport/29220/stable22

[stable22] s3 external storage fixes

Merge pull request #29398 from nextcloud/backport/29378/stable22

[stable22] Make the route name error more helpful

fixes an undefined index when getAccessList returns an empty array

- [] is a valid return value that should be honored as having no access

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #29410 from nextcloud/dependabot/composer/build/integration/stable22/behat/behat-approx-3.9.0

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Update behat/behat requirement in /build/integration

Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.8.0...v3.9.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Make the route name error more helpful

As a developer I have no clue what "Invalid route name" means. If the
exception gives me a hint I might find it easier to figure out why my
route triggers this error.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #29381 from nextcloud/backport/29357/stable22

Merge pull request #29385 from nextcloud/backport/28997/stable22

Merge pull request #29389 from nextcloud/backport/29375/stable22

[stable22] Make calendar schedule options translatable

cache versioning enabled status

Signed-off-by: Robin Appelman <robin@icewind.nl>

minor directory detect improvements

Signed-off-by: Robin Appelman <robin@icewind.nl>

always set Key field in `headObject`

Signed-off-by: Robin Appelman <robin@icewind.nl>

more reliable return value for Watcher::checkUpdate

Signed-off-by: Robin Appelman <robin@icewind.nl>

more reliable hasUpdated for s3

Signed-off-by: Robin Appelman <robin@icewind.nl>

remove old migration method

Signed-off-by: Robin Appelman <robin@icewind.nl>

optimize filetype for s3 directories a bit

Signed-off-by: Robin Appelman <robin@icewind.nl>

ci

Signed-off-by: Robin Appelman <robin@icewind.nl>

more reliable directory copy

Signed-off-by: Robin Appelman <robin@icewind.nl>

doesDirectoryExist fixes

Signed-off-by: Robin Appelman <robin@icewind.nl>

s3 external storage listing rework

Signed-off-by: Robin Appelman <robin@icewind.nl>

Make calendar schedule options translatable

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Update attendence for external users

For local users it's possible to select their calendar via the principal url and first update their own attendance status.
External users have no calendar event hence the recipient is the organizer.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Scheduling plugin not updating responding attendee status take two

Signed-off-by: Anna Larch <anna@nextcloud.com>

Merge pull request #29316 from nextcloud/backport/29180/stable22

Prevent duplicate auth token activity updates

The auth token activity logic works as follows
* Read auth token
* Compare last activity time stamp to current time
* Update auth token activity if it's older than x seconds

This works fine in isolation but with concurrency that means that
occasionally the same token is read simultaneously by two processes and
both of these processes will trigger an update of the same row.
Affectively the second update doesn't add much value. It might set the
time stamp to the exact same time stamp or one a few seconds later. But
the last activity is no precise science, we don't need this accuracy.

This patch changes the UPDATE query to include the expected value in a
comparison with the current data. This results in an affected row when
the data in the DB still has an old time stamp, but won't affect a row
if the time stamp is (nearly) up to date.

This is a micro optimization and will possibly not show any significant
performance improvement. Yet in setups with a DB cluster it means that
the write node has to send fewer changes to the read nodes due to the
lower number of actual changes.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #29359 from nextcloud/backport/29355/stable22

[stable22] Fix login button alignment

Merge pull request #29365 from nextcloud/backport/29362/stable22

[stable22] Fix security issues when copying groupfolder with advanced ACL

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix security issues when copying groupfolder with advanced ACL

Using advanced ACL, it is possible that an user has access to a
directory but not to a subdirectory, so the copying use
Common::copyFromStorage instead of Local::copyFromStorage.

Fix https://github.com/nextcloud/groupfolders/issues/1692

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Fix login button alignment

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #29288 from nextcloud/backport/28768/stable22

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29311 from nextcloud/backport/29295/stable22

Merge pull request #29263 from nextcloud/backport/29090/stable22

[stable22] Add configuration flag to disable the background job for files_versions

Merge pull request #29262 from nextcloud/backport/29125/stable22

[stable22] Add configuration flag to disable the background job for files_trashbin

Merge pull request #29301 from nextcloud/backport/29259/stable22

[stable22] Fix app upgrade

Use Psr\Log\LoggerInterface where it can easily be used in user_ldap

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix two mistakes in previous migration to LoggerInterface in OCA\User_LDAP\Access

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Use Psr\Log\LoggerInterface in OCA\User_LDAP\Access

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Avoid PHP errors when the LDAP attribute is not found

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #29283 from nextcloud/backport/28250/stable22

Merge pull request #29183 from nextcloud/backport/29028/stable22

Fix cliping issues in alternative logging buttons

The issues was caused because the button with its margins was bigger
than the parent. Instead of setting the margin of the button, add
padding to the parent. This is more reliable.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix app upgrade

Signed-off-by: Joas Schilling <coding@schilljs.com>

Simplify :)

Replace `file_exists()` method by `is_file()`

Get `filesize()` if `file_exists()`

Should make sense.

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix bug introduced on drag and drop external files

Drag and drop of external (OS filesystem) to subdirectories in the browser would fail on specific cases, mainly when the subdirectory was no longer off the root folder.
This seemed to have been an issue introduced with the subdirectory free space calculation [here](https://github.com/nextcloud/server/commit/f9536b08096ed1c80391af36d33a18198be1fced) and it seems to fail for any subdirectory that doesn't belong to the root folder.

Bug reports:
- https://help.nextcloud.com/t/drag-drop-into-subfolders/120731
- https://github.com/nextcloud/server/issues/24720

I couldn't find any reference on scenarios or quota management that would suggest when a subdirectory's free space would be different to the parent's free space, other than when on the root folder, where subdirectories can be external mounts.

As such, if my understanding is correct (please review), this calculation can - and should - be made by getting the free space from the first subdirectory in the total path, which caters for all subdirectory scenarios.

Please advise, happy to help improve this.

Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: pjft <pjft@users.noreply.github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Add configuration flag to disable the background job for files_versions

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Add configuration flag to disable the background job for files_trashbin

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #29251 from nextcloud/backport/29248/stable22

[stable22] Fix background scan doc in config

Fix background scan doc in config

The background scanner only processes entries with size < 0

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29221 from nextcloud/backport/29214/stable22

[stable22] Don't setup the filesystem to check for a favicon we don't use anyway

Merge pull request #29225 from nextcloud/backport/26688/stable22

[stable22] Add proper message to created share not found

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Default message for ShareNotFound exception

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Add proper message to created share not found

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Don't setup the filesystem to check for a favicon we don't use anyway

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #29217 from nextcloud/backport/29136/stable22

[stable22] Add documentation for files_no_background_scan

Merge pull request #29196 from nextcloud/backport/29020/stable22

[stable22] Keep group restrictions when reenabling apps after an update

Add documentation for files_no_background_scan

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #29207 from nextcloud/backport/29004/stable22

[stable22] Fix translated app details

Keep group restrictions when reenabling apps after an update

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix translated app details

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

add 'supported'-label to all supported apps, also if they are not downloaded yet

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

Merge pull request #29160 from nextcloud/backport/24185/stable22

Merge pull request #29066 from nextcloud/backport/29056/stable22

[stable22] Allow "TwoFactor Nextcloud Notifications" to pull the state of the 2FA again

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29129 from nextcloud/backport/27886/stable22

[stable22] Keep pw based auth tokens valid when pw-less login happens

Merge pull request #29133 from nextcloud/backport/28907/stable22

Merge pull request #29162 from nextcloud/backport/29122/stable22

[stable22] Tokens without password should not trigger changed password invalidation

Tokens without password should not trigger changed password invalidation

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Make sure that a empty directory can still be deleted when copied from another storage

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Delete object to cleanup leftover of paths when removing directories

Signed-off-by: Julius Härtl <jus@bitgrid.net>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29124 from nextcloud/backport/29123/stable22

Merge pull request #29121 from nextcloud/backport/28608/stable22

explicitly close source stream on encryption storage

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>