Only check the twofactor state once per request

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #29975 from nextcloud/backport/29872/stable23

Merge pull request #30008 from nextcloud/backport/30001/stable23

[stable23] Cast orphan subscription id to int

Cast orphan subscription id to int

DB columns are of type int by default, so they need to be casted.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Set profile page title

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #29967 from nextcloud/backport/29917/stable23

[stable23] Fix source of translations

Merge pull request #29977 from nextcloud/backport/29974/stable23

[stable23] Let repair step query exceptions bubble up

Include previous execption for repair steps that don't exist

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Let repair step query exceptions bubble up

And hide the type error caused by a constructor call with missing
arguments.

`new $repairStep();` only works for the rare case that no arguments are
required. Anything else will throw. Then we previously hid the trace of
the more important query exception.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #29970 from nextcloud/backport/29870/stable23

[stable23] Prevent your own status from replacing another user's status on profile

Prevent your own status from replacing another user's status

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #29961 from nextcloud/backport/29951/stable23

[stable23] Interpolate the log message also for logged exceptions

Fix source of translations

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Interpolate the log message also for logged exceptions

According to PSR-3 the log message can have placeholders that are
replaced from the context object. Our logger implementation did that for
all PSR-3 logger methods. The only exception was our custom `logException`.

Since PsrLoggerAdapter calls logException when an exception key is
present in the context object, log messages were no longer interpolated.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #29937 from nextcloud/dependabot/npm_and_yarn/stable23/testing-library/jest-dom-5.15.1

Bump @testing-library/jest-dom from 5.15.0 to 5.15.1

Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.15.0 to 5.15.1.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/jest-dom/compare/v5.15.0...v5.15.1)

---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #29936 from nextcloud/dependabot/npm_and_yarn/stable23/sass-1.43.5

Bump sass from 1.43.4 to 1.43.5

Bumps [sass](https://github.com/sass/dart-sass) from 1.43.4 to 1.43.5.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sass/dart-sass/compare/1.43.4...1.43.5)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #29925 from nextcloud/release/23.0.0

23.0.0

Merge pull request #29928 from nextcloud/backport/29926/stable23

[stable23] obey  accounts_data column length when inserting and searching

Obey col length of 255 to insert and search in accounts_data

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

add method to shorten a string to given byte size to Utils

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #29918 from nextcloud/backport/29871/stable23

Nextcloud Hub II

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Set number of visibility dropdown rows dynamically

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #29848 from nextcloud/backport/29836/stable23

[stable23] Make sure mapping cache is cleared when deleting a user

23.0.0

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Test cache invalidation for AbstractMapping in test suite

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Make sure mapping cache is cleared when deleting a user

This avoids phantom remnants staying after user deletion

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #29913 from nextcloud/backport/29906/stable23

[stable23] Use strict comparison to detect usage of redis cluster

Merge pull request #29916 from nextcloud/backport/29893/stable23

[stable23] Improve accessibility for personal info settings and profile

Improve accessibility

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #29909 from nextcloud/backport/29891/stable23

Merge pull request #29908 from nextcloud/backport/29894/stable23

[stable23] Fix inactive profile parameters being displayed in the Profile visibility section

Use strict comparison to detect usage of redis cluster

Signed-off-by: Louis Chemineau <louis@chmn.me>

Adjust margin of status on profile

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Fix inactive profile parameters being returned

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #29800 from nextcloud/backport/29632/stable23

[stable23] fix imagecreatetruecolor() error

Merge pull request #29898 from nextcloud/backport/29895/stable23

[stable23] Check for invalid characters before trimming

Correctly set the response after a ClientException as well

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add an integration test

Signed-off-by: Joas Schilling <coding@schilljs.com>

Check for invalid characters before trimming

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #29877 from nextcloud/backport/29869/stable23

Merge pull request #29882 from nextcloud/backport/29826/stable23

[stable23] Personalsettings - fix marginLeft as it breaks the layout

Personalsettings - remove marginLeft as it breaks the layout

Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #29876 from nextcloud/backport/29864/stable23

[stable23] Allow to fetch the creation time of folders

Hide user status from public

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Allow to fetch the creation time of folders

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #29858 from nextcloud/backport/29791/stable23

Merge pull request #29847 from nextcloud/backport/29833/stable23

[stable23] make profile page usable on mobile

fix imagecreatetruecolor() error

Signed-off-by: szaimen <szaimen@e.mail.de>

make profile page usable on mobile

Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Fix multiple bugs with user status

* Fix editing the status while on a call, don't send a bogus request
* Clean backup user status when setting up a new status manually
* A bit more type hinting

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #29844 from nextcloud/backport/29567/stable23

[stable23] Improve sorting of profile visibility dropdowns

Merge pull request #29845 from nextcloud/backport/29544/stable23

[stable23] Fix wording on profile page

Merge pull request #29849 from nextcloud/backport/29835/stable23

[stable23] Fix getting subnet of ipv4 mapped ipv6 addresses

Type hint in IpAddress

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>

Improve normalizer detecting IPv4 inside of IPv6

The subnet for an IPv4 address inside of IPv6 is now returned in its
IPv4 form.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix getting subnet of ipv4 mapped ipv6 addresses

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix wording on profile page

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Improve sorting
- Extract sort logic into a separate function
- Sort non-core parameters with localeCompare

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #29815 from nextcloud/dependabot/composer/build/integration/stable23/sabre/dav-4.2.0

Update sabre/dav requirement from 4.1.5 to 4.2.0 in /build/integration

Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/compare/4.1.5...4.2.0)

---
updated-dependencies:
- dependency-name: sabre/dav
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #29813 from nextcloud/dependabot/npm_and_yarn/stable23/camelcase-6.2.1

Bump camelcase from 6.2.0 to 6.2.1

Merge pull request #29828 from nextcloud/backport/29708/stable23

[stable23] Do not print verbose info about app updates if there are none

Do not print verbose info about app updates if there are none

This is cosmetical but if you have a large number of apps installed then
you'll see a wall of text during the server and app upgrade when it
tries to update each app via the app store. In may cases nothing will be
updated. For those boring cases we can hide the verbose info, but show
when occ is run with -v. Any actual update will still print a few lines.
Those are the important ones for the admin.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #29793 from nextcloud/backport/29605/stable23

[stable23] Normalize file name before existence check in scanner

Merge pull request #29797 from nextcloud/backport/29788/stable23

[stable23] Fix doc link in sharing settings

Bump camelcase from 6.2.0 to 6.2.1

Bumps [camelcase](https://github.com/sindresorhus/camelcase) from 6.2.0 to 6.2.1.
- [Release notes](https://github.com/sindresorhus/camelcase/releases)
- [Commits](https://github.com/sindresorhus/camelcase/compare/v6.2.0...v6.2.1)

---
updated-dependencies:
- dependency-name: camelcase
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix doc link in sharing settings

The doc link "i" icon was on the wrong line.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #29789 from nextcloud/backport/29784/stable23

[stable23] App summary is optional

Normalize directory entries in Encoding wrapper

Directory entry file names are now normalized in getMetaData(),
getDirectoryContents() and opendir().

This makes the scanner work properly as it assumes pre-normalized names.

In case the names were not normalized, the scanner will now skip the
entries and display a warning when applicable.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Move storage encoding compatibility warning logic

The encoding check for file names is now happening the Scanner, and an
event will be emitted only if the storage doesn't contain the encoding
compatibility wrapper.

The event is listened to by the occ scan command to be able to display a
warning in case of file name mismatches when they have NFD encoding.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Normalize file name before existence check in scanner

The scanner would not find a NFD-encoded file name in an
existing file list that is normalized.

This normalizes the file name before scanning.

Fixes issues where scanning repeatedly would make NFD files flicker in
and out of existence in the file cache.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

App summary is optional

Fixing:
Error: Undefined index: summary at /var/www/html/apps/theming/lib/Controller/ThemingController.php#392

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #29766 from nextcloud/version/23rc3

23 RC 3

Merge pull request #29760 from nextcloud/backport/29752/stable23

[stable23] Explicitly allow some routes without 2FA

23 RC 3

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Explicitly allow some routes without 2FA

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #29749 from nextcloud/backport/29747/stable23

[stable23] Allow to serve static WebAssembly and TensorFlow Lite files

Merge pull request #29746 from nextcloud/backport/29734/stable23

[stable23] Fixed grammar

Allow to serve static WebAssembly and TensorFlow Lite files

Since Talk 13 (and thus Nextcloud 23) WebAssembly (.wasm) and TensorFlow
Lite (.tflite) files need to be loaded from the web server to provide
certain features (like the background blur in the WebUI).

Those files can be treated in a similar way to other static resources,
and there should not be any problem caching or compressing them.
However, as compressed TensorFlow Lite files are only ~12% smaller,
the compression directive depends on the MIME type and there is no
standard MIME type for TensorFlow Lite files it is not worth to compress
them.

Moreover, no directives to compress WebAssembly files were added either,
as it seems that they would override any other compression directives
set in the default server configuration; for reference it could be done
with something like:
<IfModule mod_deflate.c>
  <IfModule mod_filter.c>
    AddOutputFilterByType DEFLATE application/wasm
  </IfModule>
</IfModule>

Depending on the setup "application/wasm" may not be associated with
".wasm" files, so the directive was added just in case, as otherwise
browsers log a warning.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #29672 from nextcloud/backport/29663/stable23

[stable23] Fix loading all principal calendars in the dav app calendar provider

Merge pull request #29662 from nextcloud/enhancement/calendar-search-properties-api-stable23

[stable23] Document allowed property names for calendar property searches

Fixed grammar

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Merge pull request #29737 from nextcloud/backport/29695/stable23

[stable23] Fix missing setlocale with php 8

OC_Util::isNonUTF8Locale: fix lint error

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>

OC_Util::isSetLocaleWorking: fix typo

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>

OC_Util: Add fallbacks to check if current locale is UTF8

Using escapeshellcmd to get current locale causes error
if the function is disabled.

Add fallbacks to prevent the error.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>

Add check whether escapeshellcmd behaves the same as basename

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>

Check whether setlocale works only after setlocale

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>

Fix missing setlocale with php 8

When php version = 8, basename('§') does not bug even if LC_ALL is non-UTF-8 locale.
This cause OC_Util::isSetLocaleWorking() to skip setlocale("C.UTF-8").

Fix it by using escapeshellcmd instead of basename.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>

Merge pull request #29728 from nextcloud/backport/29683/stable23

[stable23] Fix core depending on theming app

Correct comment about OC_Defaults being used

Signed-off-by: MichaIng <micha@dietpi.com>

Fix core depending on theming app

This was introduced in https://github.com/nextcloud/server/commit/309354852f12ae88d5eef05d311d6ebcba8ee762
to fix a bug but I can't reproduce the bug after reverting this change.

Ideally we would need to create an interface in OCP and cleanup OC_Defaults
instead of depending on OC_Defaults.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #29716 from nextcloud/bump-doctrine-dbal-23

Bump doctrine/dbal to 3.1.4

Signed-off-by: Joas Schilling <coding@schilljs.com>

Allow NULL as well for limit, not integer only

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #29705 from nextcloud/backport/29679/stable23

[stable23] don't flash external storage mountpoints during the status check

don't flash external storage mountpoints during the status check

Signed-off-by: szaimen <szaimen@e.mail.de>