Avoid assignment in if clause

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix typing problems in OC_Image

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Avoid calling image* methods on boolean

This avoids fatal errors on PHP>=8, and warnings on older versions.
Log should also be clearer.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30216 from nextcloud/dependabot/composer/build/integration/stable21/sabre/dav-4.2.3

Update sabre/dav requirement from 4.2.1 to 4.2.3 in /build/integration

Update sabre/dav requirement from 4.2.1 to 4.2.3 in /build/integration

Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/compare/4.2.1...4.2.3)

---
updated-dependencies:
- dependency-name: sabre/dav
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30189 from nextcloud/backport/30164/stable21

[stable21] Use correct icon for dir-external-root

Use correct icon for dir-external-root

When an external storage mount is shared with circles, it triggers the
share icon state to be rerendered. The picking of the mime type icon
would use the regular file icon because there is no actual icon for
"dir-external-root" that is shared.

This fixes the logic to use the "folder-external" icon in such
scenarios.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #30182 from nextcloud/backport/30160/stable21

[stable21] Check resource before closing in encryption wrapper

Merge pull request #30178 from nextcloud/backport/30168/stable21

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Check resource before closing in encryption wrapper

In case of error there is no guarantee that $source or $target is set or
is a resource when handling an error.

Without this fix, there's a risk that fclose will fail and the actual
exception will not be thrown, making it impossible to find out about the
root cause.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Allow to delete non-migrated previews instead of moving them

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30056 from nextcloud/backport/29735/stable21

[stable21] find users for background scan one by one

Merge pull request #30153 from nextcloud/backport/30141/stable21

[stable21] Reload page instead of file list when getting 401 authentification error

Reload page on 401 since there is an authentification problem

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Stop reloading file list when getting 401 error on root dir

When reaching the root dir, instead of reloading the file list we reload
the page completely. This trigger a redirection to the login page automatically
with the correct ?redirect_url= in thr url.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #30138 from nextcloud/backport/30134/stable21

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

do not trigger events when setting active view in gotoplugin

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30109 from nextcloud/backport/30104/stable21

[stable21] Strengthify is now in the Nextcloud org

Merge pull request #29834 from nextcloud/carl/bugfix/file-search-21

Strengthify is now in the Nextcloud org

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30082 from nextcloud/dependabot/composer/build/integration/stable21/sabre/dav-4.2.1

Update sabre/dav requirement from 4.2.0 to 4.2.1 in /build/integration

Update sabre/dav requirement from 4.2.0 to 4.2.1 in /build/integration

Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/compare/4.2.0...4.2.1)

---
updated-dependencies:
- dependency-name: sabre/dav
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30064 from nextcloud/backport/30046/stable21

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Close open cursor in the caldav back-end

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #30023 from nextcloud/backport/30018/stable21

Fix collaborative tags styles

Signed-off-by: Christopher Ng <chrng8@gmail.com>

fix tests

Signed-off-by: Robin Appelman <robin@icewind.nl>

code checker fixes for instanceOfStorage

Signed-off-by: Robin Appelman <robin@icewind.nl>

stop background scan early if a users still has unscanned files after background scan

Signed-off-by: Robin Appelman <robin@icewind.nl>

find users for background scan one by one

Signed-off-by: Robin Appelman <robin@icewind.nl>

background scan the source storage when a background scan on a storage jail is triggered

Signed-off-by: Robin Appelman <robin@icewind.nl>

teach psalm about `Storage::instanceOfStorage`

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #30061 from nextcloud/fix/stable21/jsunit-job

Add missing node version matrix for jsunit job

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #30039 from nextcloud/backport/30028/stable21

[stable21] Fix log_query config flag

Fix log_query config flag

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29997 from nextcloud/backport/27732/stable21

[stable21] Fix LDAPProviderFactory not found

unset ldap provider when disabling user_ldap

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

ensure that factoryClass exisits before instantiation

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29979 from nextcloud/backport/29974/stable21

[stable21] Let repair step query exceptions bubble up

Include previous execption for repair steps that don't exist

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Let repair step query exceptions bubble up

And hide the type error caused by a constructor call with missing
arguments.

`new $repairStep();` only works for the rare case that no arguments are
required. Anything else will throw. Then we previously hid the trace of
the more important query exception.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix search results filtering

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #29907 from nextcloud/backport/29902/stable21

[stable21] Check for invalid characters before trimming

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29803 from nextcloud/backport/29632/stable21

[stable21] fix imagecreatetruecolor() error

Merge pull request #28199 from nextcloud/backport/26936/stable21

[stable21] better cleanup of filecache when deleting an external storage

Correctly set the response after a ClientException as well

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add an integration test

Signed-off-by: Joas Schilling <coding@schilljs.com>

Check for invalid characters before trimming

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #29851 from nextcloud/backport/29836/stable21

[stable21] Make sure mapping cache is cleared when deleting a user

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29883 from nextcloud/backport/28519/stable21

Add active user count to occ user:report

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Use pre-v22 query commands

Signed-off-by: MichaIng <micha@dietpi.com>

better cleanup of filecache when deleting an external storage

this way it can delete the cache entries even with per-user credentials

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #29764 from nextcloud/backport/29752/stable21

[stable21] Explicitly allow some routes without 2FA

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29853 from nextcloud/backport/29835/stable21

[stable21] Fix getting subnet of ipv4 mapped ipv6 addresses

Type hint in IpAddress

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>

Improve normalizer detecting IPv4 inside of IPv6

The subnet for an IPv4 address inside of IPv6 is now returned in its
IPv4 form.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix getting subnet of ipv4 mapped ipv6 addresses

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Test cache invalidation for AbstractMapping in test suite

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Make sure mapping cache is cleared when deleting a user

This avoids phantom remnants staying after user deletion

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #29629 from nextcloud/backport/29611/stable21

[stable21] Show most recently deleted files first in trash can

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29840 from nextcloud/backport/29708/stable21

[stable21] Do not print verbose info about app updates if there are none

Do not print verbose info about app updates if there are none

This is cosmetical but if you have a large number of apps installed then
you'll see a wall of text during the server and app upgrade when it
tries to update each app via the app store. In may cases nothing will be
updated. For those boring cases we can hide the verbose info, but show
when occ is run with -v. Any actual update will still print a few lines.
Those are the important ones for the admin.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #29810 from nextcloud/dependabot/composer/build/integration/stable21/sabre/dav-4.2.0

Update sabre/dav requirement from 3.2.3 to 4.2.0 in /build/integration

Manual compilation

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #29811 from nextcloud/dependabot/npm_and_yarn/stable21/camelcase-6.2.1

Bump camelcase from 6.2.0 to 6.2.1

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29794 from nextcloud/backport/29605/stable21

[stable21] Normalize file name before existence check in scanner

Bump camelcase from 6.2.0 to 6.2.1

Bumps [camelcase](https://github.com/sindresorhus/camelcase) from 6.2.0 to 6.2.1.
- [Release notes](https://github.com/sindresorhus/camelcase/releases)
- [Commits](https://github.com/sindresorhus/camelcase/compare/v6.2.0...v6.2.1)

---
updated-dependencies:
- dependency-name: camelcase
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Update sabre/dav requirement from 3.2.3 to 4.2.0 in /build/integration

Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/compare/3.2.3...4.2.0)

---
updated-dependencies:
- dependency-name: sabre/dav
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix imagecreatetruecolor() error

Signed-off-by: szaimen <szaimen@e.mail.de>

Normalize directory entries in Encoding wrapper

Directory entry file names are now normalized in getMetaData(),
getDirectoryContents() and opendir().

This makes the scanner work properly as it assumes pre-normalized names.

In case the names were not normalized, the scanner will now skip the
entries and display a warning when applicable.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Move storage encoding compatibility warning logic

The encoding check for file names is now happening the Scanner, and an
event will be emitted only if the storage doesn't contain the encoding
compatibility wrapper.

The event is listened to by the occ scan command to be able to display a
warning in case of file name mismatches when they have NFD encoding.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Normalize file name before existence check in scanner

The scanner would not find a NFD-encoded file name in an
existing file list that is normalized.

This normalizes the file name before scanning.

Fixes issues where scanning repeatedly would make NFD files flicker in
and out of existence in the file cache.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>