fix potential unwarranted memberships in nested groups from LDAP

- the issue was present only when using PHP based resolving of nested
  group members. Normally nested members are common in AD (and Samba4) and
  are resolved per LDAP_MATCHING_RULE_IN_CHAIN by default
- resolving nested members is recursive
- when the cache entry was created it happend for intermediate groups, too,
  containing members from the parent group
- the check was added to only cache the root group with its members
- a runtime cache stores intermediate ldap read results

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30327 from nextcloud/dependabot/composer/build/integration/stable21/sabre/dav-4.3.0

Update sabre/dav requirement from 4.2.3 to 4.3.0 in /build/integration

Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/compare/4.2.3...4.3.0)

---
updated-dependencies:
- dependency-name: sabre/dav
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30192 from nextcloud/backport/30157/stable21

[stable21] Properly format sharing datepicker locale

Manual compilation

Signed-off-by: Louis Chemineau <louis@chmn.me>

Fix first day locale

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Properly format sharing datepicker locale

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Merge pull request #30287 from nextcloud/backport/30256/stable21

[stable21] Fix ShareLink Upload UI for Folders

Merge pull request #30261 from nextcloud/backport/29523/stable21

[stable21] Support LDAP dns longer than 255 characters

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Build assets

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>

Fix ShareLink Upload UI for Folders

Do not show the Upload-Option if it is not allowed to check.

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>

Merge pull request #30270 from nextcloud/search-folder-case-insensitive-21

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

also use case sensitive like when searching in a folder

this case was missed from https://github.com/nextcloud/server/pull/29080

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #30117 from nextcloud/backport/30040/stable21

[stable21] Avoid calling image* methods on boolean

Avoid assignment in if clause

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix typing problems in OC_Image

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Avoid calling image* methods on boolean

This avoids fatal errors on PHP>=8, and warnings on older versions.
Log should also be clearer.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Adapt execute function name for stable21

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Bump user_ldap version to make sure the migration runs

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Add missing copyright headers in migration steps

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Use clearer names for variables

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Add an index for directory_uuid as well

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Make sure that hash function returns a string

The documentation says it can return false, and even if that is highly
 unlikely for sha256, better safe than sorry.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Add the columns and alter the index in Version1010Date20200630192842

This is to ensure new installations do not need to go through migration
 history.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fixes in migration step

We cannot set ldap_dn_hash column as notnull because it is empty for
 existing users before postSchemaChange is called

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Put back length check to have a clear error

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fixed migration step for user_ldap

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix variable names

Signed-off-by: Joas Schilling <coding@schilljs.com>

Change column names to ldap_dn and ldap_dn_hash and add migration

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Support LDAP dns longer than 255 characters

Adds an ldap_full_dn column to store the dn, and only store a sha256
 hash in the ldap_dn which is shorter and can be indexed without
 trouble.
Migration still needs to be implemented.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30216 from nextcloud/dependabot/composer/build/integration/stable21/sabre/dav-4.2.3

Update sabre/dav requirement from 4.2.1 to 4.2.3 in /build/integration

Update sabre/dav requirement from 4.2.1 to 4.2.3 in /build/integration

Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/compare/4.2.1...4.2.3)

---
updated-dependencies:
- dependency-name: sabre/dav
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30189 from nextcloud/backport/30164/stable21

[stable21] Use correct icon for dir-external-root

Use correct icon for dir-external-root

When an external storage mount is shared with circles, it triggers the
share icon state to be rerendered. The picking of the mime type icon
would use the regular file icon because there is no actual icon for
"dir-external-root" that is shared.

This fixes the logic to use the "folder-external" icon in such
scenarios.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #30182 from nextcloud/backport/30160/stable21

[stable21] Check resource before closing in encryption wrapper

Merge pull request #30178 from nextcloud/backport/30168/stable21

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Check resource before closing in encryption wrapper

In case of error there is no guarantee that $source or $target is set or
is a resource when handling an error.

Without this fix, there's a risk that fclose will fail and the actual
exception will not be thrown, making it impossible to find out about the
root cause.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Allow to delete non-migrated previews instead of moving them

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30056 from nextcloud/backport/29735/stable21

[stable21] find users for background scan one by one

Merge pull request #30153 from nextcloud/backport/30141/stable21

[stable21] Reload page instead of file list when getting 401 authentification error

Reload page on 401 since there is an authentification problem

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Stop reloading file list when getting 401 error on root dir

When reaching the root dir, instead of reloading the file list we reload
the page completely. This trigger a redirection to the login page automatically
with the correct ?redirect_url= in thr url.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #30138 from nextcloud/backport/30134/stable21

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

do not trigger events when setting active view in gotoplugin

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30109 from nextcloud/backport/30104/stable21

[stable21] Strengthify is now in the Nextcloud org

Merge pull request #29834 from nextcloud/carl/bugfix/file-search-21

Strengthify is now in the Nextcloud org

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30082 from nextcloud/dependabot/composer/build/integration/stable21/sabre/dav-4.2.1

Update sabre/dav requirement from 4.2.0 to 4.2.1 in /build/integration

Update sabre/dav requirement from 4.2.0 to 4.2.1 in /build/integration

Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/compare/4.2.0...4.2.1)

---
updated-dependencies:
- dependency-name: sabre/dav
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30064 from nextcloud/backport/30046/stable21

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Close open cursor in the caldav back-end

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #30023 from nextcloud/backport/30018/stable21

Fix collaborative tags styles

Signed-off-by: Christopher Ng <chrng8@gmail.com>

fix tests

Signed-off-by: Robin Appelman <robin@icewind.nl>

code checker fixes for instanceOfStorage

Signed-off-by: Robin Appelman <robin@icewind.nl>

stop background scan early if a users still has unscanned files after background scan

Signed-off-by: Robin Appelman <robin@icewind.nl>

find users for background scan one by one

Signed-off-by: Robin Appelman <robin@icewind.nl>

background scan the source storage when a background scan on a storage jail is triggered

Signed-off-by: Robin Appelman <robin@icewind.nl>

teach psalm about `Storage::instanceOfStorage`

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #30061 from nextcloud/fix/stable21/jsunit-job

Add missing node version matrix for jsunit job

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #30039 from nextcloud/backport/30028/stable21

[stable21] Fix log_query config flag

Fix log_query config flag

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29997 from nextcloud/backport/27732/stable21

[stable21] Fix LDAPProviderFactory not found

unset ldap provider when disabling user_ldap

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

ensure that factoryClass exisits before instantiation

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29979 from nextcloud/backport/29974/stable21

[stable21] Let repair step query exceptions bubble up

Include previous execption for repair steps that don't exist

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Let repair step query exceptions bubble up

And hide the type error caused by a constructor call with missing
arguments.

`new $repairStep();` only works for the rare case that no arguments are
required. Anything else will throw. Then we previously hid the trace of
the more important query exception.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix search results filtering

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #29907 from nextcloud/backport/29902/stable21

[stable21] Check for invalid characters before trimming

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #29803 from nextcloud/backport/29632/stable21

[stable21] fix imagecreatetruecolor() error

Merge pull request #28199 from nextcloud/backport/26936/stable21

[stable21] better cleanup of filecache when deleting an external storage

Correctly set the response after a ClientException as well

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add an integration test

Signed-off-by: Joas Schilling <coding@schilljs.com>