Remove inefficient fed share scanner

Remove scanAll which relies on the "shareinfo" endpoint that returns the
full cache tree.
The latter can become big for big shares and result in timeouts.
Furthermode, the full tree would be retrieved again for each and every
detected change which can become expensive quickly.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #30669 from nextcloud/backport/30363/stable21

[stable21] improve accessibility settings on mobile

Merge pull request #30667 from nextcloud/backport/30568/stable21

[stable21] Fix primary key change in user_ldap migration

address 2nd review

Signed-off-by: szaimen <szaimen@e.mail.de>

address review

Signed-off-by: szaimen <szaimen@e.mail.de>

improve accessibility settings on mobile

Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #30642 from nextcloud/backport/30600/stable21

[stable21] Fix idn emails not working in shares

Remove useless indexes with duplicated names on backup table

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Update autoloader

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix user_ldap migration for long DNs support

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Move duplicated code to a base class for group_mapping migrations

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>

Split dropTable and createTable in two migrations

It is not possible to drop and create the same table in one migration

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix primary key change in user_ldap migration

Use a backup table to copy the data, drop table and recreate it with
 correct primary key, then copy the data back and drop the backup table.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #30596 from nextcloud/fix/static_analysis

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30599 from nextcloud/backport/29118/stable21

[stable21] add better index for finding unindexed paths

Fix static analysis on CI

Signed-off-by: Louis Chemineau <louis@chmn.me>

Fix idn emails not working in shares

And add check before sending email that email address is valid

Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

add better index for finding unindexed paths

for the following query 'SELECT "path" FROM "oc_filecache" WHERE ("storage" = $storage) AND ("size" < 0) ORDER BY "fileid" DESC LIMIT 1;'

currently the database will in some cases decide to priorize the sort by fileid over the filter when picking what index to use, resulting in a much slower query.

by creating an index that allows first sorting by fileid and also filter by storage and size this case will be greatly sped up

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #30638 from nextcloud/backport/30620/stable21

[stable21] Properly abort uploads

Properly hide progress bar after error

Whenever an error occurs, also hide the progress bar.

The logic was also adjusted to properly detect uploads that are pending
deletion, in which case the progress bar can already be hidden.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Properly abort uploads

Add a new approach for flagging an upload as aborted because we can't
rely on the browser fully cancelling the request as we now seem to
receive an error response from the server instead of a jQuery "abort"
message.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30629 from nextcloud/backport/30593/stable21

[stable21] Trigger "changeDirectory" event on URL change

Trigger "changeDirectory" even on URL change

When using the browser back button or clicking on sections on the left
sidebar (like favorites), the "changeDirectory" jQuery event did not get
called, so apps like recommendations would not notice the directory
change.

This fixes the issue by also setting changeUrl to true when the file
list's directory got changed as a result from a URL change.

Added optional changedThroughUrl argument to make sure the event
recipient knows if the change was done through a URL change and make it
possible prevent a loop in the onDirectoryChange handler that actually
changes the URL when the origin was already from a URL change.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #30617 from nextcloud/backport/30609/stable21

[stable21] Fix RequestURL check for cli commands

Merge pull request #30601 from nextcloud/backport/30291/stable21

[stable21] Prevent loading images that would require too much memory.

Fix RequestURL check for cli commands

Fix https://github.com/nextcloud/files_automatedtagging/issues/526

Fix https://github.com/nextcloud/groupfolders/issues/1855

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Prevent loading images that would require too much memory.

For most image formats, the header specifies the width/height.
PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited
by the limit configured in PHP.

The memory limit can be configured through "config.php" setting
"preview_max_memory" and defaults to 128 MBytes which should be
enough for most images without filling up all memory.

Signed-off-by: Joachim Bauch <bauch@struktur.de>

Merge pull request #30590 from nextcloud/backport/30571/stable21

[stable21] fix: only use jquery once it is available

Merge pull request #30579 from nextcloud/backport/30565/stable21

[stable21] Fix fail when keys/files folder already exists

Merge pull request #30583 from nextcloud/bugfix/noid/npm-ci-for-karma/stable21

[stable21] Use npm ci when running JS tests

fix: only use jquery once it is available

publicpage.js is loaded very early and cannot rely on jquery being loaded already.

Move the use of `$` into the `DomContentLoaded` handler.

Signed-off-by: Azul <azul@riseup.net>

Fix fail when keys/files folder already exists

Fixes an issue with transfer ownership in move mode where the folder
"files_encryption/keys/files" already exists.

Instead of failing, its existence is checked before calling mkdir.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Update package-lock in build dir

It wasn't up to date with package.json

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Recompile JS

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix JS tests after test lib updates

Prevent XHR during load by checking window.TESTING.
Adjust some expected values.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Make chokidar happy with fsevents

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Update node deps for JS tests

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Use npm ci when running JS tests

This makes sure that the pinned versions are selected correctly.
Fixes the colors.js incident.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30559 from nextcloud/backport/30468/stable21

[stable21] Handle LocalServerException when scanning external shares

Handle LocalServerException when scanning external shares

When remoteIsOwnCloud trows LocalServerException, the storage is
unavailable and instead of crashing the scanner, ignore the specific
storage.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30454 from nextcloud/backport/30420/stable21

[stable21] improve status modal

fix compiling

Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30527 from nextcloud/backport/30511/stable21

[stable21]  update CRL after revocation of sharerenamer.crt

Merge pull request #30520 from nextcloud/release/21.0.8

Merge pull request #30488 from nextcloud/backport/29780/stable21

Merge pull request #30521 from nextcloud/backport/30515/stable21

[stable21] Remove iconv from dependencies and tests

Update crl

Signed-off-by: Vitor Mattos <vitor@php.rio>

Merge pull request #30524 from nextcloud/backport/30492/stable21

[stable21] Fix passing on the parameter

[stable22] Remove iconv from dependencies and tests

which is not used anymore since: https://github.com/nextcloud/server/pull/29470

Signed-off-by: MichaIng <micha@dietpi.com>

Fix passing on the parameter

Signed-off-by: Joas Schilling <coding@schilljs.com>

Run migrations fully when reenabling an app

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #30482 from nextcloud/backport/30423/stable21

Merge pull request #29963 from nextcloud/backport/29951/stable21

Merge pull request #29325 from nextcloud/backport/28541/stable21

Merge pull request #28657 from nextcloud/backport/28419/stable21

21.0.8 RC1

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix uploading text position

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30448 from nextcloud/backport/30440/stable21

[stable21] Make sure to get file model in template picker

Merge pull request #30435 from nextcloud/backport/30392/stable21

[stable21] Add missing index for propertypath only queries of DAV properties

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

improve status modal

Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Manual compilation

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix template picker for file actions using the fileInfoModel

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #30341 from nextcloud/backport/29329/stable21

[stable21] fix potential unwarranted memberships in nested groups from LDAP

Merge pull request #30442 from nextcloud/backport/30353/stable21

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Handle external share with invalid host

remoteIsOwnCloud might throw an exception when the host is localhost.
Handle this case instead of aborting completely. The behavior is the
same as that is done 10 lines under it

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Add missing index for propertypath only queries against properties

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30314 from nextcloud/backport/30266/stable21

Fix share owner not being displayed in sharing tab

This only concerns subfolder and files inside a shared folder and is
used as fallback when the OCS api returns a empty result, because it
only works on the shared folder and not the content inside of it.
This unify the tab with the folder list.

This offers a less descriptive share information but making the
OCS api returns all the details even for the subfolder would very
probably be bad for performance (since we would need to fetch the shares
for all the parent folders until we found one or are in the root folder).

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #30251 from nextcloud/backport/30193/stable21

[stable21] Fix setting up 2FA when no providers are set up but backup codes

Merge pull request #30248 from nextcloud/backport/30245/stable21

[stable21] Only wildcard search if enumeration is allowed

Merge pull request #30348 from nextcloud/backport/29965/stable21

[stable21] [stable23] Avoid use of iconv to get rid of unicode

Merge pull request #30346 from nextcloud/backport/30322/stable21

[stable21] fix overlapping in the help settings section

[stable23] Avoid use of iconv to get rid of unicode

Using iconv for translit depends upon server configuration, locale, and
 PHP version. Using htmlentities instead to have a consistent behavior
 independent of configuration.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: MichaIng <micha@dietpi.com>

fix overlapping in the help settings section

Signed-off-by: szaimen <szaimen@e.mail.de>

Merge pull request #30308 from nextcloud/backport/30281/stable21

[stable21] Ignore non-existing groups when notifying group shares

fix potential unwarranted memberships in nested groups from LDAP

- the issue was present only when using PHP based resolving of nested
  group members. Normally nested members are common in AD (and Samba4) and
  are resolved per LDAP_MATCHING_RULE_IN_CHAIN by default
- resolving nested members is recursive
- when the cache entry was created it happend for intermediate groups, too,
  containing members from the parent group
- the check was added to only cache the root group with its members
- a runtime cache stores intermediate ldap read results

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>