]>
source.dussan.org Git - nextcloud-server.git/log
Joas Schilling [Thu, 20 Oct 2022 15:02:28 +0000 (17:02 +0200)]
Recompile
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Thu, 20 Oct 2022 14:58:13 +0000 (16:58 +0200)]
Use @nextcloud/vue MultiselectTags component
Signed-off-by: Joas Schilling <coding@schilljs.com>
Carl Schwan [Thu, 20 Oct 2022 14:53:43 +0000 (16:53 +0200)]
Merge pull request #34624 from nextcloud/fix/files_external_psalm
Multiple fix for files external
Côme Chilliet [Thu, 20 Oct 2022 13:03:37 +0000 (15:03 +0200)]
Merge pull request #30223 from nextcloud/nested_ldap_groups
Nested ldap groups
Côme Chilliet [Thu, 20 Oct 2022 12:48:50 +0000 (14:48 +0200)]
Merge pull request #33703 from nextcloud/fix/ldap-simplify-paged-results
Clean up paged result handling.
Carl Schwan [Thu, 20 Oct 2022 10:01:19 +0000 (12:01 +0200)]
Fix psalm
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Thu, 20 Oct 2022 09:30:46 +0000 (11:30 +0200)]
Check if cache is present with isset
Otherwise we get false for empty array
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Côme Chilliet [Tue, 30 Aug 2022 14:46:00 +0000 (16:46 +0200)]
Bring back small fixes by Carl
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Tue, 26 Jul 2022 07:39:48 +0000 (09:39 +0200)]
Fix LDAP recursive nested group support
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Carl Schwan [Thu, 21 Jul 2022 15:37:30 +0000 (17:37 +0200)]
Revert Carl changes on apps/user_ldap/lib/Group_LDAP.php
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Côme Chilliet [Thu, 20 Oct 2022 10:56:54 +0000 (12:56 +0200)]
Fix autoload
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Wed, 28 Sep 2022 13:27:04 +0000 (15:27 +0200)]
Cleanup typing and improve logging
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Thu, 8 Sep 2022 14:29:23 +0000 (16:29 +0200)]
Fix ldap_parse_result call
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Thu, 8 Sep 2022 12:47:50 +0000 (14:47 +0200)]
Adapt interface to new search signature
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Thu, 8 Sep 2022 12:44:42 +0000 (14:44 +0200)]
Pass paging information directly to search and get rid of adapter
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Thu, 8 Sep 2022 10:06:08 +0000 (12:06 +0200)]
Renamed ambiguous $limit parameter to pageSize
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Thu, 8 Sep 2022 09:33:43 +0000 (11:33 +0200)]
Unfold call to ldap_parse_result. Handle cookie outside of adapter.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Thu, 1 Sep 2022 13:13:52 +0000 (15:13 +0200)]
Do not init a paged search for read operations
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Thu, 1 Sep 2022 13:09:00 +0000 (15:09 +0200)]
Remove useless getReadArgs/setReadArgs methods from PagedResults
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Thu, 25 Aug 2022 14:57:25 +0000 (16:57 +0200)]
Remove dead code in paged result handling
There is only one paged result API now that PHP 7.2 is long dead.
Starting by removing empty function calls.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Carl Schwan [Thu, 21 Jul 2022 15:24:22 +0000 (17:24 +0200)]
Fix user_ldap tests
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Mon, 18 Jul 2022 08:06:41 +0000 (10:06 +0200)]
Add back runtime cache for intermediate ldap read results
This is a small optimization that save a few LDAP queries
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Mon, 18 Jul 2022 07:58:30 +0000 (09:58 +0200)]
Only cache base inGroup search
And not intermediate search for nested groups, this is causing issues
othewise with nested groups
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Côme Chilliet [Tue, 14 Dec 2021 13:30:50 +0000 (14:30 +0100)]
Add missing copyright author in Group_LDAP
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Tue, 14 Dec 2021 12:51:18 +0000 (13:51 +0100)]
Removed unused use declaration
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Tue, 14 Dec 2021 10:13:46 +0000 (11:13 +0100)]
Fix types in docblocks
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Tue, 14 Dec 2021 09:51:39 +0000 (10:51 +0100)]
Add testing of nested group membership
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Tue, 14 Dec 2021 09:17:08 +0000 (10:17 +0100)]
Refactor group membership listing for nested groups
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Mon, 13 Dec 2021 15:02:59 +0000 (16:02 +0100)]
Add tests for nested groups
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Mon, 13 Dec 2021 15:02:05 +0000 (16:02 +0100)]
Small optimisation of _groupMembers
This will not change the result as users are check to be existing
afterwards but avoids this check when we know it’s a group.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Mon, 13 Dec 2021 11:17:06 +0000 (12:17 +0100)]
Refactor _groupMembers to correctly use cache on intermediate results
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Carl Schwan [Fri, 10 Dec 2021 15:39:50 +0000 (16:39 +0100)]
Fix merging list with null
This fixes some cases observed with the debugger where we end up merging
a non empty list with null. The result is then null and the looping over
the items would then end.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Thu, 9 Dec 2021 10:51:13 +0000 (11:51 +0100)]
Unify a bit the types of the fetcher
Now it will only accept a string as parameter instead of either a string
(DN) or a array (complete record).
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Fri, 10 Dec 2021 15:36:14 +0000 (16:36 +0100)]
Add more type hinting
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Arthur Schiwon [Sun, 12 Dec 2021 13:14:16 +0000 (14:14 +0100)]
Cache intermediates
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Arthur Schiwon [Sun, 12 Dec 2021 13:11:31 +0000 (14:11 +0100)]
Refactor code to split common loop
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Arthur Schiwon [Sun, 12 Dec 2021 13:09:16 +0000 (14:09 +0100)]
Make it possible to return nested records whem walking over groups
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Nextcloud bot [Thu, 20 Oct 2022 02:18:39 +0000 (02:18 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Pytal [Wed, 19 Oct 2022 23:02:33 +0000 (16:02 -0700)]
Merge pull request #34665 from nextcloud/fix/invert-header-icons
Invert header icons on bright preset backgrounds
Christopher Ng [Wed, 19 Oct 2022 02:07:12 +0000 (02:07 +0000)]
Invert header icons on bright preset backgrounds
Signed-off-by: Christopher Ng <chrng8@gmail.com>
John Molakvoæ [Wed, 19 Oct 2022 15:13:15 +0000 (17:13 +0200)]
Merge pull request #34576 from nextcloud/fix/user-theming-admin-overrride
Add admin user customization kill switch
John Molakvoæ [Wed, 19 Oct 2022 10:23:24 +0000 (12:23 +0200)]
Simplify variable names
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
John Molakvoæ [Wed, 19 Oct 2022 10:22:54 +0000 (12:22 +0200)]
Fix tests
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
John Molakvoæ [Thu, 13 Oct 2022 12:22:04 +0000 (14:22 +0200)]
Add admin user customization kill switch
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
John Molakvoæ [Thu, 13 Oct 2022 10:10:56 +0000 (12:10 +0200)]
Adjust testing
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
John Molakvoæ [Wed, 19 Oct 2022 09:20:30 +0000 (11:20 +0200)]
Merge pull request #34668 from nextcloud/dependabot/npm_and_yarn/jest-environment-jsdom-29.2.1
Bump jest-environment-jsdom from 29.0.3 to 29.2.1
John Molakvoæ [Wed, 19 Oct 2022 09:12:47 +0000 (11:12 +0200)]
Merge pull request #26358 from nextcloud/fix/ie-cleanup
Cleanup old IE/edge properties and implement unsupported browser error page
John Molakvoæ [Wed, 19 Oct 2022 07:08:21 +0000 (09:08 +0200)]
Add config and fix selenium
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
John Molakvoæ [Tue, 18 Oct 2022 18:12:04 +0000 (20:12 +0200)]
Compile assets
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
John Molakvoæ (skjnldsv) [Sat, 27 Mar 2021 09:37:22 +0000 (10:37 +0100)]
Cleanup ie and old edge properties
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
dependabot[bot] [Wed, 19 Oct 2022 07:56:10 +0000 (07:56 +0000)]
Bump jest-environment-jsdom from 29.0.3 to 29.2.1
Bumps [jest-environment-jsdom](https://github.com/facebook/jest/tree/HEAD/packages/jest-environment-jsdom) from 29.0.3 to 29.2.1.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v29.2.1/packages/jest-environment-jsdom)
---
updated-dependencies:
- dependency-name: jest-environment-jsdom
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Joas Schilling [Wed, 19 Oct 2022 07:54:54 +0000 (09:54 +0200)]
Merge pull request #34639 from nextcloud/dependabot/npm_and_yarn/moment-timezone-0.5.38
Bump moment-timezone from 0.5.37 to 0.5.38
Joas Schilling [Wed, 19 Oct 2022 07:46:39 +0000 (09:46 +0200)]
Merge pull request #34664 from nextcloud/nickvergessen-patch-1
Update OCI workflow of server
Nextcloud bot [Wed, 19 Oct 2022 02:14:41 +0000 (02:14 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Joas Schilling [Tue, 18 Oct 2022 21:02:52 +0000 (23:02 +0200)]
Update OCI workflow of server
* Only on pull requests
* Concurrency group
* Bump used actions
* Add summary
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Joas Schilling [Tue, 18 Oct 2022 20:27:34 +0000 (22:27 +0200)]
Merge pull request #34650 from nextcloud/bugfix/noid/fix-rebuildNavigation
Fix rebuild navigation
Joas Schilling [Tue, 18 Oct 2022 09:18:32 +0000 (11:18 +0200)]
🤖 Rebuild
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Tue, 18 Oct 2022 09:17:52 +0000 (11:17 +0200)]
🧭 Fix rebuilding the navigation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Simon L [Tue, 18 Oct 2022 17:44:51 +0000 (19:44 +0200)]
Merge pull request #34614 from nextcloud/bugfix/34441/fix-search-in-regexp
Fix regexp for unified searching in apps
Côme Chilliet [Tue, 18 Oct 2022 15:29:17 +0000 (17:29 +0200)]
Merge pull request #34632 from nextcloud/fix/rate-limit-recovery-emails
Add rate limiting on lost password emails
Carl Schwan [Tue, 18 Oct 2022 10:49:34 +0000 (12:49 +0200)]
Rename file1 and file2 to source and target in Storage abstraction
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Tue, 18 Oct 2022 14:59:57 +0000 (16:59 +0200)]
Merge pull request #34625 from nextcloud/fix/filepicker-endtoend
Fix icon of encrypted folders in filepicker
Côme Chilliet [Tue, 18 Oct 2022 13:18:40 +0000 (15:18 +0200)]
Fix LostController test
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Mon, 17 Oct 2022 12:36:24 +0000 (14:36 +0200)]
Add rate limiting on lost password emails
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Carl Schwan [Tue, 18 Oct 2022 12:44:28 +0000 (14:44 +0200)]
Merge pull request #34628 from nextcloud/fix/files_sharing_psalm
Various psalm fixes in files_sharing
Carl Schwan [Tue, 18 Oct 2022 12:42:43 +0000 (14:42 +0200)]
Merge pull request #34554 from nextcloud/fix/psalm-twofactor-registry
Fix wrong types in phpdoc for twofactor registry
Carl Schwan [Tue, 18 Oct 2022 11:22:50 +0000 (13:22 +0200)]
Fix the type of the return array in a few more places
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Tue, 18 Oct 2022 10:22:40 +0000 (12:22 +0200)]
Additional type hinting found by psalm
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Christoph Wurst [Tue, 18 Oct 2022 09:19:33 +0000 (11:19 +0200)]
Merge pull request #34379 from nextcloud/fix/transactional-session-token-renewal
Run session token renewals in a database transaction
Simon L [Tue, 18 Oct 2022 09:01:36 +0000 (11:01 +0200)]
Merge pull request #34636 from nextcloud/fix/user-status-dislexia
Fix vertical alignment of user status icon
blizzz [Tue, 18 Oct 2022 08:24:53 +0000 (10:24 +0200)]
Merge pull request #34620 from nextcloud/fix/cleanup-theming-cache
Add a repair step to cleanup old theming cache
Carl Schwan [Tue, 18 Oct 2022 08:21:21 +0000 (10:21 +0200)]
Merge pull request #34634 from nextcloud/fix/focus-file-selection
Fix unnecessary highlighting of selected element
blizzz [Tue, 18 Oct 2022 08:13:56 +0000 (10:13 +0200)]
Merge pull request #34609 from nextcloud/enh/noid/always-enable-theming
set theming app to alwaysEnabled
Carl Schwan [Mon, 17 Oct 2022 21:40:24 +0000 (23:40 +0200)]
Make css rule important
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Christoph Wurst [Sun, 2 Oct 2022 12:11:41 +0000 (14:11 +0200)]
Run session token renewals in a database transaction
The session token renewal does
1) Read the old token
2) Write a new token
3) Delete the old token
If two processes succeed to read the old token there can be two new tokens because
the queries were not run in a transaction. This is particularly problematic on
clustered DBs where 1) would go to a read node and 2) and 3) go to a write node.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Nextcloud bot [Tue, 18 Oct 2022 02:14:38 +0000 (02:14 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Christopher Ng [Sat, 15 Oct 2022 02:21:58 +0000 (02:21 +0000)]
Add a repair step to cleanup old theming cache
Signed-off-by: Christopher Ng <chrng8@gmail.com>
dependabot[bot] [Mon, 17 Oct 2022 23:58:55 +0000 (23:58 +0000)]
Bump moment-timezone from 0.5.37 to 0.5.38
Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.37 to 0.5.38.
- [Release notes](https://github.com/moment/moment-timezone/releases)
- [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md)
- [Commits](https://github.com/moment/moment-timezone/compare/0.5.37...0.5.38)
---
updated-dependencies:
- dependency-name: moment-timezone
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Pytal [Mon, 17 Oct 2022 23:42:53 +0000 (16:42 -0700)]
Merge pull request #34643 from nextcloud/dependabot/npm_and_yarn/exports-loader-4.0.0
dependabot[bot] [Mon, 17 Oct 2022 22:30:59 +0000 (22:30 +0000)]
Bump exports-loader from 3.1.0 to 4.0.0
Bumps [exports-loader](https://github.com/webpack-contrib/exports-loader) from 3.1.0 to 4.0.0.
- [Release notes](https://github.com/webpack-contrib/exports-loader/releases)
- [Changelog](https://github.com/webpack-contrib/exports-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/exports-loader/compare/v3.1.0...v4.0.0)
---
updated-dependencies:
- dependency-name: exports-loader
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Louis [Mon, 17 Oct 2022 22:29:46 +0000 (00:29 +0200)]
Merge pull request #33725 from nextcloud/dependabot/npm_and_yarn/webdav-4.11.0
Bump webdav from 4.8.0 to 4.11.0
dependabot[bot] [Mon, 17 Oct 2022 15:29:42 +0000 (15:29 +0000)]
Bump webdav from 4.8.0 to 4.11.0
Bumps [webdav](https://github.com/perry-mitchell/webdav-client) from 4.8.0 to 4.11.0.
- [Release notes](https://github.com/perry-mitchell/webdav-client/releases)
- [Changelog](https://github.com/perry-mitchell/webdav-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/perry-mitchell/webdav-client/compare/v4.8.0...v4.11.0)
---
updated-dependencies:
- dependency-name: webdav
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
John Molakvoæ [Mon, 17 Oct 2022 18:17:12 +0000 (20:17 +0200)]
Merge pull request #34631 from nextcloud/chore/no-automatic-dependabot-rebase
szaimen [Fri, 14 Oct 2022 13:25:02 +0000 (15:25 +0200)]
set theming app to alwaysEnabled
Signed-off-by: szaimen <szaimen@e.mail.de>
Louis [Mon, 17 Oct 2022 15:27:41 +0000 (17:27 +0200)]
Merge pull request #34622 from nextcloud/dependabot/npm_and_yarn/jquery-ui-dist-1.13.2
Bump jquery-ui-dist from 1.13.1 to 1.13.2
Carl Schwan [Mon, 17 Oct 2022 14:08:27 +0000 (16:08 +0200)]
Fix vertical alignment of user status icon
Now it is properly centered even if the font size is bigger (when using
the dislexia font)
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Mon, 17 Oct 2022 14:02:58 +0000 (16:02 +0200)]
Merge pull request #31499 from nextcloud/bugfix/empty-secret
Add fallback routines for empty secret cases
Carl Schwan [Mon, 17 Oct 2022 13:29:02 +0000 (15:29 +0200)]
Fix unnecessary highlighting of selected element
Use focus-visible to only show focus ring on keyboard navigation
Fix #34589
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Christoph Wurst [Mon, 17 Oct 2022 11:26:57 +0000 (13:26 +0200)]
Merge pull request #34563 from nextcloud/debt/noid/carddav-too-many-arguments
Fix TooManyArguments warning for carddav.php
Christoph Wurst [Mon, 17 Oct 2022 11:26:32 +0000 (13:26 +0200)]
Merge pull request #34565 from nextcloud/debt/noid/fakelocker-too-many-arguments
Fix TooManyArguments for FakeLockerPlugin
Christoph Wurst [Mon, 17 Oct 2022 11:18:26 +0000 (13:18 +0200)]
Disable automatic Dependabot rebases
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Carl Schwan [Mon, 17 Oct 2022 10:40:35 +0000 (12:40 +0200)]
Fix various other small psalm issues
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Mon, 17 Oct 2022 10:38:49 +0000 (12:38 +0200)]
Fix incorrect argument name in inherited method
The arguments now need to be the same as in the parent method
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Mon, 17 Oct 2022 10:38:21 +0000 (12:38 +0200)]
Fix checkpassword undocummented null parameter
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Mon, 17 Oct 2022 10:37:46 +0000 (12:37 +0200)]
Fix permission not being int
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Mon, 17 Oct 2022 10:36:50 +0000 (12:36 +0200)]
Fix exception getCode type
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Mon, 17 Oct 2022 10:36:05 +0000 (12:36 +0200)]
Fix type when getting appconfig with int
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Mon, 17 Oct 2022 09:51:51 +0000 (11:51 +0200)]
Specify type to internal storage class
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Mon, 17 Oct 2022 09:51:02 +0000 (11:51 +0200)]
Fix returning null when getMessage return null
Don't overwrite $message but instead create another temporary variable
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Carl Schwan [Mon, 17 Oct 2022 09:50:32 +0000 (11:50 +0200)]
More type safety
Signed-off-by: Carl Schwan <carl@carlschwan.eu>