Fix interned strings buffer check if 0 free bytes

With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely.

This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched.

Signed-off-by: MichaIng <micha@dietpi.com>

Merge pull request #36269 from nextcloud/bugfix/noid/fix-broken-unit-test

Fix broken user:setting command unit test

Merge pull request #36262 from nextcloud/chore/dav/void-test-methods

chore(dav): Add void return type to test methods

Merge pull request #36247 from nextcloud/bugfix/noid/bump-profiler-version

Specify the profiler app branch to test with

Fix broken user:setting command unit test

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix(l10n): 🔠 Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): 🔠 Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #36280 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Fix(l10n): 🔠 Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Specify the profiler app branch to test with

So we can test in stable25 with a matching profiler version instead of master

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #36271 from nextcloud/fix/fix-codestyle

Fix codestyle using codesniffer

Merge pull request #36264 from nextcloud/fix/occ/repair-command-comment-formatting

fix(occ): Fix comment formatting of maintenance:repair command

composer run cs:fix

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #34997 from nextcloud/fix/drop-php-7.4

Drop PHP 7.4 on master

Bump 3rdparty to master branch

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Always show the psalm baseline change, even on failure

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Show failure of SAML login in kerberos workflow

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fixing samba test and adding details to kerberos job

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix check in integration tests

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix Samba test failure details output

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Remove PHP version matrix from kerberos test

It runs on a docker image on which we cannot control which PHP version runs.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix integrity check

Signed-off-by: Joas Schilling <coding@schilljs.com>

Update test file for mimetypes

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix gzip mimetype mapping

PHP now detects it as application/gzip and not application/x-gzip anymore

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Prettify static-code-analysis.yml

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Always upload psalm result to github

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge back the two static analysis workflows together

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Attempt to fix errors in Repair command tests

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix types in OCS json answer (status code is an int)

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix crash in OCS when getting info about an application

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Attempt at reducing psalm errors

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Improve typing in Entity.php

Removing @method in Entity brings even more errors.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix kerberos step name

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Move all drone steps to PHP 8.0

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

composer update php

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Attempt at bumping psalm version

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Remove workarounds specific to 7.4

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Drop PHP 7.4 support for master (26)

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix(occ): Fix comment formatting of maintenance:repair command

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #36253 from nextcloud/chore/dav/remove-useless-var-tag

chore(dav): Remove useless var tag

chore(dav): Add void return type to test methods

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Fix(l10n): 🔠 Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

chore(dav): Remove useless var tag

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #36162 from nextcloud/fix/php82/string-var-interpolation

fix(PHP8.2): Fix deprecated string interpolation syntax

Merge pull request #35632 from nextcloud/debt/document-types-search-flag

docs: document types flag for search options

Merge pull request #36123 from nextcloud/user-settings-normalize-uid

normalize userid in user:setting

fix(PHP8.2): Fix deprecated string interpolation syntax

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #36237 from nextcloud/bugfix/noid/disable-unreliable-tests

Disable unreliable acceptance tests

docs: document types flag for search options

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Disable unreliable acceptance tests

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #36223 from nextcloud/artonge/fix/allow_interaction_with_encrypted_folders

Allow interaction with encrypted folders

Merge pull request #36203 from nextcloud/enh/a11y-search-menu

Port global search menu to focus trapped NcHeaderMenu

Fix(l10n): 🔠 Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #36225 from Jachhj-sc/patch-1

Add check config.php for ffmpeg_path in PreviewManager.php. fix for snap no video preview

Merge pull request #36211 from nextcloud/enh/catch-recurrence-exception

fix(dav): catch MaxInstancesExceededException for recurring events without end date

Update lib/private/PreviewManager.php

fix lint issue

Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: William <william.hak57@gmail.com>

Update config/config.sample.php

add better description

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: William <william.hak57@gmail.com>

Merge pull request #36219 from nextcloud/fix/correction-35886-Replace_custom_tooltips_with_native_one_for_personal_and_administration_settings

Correct title for button on federation actions button

Port global search menu to focus trapped NcHeaderMenu

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #27492 from cyclops8456/feature/24301-remove-can-install-on-occ-maintenance-install

Remove the CAN_INSTALL file when occ maintenance:install is complete

Merge pull request #1 from Jachhj-sc/patch-2

add documentation preview_ffmpeg_path

Merge branch 'nextcloud:master' into patch-1

add documentation preview_ffmpeg_path

add preview_ffmpeg_path documentation.
document custom path for ffmpeg so it can be used by the previewprovider to create video previews with the snap package of nextcloud.

Signed-off-by: William <william.hak57@gmail.com>

Merge pull request #36205 from nextcloud/bugfix/noid/fix-settings-section-icon-color

fix(search): Fix settings section icon color

Merge pull request #36221 from nextcloud/artonge/feat/cypress_git_branch

Use current git branch by default when setting up cypress container

Allow interaction with encrypted folders

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Use current git branch by default when setting up cypress container

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #35783 from nextcloud/feat/inject-controller-services-into-methods

Inject services into controller methods

Update PreviewManager.php

add a check in config.php for a configured movieBinary path.
so now it first checks in config.php if  preview_ffmpeg_path is configured.

Signed-off-by: William <william.hak57@gmail.com>

Correct title for button on federation actions button

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

fix(dav): catch MaxInstancesExceedeException for recurring events without end date

Ref https://github.com/nextcloud/calendar/issues/4811

Signed-off-by: Anna Larch <anna@nextcloud.com>

feat(app framework)!: Inject services into controller methods

Usually Nextcloud DI goes through constructor injection. This has the
implication that each instance of a class builds the full DI tree. That
is the injected services, their services, etc. Occasionally there is a
service that is only needed for one controller method. Then the DI tree
is build regardless if used or not.

If services are injected into the method, we only build the DI tree if
that method gets executed.

This is also how Laravel allows injection.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #35419 from nextcloud/fix/login-csrf-not-logged-in-clear-cookies

Fix login loop if login CSRF fails and user is not logged in

Merge pull request #36204 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

Fix login loop if login CSRF fails and user is not logged in

If CSRF fails but the user is logged in that they probably logged in in
another tab. This is fine. We can just redirect.
If CSRF fails and the user is also not logged in then something is
fishy. E.g. because Nextcloud contantly regenrates the session and the
CSRF token and the user is stuck in an endless login loop.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #36198 from nextcloud/3rdparty-remove-ds

chore: drop dependency php-ds

Merge pull request #36002 from nextcloud/feat/files2vue-quota

feat(files): Quota in navigation

fix(search): Fix settings section icon color

Signed-off-by: Joas Schilling <coding@schilljs.com>

chore: drop dependency php-ds

The dependency is not used.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #36194 from nextcloud/revert/35071

Fix failed revert for #35071

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Fix(l10n): 🔠 Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #36190 from nextcloud/3rdparty-guzzle

chore(3rdparty): Bump guzzlehttp/guzzle from 7.2.0 to 7.5.0 and egulias/email-validator from 3.2.1 to 3.2.5

feat(files): Quota in navigation

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Merge pull request #36166 from nextcloud/fix/php82/declare-symfony-console-application-property

fix(PHP8.2): Declare Symfony Application property in console application

Fix failed revert for #35071

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Revert "Add alt to the logo, adapt css for logo"

This reverts commit bba5ab0532bcf71dc421fd15efd890cd25bdc8d3.

chore(3rdparty): Bump guzzlehttp/guzzle from 7.2.0 to 7.5.0 and
egulias/email-validator from 3.2.1 to 3.2.5

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Fix(l10n): 🔠 Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #36094 from nextcloud/bugfix/noid/user-info-api-exclude-storage

Only expose storage location to admins

Merge pull request #36093 from nextcloud/techdebt/noid/improve-share-pw-generation

Improve password generation for link shares

Merge pull request #36161 from nextcloud/bugfix/36153/fix-sharemount-cache-key-include-target

still include the share target in the cache key for validating share mount

Merge pull request #36087 from nextcloud/enh/noid/improve-applicable-ext-storage

Improve saving applicable users in ext storage

fix(PHP8.2): Declare Symfony Application property in console application

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Improve password generation for link shares

Use web crypto when generating password for link shares
whenever the password policy app is disabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #36089 from nextcloud/enh/noid/ext-storage-default-values

Ext storage configs default value support + enable SSL by default

Merge pull request #36113 from nextcloud/bugfix/noid/viewonly-versions

Extend ViewOnly DAV plugin to versions endpoint

Merge pull request #35970 from nextcloud/perf/noid/exception-serializer

still include the share target in the cache key for validating share mount

Signed-off-by: Robin Appelman <robin@icewind.nl>