address review

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix one more place

Signed-off-by: Simon L <szaimen@e.mail.de>

only print deprecation logs if debug mode is enabled

Signed-off-by: Simon L <szaimen@e.mail.de>

Move deprecation warnings to debug

Signed-off-by: Simon L <szaimen@e.mail.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38625 from nextcloud/fix/noid/querysearchehelper-narrow-type

fix: expect interface, not a specific implementation

Merge pull request #38965 from nextcloud/dav-directory-clean-cache-path

dav: clean path before putting it in the statcache

Merge pull request #38948 from nextcloud/Jerome-Herbinet-collaborative-tags-alignment-change

dav: clean path before putting it in the statcache

Signed-off-by: Robin Appelman <robin@icewind.nl>

Align collaborative tags differently

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Align collaborative tags differently

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
npm run build

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Following @skjnldsv suggestion

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Merge pull request #38800 from nextcloud/bugfix/noid/version-update-or-insert

Merge pull request #38951 from nextcloud/dependabot/npm_and_yarn/fast-xml-parser-and-webdav-4.2.5

chore(deps): Bump fast-xml-parser and webdav

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) to 4.2.5 and updates ancestor dependency [webdav](https://github.com/perry-mitchell/webdav-client). These dependencies need to be updated together.

Updates `fast-xml-parser` from 4.2.4 to 4.2.5
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/NaturalIntelligence/fast-xml-parser/compare/v4.2.4...v4.2.5)

Updates `webdav` from 5.1.0 to 5.2.1
- [Changelog](https://github.com/perry-mitchell/webdav-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/perry-mitchell/webdav-client/compare/v5.1.0...v5.2.1)

---
updated-dependencies:
- dependency-name: fast-xml-parser
  dependency-type: indirect
- dependency-name: webdav
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #38939 from nextcloud/feat/f2v/more-actions

Merge pull request #38457 from nextcloud/fix/improve-ldap-offset-search-perf

Use default page size for jumping to desired offset

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

feat: add rename action with tests

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix(files): action default is false if not set

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: add favorite action with tests

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Merge pull request #38945 from nextcloud/dav-meta-directory-content

implement optimized getDirectoryContent for DAV

Do not create a new version if previousNode has the same mtime

Signed-off-by: Louis Chemineau <louis@chmn.me>

implement optimized getDirectoryContent for DAV

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #38771 from fsamapoor/constructor_property_promotion_in_core_command_part7

 Uses PHP8's constructor property promotion core/Command/Info, /Integrity, and /Preview

Merge pull request #38856 from nextcloud/fix/contacts/3404/put-location-in-proper-place

fix(sab): put location in proper address field

Merge pull request #38928 from nextcloud/fix/missing-systemtags-index

feat: add edit locally action with tests

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix(systemtags): Keep non-existing index

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(systemtags): Move index creation from new migration to existing original migration

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Merge pull request #38917 from nextcloud/bugfix/talk-9558/plural-issue-with-some-language-locale-combinations

fix(l10n): Fix plural issue with different locale and language

Merge pull request #38747 from nextcloud/perf/early-exit-mkcol

perf: skip request without write permission

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38826 from nextcloud/enh/a11y-new-user

enh(a11y): New user modal

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #38924 from nextcloud/automated/update-engines/default

chore: update node engines to next LTS

ci: pro forma check of existence of internal method

createNode() is protected and used by Folder, but being an internal-only
method it shall not be exposed in the Folder or IRootFolder interface.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

refactor: declare getMount() and getMountsIn() at IRootFolder

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

chore: ugly type juggling

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: add typehine for IRootFolder

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: expect interface, not a specific implementation

- fixes a regression when deleting folders while music app was enabled,
  for a LazyRoot was passed to this method.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #38927 from nextcloud/bugfix/noid/package.json-editorconfig

fix(systemtags): Add missing systemtags index

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

chore: Adjust editorconfig for package.json and package-lock.json

Signed-off-by: Joas Schilling <coding@schilljs.com>

chore: update node engines to next LTS (node 20 / npm 9)

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Merge pull request #38806 from nextcloud/feat/f2v/actions-1

fix: Add logging statement for cases when updating the version fails

Signed-off-by: Julius Härtl <jus@bitgrid.net>

chore: add `__tests__` and `__mocks__` to file checker and fix updated names

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Handle previousNode size === 0 on version creation

Signed-off-by: Louis Chemineau <louis@chmn.me>

chore: update old codecov config

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: prepare jest coverage support

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix(jest): replace mock with jest.spyOn

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: add open folder action testing

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: add download action testing

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: add delete action testing

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: add sidebar action testing

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

feat: prepare jest upgrade and ts testing

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix: delete action import

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

fix(l10n): Fix plural issue with different locale and language

We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #38915 from nextcloud/enh/noid/increase-https-warning

adjust admin setup check to increase warning to configure https

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

adjust admin setup check to increase warning to set up https

Signed-off-by: Simon L <szaimen@e.mail.de>

Merge pull request #38762 from fsamapoor/constructor_property_promotion_in_core_command_part1

Uses PHP8's constructor property promotion in core/Command/Encryption

Merge pull request #38768 from fsamapoor/constructor_property_promotion_in_core_command_part5

Uses PHP8's constructor property promotion in core/Command/Config and Group

Merge pull request #38639 from charno/bugfix/36644-pruneOutdatedSyncTokens-deletes-all-entries

Bugfix/36644 pruneOutdatedSyncTokens deletes all entries

Update core/Command/Encryption/DecryptAll.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Update core/Command/Encryption/EncryptAll.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Moves single constructor parameters to new lines.

Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Fixes php-cs error.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Uses PHP8's constructor property promotion in core/Command/Encryption classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

fix(sab): put location in proper address field

Signed-off-by: Johannes Merkel <mail@johannesgge.de>

Fix paged search when offset is not a multiple of default page size

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #38638 from fsamapoor/constructor_property_promotion_part3

[3/3] Refactors /core controllers using constructor property promotion.

Merge pull request #35424 from nextcloud/cleanup/comments

Cleanup comments code

Throw if creation date is read before inserting into database

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Improve typing in ICommentsManager

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Cleanup comments code

- Fix various psalm issues
- Add as much typing as possible while preserving stable API

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Update core/Controller/SetupController.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Applies agreed-upon indentation convention to the changed controllers.

Based on https://github.com/nextcloud/server/pull/38636#discussion_r1218167753

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Refactors controllers by using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Merge pull request #38774 from fsamapoor/constructor_property_promotion_in_core_command_part8

 Uses PHP8's constructor property promotion in core/Command/Log, /Security, and /SystemTag

Moves single constructor parameters to new lines.

Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

 Uses PHP8's constructor property promotion.
 in core/Command/Info, /Integrity, and /Preview classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Moves single constructor parameters to new lines.

Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Uses PHP8's constructor property promotion in core/Command/Config and  core/Command/Group classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #38888 from nextcloud/artonge/fix/dont_disable_action_during_save

Don't disable actions when saving share permissions

Merge pull request #38890 from nextcloud/obj-store-copy-list-source-cache

Merge pull request #38769 from fsamapoor/constructor_property_promotion_in_core_command_part6

 Uses PHP8's constructor property promotion core/Command/App,/Background, and /Broadcast

Merge pull request #38876 from Freiheitswolke/style/config/alphabetise-preview-providers

style(config): alphabetise preview providers

Moves single constructor parameters to new lines.

Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

 Uses PHP8's constructor property promotion.
 in core/Command/Log, /Security, and /SystemTag classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

Merge pull request #38767 from fsamapoor/constructor_property_promotion_in_core_command_part4

Uses PHP8's constructor property promotion in core/Command/Maintenance

Merge pull request #38764 from fsamapoor/constructor_property_promotion_in_core_command_part2

Uses PHP8's constructor property promotion in core/Command/Db classes.

Merge pull request #38766 from fsamapoor/constructor_property_promotion_in_core_command_part3

Uses PHP8's constructor property promotion in core/Command/User classes.

use source cache when listing folder during recursive copy

Signed-off-by: Robin Appelman <robin@icewind.nl>

perf: skip request without write permission

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #38865 from nextcloud/dependabot/npm_and_yarn/nextcloud/files-3.0.0-beta.10

bump @nextcloud/files from 3.0.0-beta.9 to 3.0.0-beta.10

Merge pull request #38773 from nextcloud/fix/noid/protect-oauth2-api-controller

Add bruteforce protection in OauthApiController

style(config): alphabetise preview providers

Signed-off-by: Joda Stößer <git@simjo.st>

Moves single constructor parameters to new lines.

Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>

 Uses PHP8's constructor property promotion.
 in core/Command/App, /Background, and /Broadcast classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>