]>
source.dussan.org Git - rspamd.git/log
Anton Yuzhaninov [Tue, 21 Sep 2021 10:14:10 +0000 (11:14 +0100)]
[Minor] Improve readability of recently changed rspamc code
Anton Yuzhaninov [Tue, 21 Sep 2021 09:00:17 +0000 (10:00 +0100)]
[Fix] buffer overflow in rspamc counters
If request to /counters returns no symbols then max_len would have
a negative value:
Results for command: counters (0.003 seconds)
=================================================================
==22096==ERROR: AddressSanitizer: negative-size-param: (size=-
2147483604 )
#0 0x33ff13 in __asan_memset (/usr/bin/rspamc+0x33ff13)
#1 0x383432 in rspamc_counters_output /usr/src/debug/rspamd/src/client/rspamc.c:1064:2
#2 0x388c49 in rspamc_client_cb /usr/src/debug/rspamd/src/client/rspamc.c:1600:6
...
Vsevolod Stakhov [Mon, 20 Sep 2021 19:30:25 +0000 (20:30 +0100)]
[Minor] Remove bogus condition
Vsevolod Stakhov [Mon, 20 Sep 2021 19:28:00 +0000 (20:28 +0100)]
[Minor] Fix macro name
Reported by: @citrin
Vsevolod Stakhov [Mon, 20 Sep 2021 19:26:15 +0000 (20:26 +0100)]
[Fix] Fix rubbish QP sequences decoding
Vsevolod Stakhov [Mon, 20 Sep 2021 19:21:49 +0000 (20:21 +0100)]
[Test] Add tests for broken qp decoding
Vsevolod Stakhov [Mon, 20 Sep 2021 16:50:41 +0000 (17:50 +0100)]
Merge pull request #3899 from citrin/cmake-cleanup
[Minor] Cleanup unused cmake checks
Anton Yuzhaninov [Mon, 20 Sep 2021 16:37:06 +0000 (17:37 +0100)]
[Minor] Cleanup unused cmake checks
Vsevolod Stakhov [Sun, 19 Sep 2021 11:15:30 +0000 (12:15 +0100)]
[Minor] Oops, fix emplacement
Vsevolod Stakhov [Sun, 19 Sep 2021 11:08:48 +0000 (12:08 +0100)]
[Minor] Fix some leaks on error paths
Found by: coverity scan
Vsevolod Stakhov [Sun, 19 Sep 2021 10:47:00 +0000 (11:47 +0100)]
[Fix] Fix hash table lookup
Found by: coverity scan
Vsevolod Stakhov [Sun, 19 Sep 2021 09:30:39 +0000 (10:30 +0100)]
[Minor] Some minor cleanups
Found by: coverity scan
Vsevolod Stakhov [Sat, 18 Sep 2021 14:53:20 +0000 (15:53 +0100)]
[Minor] Fix some more issues
Found by: coverity scan
Vsevolod Stakhov [Sat, 18 Sep 2021 11:56:46 +0000 (12:56 +0100)]
[Minor] Fix more issues in libmime
Found by: coverity scan
Vsevolod Stakhov [Sat, 18 Sep 2021 11:29:57 +0000 (12:29 +0100)]
[Minor] Plug some leaks on error paths
Found by: coverity scan
Vsevolod Stakhov [Sat, 18 Sep 2021 08:35:51 +0000 (09:35 +0100)]
[Minor] Use the proper variable in debug
Found by: coverity scan
Vsevolod Stakhov [Fri, 17 Sep 2021 20:55:43 +0000 (21:55 +0100)]
[Minor] Do not read extra byte of garbadge
Found by: coverity scan
Vsevolod Stakhov [Fri, 17 Sep 2021 20:47:17 +0000 (21:47 +0100)]
[Minor] Fix some double frees
Found by: coverity scan
Vsevolod Stakhov [Fri, 17 Sep 2021 20:36:32 +0000 (21:36 +0100)]
[Minor] Remove dead loop
Vsevolod Stakhov [Fri, 17 Sep 2021 20:35:30 +0000 (21:35 +0100)]
[Minor] Fix some dead ends
Found by: coverity scan
Vsevolod Stakhov [Fri, 17 Sep 2021 20:33:01 +0000 (21:33 +0100)]
[Minor] Fix error path varargs handling
Found by: coverity
Vsevolod Stakhov [Fri, 17 Sep 2021 15:43:32 +0000 (16:43 +0100)]
[Feature] Antivirus: Allow to set fake eicar patterns for testing AV engines
Vsevolod Stakhov [Fri, 17 Sep 2021 11:46:41 +0000 (12:46 +0100)]
[Minor] Escape \uFFFD in the sources
Vsevolod Stakhov [Fri, 17 Sep 2021 08:56:57 +0000 (09:56 +0100)]
Merge pull request #3894 from citrin/bitcoin-lua-opt
[Minor] Skip bitcoin address check for very long words
Anton Yuzhaninov [Fri, 17 Sep 2021 08:46:32 +0000 (09:46 +0100)]
[Minor] Skip bitcoin address check for very long words
Exclude very long words (which can be extracted e. g. from some text
attachments) from bitcoin address check to avoid excessive resource
usage.
Vsevolod Stakhov [Thu, 16 Sep 2021 12:47:48 +0000 (13:47 +0100)]
[Minor] One more polishing thing
Vsevolod Stakhov [Thu, 16 Sep 2021 12:38:35 +0000 (13:38 +0100)]
[Minor] Fix unregistration of the context and improve logging
Vsevolod Stakhov [Thu, 16 Sep 2021 09:34:57 +0000 (10:34 +0100)]
[Minor] Fix list splice
Vsevolod Stakhov [Wed, 15 Sep 2021 13:05:05 +0000 (14:05 +0100)]
Merge pull request #3892 from fatalbanana/friendlier_tests
[Test] Avoid importing user configuration
Andrew Lewis [Wed, 15 Sep 2021 11:31:44 +0000 (13:31 +0200)]
[Test] Avoid importing user configuration
Vsevolod Stakhov [Tue, 14 Sep 2021 20:21:07 +0000 (21:21 +0100)]
[Minor] Add attribute noreturn to start_hs_helper function
Suggested by: @citrin
Vsevolod Stakhov [Tue, 14 Sep 2021 15:35:15 +0000 (16:35 +0100)]
Merge pull request #3891 from fatalbanana/doxydown
[Minor] Update embedded doxydown
Andrew Lewis [Tue, 14 Sep 2021 14:17:20 +0000 (16:17 +0200)]
[Minor] Update embedded doxydown
- To fix nested lists
Vsevolod Stakhov [Tue, 14 Sep 2021 13:44:07 +0000 (14:44 +0100)]
Merge pull request #3890 from fatalbanana/docs
[Minor] Updates for API documentation
Andrew Lewis [Tue, 14 Sep 2021 13:33:48 +0000 (15:33 +0200)]
[Minor] Updates for API documentation
- Put nested lists on the correct level
- Document more symbol type options
- Try be clearer about dependencies
Vsevolod Stakhov [Mon, 13 Sep 2021 15:53:49 +0000 (16:53 +0100)]
[Minor] One more try to fix the release order
Vsevolod Stakhov [Mon, 13 Sep 2021 15:28:09 +0000 (16:28 +0100)]
[Minor] Do not unref what's not been refed
Vsevolod Stakhov [Mon, 13 Sep 2021 14:07:09 +0000 (15:07 +0100)]
[Minor] Another try to fight with hiredis...
Vsevolod Stakhov [Mon, 13 Sep 2021 13:49:25 +0000 (14:49 +0100)]
[Minor] Add one more check for use-after-free prevention
Vsevolod Stakhov [Mon, 13 Sep 2021 13:40:06 +0000 (14:40 +0100)]
[Minor] Allow to capture upstream object
Vsevolod Stakhov [Mon, 13 Sep 2021 12:16:31 +0000 (13:16 +0100)]
[Minor] Fix deinit order
Vsevolod Stakhov [Mon, 13 Sep 2021 10:05:24 +0000 (11:05 +0100)]
[Minor] Fix redis termination case not being caught by fuzzy redis
Vsevolod Stakhov [Mon, 13 Sep 2021 10:00:12 +0000 (11:00 +0100)]
[Minor] Fix C++ logging
Vsevolod Stakhov [Mon, 13 Sep 2021 09:51:45 +0000 (10:51 +0100)]
[Minor] Fix list splice
Vsevolod Stakhov [Sun, 12 Sep 2021 11:39:57 +0000 (12:39 +0100)]
[Minor] Redis_pool: Slightly improve style
Vsevolod Stakhov [Sun, 12 Sep 2021 11:27:47 +0000 (12:27 +0100)]
[Rework] Redis_pool: fix issues found
Vsevolod Stakhov [Sat, 11 Sep 2021 19:53:29 +0000 (20:53 +0100)]
[Rework] Further rework of the redis pool
Vsevolod Stakhov [Sat, 11 Sep 2021 13:30:56 +0000 (14:30 +0100)]
[Rework] Start rewriting of the redis pool logic
Vsevolod Stakhov [Fri, 10 Sep 2021 19:18:44 +0000 (20:18 +0100)]
[Minor] Try to deal with broken CD headers
Vsevolod Stakhov [Fri, 10 Sep 2021 15:53:19 +0000 (16:53 +0100)]
[Minor] Remove unused cfg fields
Vsevolod Stakhov [Thu, 9 Sep 2021 15:39:48 +0000 (16:39 +0100)]
[Minor] Store obfuscated subjects in Redis
Issue: #3886
Vsevolod Stakhov [Thu, 9 Sep 2021 14:56:42 +0000 (15:56 +0100)]
Merge pull request #3889 from arkamar/dep-info
Reflect recent doctest version bump in dependency info table
Vsevolod Stakhov [Thu, 9 Sep 2021 14:52:25 +0000 (15:52 +0100)]
[Minor] Add content type to MIME_BAD_ATTACHMET symbol
Petr Vaněk [Thu, 9 Sep 2021 14:45:40 +0000 (16:45 +0200)]
Reflect recent doctest version bump in dependency info table
This just bumps the version number of currently bundled doctest library
in dependency info table.
Vsevolod Stakhov [Thu, 9 Sep 2021 09:41:17 +0000 (10:41 +0100)]
[Minor] Update bundled doctest to the latest version
Vsevolod Stakhov [Wed, 8 Sep 2021 13:45:33 +0000 (14:45 +0100)]
[Fix] Fix some complicated case with the closing tags parsing
Vsevolod Stakhov [Wed, 8 Sep 2021 11:26:19 +0000 (12:26 +0100)]
[Minor] Cleanup metrics output
Vsevolod Stakhov [Wed, 8 Sep 2021 11:18:40 +0000 (12:18 +0100)]
Merge pull request #3883 from pdf/fix_openmetrics
[Fix] Namespace and add metadata for OpenMetrics, fix interleaving
Peter Fern [Tue, 7 Sep 2021 23:37:10 +0000 (09:37 +1000)]
[Fix] Namespace and add metadata for OpenMetrics, fix interleaving
Vsevolod Stakhov [Tue, 7 Sep 2021 15:35:02 +0000 (16:35 +0100)]
[Minor] Allow to get invisible content in `rspamadm mime ex`
Vsevolod Stakhov [Tue, 7 Sep 2021 15:34:49 +0000 (16:34 +0100)]
[Minor] Allow to get invisible content from html
Vsevolod Stakhov [Tue, 7 Sep 2021 14:00:58 +0000 (15:00 +0100)]
[Rules] Improve zero font rule
Vsevolod Stakhov [Tue, 7 Sep 2021 14:00:38 +0000 (15:00 +0100)]
[Rework] Save invisible content to a separate buffer
Vsevolod Stakhov [Mon, 6 Sep 2021 10:12:53 +0000 (11:12 +0100)]
Merge pull request #3880 from fatalbanana/lua_milterheaders
Milter_headers: fix x-spamd-bar for plain lua (#3879)
Andrew Lewis [Mon, 6 Sep 2021 09:17:28 +0000 (11:17 +0200)]
[Minor] Another PUC-Rio Lua compatibility fix
- Reported by @mebourne
Vsevolod Stakhov [Fri, 3 Sep 2021 15:51:02 +0000 (16:51 +0100)]
Merge pull request #3875 from arkamar/system-doctest
Add SYSTEM_DOCTEST cmake option
Vsevolod Stakhov [Fri, 3 Sep 2021 13:33:36 +0000 (14:33 +0100)]
[Minor] Dmarc_report: Fix template
Issue: #3877
Vsevolod Stakhov [Fri, 3 Sep 2021 12:31:32 +0000 (13:31 +0100)]
[Minor] Another fix of the remaining octets logic
Vsevolod Stakhov [Fri, 3 Sep 2021 12:10:59 +0000 (13:10 +0100)]
[Minor] Fix remaining octets logic
Vsevolod Stakhov [Fri, 3 Sep 2021 09:09:40 +0000 (10:09 +0100)]
[Fix] Fix the case when l tag is too small
Vsevolod Stakhov [Thu, 2 Sep 2021 13:07:14 +0000 (14:07 +0100)]
[Minor] Fix misused variable
Vsevolod Stakhov [Thu, 2 Sep 2021 12:56:15 +0000 (13:56 +0100)]
[Fix] Preserve SPF top record in the mempool variable
Vsevolod Stakhov [Thu, 2 Sep 2021 12:32:09 +0000 (13:32 +0100)]
[Minor] Fix stupid memory leak
Vsevolod Stakhov [Thu, 2 Sep 2021 10:28:19 +0000 (11:28 +0100)]
[Fix] Plug memory leak in http settings reload
Reverts:
d9180d3ac0fac6d0aa12cd33117cb7efc731e2a2
Vsevolod Stakhov [Thu, 2 Sep 2021 09:51:59 +0000 (10:51 +0100)]
[Minor] Explicitly disallow to set settings on top of other settings
Petr Vaněk [Wed, 1 Sep 2021 11:30:56 +0000 (13:30 +0200)]
Add SYSTEM_DOCTEST cmake option
This gives packagers option to use system version of doctest rather than
bundled one. It is disabled by default. Additionally, there is no need
to link rspamd-test-cxx with doctest as it is is single header library.
Main reason for this change is that currently bundled version of
doctest-2.4.5 can't compile with glibc-2.34 [1]. However, this issue was
already fixed in upstream doctest-2.4.6 [2] in commit [3]. With this,
packagers can just bump doctest to fixed version.
[1] https://github.com/onqtam/doctest/issues/473
[2] https://github.com/onqtam/doctest/blob/master/CHANGELOG.md#246-2021-03-22
[3] https://github.com/onqtam/doctest/commit/
099d5414e97244ec44cf46b14cd176b3a3dc52e3
Vsevolod Stakhov [Wed, 1 Sep 2021 14:38:55 +0000 (15:38 +0100)]
Merge pull request #3874 from fatalbanana/rspamd_stats_rescore
[Minor] rspamd_stats: support rescoring symbols
Andrew Lewis [Wed, 1 Sep 2021 11:56:59 +0000 (13:56 +0200)]
[Minor] rspamd_stats: support rescoring symbols
Vsevolod Stakhov [Wed, 1 Sep 2021 14:14:43 +0000 (15:14 +0100)]
[Minor] Fix number of arguments to invoke a lua function
Vsevolod Stakhov [Wed, 1 Sep 2021 13:52:57 +0000 (14:52 +0100)]
[Minor] Plug dtor memory leak (not important)
Vsevolod Stakhov [Wed, 1 Sep 2021 13:26:32 +0000 (14:26 +0100)]
[Rework] Rework learn and add classify condition
Vsevolod Stakhov [Wed, 1 Sep 2021 12:35:13 +0000 (13:35 +0100)]
[Minor] Add function to get a lua_reference from a string returning a function
Vsevolod Stakhov [Tue, 31 Aug 2021 15:44:49 +0000 (16:44 +0100)]
Merge pull request #3873 from jendis/fix_fuzzy_crash
[Fix] src/lua/lua_mimepart.c: fix null dereference
Vsevolod Stakhov [Tue, 31 Aug 2021 13:25:12 +0000 (14:25 +0100)]
[Fix] Fix http message flag shift
Issue: #3872
Jan Smutny [Tue, 31 Aug 2021 12:25:23 +0000 (14:25 +0200)]
[Fix] src/lua/lua_mimepart.c: fix null dereference
Vsevolod Stakhov [Tue, 31 Aug 2021 12:12:00 +0000 (13:12 +0100)]
[Fix] Another try to fix references safety
Issue: #3871
Vsevolod Stakhov [Tue, 31 Aug 2021 10:08:09 +0000 (11:08 +0100)]
[Fix] Avoid dangling reference
Issue: #3871
Vsevolod Stakhov [Mon, 30 Aug 2021 09:23:00 +0000 (10:23 +0100)]
[Fix] Delete the correct pointer type
Issue: #3853
Vsevolod Stakhov [Sun, 29 Aug 2021 18:59:03 +0000 (19:59 +0100)]
[Minor] Fix exit codes usage to POSIX portable EXIT_FAILURE
Vsevolod Stakhov [Sat, 28 Aug 2021 10:19:14 +0000 (11:19 +0100)]
[Minor] Further priorities adjustment
Vsevolod Stakhov [Fri, 27 Aug 2021 13:47:31 +0000 (14:47 +0100)]
[Minor] Fix expressions priorities
Vsevolod Stakhov [Fri, 27 Aug 2021 12:40:44 +0000 (13:40 +0100)]
[Minor] Mime_types: Allow application/octet-stream for all extensions
Vsevolod Stakhov [Thu, 26 Aug 2021 15:08:28 +0000 (16:08 +0100)]
[Minor] Lua_compression: Add support of the compression level for gzip
Vsevolod Stakhov [Thu, 26 Aug 2021 09:23:10 +0000 (10:23 +0100)]
Merge pull request #3866 from HeinleinSupport/lua_scanners/common
[Fix] lua_scanners - message_min_words logic
Carsten Rosenberg [Wed, 25 Aug 2021 17:14:39 +0000 (19:14 +0200)]
[Fix] lua_scanners - message_min_words logic
Vsevolod Stakhov [Wed, 25 Aug 2021 16:37:21 +0000 (17:37 +0100)]
[Minor] Store multiple base tags (but use only first one as usually)
Vsevolod Stakhov [Wed, 25 Aug 2021 16:32:58 +0000 (17:32 +0100)]
[Minor] Fix small href values with a base urls presented
Vsevolod Stakhov [Wed, 25 Aug 2021 16:12:28 +0000 (17:12 +0100)]
[Minor] Fix match_limit in pcre2 code
Vsevolod Stakhov [Wed, 25 Aug 2021 15:41:47 +0000 (16:41 +0100)]
[Fix] Add concept of uncancellable events to prevent use-after-free
Vsevolod Stakhov [Wed, 25 Aug 2021 11:11:58 +0000 (12:11 +0100)]
Merge pull request #3863 from CrawX/aarch64-luajit-fixes
[Fix] Remove aarch64 GC64 workaround