]>
source.dussan.org Git - rspamd.git/log
Anton Yuzhaninov [Thu, 10 Feb 2022 10:05:08 +0000 (10:05 +0000)]
[Fix] ClickHouse cleanup of old partitions
If /var/lib/rspamd/clickhouse_retention_run is missing or has no
number cleanup was not performed because of a following Lua error:
lua_periodic_callback_error: call to periodic script (registered at clickhouse.lua:1531) failed: /usr/share/rspamd/plugins/clickhouse.lua:991: attempt to compare number with nil; trace: [1]:{/usr/share/rspamd/plugins/clickhouse.lua:1069 - <unknown> [Lua]};
Vsevolod Stakhov [Wed, 9 Feb 2022 20:03:23 +0000 (20:03 +0000)]
Merge pull request #4067 from citrin/nitpick
[Minor] Remove repeated strcmp(key, "score")
Vsevolod Stakhov [Wed, 9 Feb 2022 20:02:43 +0000 (20:02 +0000)]
Merge pull request #4066 from citrin/lua-tests-gc
[Minor] Tune Lua GC for Lua unit tests
Anton Yuzhaninov [Tue, 8 Feb 2022 21:29:03 +0000 (21:29 +0000)]
[Minor] Remove repeated strcmp(key, "score")
Anton Yuzhaninov [Tue, 8 Feb 2022 21:22:34 +0000 (21:22 +0000)]
[Minor] Tune Lua GC for Lua unit tests
Fixes sporadic unit test failures (on Mac OS X).
Vsevolod Stakhov [Tue, 8 Feb 2022 09:05:35 +0000 (09:05 +0000)]
[Minor] Off by one
Vsevolod Stakhov [Mon, 7 Feb 2022 22:08:29 +0000 (22:08 +0000)]
[Minor] Fix a corner case
Vsevolod Stakhov [Mon, 7 Feb 2022 22:06:25 +0000 (22:06 +0000)]
[CritFix] Fix upstreams name resolution when there is also a port
This fix is intended to address the case when Rspamd queries for a hostname with
a port part when re-resolving upstreams addresses via the upstreams module.
Found by: @slavkoja
Confirmed by: @moisseev
Vsevolod Stakhov [Sun, 6 Feb 2022 20:15:46 +0000 (20:15 +0000)]
[Rework] Make `rspamadm dmarc_report` default behaviour more sane
Issue: #4062
Vsevolod Stakhov [Sat, 5 Feb 2022 12:28:30 +0000 (12:28 +0000)]
[Fix] Rework unshedule DNS request function
Vsevolod Stakhov [Fri, 4 Feb 2022 20:42:31 +0000 (20:42 +0000)]
[Minor] Improve logging logic
Vsevolod Stakhov [Thu, 3 Feb 2022 23:00:26 +0000 (23:00 +0000)]
[Minor] Do not trigger obfuscated archive on undetecde 8bit characters
Vsevolod Stakhov [Wed, 2 Feb 2022 20:11:04 +0000 (20:11 +0000)]
Merge pull request #4056 from fatalbanana/remove_result_fix
[Fix] Lua: task:remove_result didn't work in some cases
Andrew Lewis [Wed, 2 Feb 2022 10:14:29 +0000 (12:14 +0200)]
[Fix] Lua: task:remove_result didn't work in some cases
Vsevolod Stakhov [Tue, 1 Feb 2022 20:44:29 +0000 (20:44 +0000)]
Merge pull request #4055 from fatalbanana/remove_result_test
[Test] task:remove_symbol() on grouped virtual symbol
Andrew Lewis [Tue, 1 Feb 2022 11:09:19 +0000 (13:09 +0200)]
[Test] task:remove_symbol() on grouped virtual symbol
Vsevolod Stakhov [Mon, 31 Jan 2022 20:03:36 +0000 (20:03 +0000)]
Merge pull request #4052 from twesterhever/rbl-dbl-helo-ptr-replyto
[Feature] Query HELOs, PTRs, and Reply-To's against Spamhaus DBL as well
twesterhever [Sun, 30 Jan 2022 13:35:57 +0000 (13:35 +0000)]
[Enhancement] Query HELOs, PTRs, and Reply-To's against Spamhaus DBL too
Vsevolod Stakhov [Sun, 30 Jan 2022 12:24:31 +0000 (12:24 +0000)]
[Minor] Try to fix on-termination race
Vsevolod Stakhov [Sat, 29 Jan 2022 14:02:48 +0000 (14:02 +0000)]
[Minor] Fix inversed logic
Vsevolod Stakhov [Sat, 29 Jan 2022 13:49:34 +0000 (13:49 +0000)]
[Minor] malloc -> g_malloc
Vsevolod Stakhov [Sat, 29 Jan 2022 13:44:50 +0000 (13:44 +0000)]
[Fix] Fix host header usage in lua_http
The issue is that `rspamd_http_message_get_http_host` actually returns
non zero-terminated string in the case where `Host` header is found in a
message. Hence, we *cannot* treat it as a zero terminated string.
The proper approach is to use `rspamd_ftok_t` everywhere for strings
but the change will be too intrusive, since it also involves many libraries,
e.g. `rdns` and others.
The current approach is much simplier: just copy a string into a temporary
buffer ensuring that it is zero terminated in all the cases.
Issue: #4051
Vsevolod Stakhov [Sat, 29 Jan 2022 13:08:38 +0000 (13:08 +0000)]
[Minor] Sigh, reverse loop is bloody hard in C
Vsevolod Stakhov [Sat, 29 Jan 2022 12:46:18 +0000 (12:46 +0000)]
[Fix] Do not forget to clear pointers on IOC reset
Vsevolod Stakhov [Sat, 29 Jan 2022 12:39:47 +0000 (12:39 +0000)]
[Rework] Take disabled flag into account
Issue: #4025
Vsevolod Stakhov [Sat, 29 Jan 2022 12:27:41 +0000 (12:27 +0000)]
[Rework] Allow to set a different behaviour for actions from settings
Issue: #4025
Vsevolod Stakhov [Fri, 28 Jan 2022 19:47:25 +0000 (19:47 +0000)]
Merge pull request #4049 from StSturge/feature/configdump_symbol_detail
[Minor] rspamadm configdump: parsing fixes and output enhancements
ssturges [Thu, 27 Jan 2022 23:35:29 +0000 (18:35 -0500)]
Fix build error with conflicting definition between .h and .c
ssturges [Thu, 27 Jan 2022 22:14:57 +0000 (17:14 -0500)]
Address PR review comments
Vsevolod Stakhov [Wed, 26 Jan 2022 20:58:56 +0000 (20:58 +0000)]
[Minor] Improve documentation
Vsevolod Stakhov [Tue, 25 Jan 2022 21:19:28 +0000 (21:19 +0000)]
Merge pull request #4047 from a16bitsysop/ppc64le
[Feature] Allow hyperscan for ppc64, as vectorscan now suports it.
Duncan Bellamy [Sat, 22 Jan 2022 11:41:53 +0000 (11:41 +0000)]
[Feature] Allow hyperscan for ppc64, as vectorscan now suports it.
ssturges [Tue, 25 Jan 2022 18:39:09 +0000 (13:39 -0500)]
[Enhancement] Add rspamadm configdump option --symbol-detail which provides a consolidated output of every setting for a symbol across all configuration locations.
ssturges [Tue, 25 Jan 2022 18:37:10 +0000 (13:37 -0500)]
[Fix] Support definition of ungrouped symbol in conf file, use group info from lua or other conf file
Vsevolod Stakhov [Mon, 24 Jan 2022 19:48:52 +0000 (19:48 +0000)]
[Minor] Oops, fix refactoring aftermath
Vsevolod Stakhov [Mon, 24 Jan 2022 19:04:26 +0000 (19:04 +0000)]
[Minor] Fix a name and the description of bogus `user` field in the task
Vsevolod Stakhov [Sun, 23 Jan 2022 19:47:48 +0000 (19:47 +0000)]
[Minor] Remove redundant abs call
Vsevolod Stakhov [Sat, 22 Jan 2022 12:29:51 +0000 (12:29 +0000)]
[Fix] Unschedule DNS request when clearing IO channel
Vsevolod Stakhov [Fri, 21 Jan 2022 21:08:16 +0000 (21:08 +0000)]
[Minor] Use raw more intentionally in a client
--raw flag now means raw **input**, and there is a special flag to emit
reply in ucl. Previously, `--raw` and `--ucl` had the same meaning which
was stupid. Now `--raw` is an input flag whilst `--ucl` is an output flag
as intended.
Vsevolod Stakhov [Wed, 19 Jan 2022 21:14:07 +0000 (21:14 +0000)]
[Minor] Rbl: The default behaviour must be bypass
Vsevolod Stakhov [Wed, 19 Jan 2022 21:01:10 +0000 (21:01 +0000)]
[Minor] Rbl: Fix require symbols option
Vsevolod Stakhov [Tue, 18 Jan 2022 21:26:27 +0000 (21:26 +0000)]
[Minor] Remove sequential algorithm as it is not actually a rotation alg
Sequential rotation was used just to rotate all upstreams in the loop (e.g.
when you need to do some action for all upstreams). Allowing to specify it as
a user defined algorithm was a mistake as it breaks upstreams API expectations.
See #4043
Vsevolod Stakhov [Mon, 17 Jan 2022 21:26:40 +0000 (21:26 +0000)]
[Minor] Place obfuscated check properly to count u16 characters and not u8
Vsevolod Stakhov [Sun, 16 Jan 2022 20:20:34 +0000 (20:20 +0000)]
[Minor] Fix for random monitored
Reported by: @moisseev
Vsevolod Stakhov [Sat, 15 Jan 2022 12:57:50 +0000 (12:57 +0000)]
[Minor] Improve logic to select a random monitored mode for RBLs
Vsevolod Stakhov [Sat, 15 Jan 2022 12:28:15 +0000 (12:28 +0000)]
[Minor] Add missing namespace
Vsevolod Stakhov [Sat, 15 Jan 2022 12:25:02 +0000 (12:25 +0000)]
[Minor] Composites: Always register composite symbols
Vsevolod Stakhov [Sat, 15 Jan 2022 12:24:25 +0000 (12:24 +0000)]
[Minor] Deal with unknown weight more carefully to avoid special meaning of 0
The special unknown weight must be NAN not 0.0
Vsevolod Stakhov [Thu, 13 Jan 2022 20:54:39 +0000 (20:54 +0000)]
[Minor] Improve logging
Vsevolod Stakhov [Thu, 13 Jan 2022 20:45:14 +0000 (20:45 +0000)]
[Conf] Score MIME_OBFUSCATED_ARCHIVE to 8 points
Vsevolod Stakhov [Thu, 13 Jan 2022 20:44:57 +0000 (20:44 +0000)]
[Minor] Mime_types: Insert MIME_OBFUSCATED_ARCHIVE symbol
Vsevolod Stakhov [Thu, 13 Jan 2022 20:44:37 +0000 (20:44 +0000)]
[Minor] Add knobs to check if an archive was obfuscated
Vsevolod Stakhov [Wed, 12 Jan 2022 21:04:17 +0000 (21:04 +0000)]
[Minor] Check archive file names for 'strange' stuff
Vsevolod Stakhov [Tue, 11 Jan 2022 21:21:43 +0000 (21:21 +0000)]
[Minor] Damn C++ implicit conversions
Vsevolod Stakhov [Tue, 11 Jan 2022 20:59:25 +0000 (20:59 +0000)]
[Minor] Oops, fix foldl call
Vsevolod Stakhov [Tue, 11 Jan 2022 20:25:52 +0000 (20:25 +0000)]
[Minor] Fix some issues in URI_COUNT_ODD rule
Issue: #4037
Vsevolod Stakhov [Tue, 11 Jan 2022 20:25:27 +0000 (20:25 +0000)]
[Minor] Set special flag for non A generated html urls
Vsevolod Stakhov [Tue, 11 Jan 2022 20:25:12 +0000 (20:25 +0000)]
[Minor] Add `special` flag for URLs
Vsevolod Stakhov [Tue, 11 Jan 2022 20:24:51 +0000 (20:24 +0000)]
[Fix] Fix exclude flags setting
Vsevolod Stakhov [Mon, 10 Jan 2022 19:57:31 +0000 (19:57 +0000)]
[Minor] Arc: Do not fail if no AAR header is presented
Vsevolod Stakhov [Sun, 9 Jan 2022 18:00:32 +0000 (18:00 +0000)]
[Minor] Arc: Add logic to adjust rejected dmarc policy by ARC trusted forwarding
Vsevolod Stakhov [Sun, 9 Jan 2022 17:13:46 +0000 (17:13 +0000)]
[Minor] Arc: Use ARC_CHECK as the callback symbol's name
Vsevolod Stakhov [Sun, 9 Jan 2022 12:59:18 +0000 (12:59 +0000)]
[Minor] Arc: Check AAR on trusted forwarding check
Vsevolod Stakhov [Sat, 8 Jan 2022 20:44:45 +0000 (20:44 +0000)]
[Minor] Fix iteration
Vsevolod Stakhov [Sat, 8 Jan 2022 14:43:34 +0000 (14:43 +0000)]
[Minor] Arc: Process AAR headers
Vsevolod Stakhov [Sat, 8 Jan 2022 14:34:58 +0000 (14:34 +0000)]
[Minor] Add authentication results parser function
Vsevolod Stakhov [Sat, 8 Jan 2022 12:09:01 +0000 (12:09 +0000)]
[Minor] Arc: Rename bogus variable
Vsevolod Stakhov [Fri, 7 Jan 2022 14:16:24 +0000 (14:16 +0000)]
[Minor] Close socket on connect error
Vsevolod Stakhov [Fri, 7 Jan 2022 14:12:05 +0000 (14:12 +0000)]
[Fix] Add guards to avoid race condition on TCP connection
Vsevolod Stakhov [Thu, 6 Jan 2022 15:12:50 +0000 (15:12 +0000)]
[Rework] Timeouts are now global per event and not reseted by IO activity
This actually reproduces old libevent behaviour and it was changed by a big design mistake.
We really want IO timeouts to be fired for the whole set of subsequent events, otherwise it should be
designed in a more configurable way...
Vsevolod Stakhov [Thu, 6 Jan 2022 15:03:23 +0000 (15:03 +0000)]
[Minor] Fix parsing of the very long TXT records
Vsevolod Stakhov [Thu, 6 Jan 2022 14:47:10 +0000 (14:47 +0000)]
[Fix] Fix expanding of the variables
Vsevolod Stakhov [Thu, 6 Jan 2022 14:05:35 +0000 (14:05 +0000)]
[Fix] Backport PR from libucl
https://github.com/vstakhov/libucl/pull/260
Vsevolod Stakhov [Wed, 5 Jan 2022 21:36:58 +0000 (21:36 +0000)]
[Fix] Fix HTTP(s) client timeout
Vsevolod Stakhov [Wed, 5 Jan 2022 20:08:26 +0000 (20:08 +0000)]
[Minor] Rdns: Fix hash delisting
Vsevolod Stakhov [Wed, 5 Jan 2022 17:02:39 +0000 (17:02 +0000)]
[Minor] Fix format string
Vsevolod Stakhov [Wed, 5 Jan 2022 13:51:30 +0000 (13:51 +0000)]
[Minor] Use memcpy instead of unaligned access
Vsevolod Stakhov [Wed, 5 Jan 2022 13:51:17 +0000 (13:51 +0000)]
[Minor] Init xxhash3 state properly
Vsevolod Stakhov [Wed, 5 Jan 2022 11:21:59 +0000 (11:21 +0000)]
Merge pull request #4033 from rspamd/rdns-tcp-rework
Rdns tcp rework
Vsevolod Stakhov [Wed, 5 Jan 2022 11:05:57 +0000 (11:05 +0000)]
[Project] Rdns: Fix various ownership issues
Vsevolod Stakhov [Wed, 5 Jan 2022 10:00:50 +0000 (10:00 +0000)]
[Project] Rdns: Restore the previous EDNS0 size
Vsevolod Stakhov [Wed, 5 Jan 2022 10:00:17 +0000 (10:00 +0000)]
[Project] Rdns: Add timeout logic for TCP requests
Vsevolod Stakhov [Wed, 5 Jan 2022 09:56:25 +0000 (09:56 +0000)]
[Project] Rdns: More fixes in TCP handling
Vsevolod Stakhov [Wed, 5 Jan 2022 08:59:43 +0000 (08:59 +0000)]
[Project] Rdns: Unregister TCP requests
Vsevolod Stakhov [Tue, 4 Jan 2022 21:46:40 +0000 (21:46 +0000)]
[Project] Rdns: Send truncated replies via TCP
Vsevolod Stakhov [Mon, 3 Jan 2022 21:59:16 +0000 (21:59 +0000)]
Merge pull request #4031 from dupondje/add_soft_reject
[Minor] Add no soft reject selector for metadata exporter
Vsevolod Stakhov [Mon, 3 Jan 2022 20:55:54 +0000 (20:55 +0000)]
[Project] Rdns: Fix TCP stuff cleanup
Vsevolod Stakhov [Mon, 3 Jan 2022 17:13:37 +0000 (17:13 +0000)]
[Project] Rdns: Add preliminary reading logic for TCP channels
Jean-Louis Dupond [Mon, 3 Jan 2022 12:42:49 +0000 (13:42 +0100)]
[Minor] Add no soft reject selector for metadata exporter
I think its quite common to not export soft rejects via the metadata
exporter. Because when its not spam, the sender will most likely try to
redeliver it again anyway.
Vsevolod Stakhov [Mon, 3 Jan 2022 11:31:30 +0000 (11:31 +0000)]
[Project] Rdns: Implement TCP writing logic
Vsevolod Stakhov [Mon, 3 Jan 2022 00:27:13 +0000 (00:27 +0000)]
[Project] Rdns: Fix TCP connection mess
Vsevolod Stakhov [Sun, 2 Jan 2022 23:53:55 +0000 (23:53 +0000)]
[Project] Rdns: Add reaper for inactive TCP connections
Vsevolod Stakhov [Sun, 2 Jan 2022 23:04:16 +0000 (23:04 +0000)]
Merge pull request #4030 from moisseev/webui
[WebUI] Add scan options
Vsevolod Stakhov [Sun, 2 Jan 2022 21:29:28 +0000 (21:29 +0000)]
[Project] Rdns: Add more functions for TCP based requests
Vsevolod Stakhov [Sun, 2 Jan 2022 20:49:45 +0000 (20:49 +0000)]
[Fix] Fix removing from khash
Vsevolod Stakhov [Sun, 2 Jan 2022 10:34:05 +0000 (10:34 +0000)]
[Project] Rdns: Do not treat TCP channels failure as fatal
moisseev [Sun, 2 Jan 2022 08:05:58 +0000 (11:05 +0300)]
[WebUI] Add scan options
which allow to set HTTP headers for scan request
Vsevolod Stakhov [Sat, 1 Jan 2022 22:49:48 +0000 (22:49 +0000)]
[Project] Further DNS over TCP architecturing
Vsevolod Stakhov [Sat, 1 Jan 2022 17:49:27 +0000 (17:49 +0000)]
[Project] Rdns: Initial support of TCP IO channels
Vsevolod Stakhov [Sat, 1 Jan 2022 17:05:59 +0000 (17:05 +0000)]
[Rework] Rdns: Use faster and more compact hash table for DNS requests