fix objectstore rename

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #4490 from GitHubUser4234/audit_log_group_creation_deletion

Audit group creation/deletion

Merge pull request #3531 from nextcloud/theming-scss

Theming using SCSS variables

Merge pull request #4485 from nextcloud/translation-checker

Check whether we can json decode the translations

Merge pull request #3195 from nextcloud/settings-apps-tabular

Make apps settings tabular

Loop over the apps directory and add the task

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #4462 from danxuliu/fix-sharing-password-protected-link

Fix sharing a password protected link

Merge pull request #4484 from nextcloud/fix/logincontroller-redirect-url-failed-login

Fix remember redirect_url on failed login attempts

4190

Signed-off-by: Roger Szabo <roger.szabo@web.de>

Mock it

Signed-off-by: Joas Schilling <coding@schilljs.com>

Logo and background URLs must be relative

They are used way to often for such a change

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix theming tests

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Use theming cachebuster for server resources

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Implement scss variable injection by OC_Defaults

Signed-off-by: Julius Haertl <jus@bitgrid.net>
Add Scss variables to example theme and theming app

Signed-off-by: Julius Haertl <jus@bitgrid.net>
Use SCSSCacher to build theming css

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Update theming.scss

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Code cleanup

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Fix tests

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Inject SCSSCacher for easier testing

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Fix typehint

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Generate absolute URLs

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Fix tests to always use absolute urls for theming images

Signed-off-by: Julius Härtl <jus@bitgrid.net>
MailheaderColor -> ColorPrimary

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Fix invalid character

Signed-off-by: Joas Schilling <coding@schilljs.com>

Check whether we can json decode the translations

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix remember redirect_url on failed login attempts

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

[tx-robot] updated from transifex

Fix app icon being inverted for app store apps too

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Show spinner until app store images loaded

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Show placeholder for image-less apps in app management

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Center spinner in apps management

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Add installed category in AppSettingsControlerTest

Signed-off-by: Felix A. Epp <work@felixepp.de>

Make svgs more fluid and consistent remove action, instead of 'remove app'

Signed-off-by: Felix A. Epp <work@felixepp.de>

rename Uninstall to Remove

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

also improve layout of apps from store

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Revert "Add Minor styling improvements with opacity instead of grey"

This reverts commit e9f8a15692ccd4690eef9d4268343d59aa8491ea.

Signed-off-by: Felix A. Epp <work@felixepp.de>

fix sizing and alignment of your app list

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

hide app version and level on narrower screens

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

improve wording of Apps mgmt navigation entries

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Add Minor styling improvements with opacity instead of grey

Signed-off-by: Felix A. Epp <work@felixepp.de>

Fix spacing between enbale-groups label and select2

Signed-off-by: Felix A. Epp <work@felixepp.de>

Fix uninstall in tabular view

Signed-off-by: Felix A. Epp <work@felixepp.de>

Fix app-icon opacity and positioing

Signed-off-by: Felix A. Epp <work@felixepp.de>

Add a link to the appstore page in the installed apps settings categories

Signed-off-by: Felix A. Epp <work@felixepp.de>

Add apps category 'all installed'

Signed-off-by: Felix A. Epp <work@felixepp.de>

Make enabled and disabled apps a tabular list

Signed-off-by: Felix A. Epp <work@felixepp.de>

Use "complete" callback in onPasswordEntered

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Extract common ajax call for addShare and updateShare

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Document options parameter in saveLinkShare

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add "complete" callback support for addShare

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add "complete" callback support for updateShare

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add missing unit test cases and conditions

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #4472 from nextcloud/downstream-27714

Allow apps to register plugins for the user management

Merge pull request #4477 from danxuliu/acceptance-macos-nitpicking

Fix minor code style issues in acceptance test runner

Merge pull request #4473 from nextcloud/downstream-27488

Add unit tests for mounts of delete users

Add unit tests for mounts of delete users

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #4321 from nextcloud/improve-sharing-tooltip

change sharing tooltip with a more general description of all available share options

Allow apps to register plugins for the user management

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #4465 from nextcloud/fix-test-mail

Don't send the test mail twice

Merge pull request #4457 from nextcloud/fix-storage-info-with-wrong-casing

Fix storage info with wrong casing

Merge pull request #4468 from nextcloud/fix_link_password

Fix link password toggle

Fix link password toggle

We took the wrong field from the share api response. So the password was
never shown as set.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #4463 from danxuliu/fix-working-icon-placement-on-password-save

Fix working icon placement on password save

Merge pull request #4458 from nextcloud/fix/sinon-stub-deprecation-warnings

Fix sinon.stub deprecation warnings

Extract updateSharePasswordIfNeeded function

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Join if block to preceding if chain

If getShareType() returns "email" it can not also return "user", "group"
nor "link", so the if block can be added to the preceding if chain.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Don't send the test mail twice

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #1023 from GitHubUser4234/ldap_password_renew_pr

Handle password expiry in user_ldap

Fix working icon placement on password save

Before, the icon appeared below the text input for the password. Now, it
appears inside the text input, to the right end.

The CSS was adjusted based on other icons shown in that position for
other text inputs in the Share tab view, like the information icon or
the clipboard icon.

Fixes #4135

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #4443 from nextcloud/cleanup-unused-imports

Remove unused use statements

Add missing unit test for updateShare with email share

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add missing hook check

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix double hashing of shared link passwords

The plain text password for a shared links was hashed and, then, the
hashed password was hashed again and set as the final password. Due to
this the password introduced in the "Authenticate" page for the shared
link was always a wrong password, and thus the file could not be
accessed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix working icon not hidden when successfully setting a password

When a request to set the password of a shared link is sent a working
icon is shown. However, as there was no "success" callback, the icon was
never hidden again after successfully setting the password (it worked
fine if there was an error, though).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add acceptance tests for sharing password protected links

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add system to share data between acceptance test steps

The data storage (the "notebook") is shared between all the actors, so
the data can be stored and retrieved between different steps by any
actor in the same scenario.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix sinon.stub deprecation warnings

Calls to `sinon.stub(obj, 'meth', fn)` are deprecated and therefore
replaced by `sinon.stub(obj, 'meth).callsFake(fn)` as instructed by
the deprecation warning.

This makes the js unit testing output readable again.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Remove dead arguments

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix similar issues with the group id

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix the storage info and other checks when the user has wrong casing

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #4434 from nextcloud/add-rate-limiting-to-solve-challenge-controller

Add rate limit to TOTP solve challenge controller

Merge pull request #4401 from nextcloud/caldav-carddav-nc-owner-displayname

add owner-displayname property to calendars and addressbooks

Merge pull request #4444 from nextcloud/remove-unused-variables

Remove unused variables

[tx-robot] updated from transifex

add owner-displayname property to calendars and addressbooks

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Remove unused use statements

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

[tx-robot] updated from transifex

Remove unused variables

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Fix minor code style issues (also known as nitpicking)

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #4435 from nextcloud/allow-at-maximum-10-reset-mails-requests-per-5-minutes

Add at most 10 password reset requests per 5 minutes and IP range

Merge pull request #4432 from nextcloud/fix-grammar

Fix grammar

Add at most 10 password reset requests per 5 minutes and IP range

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Add rate limit to TOTP solve challenge controller

Fixes https://github.com/nextcloud/server/issues/2626

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

[tx-robot] updated from transifex

Merge pull request #4431 from nextcloud/acceptance-macos

Run acceptance tests on macOS

Fix grammar

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Run acceptance tests on macOS

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #4208 from danxuliu/add-basic-acceptance-test-system

Add basic acceptance test system

Merge pull request #4396 from nextcloud/scan-non-existing

show error when trying to scan non existing path

Merge pull request #4428 from nextcloud/file-by-id-limit-user

limit the user when searching for a file by id if we know the user already

Merge pull request #4426 from nextcloud/update-dom-purify

Bump to DOMPurify 0.8.6

Merge pull request #4429 from nextcloud/proper-return-code-for-welcome-email

Use RESPOND_NOT_FOUND for non existing user

Use RESPOND_NOT_FOUND for non existing user

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

limit the user when searching for a file by id if we know the user already

Signed-off-by: Robin Appelman <robin@icewind.nl>

Update core.js

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #4422 from nextcloud/favorite-wording-detail

Wording detail fix for favorite emptycontent view

Merge pull request #4423 from nextcloud/reload-fav-view

properly reload favorites list

Bump to DOMPurify 0.8.6

Fixes https://github.com/nextcloud/server/issues/4424

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Make test passwords valid for the password_policy app

As requested by Morris Jobke, the passwords in the acceptance tests were
modified to make them valid both for a clean Nextcloud server and one
with the password_policy app enabled.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>