chore(deps): bump underscore from 1.13.6 to 1.13.7

Bumps [underscore](https://github.com/jashkenas/underscore) from 1.13.6 to 1.13.7.
- [Commits](https://github.com/jashkenas/underscore/compare/1.13.6...1.13.7)

---
updated-dependencies:
- dependency-name: underscore
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #47802 from nextcloud/fix/fallback-icons

fix(files): Fallback icons should fill the container

Merge pull request #47801 from nextcloud/fix/taskproc/error-msg

fix(TaskProcessing): increase error_message column length

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

chore: update autoloader

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>

fix(TaskProcessing): increase error_message column length

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>

fix(files): Fallback icons should fill the container

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #47649 from nextcloud/fix/footer-overlap

fix: Fix inaccessible content on public pages due to overlapping footer

Merge pull request #45652 from nextcloud/feat/migrate-files-sharing-public-to-vue

feat(files_sharing): Migrate public shares to Vue

Merge pull request #47731 from nextcloud/refactStorDav

chore(storage): refactor some code portions

chore(storage): refactor some code portions

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
chore: revert portion

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Merge pull request #47784 from nextcloud/fix/file-info

fix(FileInfo): correctly implement `\ArrayAccess::offsetGet`

Merge pull request #47756 from nextcloud/fixingPathShareCheck

fix(files): Check if target path is a descendant of the shared folder

fix(FileInfo): correctly implement `\ArrayAccess::offsetGet`

We are targetting PHP 8.1+, since PHP 8.0 `offsetGet` has the `mixed` types for `offset` and return value.
So this adds the types to correctly implement the interface.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

chore: Compile assets

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

test: Add end-to-end tests for new public share Vue UI

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): "Edit locally" action should not be shown on public shares

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): Do not add click listener if there is no default action on public shares

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files_sharing): Ensure sidebar share entry lists are labelled

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): "New folder" menu entry requires read permission

This will disable "New folder" menu entry for file-drop shares.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

chore(files_sharing): Remove now unused legacy scripts

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): Disable internal views on public shares

This is needed because some views have side effects, like `favorites` doing requests on registration time.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files_sharing): Set file-request header for nextcloud/upload

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files_sharing): Disable sharing status action for public shares

This is disabled to not leak personal information into the public

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files_sharing): Handle download permission the same way for public and internal shares

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): Do not allow copy action on public shares without `create` permission

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

feat(files): Allow to download files on public shares

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): Do not allow rename action on single-file-shares

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

refactor(files_sharing): Make file structure more clear

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): Disable copy-move-action of single file shares

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

refactor(files): Make `RouterService` provide a protected getter for the router to allow injecting the `files_sharing` router

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): Adjust files list for sharing permissions on public shares

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): Fix file previews for public shares

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): Do not use `favorite`, `sidebar` and `view-in-folder` action for public shares

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

feat(files_sharing): Migrate public share to use Vue files list

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

chore: compile scss

Signed-off-by: Christopher Ng <chrng8@gmail.com>

fix: Fix inaccessible content on public pages due to overlapping footer

Signed-off-by: Christopher Ng <chrng8@gmail.com>

fix(files): Check if the target path is a descendant of the shared folder path

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: add tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests

Merge pull request #47789 from nextcloud/fix/cs-fixer-errors

chore: adjust code to adhere to coding standard

chore: add coding standard code change to .git-blame-ignore-revs

Signed-off-by: Anna Larch <anna@nextcloud.com>

chore: adjust code to adhere to coding standard

Signed-off-by: Anna Larch <anna@nextcloud.com>

Merge pull request #47770 from nextcloud/artonge/fix/always_respond_custom_error_page_on_exceptions

fix(dav): Always respond custom error page on exceptions

Merge pull request #47761 from nextcloud/fix/missing-footer

fix: Fix missing footer on public pages

Merge pull request #47519 from nextcloud/fix/transfer-ownership-encrypted-files

feat(transfer-ownership): Correctly react to encrypted files

Merge pull request #47769 from nextcloud/artonge/fix/use_sha256_for_arguments_hash_forbg_jobs

fix: Use sha256 to hash arguments of background jobs

Merge pull request #46255 from nextcloud/bug/add-option-to-remove-webroot-for-setupchecks

fix: add option to remove the webroot for setup checks and don't chec…

fix(dav): Always respond custom error page on exceptions

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix: Migrate existing bg jobs to use sha256

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix: Use sha256 to hash arguments of background jobs

This is to prevent collision as we are sometime hashing user input, yet using that hash to target the background job in the database.

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix(transfer-ownership): Improve comments according to code review

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

feat(transfer-ownership): Correctly react to encrypted files

For E2EE encrypted files, we abort the transfer.
For SSE encrypted files, we abort only if not using master key.
Also fixed the check for when the path to a single file is used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix(setupchecks): Test overwrite.cli url first, then generated one, and

 trusted domains as last fallback.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix: add option to remove the webroot for setup checks and don't check trusted_domains.

1) The checks for well-known urls should always run against the root domain and therefore the option to remove the webroot.

2) For trusted domains, the available protocol is unknown, and thus some guesswork would be needed to make that work. I've decided for now to not consider them anymore to reduce false-positives.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #47754 from nextcloud/fix/noid/cache-appstore-on-dev-instances

fix(appstore): Cache apps.json also on dev instances

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix: Fix missing footer on public pages

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #47752 from nextcloud/backport/47745/master

[master] fix(files): undefined displayname for outdated `@nextcloud/files`<3.6.0 apps

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(appstore): Cache apps.json also on dev instances

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>

fix(files): undefined displayname for outdated `@nextcloud/files`<3.6.0 apps

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Merge pull request #47417 from nextcloud/fix/files/create-mountpoint-parents

Merge pull request #47738 from nextcloud/fix/sidebar-undefined

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files): undefined sidebar

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Merge pull request #46859 from nextcloud/fix-status-check-and-saving-of-external-storages

Merge pull request #47724 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

Merge pull request #40164 from nextcloud/exceptionsTranslateShare

fix: Hide status tooltip in row to add a new mount point

The row to add a new mount point is cloned when a new mountpoint is
added, so it is expected that it includes a status span. However, it
should not be displayed in that row, only in the cloned row when its
status is updated.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Fix unmodified placeholder replacing the actual value when updating

When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

test: Add integration tests for saving external userglobal storages

As the external storage uses the Nextcloud server itself the number of
workers of the PHP process running the Nextcloud server had to be
increased. Otherwise if a request is sent for the external storage while
handling a request from the integration tests a deadlock would occur.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Reset selected backend when adding a new storage

As a new storage is added by selecting a backend the selected backend
needs to be reset. Otherwise it is not possible to add another storage
with the same backend.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Add missing translation for UI string

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Restore default status tooltip when no status message is provided

If the status is updated but no explicit message is provided (for
example, if the status check succeeded) the default tooltip (from the
template) is now set to prevent a mismatch between the status and the
tooltip (for example, if the configuration is fixed after a failed
status check).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Set status tooltip to error message on failed actions

When saving, updating and rechecking an storage fails (which is
different to the soft-fail when the action itself succeeds but the
status check does not) further details are provided in the error message
of the response, which is now set as the tooltip.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Set status tooltip to status message when saving an storage

When a storage is saved the status check can fail even if saving the
storage succeeds. In those cases further details are provided in the
status message of the storage, which is now set as the tooltip,
similarly to how it is done when rechecking the storage.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Remove status check when configuration was changed

Setting a null status was supposed to remove the status check, but
nothing was changed in that case. Now the status check is properly
removed, and doing that by hiding the element rather than just turning
it invisible also prevents that clicking on the invisible status
triggers a check, as until the new configuration is saved the check will
still be performed with the old configuration, which could be misleading
for the user.

Additionally, an explicit width is set to the parent of the span element
to prevent its width from changing when the span is shown and hidden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

fix: Recheck userglobal storages when loaded

Userglobal storages are now automatically recheck when loaded, similarly
to how it is done for global storages.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

refactor: Store result in its own variable

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #47690 from nextcloud/chore/theming

Merge pull request #47155 from nextcloud/executeStatementOnDelete

Merge pull request #39242 from joshtrichards/db-convert-type-mysql-socket-no-pw

Merge pull request #47285 from nextcloud/fix/appstore-upgrade-failure

fix: Do not throw if appstore is unavailable during upgrade

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #47675 from nextcloud/adapterQueryOpti

fix: share manager tests translation string

Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>

fix: adjust sharing controller exceptions case

Co-authored-by: F. E Noel Nfebe <fenn25.fn@gmail.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>

fix(l10n): Translate all share exceptions

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Fix drone

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

chore(tests): Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #47709 from nextcloud/fix/server-webpack-appverson

fix: only keep major as server version

Merge pull request #47158 from nextcloud/fix/breadcrumbs-highlight

fix(files): Fix navigating with breadcrumbs not highlighting navigation entry

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files): Fix navigating with breadcrumbs not highlighting navigation entry

Signed-off-by: Christopher Ng <chrng8@gmail.com>

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #47679 from nextcloud/chore/typo-docs

chore(IGetRealUIDBackend): Fix typo in doc block

fix: only keep major as server version

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Merge pull request #47412 from Luka-sama/feat/shares-reminder