]> source.dussan.org Git - tigervnc.git/commit
projects / tigervnc.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 91bdaa6) | patch
Handle pixel formats with odd shift values 921/head
authorPierre Ossman <ossman@cendio.se>
Wed, 2 Oct 2019 14:06:08 +0000 (16:06 +0200)
committerPierre Ossman <ossman@cendio.se>
Fri, 15 Nov 2019 11:26:25 +0000 (12:26 +0100)
commit05e28490873a861379c943bf616614b78b558b89
tree91ba8a69622340b19a849c87b7fdd68cf7492cf9tree | snapshot
parent91bdaa6c87a7f311163b5f1e4bbcd9de584968cdcommit | diff
Handle pixel formats with odd shift values

Our fast paths assume that each channel fits in to a separate byte.
That means the shift needs to be a multiple of 8. Start actually
checking this so that a client cannot trip us up and possibly cause
incorrect code exection.

Issue found by Pavel Cheremushkin from Kaspersky Lab.
common/rfb/PixelFormat.cxx diff | blob | history
tests/unit/pixelformat.cxx diff | blob | history
High performance, multi-platform VNC client and server: https://github.com/TigerVNC/tigervnc