]> source.dussan.org Git - jgit.git/commit
Make inner classes static where possible 93/129893/2
authorDavid Pursehouse <david.pursehouse@gmail.com>
Tue, 25 Sep 2018 05:11:23 +0000 (14:11 +0900)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Tue, 25 Sep 2018 23:31:13 +0000 (08:31 +0900)
commitee40efcea44bc0c9a28afe29a80c87636947484e
tree8ca21706241f80c724b1c1bf8075553e1aaa0c80
parent1f14c16ae459d82b14fcde504bde8d4657b57f57
Make inner classes static where possible

As reported by Error Prone:

An inner class should be static unless it references members of its
enclosing class. An inner class that is made non-static unnecessarily
uses more memory and does not make the intent of the class clear.

See https://errorprone.info/bugpattern/ClassCanBeStatic

Change-Id: Ib99d120532630dba63cf400cc1c61c318286fc41
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
12 files changed:
org.eclipse.jgit.http.test/tst/org/eclipse/jgit/transport/http/apache/HttpClientConnectionTest.java
org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/MockSystemReader.java
org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/debug/TextHashFunctions.java
org.eclipse.jgit.test/tst/org/eclipse/jgit/api/ArchiveCommandTest.java
org.eclipse.jgit.test/tst/org/eclipse/jgit/gitrepo/RepoCommandTest.java
org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/WindowCacheGetTest.java
org.eclipse.jgit.test/tst/org/eclipse/jgit/merge/MergerTest.java
org.eclipse.jgit.test/tst/org/eclipse/jgit/revplot/PlotCommitListTest.java
org.eclipse.jgit.test/tst/org/eclipse/jgit/treewalk/AbstractTreeIteratorTest.java
org.eclipse.jgit.test/tst/org/eclipse/jgit/util/io/TimeoutOutputStreamTest.java
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/PackBitmapIndexRemapper.java
org.eclipse.jgit/src/org/eclipse/jgit/lib/RefUpdate.java