From 01957cc955464094f78975ace68e5e74cf7d78b8 Mon Sep 17 00:00:00 2001 From: Stas Vilchik Date: Mon, 8 Dec 2014 13:24:34 +0100 Subject: [PATCH] SONAR-5877 Update component viewer coverage popup --- .../coffee/component-viewer/coverage-popup.coffee | 1 + .../src/main/coffee/component-viewer/source.coffee | 3 +++ .../hbs/component-viewer/cw-coverage-popup.hbs | 14 +++++++++++++- 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/server/sonar-web/src/main/coffee/component-viewer/coverage-popup.coffee b/server/sonar-web/src/main/coffee/component-viewer/coverage-popup.coffee index 065db092f50..f6fc34b7794 100644 --- a/server/sonar-web/src/main/coffee/component-viewer/coverage-popup.coffee +++ b/server/sonar-web/src/main/coffee/component-viewer/coverage-popup.coffee @@ -60,3 +60,4 @@ define [ file: files[fileRef] tests: testSet testFiles: testFiles + row: @options.row diff --git a/server/sonar-web/src/main/coffee/component-viewer/source.coffee b/server/sonar-web/src/main/coffee/component-viewer/source.coffee index cf6843ed1a6..2b1cc7c3de4 100644 --- a/server/sonar-web/src/main/coffee/component-viewer/source.coffee +++ b/server/sonar-web/src/main/coffee/component-viewer/source.coffee @@ -43,6 +43,7 @@ define [ 'click .source-line-covered': 'showCoveragePopup' 'click .source-line-partially-covered': 'showCoveragePopup' + 'click .source-line-uncovered': 'showCoveragePopup' 'click .source-line-duplications-extra': 'showDuplicationPopup' @@ -208,11 +209,13 @@ define [ e.stopPropagation() $('body').click() line = $(e.currentTarget).closest('.source-line').data 'line-number' + row = _.findWhere @options.main.source.get('formattedSource'), lineNumber: line $.get API_COVERAGE_TESTS, key: @options.main.component.get('key'), line: line, (data) => popup = new CoveragePopupView model: new Backbone.Model data triggerEl: $(e.currentTarget) main: @options.main + row: row popup.render() diff --git a/server/sonar-web/src/main/hbs/component-viewer/cw-coverage-popup.hbs b/server/sonar-web/src/main/hbs/component-viewer/cw-coverage-popup.hbs index be7d99c755a..7a88f3828aa 100644 --- a/server/sonar-web/src/main/hbs/component-viewer/cw-coverage-popup.hbs +++ b/server/sonar-web/src/main/hbs/component-viewer/cw-coverage-popup.hbs @@ -1,5 +1,17 @@
-
{{t 'component_viewer.transition.coverage'}}
+
+ {{#if row.coverage.covered}} + {{t 'source_viewer.covered'}} + {{#if row.coverage.branches}} + ({{default row.coverage.coveredBranches 0}} of {{row.coverage.branches}} {{t 'source_viewer.conditions'}}) + {{/if}} + {{else}} + {{t 'source_viewer.not_covered'}} + {{#if row.coverage.branches}} + ({{row.coverage.branches}} {{t 'source_viewer.conditions'}}) + {{/if}} + {{/if}} +
{{#each testFiles}}
-- 2.39.5