From 067add65706aef0b125b3fac8f42a76051fb4ee3 Mon Sep 17 00:00:00 2001 From: aclement Date: Thu, 10 Mar 2005 17:53:21 +0000 Subject: [PATCH] Improved FIXME comments ;) --- weaver/src/org/aspectj/weaver/bcel/BcelShadow.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java b/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java index edeb4f05f..009343249 100644 --- a/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java +++ b/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java @@ -889,7 +889,7 @@ public class BcelShadow extends Shadow { if (!hasThis()) { throw new IllegalStateException("no this"); } - initializeThisAnnotationVars(); // FIXME ASC Why bother with this if we always return one? + initializeThisAnnotationVars(); // FIXME asc Why bother with this if we always return one? // Even if we can't find one, we have to return one as we might have this annotation at runtime Var v = (Var) thisAnnotationVars.get(forAnnotationType); if (v==null) @@ -907,7 +907,7 @@ public class BcelShadow extends Shadow { if (!hasTarget()) { throw new IllegalStateException("no target"); } - initializeTargetAnnotationVars(); // FIXME ASC why bother with this if we always return one? + initializeTargetAnnotationVars(); // FIXME asc why bother with this if we always return one? Var v =(Var) targetAnnotationVars.get(forAnnotationType); // Even if we can't find one, we have to return one as we might have this annotation at runtime if (v==null) @@ -1304,8 +1304,8 @@ public class BcelShadow extends Shadow { argAnnotationVars = new Map[numArgs]; for (int i = 0; i < argAnnotationVars.length; i++) { argAnnotationVars[i] = new HashMap(); - //FIXME ASC Fill this in - // populate + //FIXME asc just delete this logic - we always build the Var on demand, as we don't know at weave time + // what the full set of annotations could be (due to static/dynamic type differences...) } } public void initializeKindedAnnotationVars() { @@ -1316,7 +1316,7 @@ public class BcelShadow extends Shadow { // Then create one BcelVar entry in the map for each annotation, keyed by // annotation type (TypeX). - // FIXME Refactor these once all shadow kinds added - there is lots of commonality + // FIXME asc Refactor these once all shadow kinds added - there is lots of commonality ResolvedTypeX[] annotations = null; TypeX relevantType = null; -- 2.39.5