From 09099cfaeceada44dd4454a400d4753e2cc2f0b0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?C=C3=B4me=20Chilliet?= Date: Tue, 10 Jan 2023 14:59:43 +0100 Subject: [PATCH] Fix theming migration repair step by passing correct type for argument MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Côme Chilliet --- apps/theming/lib/Jobs/MigrateBackgroundImages.php | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/apps/theming/lib/Jobs/MigrateBackgroundImages.php b/apps/theming/lib/Jobs/MigrateBackgroundImages.php index 54c0d591e40..97665d1179f 100644 --- a/apps/theming/lib/Jobs/MigrateBackgroundImages.php +++ b/apps/theming/lib/Jobs/MigrateBackgroundImages.php @@ -68,10 +68,9 @@ class MigrateBackgroundImages extends QueuedJob { $this->logger = $logger; } - protected function run($argument): void { - if (!isset($argument['stage'])) { - // not executed in 25.0.0?! - $argument['stage'] = self::STAGE_PREPARE; + protected function run(mixed $argument): void { + if (!is_array($argument) || !isset($argument['stage'])) { + throw new \Exception('Job '.self::class.' called with wrong argument'); } switch ($argument['stage']) { @@ -99,10 +98,10 @@ class MigrateBackgroundImages extends QueuedJob { $userIds = $result->fetchAll(\PDO::FETCH_COLUMN); $this->storeUserIdsToProcess($userIds); } catch (\Throwable $t) { - $this->jobList->add(self::class, self::STAGE_PREPARE); + $this->jobList->add(self::class, ['stage' => self::STAGE_PREPARE]); throw $t; } - $this->jobList->add(self::class, self::STAGE_EXECUTE); + $this->jobList->add(self::class, ['stage' => self::STAGE_EXECUTE]); } /** -- 2.39.5