From 0a3b8ac8957b8795fae685beba9691697471e92f Mon Sep 17 00:00:00 2001
From: Stas Vilchik <vilchiks@gmail.com>
Date: Tue, 9 Jun 2015 11:23:58 +0200
Subject: [PATCH] SONAR-5892 apply feedback

---
 .../issues/templates/issues-workspace-header.hbs     |  3 ++-
 .../src/main/js/apps/issues/workspace-header-view.js |  1 +
 .../js/components/navigator/workspace-header-view.js | 12 ++++++++++++
 .../main/resources/org/sonar/l10n/core.properties    |  1 +
 4 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/server/sonar-web/src/main/js/apps/issues/templates/issues-workspace-header.hbs b/server/sonar-web/src/main/js/apps/issues/templates/issues-workspace-header.hbs
index dd98ec389b8..163280ac9d9 100644
--- a/server/sonar-web/src/main/js/apps/issues/templates/issues-workspace-header.hbs
+++ b/server/sonar-web/src/main/js/apps/issues/templates/issues-workspace-header.hbs
@@ -22,7 +22,8 @@
 
     {{else}}
       {{#if state.canBulkChange}}
-        <a class="js-selection icon-checkbox {{#if allSelected}}icon-checkbox-checked{{/if}} {{#if someSelected}}icon-checkbox-checked icon-checkbox-single{{/if}}"></a>
+        <a class="js-selection icon-checkbox {{#if allSelected}}icon-checkbox-checked{{/if}} {{#if someSelected}}icon-checkbox-checked icon-checkbox-single{{/if}}"
+            data-toggle="tooltip" title="{{t 'issues.toggle_selection_tooltip'}}"></a>
       {{else}}
         &nbsp;
       {{/if}}
diff --git a/server/sonar-web/src/main/js/apps/issues/workspace-header-view.js b/server/sonar-web/src/main/js/apps/issues/workspace-header-view.js
index e7b317442b9..c301c40e872 100644
--- a/server/sonar-web/src/main/js/apps/issues/workspace-header-view.js
+++ b/server/sonar-web/src/main/js/apps/issues/workspace-header-view.js
@@ -24,6 +24,7 @@ define([
     },
 
     onClose: function () {
+      this._super();
       window.onBulkIssues = this._onBulkIssues;
     },
 
diff --git a/server/sonar-web/src/main/js/components/navigator/workspace-header-view.js b/server/sonar-web/src/main/js/components/navigator/workspace-header-view.js
index bc4296fcb8a..524346fa080 100644
--- a/server/sonar-web/src/main/js/components/navigator/workspace-header-view.js
+++ b/server/sonar-web/src/main/js/components/navigator/workspace-header-view.js
@@ -40,6 +40,18 @@ define(function () {
       this.listenTo(options.app.state, 'change', this.render);
     },
 
+    onRender: function () {
+      this.$('[data-toggle="tooltip"]').tooltip({ container: 'body', placement: 'bottom' });
+    },
+
+    onBeforeRender: function () {
+      this.$('[data-toggle="tooltip"]').tooltip('destroy');
+    },
+
+    onClose: function () {
+      this.$('[data-toggle="tooltip"]').tooltip('destroy');
+    },
+
     onBulkChangeClick: function (e) {
       e.preventDefault();
       this.bulkChange();
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index 12b7df60cca..249651373f0 100644
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -730,6 +730,7 @@ issues.home.my_filters=My Filters
 issues.home.projects=Projects
 issues.home.authors=Authors
 issues.home.tags=Tags
+issues.toggle_selection_tooltip=(De-)Select all currently visible issues
 
 
 #------------------------------------------------------------------------------
-- 
2.39.5