From 0e15f573d6f1d5c138ce63d2a462737dbb874faa Mon Sep 17 00:00:00 2001 From: =?utf8?q?Scott=20Gonz=C3=A1lez?= Date: Fri, 10 Dec 2010 13:42:29 -0500 Subject: [PATCH] Revert "Dialog: Moved the default value for the position.of option inside the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError." This reverts commit 22671ad4f8e3e2e921c27bd2933fa088950abf2f. --- tests/unit/dialog/dialog_defaults.js | 1 + ui/jquery.ui.dialog.js | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/unit/dialog/dialog_defaults.js b/tests/unit/dialog/dialog_defaults.js index 7c94d3336..612fd58c8 100644 --- a/tests/unit/dialog/dialog_defaults.js +++ b/tests/unit/dialog/dialog_defaults.js @@ -20,6 +20,7 @@ var dialog_defaults = { position: { my: 'center', at: 'center', + of: window, collision: 'fit', using: $.ui.dialog.prototype.options.position.using }, diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js index c53169b5b..81df1d19b 100644 --- a/ui/jquery.ui.dialog.js +++ b/ui/jquery.ui.dialog.js @@ -57,6 +57,7 @@ $.widget("ui.dialog", { position: { my: 'center', at: 'center', + of: window, collision: 'fit', // ensure that the titlebar is never outside the document using: function(pos) { @@ -527,7 +528,7 @@ $.widget("ui.dialog", { this.uiDialog // workaround for jQuery bug #5781 http://dev.jquery.com/ticket/5781 .css({ top: 0, left: 0 }) - .position($.extend({ of: window }, position)); + .position(position); if (!isVisible) { this.uiDialog.hide(); } -- 2.39.5