From 11094048151b06cf777798d94fd9cee26adddbd7 Mon Sep 17 00:00:00 2001 From: Martin Strecker Date: Tue, 28 Nov 2023 09:56:11 +0100 Subject: [PATCH] Fix fail_on_reference_overlaps_declaration test --- .../internal/DefaultSymbolTableTest.java | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/sonar-plugin-api-impl/src/test/java/org/sonar/api/batch/sensor/symbol/internal/DefaultSymbolTableTest.java b/sonar-plugin-api-impl/src/test/java/org/sonar/api/batch/sensor/symbol/internal/DefaultSymbolTableTest.java index 1f40ff3107c..dabcb4713af 100644 --- a/sonar-plugin-api-impl/src/test/java/org/sonar/api/batch/sensor/symbol/internal/DefaultSymbolTableTest.java +++ b/sonar-plugin-api-impl/src/test/java/org/sonar/api/batch/sensor/symbol/internal/DefaultSymbolTableTest.java @@ -27,8 +27,10 @@ import org.sonar.api.batch.fs.InputFile; import org.sonar.api.batch.fs.TextRange; import org.sonar.api.batch.fs.internal.TestInputFileBuilder; import org.sonar.api.batch.sensor.internal.SensorStorage; +import org.sonar.api.batch.sensor.symbol.NewSymbol; import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; import static org.mockito.Mockito.mock; public class DefaultSymbolTableTest { @@ -42,7 +44,6 @@ public class DefaultSymbolTableTest { private Map> referencesPerSymbol; - @Before public void setUpSampleSymbols() { @@ -51,7 +52,7 @@ public class DefaultSymbolTableTest { symbolTableBuilder .newSymbol(1, 0, 1, 10) .newReference(2, 10, 2, 15) - .newReference(1, 16, 1, 20); + .newReference(1, 16, 1, 20); symbolTableBuilder .newSymbol(1, 12, 1, 15) @@ -68,15 +69,14 @@ public class DefaultSymbolTableTest { } @Test - public void should_fail_on_reference_overlaps_declaration() { - DefaultSymbolTable symbolTableBuilder = new DefaultSymbolTable(mock(SensorStorage.class)) - .onFile(INPUT_FILE); - symbolTableBuilder = symbolTableBuilder + public void fail_on_reference_overlaps_declaration() { + NewSymbol symbol = new DefaultSymbolTable(mock(SensorStorage.class)) + .onFile(INPUT_FILE) .newSymbol(1, 0, 1, 10); - - assertThatThrownBy(() -> { - symbolTableBuilder.newReference(1, 0, 1, 10); - }).isInstanceOf(IllegalArgumentException.class) - .hasMessageMatching(".*"); + + assertThatThrownBy(() -> symbol.newReference(1, 3, 1, 12)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage( + "Overlapping symbol declaration and reference for symbol declared at Range[from [line=1, lineOffset=0] to [line=1, lineOffset=10]] and referenced at Range[from [line=1, lineOffset=3] to [line=1, lineOffset=12]] in file src/Foo.java"); } } -- 2.39.5