From 148ac23c0d2e17f25d943659b5c5d769f1df9fdb Mon Sep 17 00:00:00 2001 From: Dominik Stadler Date: Sun, 14 Jul 2024 11:26:38 +0000 Subject: [PATCH] List expected failures in stress.xls instead of fully excluding them We list expected failures in stress.xls to verify that the error message is correct and no unexpected exception is introduced git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1919212 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/poi/stress/TestAllFiles.java | 7 ++----- test-data/spreadsheet/stress.xls | Bin 65536 -> 67584 bytes 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java b/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java index 2f8ba9aafa..2767ca9f72 100644 --- a/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java +++ b/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java @@ -97,11 +97,8 @@ public class TestAllFiles { "poifs/60320-protected.xlsx", "poifs/protected_sha512.xlsx", - // corrupt file - "document/unicode-path.docx", - "spreadsheet/duplicate-filename.xlsx", - "spreadsheet/duplicate-filename-case-insensitive.xlsx", - "document/clusterfuzz-testcase-minimized-POIXWPFFuzzer-5166796835258368.docx", + // NOTE: Expected failures should usually be added in file "stress.xls" instead + // of being listed here in order to also verify the expected exception details! }; // cheap workaround of skipping the few problematic files diff --git a/test-data/spreadsheet/stress.xls b/test-data/spreadsheet/stress.xls index f4d52ecf69409b8ebb777a11b272176c684ede3d..04046bd635862ed77db5acd57fe09fbd8a12826d 100644 GIT binary patch delta 3647 zcmai%dr(wW9LLXD7FrRx2nht-nYCsLxcdkda9cIRpfn$$W@uV&yVqeISa#S&$rqbu z52K<^?@W7IDOs_-ANDSzmuXfIC8Cz1&S)t$0ow1J{jqrVpJ48fJ)e8d=leT*?_D4i zGKQLs&6ZpPA>$e8=K+x*)c)Z-~s9A9XjImwSU%Ky))-I+1O>!0Mgl*Xvw7Ho7yFkSQ+TB|&qoU-yaG z0l)6{F7fIf5isumda}A*0o@86=)M5#Xj!C5_Wcw`dSO9PQL&?F{Mf=Vh2zH-jTdi+ z0~*POG`G#`3+i?72H2+hmbt3Eo&{ciw5{-GmGSXeS>!ZHKaY?kxEj61gzSXt`Y>FZ zvea z(rBKj`J!r~T12&qY7^BSw*Iuv&^Q2hVlH?x$V#Y@5rvTs>d43dqkI@qLjuf&v6ucQN|%8l%EIdaf{!a^V_Of^rp0K)0~0!y0{_ zl|y}j)g3OTFS4yrx3X@i+gR2Sjkd6Is4uZPsN2~ls4ufNsIRczBbxFmZbuW_X=Ru8 zs7e@_1=+$LmA=MS^l0>Twxvf?-oW#AJm1xmr@V>mQe>G&Rp(pC3L*?fJKz^r0lZcG zrX9R($B4J*ZJav>*ZYsE$~(x$BHIY;U1Z~s?S!27kQGWfg)uq&w#y*z}^4KUL=s$Yw}6Gh%XP zik!VTcP6g?5S%|En}zHcu%D1!gDmqe)%i2B3Mr=|CTF(DX~(&wEI+58BD5r2T@ z$K)&!Is0+$0$jffoZZN-N7fJQ0J4S1a!;$ygUA+1Ig4U)ZV)+#aPAGbK6F}Den)mA zvX;{|${)xU59ai$&cn!DQjRMo=O&SJ1n1r~nA58&J;>Y<7H;XCOPT-gW^ptdvs?ce z7dJ8vmKVT>R|)(ikFHhYSVdnNtL#fMxl6~??AhBv*=XbWEYueoHUR(D@xOM?gh&6g akKVU9^Zx!IZDjTR>kPTQ;eY!R;{F2&njCom delta 2662 zcmZved2AF_9LL|A?)G3?rrVZQTqkk=F(Cs%xmFmV5*xvG^W-ot{O#|kucnC%G*lW%LA zW_5RCqn`*qylBaSvPT|U!_wKP<6>3ndiU%^#{M=l(}w3MkEWYN6Usd1)?&9iBZIZD z>?FogX;cd^7FEsKxy5{?zp#g8qm8A~W;mPgjjt7^u1kNAIc&M;akdvP7rAG3zCx5zT`9s;L*fY4r$m(M zD&afl8@!t44$@pA-PGIZ*Cj31eaK-?!`xvZ(x zU<1H55HrCBg6*fAkH7}mat1ka=&O%DL?5F!fO&6=rhWo;FW69G`@jZ+Eojk??WdgIz=~`+MUEWnpN|}N9KF*p@4cz1zk^K& z8%pd1*bJ}*H#OrAuwq+Iu_I@u%sGkPnV7F5=P9sRV9mtp!DfT?Y}JfE!RFX<<~VZZ z%A5xD&c*!V)`jY6u!lNxS~WESR??Z%rWt>M&5JQwS)ZSIj+~&(IfLF{tk+!JHkDW3 z8jz5#&}r)reI6a5e&xHvlQ_=`Pv<-}`RIwPJJ%dI#f9IM6%KJ8+U(*>`10`MF1}g` Mw(M(l@x+9G0nxoTc>n+a -- 2.39.5