From 160109946acd018e7c3b79dbe008c39d51235ddf Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Tue, 6 Dec 2016 12:13:48 +0100 Subject: [PATCH] SONAR-8503 Make WS api/users/identity_providers accessible without authentication --- it/it-tests/src/test/java/it/user/ForceAuthenticationTest.java | 1 + .../org/sonar/server/authentication/UserSessionInitializer.java | 1 + .../sonar/server/authentication/UserSessionInitializerTest.java | 1 + 3 files changed, 3 insertions(+) diff --git a/it/it-tests/src/test/java/it/user/ForceAuthenticationTest.java b/it/it-tests/src/test/java/it/user/ForceAuthenticationTest.java index b614374e6c7..d03f7291c86 100644 --- a/it/it-tests/src/test/java/it/user/ForceAuthenticationTest.java +++ b/it/it-tests/src/test/java/it/user/ForceAuthenticationTest.java @@ -99,6 +99,7 @@ public class ForceAuthenticationTest { verifyPathDoesNotRequiresAuthentication("/api/system/db_migration_status", GET); verifyPathDoesNotRequiresAuthentication("/api/system/status", GET); verifyPathDoesNotRequiresAuthentication("/api/system/migrate_db", POST); + verifyPathDoesNotRequiresAuthentication("/api/users/identity_providers", GET); } @Test diff --git a/server/sonar-server/src/main/java/org/sonar/server/authentication/UserSessionInitializer.java b/server/sonar-server/src/main/java/org/sonar/server/authentication/UserSessionInitializer.java index df21619b05b..af14f73165f 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/authentication/UserSessionInitializer.java +++ b/server/sonar-server/src/main/java/org/sonar/server/authentication/UserSessionInitializer.java @@ -65,6 +65,7 @@ public class UserSessionInitializer { "/sessions/*", "/api/system/db_migration_status", "/api/system/status", "/api/system/migrate_db", "/api/server/index", "/api/server/setup", "/api/server/version", + "/api/users/identity_providers", LOGIN_URL, LOGOUT_URL, VALIDATE_URL); private static final UrlPattern URL_PATTERN = UrlPattern.builder() diff --git a/server/sonar-server/src/test/java/org/sonar/server/authentication/UserSessionInitializerTest.java b/server/sonar-server/src/test/java/org/sonar/server/authentication/UserSessionInitializerTest.java index 6c878793baa..94acef3059f 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/authentication/UserSessionInitializerTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/authentication/UserSessionInitializerTest.java @@ -110,6 +110,7 @@ public class UserSessionInitializerTest { assertPathIsIgnored("/api/server/index"); assertPathIsIgnored("/api/server/setup"); assertPathIsIgnored("/api/server/version"); + assertPathIsIgnored("/api/users/identity_providers"); // exclude static resources assertPathIsIgnored("/css/style.css"); -- 2.39.5