From 163e6eb6f73f94538f79ab65b4056774bbc0f7e4 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Sat, 19 Oct 2019 11:15:54 +0000 Subject: [PATCH] code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/unified_diff.rb git-svn-id: http://svn.redmine.org/redmine/trunk@18759 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 1 - lib/redmine/unified_diff.rb | 6 ++++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 2c379d0ae..008bb94d7 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1446,7 +1446,6 @@ Style/VariableInterpolation: Style/WhileUntilModifier: Exclude: - 'app/models/attachment.rb' - - 'lib/redmine/unified_diff.rb' - 'lib/redmine/utils.rb' # Cop supports --auto-correct. diff --git a/lib/redmine/unified_diff.rb b/lib/redmine/unified_diff.rb index 5660fa91d..64e3f13e8 100644 --- a/lib/redmine/unified_diff.rb +++ b/lib/redmine/unified_diff.rb @@ -203,11 +203,13 @@ module Redmine if line_left.present? && line_right.present? && line_left != line_right max = [line_left.size, line_right.size].min starting = 0 - while starting < max && line_left[starting] == line_right[starting] + while starting < max && + line_left[starting] == line_right[starting] starting += 1 end ending = -1 - while ending >= -(max - starting) && (line_left[ending] == line_right[ending]) + while ending >= -(max - starting) && + (line_left[ending] == line_right[ending]) ending -= 1 end unless starting == 0 && ending == -1 -- 2.39.5