From 17d4d76f4f7d2c24e9a8f2d993b9c9f9a291cf5f Mon Sep 17 00:00:00 2001 From: Tim Allison Date: Tue, 18 Oct 2016 18:24:39 +0000 Subject: [PATCH] BUG 60273 -- Use codepageutil to get correct charset in VBAMacroReader git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765490 13f79535-47bb-0310-9956-ffa450edef68 --- .../apache/poi/poifs/macros/VBAMacroReader.java | 3 ++- .../poi/poifs/macros/TestVBAMacroReader.java | 10 ++++++++++ test-data/spreadsheet/60273.xls | Bin 0 -> 30208 bytes 3 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 test-data/spreadsheet/60273.xls diff --git a/src/java/org/apache/poi/poifs/macros/VBAMacroReader.java b/src/java/org/apache/poi/poifs/macros/VBAMacroReader.java index 21b535b104..42902d1311 100644 --- a/src/java/org/apache/poi/poifs/macros/VBAMacroReader.java +++ b/src/java/org/apache/poi/poifs/macros/VBAMacroReader.java @@ -41,6 +41,7 @@ import org.apache.poi.poifs.filesystem.DocumentNode; import org.apache.poi.poifs.filesystem.Entry; import org.apache.poi.poifs.filesystem.NPOIFSFileSystem; import org.apache.poi.poifs.filesystem.OfficeXmlFileException; +import org.apache.poi.util.CodePageUtil; import org.apache.poi.util.HexDump; import org.apache.poi.util.IOUtils; import org.apache.poi.util.RLEDecompressingInputStream; @@ -305,7 +306,7 @@ public class VBAMacroReader implements Closeable { break; case PROJECTCODEPAGE: int codepage = in.readShort(); - modules.charset = Charset.forName("Cp" + codepage); + modules.charset = Charset.forName(CodePageUtil.codepageToEncoding(codepage, true)); break; case STREAMNAME: streamName = readString(in, recordLength, modules.charset); diff --git a/src/testcases/org/apache/poi/poifs/macros/TestVBAMacroReader.java b/src/testcases/org/apache/poi/poifs/macros/TestVBAMacroReader.java index a001ad9896..df90c8f444 100644 --- a/src/testcases/org/apache/poi/poifs/macros/TestVBAMacroReader.java +++ b/src/testcases/org/apache/poi/poifs/macros/TestVBAMacroReader.java @@ -272,4 +272,14 @@ public class TestVBAMacroReader { assertNotNull(macros.get("NewMacros")); assertContains(macros.get("NewMacros"), "' dirty"); } + + @Test + public void bug60273() throws IOException { + //test file derives from govdocs1 147240.xls + File f = POIDataSamples.getSpreadSheetInstance().getFile("60273.xls"); + VBAMacroReader r = new VBAMacroReader(f); + Map macros = r.readMacros(); + assertNotNull(macros.get("Module1")); + assertContains(macros.get("Module1"), "9/8/2004"); + } } diff --git a/test-data/spreadsheet/60273.xls b/test-data/spreadsheet/60273.xls new file mode 100644 index 0000000000000000000000000000000000000000..07933cff6fa9935172d8165b02c9bd8f4d6d9d63 GIT binary patch literal 30208 zcmeHw30zah_V6SG2&+U8apejqD2oXon<7g{T7`|8@-eCOPo8^>ftMhw zA2gm7fB?W60NdOaKnP$5U=QE`;0WLZ;0(|L091g809pdL0=NOR0&oXt4d4OL2B0lK zJAn289RNB4cmhxWodCQ5ya9XwIsY=;)!#w~X5FiMkJAfEK0uT%k0uTxi z1`r7l4iEu=JP`gDOxHjLQNo`Z+9HvZ!d*qiL#;JGxP!*9ocWN965^GRI{Hfb;BC)! z<;RMyr+9V5%X2i`y8*5al>)*L$X!K>NDeJW5rceLWd~04DD6N9XNHG|oe<$@JHgDC}SR{Vad_6$*%u^48L3bo5GyF3l zvj7aPd8#GOt3VuGZ8VXp8!3eB!f4JQb4w?ll&&WQbaAXRilo4`fE0qUk-$(80A&ax zx)Qdu<;2Dqf>*}40421{;{r%5(#vEj7mVTd${4*~8Kd_rV(>_e#nNI~LSGRBhdNpp zp?*!5g$Dz-r8>pZ+FRhk(dm}P8sCvzfTnG2Aw9<6fkAwg40f;JfkxF_NjnPK!{7rG z4KE)r?*MOaady|9BmCHx5nVe9I>A&1CLJsa=)*JQc_WP@dBI!8uS?+LMoP!YGCa z;*J6#S&P$1c2Rn!ztKgI{R| z|A`s=Ml*PG@+>wJ|5Gz~bNre3=)}-^qOTt&ep5UnPg6W2PgA@({-4ouHjV$48N9jp z+swrO(hUA{Gx$Ab@Qgg@5E|FdCOW(8fe4s-Ku3{||6YFnUeCRrM8L?y z1B*oCpFspVuy&xU8GL{ld^eMLbV_Od9Q%M1_}_3TgM&wB*SK7aexl<+8I$-v;3KMVcH946*QjHF1R>A<2mx9k4NLrz!Z>trmr7d z9559h&|vFfm_sWiez1C0+0HE#5x4leBA6b1(WZq6`T^D2dLoCGjgfvDyZ@P#@~SeeX3 zg`%1=!3CICGSS9ZW)j*QCcz=bOt|I8B_s3Y=QkA{*N_;|ae@Gd9`+C!F@;L25_BrD`*B+=eoVIawTPIKbYmo43#D0NKC7&DU8*XWtp z>WWxZRi&kL0h=8e7~<>Kkirka)vY=^F7 z*#9w@ROz*A*Xo(DI$&6}Y-WbI=2thjW5$3OOvgmMg0?c&flA>xjwVMzG;3JJVA@iv zt=A`Dg{`fv)e>DPSYc_LPGVMALmaCcdK~1^)QaK)bEB}>+(tE6Da_&s+Zz%H^i~vI z7NZ0xF}8)ycG1G(g~dUyqlIm1p1dGcqh*B`W5!rLEE6zKG~=dBaD-`O(nLCji9Fv> zx~5EUzV=Ec^(mH_pfl0P1YS%PM{ncJ6vw+cOqksa^L2vLqDD!~)(MWr=9%DJ=9Nt9 zQ!F#VU6Dp6@M5}7EHm+G4ijc~$9!>cYS}1>**d`)jd>2RYYX6wW<6ZAP=$)rBTG80cDCh%gqPAoI&(i|qtZie|Lb~9pP zwoY(jYMu%D2hFGx%S^O9<1=ap4ECL2Eazi3B5pRpO|$W`kPYLn(Aika z^Z&Tpn{F1eVSFAs8(Vq4_SbsT z*|>4D>CrTsAPd=`SA^a#w1-fhf9~q9rn70q%_gjAHo+FM32V&8PM&}5!B3{MamQ>z zEo+)5WE0v9O{-7YefICBvuVxE#)PJMTgb*x)9O>69ou9&8xL+aCN$00LN1MO$)J* zjiIL1r+jl0G8DajO5 zA@PIJmBh>P76>DaTb|cWYXwJ)WF${NG+N`@2P_0)J>oO27V0dC3+(^Ga=KJjoLf;W zQ!A9E3xt!68S>q=4sbdN51-_c3b@MPD1`#fPnALjw)7B>OmWqU%>Y-C=nQP&@E#Iz zJ%b044c~-DZ+1p+3;8WzJsQ@-rG@g`B1$SRE?yw4;>gunYY%c2!elTPPIOW5EC=a| zjikc0nkMSQN`;FyHhQU;H&!a922EYl>8D=U_j%G65LcxsS*oO*#U$(R+tht>s7sf~kES=jcabo=8e zy75rwgFu{dpbxls#kM{+wobhSM69s`>7qC+?X)f7te%o?E+rWYO!9zPUtn1V&nmzx zAS32@-a@_|oELyao+PCb)V-%MD_&czfFuDcB}d_L`J9yqL}n#&25$oVkiK$Ro}#pX z0*`}JTq_r7pS~ak_8^p^03>5P4O)?)+a(Md&9Fm-wgt%;bGnf44Cg`(n1co7G8dU( z&R9`1%(XEa>+e88ka?&fbFidb<}FPyXRN6i=F9|xPc!df$Q&#x$E;YnnqZDrm1%cd z!)igT4ATgk>ONmcGcn!D_Hc+6R-BSc%PK$#D~y|&?*?^{46RWHy#Up%(eP+tV}WgG z+6mF);e zhGFm;Ag@rXWMJ4hLjtco3<(2(F_u&XdWa^C@ug@>4!bdIc~`)ejlQc94S_26GL{w2 z)!6_u?5}8=kQEvyJ2=GyiaS85mM;+I7$@P|LzluNYLEdJHPMTsbA}ah)^_4*cB4gS z-dNkoys@^Ed0WVLAUz4Jo~2c&=>{Il$+Q))PNR$5w22MJ7Bt01O^k>}NticQ66TGS zgn2{l?4_}Ws`4=w!P*+?Jsrxd(yuTum1R$&Q8NcA)WuL+65~`>Eub|9fikF}a$cnW_}6 z8e_*}j0NR8z>qKma!`TZvWCr+{l?h>UBlJFp`_YiHD(@^P6U60fJqKr+Ds66JpGgk zWk-8i0csWuwWuItXbozNVR#NRj4XhozPR-SdBN8lkR?1Y7yP(`#=wIHQM!u;?izf7 zhq}5txM@gDjh57edcZ?$gc^W+V4q(@7B5~5-vQ*4kQzXMnGFG`p#g9qkQNXl zT%2*9hI!E<5HgB~n^Du@oM2cl#JdqmP)K%?yi^XRAX};|$x)Qb^Ogxc$TEYP=V4R` zh*|?jsMi?K5I=_qpqKK1X|C+YpI1a4sU5Z#H~zSLqbDq?$30av&Wmnuuuu^jKp${k39j@_lKk{Skx~$)yrkolSzn*e04mcO`^n;$) zRl7ZHw;fozVqL#2zsCFf+-;XMa_!~tv~!yV&z#)WqnB)Li>1Hq-1D_x_&b{9naeWP zPW-v7Af-0CdY;O2-bbfiMDUOG7}G`bQsaEQV&DajyEErUTt6Z`d(&$B)(%6X|96@qhI+x4*JM{=IZ0a_78gAX6vmt?Jy|*M)B%sq zW4f=MC+)tbl3ewxD)ef1zTMsPX@_j=cL}F`^x)}+=s!2letz}6UnuuwpV%C@CXG2( zcy&zl-l{1_rhl}qvvByhvcIjFcz#><*XbwM^g1qSx3=$g@uHS3W}Hj=I%9Ku-pL~_ zr}`zH56$tZS~vf#?6aOrKWK9$EamiL_l&dQqc+c7e?dVTlnnY-t$mw$4m8MdKH{PlW=`0>J%Bb)mdO-reAu3N!Qq zxe7JJu|C!Q0Ob;UwQ}{?dFR4&cljme)E?Ws>j{yrXd8EE)v1-|&)&Q~HT=8FZVk)( zI}Hn1Ve2$YemrQ#mk%cetZTRar@rmK2`IjLsMXK6$9Ww2;$7Fv$%o4aR(dzgo4#q= zMe2ub{tcZT1YCUcE1%KPvy+D0I{mckwZyyrUF`W0riI^pCsIBYrZeACOm8p{n<;_> z#lAP}`0RE`?t8o6s49FBbobNYo>S#(($em=IX|>kTHPZfdE^Iof(B+S`%L_|Q7fO+ zZk^}!l|Xf@Q$V}ERF@@xNNkq-{GN30(>sI5E*ex@VDow2k~aHJjC`?s$leJL8YZS? zg)3ubZy5Wxuc(0A&l=jbx_scsd&m3M-g-9IcTL8zr_&OSI1XHVrF!qT`}bDfUAXr` zf^G1A$&=XLBHQ)XlQM!@9F<2-)xig%c}5?Z@#hil;5El zK6{p|@;K9b>Gwz6Cc3UYwRhXV-XA?&)_1kd$M4NuG`cvs@ZP;IK5@wjeDU7If*E5b zEiL%=JKtwDzeUfQHm!Tq+lkueH;0EGyG6NvsG7U6Q~0T>nh{;ZJvZHse16SmWvFof zs*}eb7m-D~cF4+q^axW`w$*%`IaG1$>N&smj4Sr>;^!qz`=}FUAeo z-)HyUVI|HrAro#*`|`l3GaKbc9o!P69Y>Cy71{sBo}sf(W`3JQ(qm`&B=`F2&1;d% z;@zH#I{U5|my{=pyAn8XzrbECj^D7Qs;Ws(pH@}-{>bV9DbJ=I z96IjlqpzOM_-1RYZPldx-F+o9T|V@15eUjESToq+57OT(hK z?Wp$Nv*4iQAG`gwYYxph+41@Ss|%UsZQMWDxM2E3)t=zD=DI|cAHSG1^X8SSqwQ`l z+A-*fck#(deFu7-(S)b)rtaQye_jqYaq-$}|?(b)wl^#?qu#5bRzriKS zNAgU5-%Gf8dvW<62k%Pmyz!W4MLa4$7l7N zG~PDE|LsFXQAs~8lJD%by|!qHYk~T=!4Cdk%oTrptNn5Dla5t)MxDs*f9z-L+q*=0 zi=_ALH|{!Io%Q&GQM{4`cZ$Yj-VlifAFh5h<^I+3uP^oMRrKD$84pfR^8C8=r%A%B z?`ryap18fi?(4KwFQ<-stL@Fnq(h&w2MsU8@q_PYJlNl1OHt|b2VN5$pWMux{jK$r z&WEq`KNg!4F27W?-0s641c`MiE}EmDV($MZQm|O zY?rUxwB7fQ2VX>2Uwrsh+m2u6_{&GuHk@0M;rwOW6_q=*`?lw61|N|+F3Jlp7&*4b z*^%#Rt1dU(JAdr#?)p8|*LN;?wEEDFzsqYEE}DD#nA?2^b=aLRyrXZPEa?5{lK0BU z)#`w=Zk~3Pcf7B(K3*)C+HZj8*lT|X%i8Q))2&=QdHV3OkL10+yHSwP=ejWPYT^1j z{+%7>Z+KIvJR(@(aa*>obo#napDjIpYT&3DQ;O|JM-uK^ft*WZ%;Yd-siWYz3pdjpPJZz!{r^L-?2_V zwwoXGRrIsfmmVD;39&-w>#L$yc8yuP`O>%{J^ztAVZutuCZWcCqAPFuy7RN{Ub?xV zVeRTMytLsybILwXEj3+R)Z#T1?apcRwd30BGlIO|%W?~;Sy%S{(ekJlfnQF3w0Kh+$I(lD{HOUk zWQ|H)^F~AHmbP8r*`4+DK>SfvpHl%?^@AGJ1(Kq_rMCI8_GZJZulJ44%{i>dpPrWa zbj;BbrRw6~mGg$!iN}@3BsJ`gjT5hLwQ$%Ox9b-}H>$>jjXqm_oF5Z=-z#zd;TP|| z`%~bqn?3eNc5r-i!>>~>j5)La#H7+iQlj4SjKZU*U-s!|$JTxZLyfl~uzZ*uE?K z^vwDvzpq_2aNuvl?`MRpZ`c|4`T4ds7h4Z&XXT%EIw{{lyyfSLyD>1MXgcR`IyrCU zcA&I_8Hq1v&cRHy=z-i|=AoN-rP}WoyG?sKWvo!CJiXIpewT|gPHZ}3HSI+TuZA7?`qS;O_yNbL!G+r-CFEi<{%Qao)OUny9{h3uK8xUr z=lq4_j}4DbrRJo^WYhR=G~S=SPN6Xx1DCHeEEN&*giHp?K5*pl_Xb3;5JS3TWK@(= z;Pc9(s4fXp>EzSsYZra;D>3*H9}}*``01Y?#&p#`--=lc`*=K9PeJdU2ONg-hoYnq zu3)L?JCCe@9f1`rGX`yRMKPI>1w4eL5?6yDH27oj;k+rlBmV}c#&G`KFI*hf85f7O#l_)) zP%f^e2^_8!aO0sea&fIp;Bb9{8xPNra&g$1xHvpR$i?9qIxY^+ka2P7#&U5TOyKa? zB{!ZY2e(J}fle~~TmthaAbX%2qDIH+{t)9r>w15qST3N|uyq70O3WV<4>c{0B)~pt zA^@zJ@om6(*}{$)azUNrQgNSLHgZ)KgI-xl}tn6?KzKwbxToOSx1B zJr(tpONFynI+;;(xl|`T6?K?Ph1F(VTGVDPwS}IFdd;P}=&7jTT&hSZ{t!uY3f<%8#kb<4CTAQ*Jp0<*YPj> z;iy1C9^78u$pp^J1kT$8&c_6^pIED}RSjpb7DP!U5#-Q`mK^ikSKu)lGsQFGSB&+30-#B;c%>h4V)noAuc!e$BB1&w7zqiVZYpdp49#UVOs5X1a3~=U z4k_SK4Kx+68^FbYEq3Osw&v!K+7pXP3SkhOS5%Plzx+FNZFS|x?$O-*ae^mCp&^+2 z{W*sE>MP_==Zkq`cy$WM8zSNFykX!0U{m0l0g8mxg6zZu<8&S;?Km~Z2{=x(aWailW}Fz~^cQ(jaL3`_3jl|5AArsP zIQZfa>j!|tB@T)>^x*)9!x#=$I3ytt)EOK^aHzlm0nI)dceE;KsL>pw(M8jW1{5bP zXdGhzVgcd+;sK-p2>^)zeE^aG`T`^a^aJP*kOGhjFaRJ8ARPc@$bfq$z#xDufWZKW zAF8{*0r%kmBLGGMya|vEfN^AS&jH8<$ODiAuX|t5(CKTb|Ds zZ{y9gBa|C|DX*^;|1jm^D}W=v(+0!uBc`jAqvg5k53RA1WBG12eET<|`S!Ma70*p* z)6$N|Z`n}te!MMl?9A`ii*N5vc&c(Wm8UG0_vW`Lhows>9Ud=TB?lF{KsuiSjq5g| z??m|JsNhlJ&=7GT5efuSTVl_5=Cu@yL&GYGcW{u{TkM@oii;~s6mTS#D5J8<<*M>1 zB7-BcQ3*;o|6Bs+HOixs$&f+vlCr3=c_g>+tvq!}c^MH)qH<-qg>n*=C(oBv6st*8 ziA+%%m6$-HhCxhj|>^od9ihe`uUkN7@uffBJKHa;*uA+d+1DsFU~ zrZQAx9jvW77L!Uc(}EIGQoK`%B3Gp>SLUnv)PX1}GDu9N@pC56r&1I-D%nQW_}EAd zX)$fJ>wX?p;0+#btaYj~Hm{;sE@^9L6+DMH$JuCRfuWr;dxnIxkA<$@H=Z|IGG&EA zQ`<3~&$A8~7~g90;!g2G|9D=TxGC?`zpofuk>dituh@2gAeeaY>g;vaQb2~(wWoiz z)2WW9tmCD1m<9IZv(ygB-+S$EC+*;}pARbAtiWqcoO#>9gz?Z4=}jo3=gs2KG!oh+ zkcYNqwrr1~`3vz4&PQW-2yg}r;9MGq7?8lbVDV&>f=*8xMkJUGjJ@U02ipl9+3Flb z1eS?lB$#Y5Arpr!;AQ|Gzn4#$gWfCk;qm7|UJO_hP-QYv|_Qk4hicO$z;bPtB^P34TI`YC0lRALYXrzG=K zDhhv{qm~Oki_j?}%leP2F|L^l>c3r<z^T1ea$QQGq`0k_=-y=4jk7W{) zVvrbWkCq%XgjINa`cDEa4+zLRy_LkN)hb0!1stQM2FGU)kd?qgH07151j7iH(#t8c zg5>C`j4*ZP*VWz0w$5%;5Sfr5FDJPwMHzmS!{g7;=`~>$o3NTqSk)#v-S*;n41@tR z7q+MPGTzAK(lN>+IhEa~qBNH`k{UruC81tUzD~Z+?N?E$yb9vRxAm+fu~~#i;l!dm zck;-fII9XcoS3JWY+F7h$V%;$Sei$X8N>Z2yx1Wc4HbluVQXo_Q|%r}x+=(u>bf^__u7e8u#f zM;sxE41~##n7K&VCqyx`AK*#IWxOB{x|2unCpZ3>IS^oi%+w$oi^+{x;Vj!nmy({w zGVyfA6l1Z$Fy*UohH(v_*>uKtuIa`U%?-361yib_6R>=Zhj4wJ(q+SX_|E`Jhhp+R zG;3gBE=AZMtDaHh^zRaE-69pXuKKYQHr;9@q`&iUj z?+}=lU$I5$hDOJ`w8@ zu^tiY5V8Ic>khHr5bF%Fz7Vvn5*)HjHM)A>53%kL>kX9}l#Y<=SiWG^`C)w@#`S@c z#>Ig`gn}CsT>1Z5`BGUwjH|-5CuY7u@u&-&>%e0xu%k`*@D&Jr%|!>S7_=PB%$vcP zx-#~^k-{vEHoh}YrmU@Z0px89vm2b;5c}ZB(1`rJd`WN)vFet<O!;x0=O>faaMW!4>Sk^&QIU@!wE3CyDeM! zk?7*b3yJ%&b?r_eXHXKJ`}EaertmZ!SK2fH1P&;<;9%rcEU>0cCK35-1XhFNRYbIR53wny%@PrfT1ae|afXO0 zS_$-hLL|!3z_4efCA{oJSnH{Pp_7Qtc?cX0{U#!s+Mn2Ef+v-WbAKY*{04Dh+yi<} zj>vK%s;Pi6nRd5`Xxt8gaX%7WpCk~n|6c_Wc@)9Ske<&BGFSD`BVlEo4>!1Wfc|YX z<7KP}e7OpI;4GLGTyZH@7YE!=XRJ*CoCf|ILvlj2*TndQuz0C7TpB2iNDK)C3oZ_f zlO`kvCWJ-AhbP2EL_~y3D!uHT7*iCjvq<(%uz*L8Q_+Sdr+b&aIPhVxcLEjtou+ONdMeX8`a? z(rB-6ad>b@SbStiI6`O`pzWQ8_f^8$W#Tya6f94!qLNGVl_Tw)^kPY(Cx%3X0Jl(a zptMh(1RrG2~)tlf(Fby=lt-RT$iV!L>H%MYI`tReYom1Sr+{BF6cT zg^yKVFW^su8up;(q#gp1;&c(M!NJB)Wbs>U`~?O4q&**2s+q5|8-G{B9A9t&>HRO< zAE8Z|xrhe%Veq^|SAJ{Qbx^|UKgz)Th}!GP6Y&?yKML}9qX&Egq5k6IpJ1%*K?ZKX z;$4}(^4I5Sg)X1Y7ZQKp&(DbgHvw5&;kr)1lGw9i<;g0)I8n`3h8^8?rnlu2(uy#VvRVnzqH;PJ^ ztMK>j;2SrXr4|GkCvY#7Y7AJ!kg;dsM} zpmr_`;W)T|!1K)sfV1Y{4nkdHePesTjf?`owAi*d1gQa90B8VkPjEc|#@z~lW!M3L zZB_?>`-X=Buq{sjVB5xU+R|LTQ4lvPC^HCF@5*E_WAC3dRogR5D#-e|}pqw~Dc33P_3lxbSBMRkm zbvZ2s)+&;)R&Y4XqcUWr1+W&0B4Sn3`;ctAQt*x`q5zN>uY1R5Y>({p>$vDi!E;EvC)A9%1sX$2eVX#2ST_nRlM_{LE?+m`xt`Y@e-)5P(d%YpA^z*;Z-Lcc KBK=>^|NjAzSwcPl literal 0 HcmV?d00001 -- 2.39.5