From 199428804fd8129559b685a0d2ddc2f73f70deaa Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Sun, 21 Sep 2008 08:54:02 +0000 Subject: [PATCH] Fixed: invalid effective date (eg. 99999-01-01) causes an error on version edition screen. git-svn-id: http://redmine.rubyforge.org/svn/trunk@1888 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/version.rb | 2 +- test/unit/version_test.rb | 36 ++++++++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 test/unit/version_test.rb diff --git a/app/models/version.rb b/app/models/version.rb index dc618af0f..e379f4b05 100644 --- a/app/models/version.rb +++ b/app/models/version.rb @@ -24,7 +24,7 @@ class Version < ActiveRecord::Base validates_presence_of :name validates_uniqueness_of :name, :scope => [:project_id] validates_length_of :name, :maximum => 60 - validates_format_of :effective_date, :with => /^\d{4}-\d{2}-\d{2}$/, :message => :activerecord_error_not_a_date, :allow_nil => true + validates_format_of :effective_date, :with => /^\d{4}-\d{2}-\d{2}$/, :message => 'activerecord_error_not_a_date', :allow_nil => true def start_date effective_date diff --git a/test/unit/version_test.rb b/test/unit/version_test.rb new file mode 100644 index 000000000..3fe5a5f87 --- /dev/null +++ b/test/unit/version_test.rb @@ -0,0 +1,36 @@ +# redMine - project management software +# Copyright (C) 2006-2007 Jean-Philippe Lang +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License +# as published by the Free Software Foundation; either version 2 +# of the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + +require File.dirname(__FILE__) + '/../test_helper' + +class ProjectTest < Test::Unit::TestCase + fixtures :projects, :issues, :issue_statuses, :versions + + def setup + end + + def test_create + v = Version.new(:project => Project.find(1), :name => '1.1', :effective_date => '2011-03-25') + assert v.save + end + + def test_invalid_effective_date_validation + v = Version.new(:project => Project.find(1), :name => '1.1', :effective_date => '99999-01-01') + assert !v.save + assert_equal 'activerecord_error_not_a_date', v.errors.on(:effective_date) + end +end -- 2.39.5