From 1a3fdbc0d14cf4d72142496df7ae8a7f14df1109 Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Fri, 3 Jul 2015 15:19:22 +0200 Subject: [PATCH] Fix stability of issue tracking --- .../src/main/java/org/sonar/core/issue/tracking/Tracker.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sonar-core/src/main/java/org/sonar/core/issue/tracking/Tracker.java b/sonar-core/src/main/java/org/sonar/core/issue/tracking/Tracker.java index 9709ca8886e..4ec4f84220b 100644 --- a/sonar-core/src/main/java/org/sonar/core/issue/tracking/Tracker.java +++ b/sonar-core/src/main/java/org/sonar/core/issue/tracking/Tracker.java @@ -87,7 +87,6 @@ public class Tracker { } private void relocateManualIssues(Input rawInput, Input baseInput, Tracking tracking) { - // FIXME copy of Set if required to avoid concurrent modifications (see tracking.associateManualIssueToLine()) Iterable manualIssues = from(tracking.getUnmatchedBases()).filter(IsManual.INSTANCE); for (BASE base : manualIssues) { if (base.getLine() == null) { @@ -107,7 +106,7 @@ public class Tracker { // issue is kept at the same location, even if code changes tracking.keepManualIssueOpen(base, base.getLine()); } - // TODO if hash found multiple times, , pick the closest line + // TODO if hash found multiple times, pick the closest line } } } @@ -254,7 +253,7 @@ public class Tracker { LineHashKey(Trackable trackable) { this.ruleKey = trackable.getRuleKey(); - this.lineHash = trackable.getLineHash(); + this.lineHash = StringUtils.defaultString(trackable.getLineHash(), ""); } @Override -- 2.39.5